summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-09-20Replace remaining occurrences of LIBO_HEADLESS with HAVE_FEATURE_UIAndras Timar
Change-Id: Ie2b04ee443dece851d3d96afbc932aa64369c75c Reviewed-on: https://gerrit.libreoffice.org/79084 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-09-20Use CPPUNIT_ASSERT_GREATER(e,a) instead of CPPUNIT_ASSERT(e<a)Stephan Bergmann
Change-Id: Ib7f74d1afdf038726842d7fc0b33555db6611270 Reviewed-on: https://gerrit.libreoffice.org/79310 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-20Missing test dependencyStephan Bergmann
`make clean && make CppunitTest_sw_uiconfig` failed with > Test name: SwUiWriterTest::testClassificationPaste > An uncaught exception of type com.sun.star.io.NotConnectedException > - because instdir/share/classification/example.xml was missing in SfxClassificationHelper::Impl::parsePolicy (sfx2/source/view/classificationhelper.cxx). Change-Id: I0c2aeff1a6192d8fac3b01f63fc75f4ce758b809 Reviewed-on: https://gerrit.libreoffice.org/79308 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-20Improve exception messageStephan Bergmann
Change-Id: If608a61f75b63327bed67fc3f752769c3a5bde62 Reviewed-on: https://gerrit.libreoffice.org/79307 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-20Fix makefile modelinesStephan Bergmann
(cf. TEMPLATE.SOURCECODE.HEADER) Change-Id: I0fb78f097273b838291241ccf63c308003cac89c Reviewed-on: https://gerrit.libreoffice.org/79306 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-20drop newly unnecessary OGenericUnoDialog::DialogCaolán McNamara
Change-Id: If047d08cea93fdfacff9ee00c69cf57ba08c916c Reviewed-on: https://gerrit.libreoffice.org/78972 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20m_xVclDialog now unusedCaolán McNamara
Change-Id: I12c11451af5c5c9fe0d635a077eee0c57c6aa14f Reviewed-on: https://gerrit.libreoffice.org/78971 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20make WizardShell use RoadmapWizardMachineCaolán McNamara
Change-Id: Id7e1e163f17cd4866c37bbd6cad73b8c721f4dae Reviewed-on: https://gerrit.libreoffice.org/78969 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20weld SwDBTablePreviewDialog and SwMailMergeDlgCaolán McNamara
Change-Id: Icb7c96b6e9a4d6777fbd0cb4a8eb54547413d390 Reviewed-on: https://gerrit.libreoffice.org/74798 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20expand to fill VclBinCaolán McNamara
Change-Id: If40894e9b92f21150936bbd8a9e25982d3a908cb Reviewed-on: https://gerrit.libreoffice.org/79305 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20get the toplevel GtkWindow widgetCaolán McNamara
Change-Id: Ibcc20027062568b239d893bcf51887749abe4646 Reviewed-on: https://gerrit.libreoffice.org/79304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20ensure embedded widget is realizedCaolán McNamara
Change-Id: Id43ca34d31d8e45482786a0739d981d7c85de686 Reviewed-on: https://gerrit.libreoffice.org/79303 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20drop newly unused SfxTabPage ctorCaolán McNamara
Change-Id: I1bdadb6fb11cafa9e29c09e7886c73aabf3d4274 Reviewed-on: https://gerrit.libreoffice.org/79288 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20weld OfaTreeOptionsDialogCaolán McNamara
including ability to host a vcl::Window based XWindow hierarchy inside a native widget, e.g. the dictionary extensions have option pages Change-Id: I17d933bac12679e10164214a9045b677291a6557 Reviewed-on: https://gerrit.libreoffice.org/79070 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Whenever fired from Dialog Editor the help page lacks 'Component' introduction. The HowToGet part requires your assistance/experience Change-Id: Ibaf25e610a38bcdca2a2d3c6703881ac8dd68ea0 Reviewed-on: https://gerrit.libreoffice.org/79219 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-09-20convert SwFieldTypesEnum to scoped enumNoel Grandin
clamp it to sal_uInt16 since we convert it that type when passing it via SfxItemSet Change-Id: I4b7bd4ba5e19015af357d5a81a629239451d71e4 Reviewed-on: https://gerrit.libreoffice.org/79289 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-20Icons: Fix for frame icon in sidebar navigator and search toolbarrizmut
Change-Id: I9dc1643f2c40d93bd3dad7e7353d3b1a4a3ac055 Reviewed-on: https://gerrit.libreoffice.org/79291 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-09-20weld Application Colors pageCaolán McNamara
Change-Id: Ib074afdb9cf57decb435bb6ec3867af5989019ef Reviewed-on: https://gerrit.libreoffice.org/79225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20Related: tdf#127645 update dialog has a slave extension dialogCaolán McNamara
when the update dialog is shown, the extension dialog was created but not executed, so there isn't a dialog execution context to end, just the unexecuted dialog to "close" Change-Id: If4b522ca5f880d3ece8403b5350c846bd14a2992 Reviewed-on: https://gerrit.libreoffice.org/79281 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20Blacklist include for IWYUKelemen Gábor
After commit a3b03ba1316b1ec0a9b0a3b45b96dc0a49aa9f1f Change-Id: I76f24a1617e9d359fd40ef4af17982c484bb3808 Reviewed-on: https://gerrit.libreoffice.org/79042 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-20Resolves: tdf#127645 ignore floating windows like we do tooltipsCaolán McNamara
Change-Id: I727e10a1e884841554437e376bde2ff483d278a4 Reviewed-on: https://gerrit.libreoffice.org/79282 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20Fix CppunitTest_sw_uiwriter for my Windows buildStephan Bergmann
...which reports 271 instead of 276 here, for whatever reason Change-Id: I897fcfdc83055e4c2aacd024792266afd0754ab5 Reviewed-on: https://gerrit.libreoffice.org/79065 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-20Remove legacy NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY supportStephan Bergmann
...for ASan/UBSan builds using Clang older than current trunk twoards Clang 9, as announced at <https://lists.freedesktop.org/archives/libreoffice/2019-May/082654.html> "Re: [Libreoffice-commits] core.git: The -fvisibility-ms-compat hack is no longer needed for UBSan on Linux...". (And drop the no longer needed solenv/sanitizers/asan-suppressions, which people might still reference from their ASAN_OPTIONS.) Change-Id: Iedc0c5955366d2cbe7dc847990e2b1576750e85b Reviewed-on: https://gerrit.libreoffice.org/72493 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-20Related: tdf#127645 return value is unusedCaolán McNamara
which is handy, cause its wrong anyway Change-Id: I0b52b3ac55c264dcd53acaa80f505cabd54faa15 Reviewed-on: https://gerrit.libreoffice.org/79270 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20Related: tdf#124600 sw anchored object allow overlap: add DOCX filterMiklos Vajna
Which also made it necessary to support allow-overlap=no for not only shapes, but for shapes-with-text in the layout. Change-Id: Ibd229d21995c0a1053db6bbab0a6ccbbf75f36d3 Reviewed-on: https://gerrit.libreoffice.org/79277 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-20tdf#109158 improve load time of autocorrect XML fileNoel Grandin
Before, it seems to be doing a lot of unnecessary work because, by default, startFastElement will call startUnknownElement, which constructs various objects, etc. It seems to me that if the class already implements createFastChildContext, it is already using XFastParser, and so it should implement startFastElement to avoid that work. By avoiding going down the startUnknownElement path, reduces load time from 1.7s to 1.4s Change-Id: Ifd745cf2cc22a8cb988a5668332cf6e70bb996da Reviewed-on: https://gerrit.libreoffice.org/79269 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-20rebuild sharedvisitor.cxx if any of its sources disappearsLuboš Luňák
Testcase: Remove any reference to LO_CLANG_SHARED_PLUGINS from e.g. blockblock.cxx, sharedvisitor.cxx should get regenerated. Change-Id: Iddff3cf41c223cfdf161060d29bde9df1df7b702 Reviewed-on: https://gerrit.libreoffice.org/79194 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-09-20tdf#109158 improve sorting when loading large autocorrect fileNoel Grandin
reduces time from 2.0s to 1.7s reduce work by (*) reserving some arrays (*) pre-sorting with a cheaper comparator (*) don't copy when returning result, just return a const& (*) flattening the data-structures to reduce pointer-chasing Change-Id: I972bd7ffdbf2121c2d38c24aca9618ca708e920c Reviewed-on: https://gerrit.libreoffice.org/79119 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-20xmloff: create XMLDrawStylesExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I875cdd1f1ee4e57522d992768dfbcdb0da9f3fd3 Reviewed-on: https://gerrit.libreoffice.org/79228 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-20Resolves: tdf#127646 remove undispatched events in dtorCaolán McNamara
Change-Id: I8d18b0b667a905131fd0edee1f73ebab144e6307 Reviewed-on: https://gerrit.libreoffice.org/79244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-20tdf#39593 Drop ScDataPilotDescriptorBase::getImplementationArkadiy Illarionov
Replace with comphelper::getUnoTunnelImplementation. Change-Id: Ice068fcce262014a812a9e0a5d92b8bac173fa39 Reviewed-on: https://gerrit.libreoffice.org/79112 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-09-20no more SwClient: sw/source/filter/htmlBjoern Michaelsen
Change-Id: I45915fa65157aa6a16ecee238d9072d359d3b464 Reviewed-on: https://gerrit.libreoffice.org/79264 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-20no more SwClient in sw/source/filter/basflt/Bjoern Michaelsen
Change-Id: I56c9d140bc92ad517cb808e99cdb942f89cdbedc Reviewed-on: https://gerrit.libreoffice.org/79263 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-20no more SwClient in sw/source/filter/ww8Bjoern Michaelsen
- prevent apparently leaking ~all InsertedTableClient by using a unique_ptr - rename InsertedTableClient to InsertedTableListener Change-Id: I60407113bf0ba28f5944ff9241a2d8a80a03d399 Reviewed-on: https://gerrit.libreoffice.org/79262 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-20remove SwClient/SwModify in source/core/viewBjoern Michaelsen
Change-Id: Ic6325def53fe5f15d731946f6069b020f3a40a32 Reviewed-on: https://gerrit.libreoffice.org/79259 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-20tdf#127534: brown paperbag commit, use the right bug ID this timeBjoern Michaelsen
Change-Id: I42224bb35f308e274ee5441948b3a9b938b0889f Reviewed-on: https://gerrit.libreoffice.org/79260 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-19tdf#123926: SVGIO: Check parent's fill when...Xisco Fauli
... the element is a clippath and fill=none fill="none" is created as SvgPaint(aColor, true, false, false) in svgtools.cxx meaning bSet = true, bCurrent = False and bOn = False, so it never checks its parent if it's a clippath Change-Id: Ia8c556674809b2b86280219e4084550e366bbff8 Reviewed-on: https://gerrit.libreoffice.org/79201 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-09-19tilebench: initial joining testMichael Meeks
Add sub-tile dumping code, and do compares. Change-Id: I5bc29c07e1075ac40b495f35d01d433e81ba309a Reviewed-on: https://gerrit.libreoffice.org/79195 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-09-19tdf#125307: move range properties check to own testBjoern Michaelsen
- the document styles tests seems mostly unrelated - also: add bug reference in commit message subject, so that the bugzilla bot can do its shtick - all the real work done already by Thomas Viehmann on commit 2f679fd3e6f46df7cda77eb70a014bcfcac7df52 Change-Id: Ice5860c15c05fae37f0ba337d804de70acf3d936 Reviewed-on: https://gerrit.libreoffice.org/79132 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-19remove SwClient/SwModify in sw/source/uibaseBjoern Michaelsen
Change-Id: If9c876104a590a966abed365766819e76e39a15d Reviewed-on: https://gerrit.libreoffice.org/79211 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-19no more SwClient/SwModify in sw/source/filter/{ww8,xml}Bjoern Michaelsen
Change-Id: Ia09e84195811c6548bc6cbafc4145ce04537ec91 Reviewed-on: https://gerrit.libreoffice.org/79185 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-19Related: tdf#124600 sw anchored object allow overlap: add layoutMiklos Vajna
If there is an overlap, then a shift towards the bottom or towards the right would resolve that. Word seems to always push down, do the same for compatibility. Otherwise, let's see if some fine-tuning will be needed for the behavior, sadly "20.4.2.3 anchor (Anchor for Floating DrawingML Object)" in the OOXML spec (the allowOverlap part) only says the overlapping object has to be re-positioned, but does no go into details. Change-Id: Ie1b4626f6d06862d617e28e0cb74838107d993d1 Reviewed-on: https://gerrit.libreoffice.org/79141 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-19tdf#104339: SVGIO: Add unittestXisco Fauli
Change-Id: I6ecb366a889fe64bc90db0e041b4ddd4bc3dfc3f Reviewed-on: https://gerrit.libreoffice.org/79129 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-09-19sw/filter/hmtl: SwClient/SwModify no moreBjoern Michaelsen
Change-Id: Ib469f83f61cea81fc551f04f6f059b3a0a2b5f18 Reviewed-on: https://gerrit.libreoffice.org/79182 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-19no more SwClient/SwModify in sw/uiBjoern Michaelsen
Change-Id: Idbf5e6826093a2e7dba3680cf08a2df348bce8b9 Reviewed-on: https://gerrit.libreoffice.org/79181 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-19cid#1453856 Uninitialized scalar fieldCaolán McNamara
Change-Id: I36217924d6082e65d570e218da317916b67f45eb Reviewed-on: https://gerrit.libreoffice.org/79139 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-19Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Add a warning detailing how to check Python's presence. Change-Id: I31a1f4a99742b05f6f7a0c1b9904e78475ea9a4e Reviewed-on: https://gerrit.libreoffice.org/79177 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-09-19mpWindow might be a GtkEventBox instead of a GtkWindowCaolán McNamara
Change-Id: I6f547d6d21a60661c78bc919536dc4cf319089e5 Reviewed-on: https://gerrit.libreoffice.org/79120 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-19cid#1453855 Uninitialized scalar fieldCaolán McNamara
Change-Id: I31f9fc5da574d527e9214299b079b30dd0df0dfe Reviewed-on: https://gerrit.libreoffice.org/79140 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-19Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix bad writing style Change-Id: I1956984253f29cd2c48d624bbbcfbf9d0531f11a Reviewed-on: https://gerrit.libreoffice.org/79107 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>