summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-10-07disambiguate uniform_int_distributionCaolán McNamara
Change-Id: Ifa0c1b1983d1cc7f22d55b15dee88b7f709dbcf8
2014-10-07-Werror=unused-resultMiklos Vajna
Change-Id: Idf10a5cb70176c24d609f70ec01c1630ab1dad37
2014-10-07LocalOffice should be an abstract classNoel Grandin
Change-Id: I9531b64dc8cb2545dfc41ae4d69007eced8f2d26
2014-10-07java: simplify some for loops to while loopsNoel Grandin
Change-Id: I323ab12c634d3baa4f624b63d7d483112c23192c
2014-10-07while loop that ends in a return is more accurately an if blockNoel Grandin
Change-Id: I94b74b46b185e1061b6b72acdf3d9dc0c1d122c8
2014-10-07java: use isEmpty() instead of "size() == 0"Noel Grandin
Change-Id: I23e1038246999b0744d8e9ae83b66fa1f7dafa99
2014-10-07java: use equalsIgnoreCase() instead of toLowerCase().equals()Noel Grandin
Change-Id: I8f4afc7e15a9d85d99ea80edbbbd2b507b254ddc
2014-10-07java: use equals() to compare Strings, not ==Noel Grandin
Change-Id: Ia41a4899fb82df7b580a020765404c4ef0cddfa2
2014-10-07java: simplify conditions involving logical negationNoel Grandin
Change-Id: Ib45e58273e650ef9a31dbdb5f71e995a5976f50e
2014-10-07java: log exceptions correctly, using the right version of WARNNoel Grandin
Change-Id: Ide21786d5275802ee60de2d5f056aa08cc8497ca
2014-10-07java: remove some unnecessary intermediary object creationNoel Grandin
Change-Id: Id4949fa08546e710fbf9bd0c7e3bf62979f29c83
2014-10-07java: optimise calls to toArrayNoel Grandin
passing in a correctly sized array requires one less allocation Change-Id: I6198d226d9b630c99c4e8b6e3d0fdf890c495b44
2014-10-07java: remove unnecessary adding of empty stringsNoel Grandin
Change-Id: I3825ea5fb1eb34ca52659350e202f95abea945a9
2014-10-07fix classname in loggerNoel Grandin
Change-Id: Id4d954059d63036b78cfeb7b14a7ebd8eae73f46
2014-10-07java: no need to check for null before calling instanceofNoel Grandin
the instanceof check returns false when passed a null value Change-Id: I7742d0d9cf25ef23d9adee7328f701c7efeea8b5
2014-10-07java: remove useless overriding methodsNoel Grandin
that only call their superclass method Change-Id: I9be2f69be132eec7918964f504c50df0ae8401a2
2014-10-07java: no need to explicitly extend java.lang.ObjectNoel Grandin
Change-Id: I635d1f99aa104909bd53a49c18efd433b9b9cb98
2014-10-07-Werror=sign-compareMiklos Vajna
Change-Id: Ic96b85c5c4995f47781eceb6a426a29d8b7679ea
2014-10-07Proper AC_CONFIG_FILE treatmentStephan Bergmann
Change-Id: Ic029d0d174a00af783fd276852231523aae59866
2014-10-07Disable sdremote by default, and improve flow control.Michael Meeks
It was intended to disable sdremote by default when it exited experimental mode. This reverts commit 576943b9bf7506829de97d2194c4bee35a485436. Change-Id: I2c1b5443e334021bd9574316167f48b1af6200e5
2014-10-07xmerge: reuse the value of node.getNodeName() and remove duplicated constantsRobert Antoni Buj i Gelonch
Change-Id: Ia835139496ab8e5230a09df2caf23637a5559ba4 Reviewed-on: https://gerrit.libreoffice.org/11836 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-07fdo#81475 Finalizing new layout of Writer formatting toolbarYousuf Philips
Change-Id: I0d65c96d8d0447ab2191c441acfd5bd9ce8015b8 Reviewed-on: https://gerrit.libreoffice.org/11817 Reviewed-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com> Tested-by: Samuel Mehrbrodt <s.mehrbrodt@gmail.com>
2014-10-07I shouldn't be shy, just assert()Tor Lillqvist
Stephan dislikes "defensive programming" and I trust him. Change-Id: Ic4864de98a5155129179eb89873f3ffdc8921614
2014-10-07Don't call comphelper::rng::uniform_real_distribution(a,b) with a==bTor Lillqvist
Change-Id: I95a3ac8da83e02001de13af8d31a04fe0d654dc0
2014-10-07Handle incorrect usage of uniform_real_distribution()Tor Lillqvist
uniform_real_distribution(a,b) should be called with a < b, otherwise the result is undefined. Currently, when called with both zero, it gets stuck in a loop. Not sure if a blunt assert() would be the right thing here, so I just return a if a >= b. Change-Id: I769688c7192bd02bad24ad597948984db56dd4fc
2014-10-07Use constants for ST_Em valuesMiklos Vajna
No need to adapt dmapper/rtftok for this one, as those do not handle <w:em> ATM. Change-Id: I88da1d0dae804e3d054b7d4158a81cb64cc4b600
2014-10-07-Werror,-WuninitializedStephan Bergmann
Change-Id: I91333f5290c84c6317b85572824be065da9cf64b
2014-10-07~SdUnoPageBackground() gets a SolarMutexGuardMichael Stahl
Change-Id: I76582bb6a1a8dee56611f1463d3e63246eefb310
2014-10-07fdo#79604: sw: fix clicking on hyper-links in Draw objectsMichael Stahl
The URL is dispatched in MouseButtonUp(), but this relies on MouseButtonDown() not selecting the drawing object when the cursor is over an URL field. (probably regression from commit 7e2f98d0a0c4a0f36a94353a256e7cc5caa3113b and commit 5ed14025645200c77249da364870f5772c01df17) Change-Id: Ib1504baff5d1fffd6ce53b41d3ff726d8e4d5c9d
2014-10-06-Werror,-Wnon-virtual-dtorStephan Bergmann
Change-Id: I8fa5c345760185baf1f0fa83c94898b2a5a86719
2014-10-06Remove pointless commented-out 'virtual' keywordsTor Lillqvist
Nobody knows any more what such a metacomment was supposed to mean, if it had any deeper meaning at all. Change-Id: Iefb4fedc7b833c09ee0e39b3eb28202229323ef2
2014-10-06avoid use of ref. to possibly deleted objectDavid Tardon
Change-Id: If5977b280fed8d8b053f59852d3984a59ce61a69
2014-10-06Revert "ADO driver: don't override a virtual method just to call the one of ↵Lionel Elie Mamane
the parent" This reverts commit 220deb0a0ed7b3efa14088acdab0520709309105.
2014-10-06Revert "ADO: don't override a virtual method to call the one of the parent"Lionel Elie Mamane
This reverts commit fa8f2fdf45c168a25dd955ebd24780b4863d6cde. Change-Id: I252e29648fb59a15379ba2f3b63d6914a7fc3a93
2014-10-06ADO: don't override a virtual method just to call the one of the parentLionel Elie Mamane
Change-Id: Ibae309ffbb7b2500c9113a95ca3fc508de378976
2014-10-06mozab driver: don't pretend to implement an interface one does notLionel Elie Mamane
Change-Id: I8ab2e2691ecf35e00283bd3144b2f4c8203adc3a
2014-10-06ADO driver: don't override a virtual method just to call the one of the parentLionel Elie Mamane
Change-Id: I39020452e8ff4b17b0c1cfb9ff54bf650ab97fc3
2014-10-06ADO driver: don't pretend to implement an interface one does notLionel Elie Mamane
Change-Id: I6234974cfc1b7650a35b8f7b9a4132acf797c91b
2014-10-06warning C4101: unreferenced local variableStephan Bergmann
Change-Id: I526e68b93f9665db25a824cc44ff231bcef29277
2014-10-06loplugin:unreffunStephan Bergmann
Change-Id: I00240e0d17e40e187b82875bbd25a0630120c4d7
2014-10-06encrypt sf_508f4e1..rtf to avoid it triggering virus detectionCaolán McNamara
use name CVE-pseudo-2009-0238-1.rtf to record its detected as Virus:Trojan.Mdropper and pseudo because its just a fuzzed file from some random .rtf and not an original reproducer for CVE-2009-0238 Change-Id: I85f6a72e0d32c14ea27cbe03bc4da3c2306fd1f5
2014-10-06Resolves: fdo#80101 inserting non-chart as chart -> unhandled exceptionCaolán McNamara
Change-Id: I4d5438292d9a5c49f1336304ebd3dc4e155dd212
2014-10-06Resolves: fdo#84588 loop in TableInfo::getNextNodeCaolán McNamara
Change-Id: I5bb44dc94041c3b3cd9d80ba125594a48c9c921f
2014-10-06cast to size_t altogetherCaolán McNamara
Change-Id: I93cb374bd9743c45c4f3a98799a5f448dbb46fd8
2014-10-06Related; #i125163# rename IsAdaptedToNewFillPropertiesCaolán McNamara
to supportsFullDrawingLayerFillAttributeSet so as to rename our equivalent solution of d3de12fcfc85feb36eda3b0495807ef11d8fe772 "Resolves: fdo#81277 missing table cell background color in doc/html import" with that of 36cc153d32bc262c2285d333a1369f6ca36a7fba "i125163 Corrected FillStyle handling for tables in Writer" Change-Id: If8ecbc712e01d823d034ff3771bf38a4df16368d
2014-10-06SwTxtNode::Update: don't move anchors at insert positionMiklos Vajna
Use cases: 1) User of the XTextAppend API's uses appendTextPortion(), then appendTextContent(), then appendTextPortion() again. It's expected that the text content will be in the middle of the paragraph, but before, it was at the end of it. It's possible to work this around by inserting the text contents only at the end of the paragraph (like it's done for ODF import in XMLParaContext::~XMLParaContext()), but probably it's not a good idea to copy&paste this workaround in all the import filters. 2) User types some characters in a new document, then inserts a picture, and sets anchor type to at-char. Now the anchor point is set to the end of the paragraph, but it's impossible to type anything after that character. To be fair, now it's not possible to type something *before* the anchor point, if it's at the first character, but hopefully that's less of an issue, since setting the anchor type to at-char sets it to the end of the paragraph, not at the start of it. Change-Id: Ia8b33e8880aae86f62fae09cd5ac1cf82c83320f
2014-10-06Missing includeStephan Bergmann
Change-Id: I47ddb95018109e5e771324b699dfdc10f529dfc4
2014-10-06Resolves: fdo#84649 can have negative values from ConvertToModelPositionCaolán McNamara
Change-Id: I570ee54e15a4cd4b11da26004164d9e6a1d8cdb9
2014-10-06when size_t == unsigned intCaolán McNamara
Change-Id: If8cd3632d69f6456b0e1351efac0e428e0093e3b
2014-10-06Refactor giant SwDocTest::testModelToViewHelper() into smaller testsMatthew J. Francis
This is to clear the way for following bugfixes which will add to / amend these tests Change-Id: Ie97aba72f1a4c7b1be37577b9bcab2b2f0750d17 Reviewed-on: https://gerrit.libreoffice.org/11808 Reviewed-by: David Tardon <dtardon@redhat.com> Tested-by: David Tardon <dtardon@redhat.com>