summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-08-13xmlsec: add XSLT safety warning labelMichael Stahl
Change-Id: I8d5ac40ec0c0b0a9fb3fb369578ff1f14b512254 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120387 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-08-13tdf#114441:Convert use of sal_uLong to better integer typesEmircan Agac
Change-Id: I14cfc4113e9aff0fcff3b2d3c2b0444aad8934ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120332 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-13Export Math ML from new mathml nodesdante
Review tip: thanks for your help Code heavily based on: mathmlexport.cxx mathmlexport.hxx https://opengrok.libreoffice.org/xref/core/starmath/source/mathml/mathmlexport.cxx?r=e271fce8 https://opengrok.libreoffice.org/xref/core/starmath/inc/mathml/mathmlexport.hxx?r=10d29c39 Change-Id: I798d0e207b844240f4b25720ee37c394eb4c2e65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-13tdf#139734 Drop redundant asserts after MacrosTest::loadFromDesktopKaranAbrol
Change-Id: I9a183ed9046ab0610a538c74e3ff8b327a6f6e4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120348 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-13sw: handle mbKernAsianPunctuation when replacing compat optionsMiklos Vajna
This is a compat setting in Word documents as well. Change-Id: I69f80ffaff00564fd6e09c5ca7495fa718ba6528 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120411 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-13sw bibliography: fix missing identifier + local URL in biblio referenceMiklos Vajna
Regression from commit 5fd2f212a1db9e061fb3a886810b427251e8a6bf (sw bibliography, local copy: handle the bibliography database window, 2021-07-27), the problem was that the newly added LOCAL_URL column affected BibliographyLoader::getPropertyValue(), which was not adapted, done now. Change-Id: Id3bd95bdd5c692048a50ce7ba2e5cdf16e824bd9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120400 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-13indexing: allow for multiple entries in search indexing dataTomaž Vajngerl
Change-Id: Idb9bbbaa940b7cd48423c6cc65b9c7d0b94f57dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120396 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-13Replace ReadGDIMetaFile with SvmReader::Readpanoskorovesis
Use the new Read functionality Change-Id: Ied997377fda8793422b1c8877ece705e4a9b6dbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120376 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-12tdf#143809: sc_subsequent_filters: Add unittestXisco Fauli
Change-Id: I5e2729edbf46128195c441459970c5946cd2ad17 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120403 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-08-12use --with-idlc-cpp=cpp instead of --with-system-ucppCaolán McNamara
for these special targets now where we want to avoid building ucpp Change-Id: I9ffa6f4148e8b5cafd7d34df4f2e18ec6f6c75c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120413 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-12disable gcc warnings when using boost::make_sharedNoel Grandin
Change-Id: I02a54d9ab9c1faf36ce0b03b6ca42b3708f02667 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12make --with-idlc-cpp=cpp work for gcc cpp as a ucpp replacementCaolán McNamara
e.g. the example of https://bugs.launchpad.net/ubuntu/+source/libreoffice/+bug/1524638 has the same output .urd using cpp with these flags as ucpp created Change-Id: Iadfd2deba7d365c66c3260fd6736c031987e107c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120347 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-12ofz: use system .a libs when they aren't c++ onesCaolán McNamara
Change-Id: I12e44bf2dbeebc0d18e48a22831099c3dad7b12d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120402 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-12Resolves: tdf#132739 two style tags where there should be just oneCaolán McNamara
Change-Id: Id9c8c8cc8c5ffdd21ba79ff39a6279cf2ddc8025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-12Resolves: tdf#143843 disable the recently-used widget during loadCaolán McNamara
We show a busy-cursor but the widget can still be interacted with so another document can be launched by clicking on another recently-used item while the first one is still loading, and the recently-used widget isn't prepared for this scenario so the second to complete load will crash. Disable the recently-used widget when its cursor is set to busy, and in the (unlikely) case that the load doesn't complete normally (missing document or load filter error) and the recently-used widget still exists and its cursor is unset from busy then reenable it for user input at that point. Change-Id: I8f4487f3dbede14c9778e49442366bd9445f1d63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120399 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-12tdf#88205: Adapt uses of css::uno::Sequence to use initialize_list ctorZeynep Yavuz
Change-Id: I3c01bb8abeee949bcd1aae861aeb1b1ac516ec58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120299 Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-12SfxModule optional fields might be empty, cannot unconditionally derefNoel Grandin
fallout from commit 9ce7ada4530074d95d05efdc89a7eba1032d99e0 Author: Noel Grandin <noelgrandin@gmail.com> Date: Wed Aug 11 20:47:36 2021 +0200 flatten SfxInterface_Impl Change-Id: Ib57dd89903ec7f3c73a8466e33e47c4184962620 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120397 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-08-12cCSS1_style_opt_end is '\"' so these two lines are the sameCaolán McNamara
Change-Id: I20974698706a6b64fe6a60030364c7a8b91415a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120392 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-12Remove unused, obsolete checknewapi toolStephan Bergmann
...that had been introduced with bbdd3fe352b320e7183ae18449e15ac517269b55 "INTEGRATION: CWS jl31" ("2006/02/17 14:26:14 jsc 1.1.2.1: #i62141# new script to prepare some uno type statistics") Change-Id: I7d738311da73390d29ee1b25e90f58d007cf4cca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120395 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-08-12tdf#95549 speed up xls openNoel Grandin
Remove the m_wThis field, and instead just check the ref count to know if we are being called from our own destructor. Also re-order ScCellRangesBase::Notify so we do the cheap checks first. This shaves 2% off the load time Change-Id: Ie95a4ff46bacba583ec4b3a934f98a9aac3551b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120385 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12tdf#129270: sw: do not copy list level on paragraph cutVasily Melenchuk
Current list level (RES_PARATR_LIST_LEVEL) is initialized before, but current value can overwrite it with invalid in given context. So we could have mismatch of outline style (which are not overwritten) and actual list level. Change-Id: Ibf34a6f35b922493c4a1477326ea6c1599b4938f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120212 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-08-12tdf#95549 speed up navigator tree loadNoel Grandin
(*) inline the load loop (*) remove Refresh call from ScNavigatorDlg constructor, the SetListMode call at the bottom will trigger a load of the tree content Change-Id: I27f1d1bde89d8dcb5cc111ae132fbb05abc2fc7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120383 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12tdf#95549 speed up load of xlsNoel Grandin
we don't need to perform layout during load, so disable a few places that do that reduces load time by 50% Change-Id: Ie746ca0b46de3b76ca1b7291e0528b525333278f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12s/mpEdtOutl/mpEditingOutliner/gNoel Grandin
Change-Id: I5eb188cc1808055857f95c73ab838251cd93e4b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120379 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12backendtest: Closed Bezier loop test using various drawing methodshomeboy445
Change-Id: Ib2ddc8475e2476ce377f3541caa0d48e7c57241a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118783 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-12include optional header for std::optionalCaolán McNamara
Change-Id: I5e2c42498691d1fccf5122720e56bf44462ce21d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120382 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-12ofz: liberation-fonts-ttf alone is sufficientCaolán McNamara
Change-Id: Ifa6938c759c0c1036120da2eeadefbe00ae96f0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120381 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-12Capsulate TableBox<>TableBoxFormat relation in a functionBjoern Michaelsen
Change-Id: I731e9bae04147f7453721661228e78a16ed585db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120160 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2021-08-12tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorEmircan Agac
Change-Id: Ifce4c42df52ce03ed1c509d9fc28de79f5b3426c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120199 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-08-12Add Handler for TextLineColor Writepanoskorovesis
The handler separates MetaTextLineColorAction::Write from metaact.hxx Remove default case as it's not needed anymore. Write implementation is now in SvmWriter.hxx' Change-Id: If0c23649d9fef49e07c558c8f7fddb028d5da9ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120372 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-12Add Handler for TextFillColor Writepanoskorovesis
The handler separates MetaTextFillColorAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I9f67def86f0c189bed880f790760c18098611c45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120351 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-12Add Handler for TextColor Writepanoskorovesis
The handler separates MetaTextColorAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I58f7102edeae6f9a712a79ed5de8ce9b3e27510a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120350 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-12Add Handler for FillColor Writepanoskorovesis
The handler separates MetaFillColorAction::Write from metaact.hxx Write implementation is now in SvmWriter.hxx Change-Id: I324b1a41f1be122367a69b8ac601bd12ca8401fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120349 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-08-12tdf#143318 DOCX import: fix missing redlines in flying tablesLászló Németh
makeRedline() exceptions (in the case of already existing redlines) skip the creation of the next (not existing yet) redlines in tables inside fly frames. Here: a tracked table moving revealed the problem, with the missing rejection of the new position, i.e. the "new" (second) table of the document. Note: fix also collecting redlines within tables: IsInTable() isn't true in the first cell of the table, losing the redline here, so it's replaced with m_nTableDepth > 0. Follow-up to commit 7f3c0bbc174b9b0316991c174ca3b407c0e3d141 "tdf#143510 DOCX import: fix tracked table drag & drop". Change-Id: Icf6dd62eb950e5af6a75353dffabb9e9433c1b44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120333 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-12tdf#143129 PPTX: custom slide show use as default is not exported.Tibor Nagy
Follow-up to commit 11ef976624dce8a8e50a1eb20e9c586519fd7ec8 "tdf#142590 PPTX import: fix custom slide show use as default" Change-Id: Ie8a53a79bd531cfe2c3b3559b70d28770ca8b960 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/119564 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-12add some --disable-scripting fixesCaolán McNamara
Change-Id: I94523d4323544fe6c475f0c5cf4113e6d783939e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120374 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-08-12tdf#114441:Convert use of sal_uLong to better integer typesEmircan Agac
Change-Id: I0642261314f9b04fb38b68afd44d879c1e83c830 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120300 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-08-12flatten SfxInterface_ImplNoel Grandin
Change-Id: Ic66ed6d9738ee6fbbc2dc0b5a572e1ea57092b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120345 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12flatten SfxFoundCacheArr_ImplNoel Grandin
Change-Id: Ie2b29b041bb0f678494126b21df651371a40dbda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120344 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12tdf#131546 DOCX import: fix performance regression at tablesBalazs Santha
Commit 2ab481b038b62b1ff576ac4d49d03c1798cd7f84 "tdf#90069 DOCX: fix character style of new table rows" caused ~20% slowing down in loading time of documents with huge tables, related to the extra processing of the redundant w:rPr of table paragraph runs. (In DOCX tables, MSO exports the run properties into the run and paragraph sections too, probably because of compatibility or usability reasons.) Theoretically in this case, the run properties which are under the run section win. On the other hand, because LO copies the props which are applied on paragraph level, and only them, when copying a row (e.g. upon inserting a new one), it was needed to apply the mentioned run props not only as direct character formatting, but as a direct paragraph formatting too. This way, the support of copying of rows are solved. Unfortunately, this "double" applying was done for every single paragraph, which quite slowed down the opening time. This patch gives a workaround, which completely removes this double applying functionality in the writerfilter by reverting commit 2ab481b038b62b1ff576ac4d49d03c1798cd7f84 (except its unit test), and copy the mentioned run properties into paragraph level, when its needed: upon inserting a new row before/after. This way we spare a lot of cycles, as most of the original applies had no real use whatsoever. Change-Id: Ic24d0d1830e9ec43323e5e213d6481ec28e9abe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118985 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-08-12lok: sw: avoid duplicate LOK_CALLBACK_TABLE_SELECTED msgsDennis Francis
Alternate approach is to track changes in the active table in each view but it needs a bigger change and run the risk of overlooking cases where table dimensions and position changes, which is possibly why this message is created from UpdateCursor() in the first place. Change-Id: I06643e2a7416d6c0fe2b0dc5c9b4adcd45fa50c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118001 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 34ade20a09a1c3fe08daec2b276a06a1f895bd5a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120354 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2021-08-12Fix typoAndrea Gelmini
Change-Id: I22b6912d2d26c26447fbddefcf15fc6dea8e8717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120228 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-08-12sw: remove some unused includesMiklos Vajna
See tdf#42949 for motivation. Change-Id: I4931ac951e4051fb02e44868a9743bf6bb73d645 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120336 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-08-12tdf#126961 link to macOS address book - crashes and restartsNoel Grandin
completely untested, but highly plausible Change-Id: I107978aa6bf8b77cee06ffc5be6bff8b651b11f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120287 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12flatten SfxModule a littleNoel Grandin
Change-Id: I6620e9d6d6d4b0a1b39f6d98acb0e72621f853a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120343 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12flatten FastSaxParserImpl a littleNoel Grandin
The EventList instances are movable (and are really just pointers to buffers of data), so no need to use unique_ptr Change-Id: Ic3e13e949f5a61ee9cc5fcf8da9e22094e8ab9da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120342 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12flatten OZipFileAccess a littleNoel Grandin
Change-Id: Ib03dadcd69a65493ddd9c0437fc654beef039ad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120341 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12flatten ZipPackage a littleNoel Grandin
Change-Id: I0295bd8d72686996afb9d361db12b6014594b402 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120340 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12flatten LngSvcMgrNoel Grandin
Change-Id: I757cf9512fc3b87dd826eb39c2bbe456dc14d097 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120339 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-08-12Unify and simplify tools::Rectangle methods returning PointMike Kaganski
Make the methods use Left()/Top()/Right()/Bottom(), allowing to avoid explicit checks for emptiness. Also do not use std::min/max in *Center(), so that e.g. TopCenter returns top value the same way as TopLeft and TopRight do. Change-Id: Ie1edd7a0ab7e32b4f98d0c2fb3917ce2902bdf7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120353 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>