summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-12-23drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for writerperfect Change-Id: Ia401f8e92f1ef16df646c1adc9e6ad05a0f9af0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108205 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23remove deprecated (and unwanted) resize-modeCaolán McNamara
which probably got in initially by accident on scrolling in glade's property templace when the mouse was over "resize mode" and then copied and pasted around the notebook especially Change-Id: Icd01848b7f51f670db1cb150ffba4ee7a487ce96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23add utility NbcRotate methodNoel Grandin
Change-Id: I66d016a22158f9f9ef68a80842e95e45516f0b4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108228 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-23fix ppt gradient importNoel Grandin
it is this way as far back as 2009 (couldn't see beyond that). Found while doing some work on verifying how degree units are passed around. Change-Id: I6c8839aa390825f2aab38c70d623109543fddf19 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108237 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-23tdf#135504: Install application metadata in /usr/share/metainfoChris Mayo
Current path /usr/share/appdata is deprecated [1]. [1] https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#spec-component-location Change-Id: Ibd837240ad329c005a840f9ae2e0f4f13f139b59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106025 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-12-23Initialize method mapping table at compile timeMike Kaganski
This removes the need to calculate hashes for the table at runtime. Also this introduces a static assertion to make sure that the table has correct structure, and fixes some methods that had wrong argument counts: CreateUnoListener: 1 -> 2 MIRR: 2 -> 3 SLN: 2 -> 3 SYD: 2 -> 4 Changes in basic/source/classes/sb.cxx are related to the change of SbxVariable::MakeHashCode into constexpr function taking string view. Change-Id: I2fec4994e976f36c4b647c30b51a9e879a815775 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108220 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-23drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for fpicker Change-Id: I47ac66f7b823aa6cf8faa184f561cffb259eb2f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108204 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for reportdesign Change-Id: I5a68d542dbc071e6e1aa01d1f7ff7ae4d9758698 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108203 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for extensions Change-Id: I3dcde5981ba6254277edcf2442cfa03de2a6be5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108207 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for sidebar* Change-Id: I484812e8fe22b1789c45746f9a3b2be40f33c75f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for filter Change-Id: If10a96a3f51849076d45ed7d1553bb898a64b5b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for basctl Change-Id: I635b305ee0a02a0d8629a324f9f46405515e9f08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23if the label is explicitly set there is no ambiguity as to the labelCaolán McNamara
a child-count of 3 can arise for a temporary period during loading of widgets inside GtkScrolledWindow where the child widget supports its own scrolling and is parented as a sibling of the GtkScrolledWindow during load until the node is complete and then the redundant GtkScrolledWindow is removed after mirroring its properties to the scrolled-child Change-Id: I1a7dbf9ec2415beb0f7e920fec5c05e87ddaaeee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108221 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23tdf#138457 Cursor position wrong when using functions in a writer tableCaolán McNamara
Change-Id: I70156d8492afbab2c5993e1627a024ef8e07c492 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108195 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-23Directly pass in OUString instancesStephan Bergmann
All the passed-in pStrmName are either pXMLImplCplStt_ExcptLstStr or pXMLImplWrdStt_ExcptLstStr, both of which are ASCII-only, so using RTL_TEXTENCODING_MS_1252 wasn't relevant. Change-Id: Idc6fa06b31641f4004da090378adaed73e07e5bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108234 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23jsdialog: fix disable idle notifyHenry Castro
There is a possible crash due to nullptr deference Change-Id: I3e2034ad89832eec61f1d6910a5ffd34c56df6a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108224 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2020-12-23Directly create strings in *::MapTokenToServiceNameStephan Bergmann
...and pass them into XMLTextFieldImportContext and derived ctors. The assert in the XMLTextFieldImportContext ctor is moved up to the two MapTokenToServiceName functions. Change-Id: I75c76cd6129e79ad54ea87e7d3419ca49679875d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108235 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23Directly create OUString instancesStephan Bergmann
Change-Id: I58c9104b5efbc2252be7f32019a667ab95ccfaf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108233 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23Rename sorted_vector::erase(size_t) to erase_atJan-Marek Glogowski
emscripten clang fails with: sc/source/core/data/attarray.cxx:378:44: \ error: call to member function 'erase' is ambiguous aNewCondFormatData.erase(nIndex); ~~~~~~~~~~~~~~~~~~~^~~~~ include/o3tl/sorted_vector.hxx:86:15: note: candidate function size_type erase( const Value& x ) ^ include/o3tl/sorted_vector.hxx:97:10: note: candidate function void erase( size_t index ) This looks like a compiler error, but if the vector contained size_t values, this would also be ambiguous to begin with. So this just renames erase(size_t) to erase_at. And instead of a 2nd find in the failing code, after copying the vector, it mow uses std::distance to remove the item. Change-Id: I7d03ff32352a1890cc01ca241452c0f00d6a9302 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108212 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-12-23tdf#138246 Disable edit rename delete contextmenu items for built-in templatesVert D
Change-Id: I7bcaa8acc034a3d3e9926db2f1f54bbeceddca2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107611 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-23tdf#130275: Fields dialog is too tallKevin Suo
...which makes the OK/Cancel buttons invisible under small displays. This commit changed the height of these widgets. Also I did some tweats to the UI file and the width so that the edit dialog of these fields looks nicer (at least on my display). Change-Id: I9f39727afd566d75db525c5a5cafe2eabb66d7ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/107965 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-23tdf#127401 Fix release notes URL for simplified Chinese (zh-CN) UIMing Hua
Use getBcp47() instead of getLanguage() to construct release notes URL for About dialog, just like what commit 787647b488d02be2acbbad4fa7873508dcb926c2 did for WhatsNew infobar. Should also affect other locales using ll-CC style wiki notation with both language and country codes, like pt-BR. Change-Id: Ic4698946f500b5901eb0c519f1fd4e3a4b8456cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108147 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-23fix columns widths and formated stringVert D
Change-Id: I99d4cf17a49ce78857b282b5be5d8c88ddd7e740 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108136 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-12-23tdf#121472 XLSX export: fix external Linux pathAttila Szűcs
Removed the extra 4th '/' after 'file:///' from aData.maBasePath at exportDocument(). In Linux, the root path could start with '/'.. like /home/... in that case 'file:///'+'/home/..' resulted 'file:////home/ that is invalid. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Ia37a11def80df2747578807ee021fafe38d48ec0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108131 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-23use Degree10 in SdOptionsSnap and fix some conversionsNoel Grandin
Change-Id: I254b11d08049c4fbeaf77dc84812b19bc7f55c45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108230 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-12-23Make functions in rtl/character.hxx constexpr for internal useMike Kaganski
Allows to use them in compile-time initializers. Change-Id: Ifa4b8da5db6ad7b1d7c87cb2476f4c59abeb32d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108219 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-23Use char16_t string literalsStephan Bergmann
Change-Id: I0a8b577957ac1d4cad5fc1163f244012a8391a77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108216 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23Related tdf#139073: deal with "none" for border-width in odf2uof_spreadsheetJulien Nabet
Change-Id: I040aab5a1863b359cf343de45930127a80e28506 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108217 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-12-23Fix dubious OUStringLiteral with automatic storage durationStephan Bergmann
Change-Id: I0c80ce6efbbc950ce975e55663a5643ea8fb37f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108215 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23Use optional rest argument of OUString::startsWithStephan Bergmann
Change-Id: Id8f9e7464c2c35a1a5ffadbc4c9c5d1f0d780923 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108214 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23Use OUStringCharStephan Bergmann
Change-Id: I4780de855682d252bd12bcf8f0c0c7230098f3a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108213 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-23elementary: restore deleted Macro Editor & Pivot Table iconsRizal Muttaqin
Change-Id: I2906674004223916152f3d8b893237410969036d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108226 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-23Drop RTLNAME obfuscating macroMike Kaganski
which only purpose is to make "git grep SbRtl_Foo" a kind of IQ test. Change-Id: I47cfc2ecd1cc4a5ecf2e348465554fa2caeaccf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108218 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-12-23Don't lock galleries build into DESKTOPJan-Marek Glogowski
And add the missing dependency of Executable_gengal on Package_svx_gengal, so the actual executable script is created in instdir_for_build for the cross-toolset. Change-Id: I98ea1d58273c871f0a3b804a93970eedfb7f8908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108108 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-12-23tdf#138160 Set minimal width of sidebar tabpage after UNO callIlhan Yesil
Call OpenThenToggleDeck in SidebarController instead SwitchToDeck to ensure the minimal width of the tabpage is considered and the width of the sidebar is set correctly. Change-Id: I27c21572b5c648b3ddbb4d908d40af686ac87a9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105758 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-12-22elementary: various icon updatesRizal Muttaqin
Change-Id: Ic8f2e9f87ae5bab7fbfca623f960604bb93fdc12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108208 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-22drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for svtools Change-Id: Iea5d5996cfcd6fe2e356e6565b8366e0db7a0424 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108199 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for vcl Change-Id: I8ed97064bb65b00fac3b024a88677b5abe71d4f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22drop deprecated GtkAlignment, move left/top-padding into child margin-start/topCaolán McNamara
for xmlsecurity, this uses the standard margin-top of 6, removing the additional 6 used in this one dialog Change-Id: Iac729122cc6e28fb17db3866bc7d8759861d3344 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22state GtkAlignment is deprecated in lint-uiCaolán McNamara
Change-Id: I138d21ed6fdf4c07e77c3f096cdd7ac94c61c292 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108198 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22fix lint-ui syntax errorCaolán McNamara
Change-Id: I8c94c28363a358e4e1dfe34b827a084c4c0e7a90 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108197 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22elementary: tdf#139048 update pencil element to be yellow (3rd patch)Rizal Muttaqin
Change-Id: If80b9d252933d0e52f296f132775a89f2ea73b56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108139 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-12-22loplugin:loopvartoosmallStephan Bergmann
Change-Id: Ia9ae40b6286801c7cbdab6856d57e0ddd37aba87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108161 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-12-22tdf#136578 sw BreakDashedLine: edit/delete PageAfterJustin Luth
When you click on the blue dashed line indicating a page break, that delete should remove both that page's break-before, and the previous paragraph's break-after. Also, edit should detect if a break comes from a PageAfter. Prior to this commit, multiple things were wrong: -the previous paragraph wasn't checked, so PageAfter breaks were not deleted. -edit looked at the wrong para if break was PageAfter. -the current paragraph's PageAfter was deleted - deleting the NEXT page break, and not THIS one. I hope only tables are the exception to the rule. It doesn't seem to matter which table pNd is set with the NONE'd break. In theory, I could edit the real GetBreakItem functions to add in that code, but that seems very dangerous at this low of a level. Prior commit d7dfae214384f37901b532618e4d3ef117bd0285 flattened this function and did other minor cleanup. Change-Id: I9944c25853ec206f9febb6ea9f4e34c13c770ebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108072 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-12-22left/top variable names don't match propertyCaolán McNamara
Change-Id: I3bca14652fba5a3aad9816417ac7f94b8651f3a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108160 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2020-12-22tdf#139120 tdf#139127 sw: fix empty redline related crashLászló Németh
and bad "$2" redline text in ChangesInMargin mode. Also in the default "changes-in-text" mode, Undo didn't remove this empty redline added for tdf#119571 in the case of associated redline ExtraData (i.e. joining paragraphs with different styles), see also commit 66b39ca79b36da8d5e151deab17a0fb7690eebe6 (tdf#131147 don't store redline ExtraData during Undo). Change-Id: I7faa7c3acd8f8a0312339087072453a15751dd81 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108126 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-12-22oss-fuzz: tgafuzzer doesn't pass sanity checkCaolán McNamara
Step #5: #6 0x63cce7f in __cxa_throw (/tmp/not-out/tgafuzzer+0x63cce7f) Step #5: #7 0x4f13aa in SvStream::ReadUInt16(unsigned short&) (/tmp/not-out/tgafuzzer+0x4f13aa) Step #5: #8 0x1d8d9c5 in (anonymous namespace)::TGAReader::ImplReadHeader() (/tmp/not-out/tgafuzzer+0x1d8d9c5) Step #5: #9 0x1d8c9ca in (anonymous namespace)::TGAReader::ReadTGA(Graphic&) (/tmp/not-out/tgafuzzer+0x1d8c9ca) Step #5: #10 0x1d8c598 in itgGraphicImport (/tmp/not-out/tgafuzzer+0x1d8c598) Change-Id: I1b01435d07d5e553e2941b402d4820836a9dce15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22oss-fuzz: psdfuzzer doesn't pass sanity checkCaolán McNamara
Step #5: #6 0x63cce7f in __cxa_throw (/tmp/not-out/psdfuzzer+0x63cce7f) Step #5: #7 0x4f1af9 in SvStream::ReadUInt32(unsigned int&) (/tmp/not-out/psdfuzzer+0x4f1af9) Step #5: #8 0x1d9dfd6 in (anonymous namespace)::PSDReader::ImplReadHeader() (/tmp/not-out/psdfuzzer+0x1d9dfd6) Step #5: #9 0x1d9d1a6 in (anonymous namespace)::PSDReader::ReadPSD(Graphic&) (/tmp/not-out/psdfuzzer+0x1d9d1a6) Step #5: #10 0x1d9cd38 in ipdGraphicImport (/tmp/not-out/psdfuzzer+0x1d9cd38) Change-Id: I407e7a32dd8e2fffb508edf896b9ca4783b94c97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108157 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-12-22sw: check for remaining stream size in the WW8Fib ctorMiklos Vajna
Commit 8c9a4ff511a3b1d84a7a6d08a1b153c07f164abb (throw exception in SvStream when reading past end of file, 2020-11-16) changed the "read past the end of the stream" behavior to throw, and this broke online.git's unit-password-protected test. Fix the problem by not attempting to read if we know the remaining size is too small, even if the stream is good. Change-Id: I62f1532fc87a14c9f1f5e681e3ad67e4d575e8a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108152 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-12-22oss-fuzz: epsfuzzer doesn't pass sanity checkCaolán McNamara
Step #5: #6 0x640b42f in __cxa_throw (/tmp/not-out/epsfuzzer+0x640b42f) Step #5: #7 0x5413d9 in SvStream::ReadUInt32(unsigned int&) (/tmp/not-out/epsfuzzer+0x5413d9) Step #5: #8 0x1dd29b1 in ipsGraphicImport (/tmp/not-out/epsfuzzer+0x1dd29b1) Change-Id: Ieab45edabd5f13d07359be558618ff65badfde2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>