summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-11Check for erroneously localized values of non-localized propertiesStephan Bergmann
See ffd8369b909c86653ef30593fddf67c9f5308583 "rhbz#1541486: Fix localized'ness of ooSetupFactoryUIName props". Turns out adapting the XSLT was easier than feared. The two other incidents found are fixed with c7ab472b47023c94c06de9e3479a2e0271084dfc "/org.openoffice.Office.Writer/Layout/Other/TabStop should be localized" and 552bebc85d907748dcd72b7978a00a3eee7c4f34 "/org...Writer/Insert/Caption/CaptionOrderNumberingFirst should be localized". Change-Id: Ic3b29a69d517440d133daed1f3b07d1f7510dab8 Reviewed-on: https://gerrit.libreoffice.org/49473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-11Replace non-us-ascii characters that cause build failure on cp-950Mike Kaganski
Change-Id: Ic3d09cbc20b6bbfcaa15d46bae332945e42ccb3d Reviewed-on: https://gerrit.libreoffice.org/49560 Reviewed-by: Mark Hung <marklh9@gmail.com> Tested-by: Mark Hung <marklh9@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-11iOS, added missing document state in callbackjan Iversen
Change-Id: Ib710eb4ce1186571732588948726874a0fb9cb58
2018-02-11Add origin URL to Graphic to remember where the image came fromTomaž Vajngerl
Change-Id: I73e7377c2049211de0b464efff03058dc5de33a6 Reviewed-on: https://gerrit.libreoffice.org/49554 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-11extend XGraphicStorageHandler with saveGraphicByNameTomaž Vajngerl
We want to save the graphic with a specific name, usually this is when we want to use the same name that was used when reading the image from the document. Change-Id: I7419f0593dea333a60ce513190211e0409480e66 Reviewed-on: https://gerrit.libreoffice.org/49553 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-11Remove unused includeTomaž Vajngerl
Change-Id: Ie71de80213ffd8ba3e4ee75b0a92d13faeaf3d09 Reviewed-on: https://gerrit.libreoffice.org/49555 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-11extend testLinkedGraphicRT if state after import is as expectedTomaž Vajngerl
Change-Id: Ia3452d7946148db20f8a876c92f945cb4e68ddb5 Reviewed-on: https://gerrit.libreoffice.org/49552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-11Updated links in readme files (https etc.)Ilmari Lauhakangas
Change-Id: Id4906290f312dc6d1800d5d17dedf1f07dd3480d Reviewed-on: https://gerrit.libreoffice.org/49491 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-02-11Pre-load key UNO mappings.Michael Meeks
Change-Id: I415e07d737c734d63ac969783464babcbb9ea884 Reviewed-on: https://gerrit.libreoffice.org/48365 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-11lok: allow libraries to pre-init themselves.Michael Meeks
Populate static module references before entering a jail containing no code. Implement for scfilt, scui, swui, sdui. Change-Id: I8fec2aa78e67053a7945926c818122bd4290103c Reviewed-on: https://gerrit.libreoffice.org/49545 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-10tdf#107403 Don't scale frame icons twiceMaxim Monastirsky
It's already done by ImplImageTree, see loadImageFromStream function in ImplImageTree.cxx. Change-Id: I5aa7439876037fb0168f6c1da264af9697788ef0 Reviewed-on: https://gerrit.libreoffice.org/49478 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-02-10lokdialog: Render non-pixel based preview windowsTamás Zolnai
PaintToDevice() method was designed for pixel based windows, now I added some scaling to handle different units. Change-Id: Id242c44101c1e842409ba3a9b13291e48bdd44ca Reviewed-on: https://gerrit.libreoffice.org/49543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-10use RawBitmap and BitmapEx in icgm filterNoel Grandin
Change-Id: Icaffda666c27f733c0d490905e91a68b72073bcb Reviewed-on: https://gerrit.libreoffice.org/49502 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-02-10ofz#6180 Integer-overflowCaolán McNamara
Change-Id: Ibf4b40521f5be3866451e574abc59b7e1cf3aec9
2018-02-10speed up jpg fuzzingCaolán McNamara
Change-Id: Iad65200d132f8fdd0e598ff5a4ee4943a9f7ac26 Reviewed-on: https://gerrit.libreoffice.org/49508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10speed up qpw fuzzing, skip CalcAfterLoadCaolán McNamara
Change-Id: Ia94032d6789e830e8dbdc3093201cf8d5d44f537 Reviewed-on: https://gerrit.libreoffice.org/49507 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10ofz: Infinite loopCaolán McNamara
Change-Id: I9344cb70aab0fbaa194d431928eba9806d76f115 Reviewed-on: https://gerrit.libreoffice.org/49504 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10ofz: time-outCaolán McNamara
Change-Id: I89a1166f78938d7e36435bfeecb4a4f3f2ba9ad2 Reviewed-on: https://gerrit.libreoffice.org/49503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10use read_uInt8s_ToOUStringCaolán McNamara
Change-Id: I3575019373632f476737b00d8616d01867970ae6 Reviewed-on: https://gerrit.libreoffice.org/49506 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10coverity#1401328 Uncaught exceptionCaolán McNamara
Change-Id: Idc2363f80026370953f5c48a9d0eeb396a43362c Reviewed-on: https://gerrit.libreoffice.org/49526 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10ofz#1429182 Unchecked dynamic_castCaolán McNamara
Change-Id: Id070114568cc1cfac2d09c42a8d17f137f5bb075 Reviewed-on: https://gerrit.libreoffice.org/49525 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-10lokdialog: Handle dialog items' invalidation in generalTamás Zolnai
Change-Id: Ib7b178fe97964bc5fd6ac173a143ba8ba089e237 Reviewed-on: https://gerrit.libreoffice.org/49240 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-02-10tdf#115032: Above as default position for Autocaption prefJulien Nabet
Change-Id: Idcd4e4a409476fe269340ac9d8f3ceacc6fbd7f3 Reviewed-on: https://gerrit.libreoffice.org/48058 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-02-10writerfilter / ww8filter: enhancement to support new ruby position.Mark Hung
1. Allow ooxml / rtf import the ruby aligned on the right side ( rightVertical or jc=5 ) as css::text::RubyPosition::INTER_CHARACTER. 2. Allow rtf / ww8 export of css::text::RubyPosition::INTER_CHARACTER as jc=5. Though rtf filter can save and load the new ruby position, character format seems lost. The reset of the MSO formats have other issues that they can't make roundtrip yet. Change-Id: Idb77423842f43abc375a1282a52b0bc6f20049e4 Reviewed-on: https://gerrit.libreoffice.org/49177 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-02-10improve loplugin rewriter double source modification detectionNoel Grandin
because my new rewriter easily generates overlapping rewriting. Move the code from flatten and salcall up into the pluginhandler, and drop the simpler detection logic. Change-Id: I3da51ac510954a5d4276cee0924cc5dc1fc9a734 Reviewed-on: https://gerrit.libreoffice.org/49493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-10make Pair protected base in Pair/Size/SelectionNoel Grandin
as part of cleaning up the use of the non-const-ref returning methods. i.e. methods like long& X() And make the classes final. Change-Id: Ice0aa1932124e77f5ed672b527c2a092ec80c481 Reviewed-on: https://gerrit.libreoffice.org/49475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-10use VirtualDevice in ColorFieldControlNoel Grandin
as part of moving use of BitmapWriteAccess inside of vcl/ Change-Id: Ia092eee7d56a6c6a6485555f470de10f31be8ed1 Reviewed-on: https://gerrit.libreoffice.org/49415 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-09tdf#115319 unit test for references with Hungarian articlesLászló Németh
Change-Id: I74b4640eb1845875261b7858cef4bdc059608d69 Reviewed-on: https://gerrit.libreoffice.org/48945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2018-02-09ofz#6180 Integer-overflowCaolán McNamara
Change-Id: I6339a6ebb188dc9e7bccfa629a40af8e67c13feb Reviewed-on: https://gerrit.libreoffice.org/49487 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-09ofz#6173 check index before useCaolán McNamara
Change-Id: I09d15ab324af0a8b3566f11868eb3266a68c4afe Reviewed-on: https://gerrit.libreoffice.org/49486 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-09tdf#114299 Ensure groupedbar full works in print preview modeYousuf Philips
Change-Id: I154d22deeafc76e6afff9ccf5cbd5f8aa9ec3a57 Reviewed-on: https://gerrit.libreoffice.org/49480 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2018-02-09Add missing @since tags in css.ui.dialogs.ExtendedFilePickerElementIdsStephan Bergmann
...for entities added with 4e825d97a8423c9493c5f6f4ac0493b8799f86f6 "gpg4libre: Encrypt with GPG checkbox in SaveAs file dialog, 1st stab" and 38774ce79b4b24628c3a73f387489bf2498363f1 "tdf#86739 Option to set image anchor type in image insert dialog" Change-Id: Ifa03d7fb143ea8fd4582431e780aa174e2b0f690 Reviewed-on: https://gerrit.libreoffice.org/49477 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-09Updated coreIlmari Lauhakangas
Project: help 863b926ed16b372800f75e8ac467afbf3443f61e Tweaked contents expansion Stopped excluding main items. Highlighted current item. Harmonised the help.js indentation. Change-Id: I6b8f22940d077d008662a387071a5d5db04409f7 Reviewed-on: https://gerrit.libreoffice.org/49488 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-02-09Adapt solenv/flatpak-manifest.inStephan Bergmann
...to e13acfcac9571da7efeec8fe5b27b11249d51c27 "Update liborcus to 0.13.2." Change-Id: I5e2b8d9ea4f91571fe884944a6c0a390d650993f
2018-02-09solenv/flatpak-manifest.in: Merge in building with GCC 7Stephan Bergmann
This merges in * <https://github.com/flathub/org.libreoffice.LibreOffice/commit/ d1ca6fbdac7f0adcfd813ac5556d6ad979924232> "switch to gcc7", * <https://github.com/flathub/org.libreoffice.LibreOffice/commit/ 687e79514c12bb8c6fd7dfd93f1e4fb84fc6af54> "Copy org.freedesktop.Sdk.Extension.gcc7 libs into app", and * <https://github.com/flathub/org.libreoffice.LibreOffice/commit/ 41b361bf4973b0981f834fe58b3f808b0ca81634> "Use `cp -d` to preserve symlinks", which should allow to build on 32-bit arm once <https://github.com/flathub/org.freedesktop.Sdk.Extension.openjdk9/issues/4> "ARM version" is fixed. Those had been reverted again on flathub with <https://github.com/flathub/ org.libreoffice.LibreOffice/commit/1168072d19f358ffacc783aa83773789c6eafb99> "Revert 'Gcc7' again, for now" because it had apeared back then that using GCC 7 caused the build to fail on aarch64. This has meanwhile been tracked down to be an issue with PDFium instead, see ffc134445ef7e935d18d816626f64e65b4cdbca6 "--disable-pdfium for Linux aarch64 Flatpak build". Change-Id: I594d38ecfdf7dbd78b91af04b9f3f3e86987b8e5
2018-02-09--disable-pdfium for Linux aarch64 Flatpak buildStephan Bergmann
At least current PDFium master <https://pdfium.googlesource.com/pdfium/+/ 026717cb667cf0c7215cf55daf794d69752fc900/third_party/base/allocator/ partition_allocator/page_allocator.h#33> still hard-codes the assumption that "All Blink-supported systems have 4096 sized system pages". On Linux aarch64 machines with 64K page size (as reported by `getconf PAGE_SIZE`, e.g., on Flathub worker <https://flathub.org/builds/#/workers/18> "gnome-aarch64-1"), that causes LO's CppunitTest_svtools_graphic to fail with SIGABRT, when pdfium::base::SetSystemPagesInaccessible (workdir/UnpackedTarball/pdfium/ third_party/base/allocator/partition_allocator/page_allocator.cpp) causes an mprotect to fail in a pattern like > mmap(0x1051200000, 2097152, PROT_READ|PROT_WRITE, MAP_PRIVATE|MAP_ANONYMOUS, -1, 0) = 0x1051200000 > mprotect(0x1051200000, 4096, PROT_NONE) = 0 > mprotect(0x1051202000, 8192, PROT_NONE) = -1 EINVAL (Invalid argument) The loss of functionality caused by --disable-pdfium is assumed to be acceptable ("used for insert->image and selecting a pdf I believe", according to caolan on IRC), and e.g. Fedora disables it for all arches since <https://src.fedoraproject.org/rpms/libreoffice/c/ 1f6713e951de6aa9af43a9bd92ed011edf0c6fe9> "update to 5.4.0 alpha1". Change-Id: I39385c332ddd6a2a3a221f0d0577181709944313
2018-02-09solenv/flatpak-manifest.in: Disable debug information again, for nowStephan Bergmann
Merge in <https://github.com/flathub/org.libreoffice.LibreOffice/commit/ c6831b215070415a32669fbe63adfc4c36b5f568> "Disable debug information again, for now", to bring repos back in sync. If we want to keep this permanently, --enable-symbols should instead be dropped from distro-configs/LibreOfficeFlatpak.conf. Change-Id: I656d77a446deecbc41ab25f05af7187dc544126c
2018-02-09Use sha256 instead of sha512Stephan Bergmann
...as the latter is apparently a recent addition to flatpak-manifest that some Flathub workers (like <https://flathub.org/builds/#/workers/16> "arm-3") still do not support, causing "module libreoffice: Sha256 not specified" failures. <http://ant.apache.org/bindownload.cgi> and <https://archive.apache.org/dist/ant/binaries/> do not provide SHA-256 values, so computed it locally. Change-Id: Iee664402f26c9ab428624a4a7933db310efd71b1
2018-02-09Use stable URL for apache-ant downloadStephan Bergmann
as proposed by <http://mail-archives.apache.org/mod_mbox/ant-user/201802.mbox/ %3c001b01d3a101$eadd7ea0$c0987be0$@de%3e> "AW: Stable link to apache-ant-*-bin.tar.xz?" (but using https instead of http) Change-Id: I6f1a5d06c4f2f6ad1861a5c0bda3341f13c8899a
2018-02-09Fix conditionSamuel Mehrbrodt
OSL_DEBUG_LEVEL is always set as it seems Change-Id: Ie555f705fd13de778463c8073e86d30b3ce09073 Reviewed-on: https://gerrit.libreoffice.org/49476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-09sw: it's called SwAnchoredDrawObject, not SwDrawFrameMiklos Vajna
It is named like this since its addition in commit 20db95b763c4e39602337ba35b4f68d49a27e983 (INTEGRATION: CWS swdrawpositioning (1.1.2); FILE ADDED, 2004-06-28). Change-Id: I776bc736e8fe25c103858f33b7e9ad425890616e
2018-02-09tdf#115584: fix crash BaseJulien Nabet
Regression from https://cgit.freedesktop.org/libreoffice/core/commit/?id=0fb4ae8767fa5ff791cd42934b4215011a269eb0 Change-Id: Ifcf183ebb4d0096193cccdd74a61eb59c7a06cdf Reviewed-on: https://gerrit.libreoffice.org/49505 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-02-09CheckLinkFormulaNeedingCheck() for .csv importEike Rathke
Change-Id: I89be713531436f10b38d38f9e0fa527db1e036cd
2018-02-09The special value of CaptionOrderNumberingFirst for hu is already setStephan Bergmann
...in the configuration data, cf. 552bebc85d907748dcd72b7978a00a3eee7c4f34 "/org...Writer/Insert/Caption/CaptionOrderNumberingFirst should be localized", so there should be no need to handle a nil value specially for hu here. (Any tests run during the build that don't use the configuration data will now use false instead of true for hu, but that's apparently not a problem for any of the `make check` tests, at least.) (Ideally, this property would always have been non-nillable anyway, or should at least have been included in the mass non-nillability change of e8bb827571f540ac4af2247cb11239bb96876669 "Fixed cppheader.xsl nillable treatment." But now, just leave it as it is and live with that.) Change-Id: Iec6937dccc2f5ab3d98ca530a7172f27f13a860e Reviewed-on: https://gerrit.libreoffice.org/49474 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-09tdf#114972 Make insert textbox work in Impress grouped notebookbarsYousuf Philips
Change-Id: I35a7efeec01a6aeae5bc4bcb49151cba1d225d61 Reviewed-on: https://gerrit.libreoffice.org/49481 Reviewed-by: andreas_kainz <kainz.a@gmail.com> Tested-by: andreas_kainz <kainz.a@gmail.com> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2018-02-09...and Clang is not affected at allStephan Bergmann
(It wouldn't really hurt to have the line enabled for more toolchains than necessary, as redeclaration of static constexpr data members outside the class is still supported for backwards-compatibility in C++17, though deprecated. However, recording a precise upper bound on toolchains in the #if allows to eventually get rid of this code, once we no longer support any affected toolchain.) Change-Id: I40ae37e7006754cc89538d5c97230200a2ca633c Reviewed-on: https://gerrit.libreoffice.org/49472 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-09clang-format: improve error message when CI failsMiklos Vajna
Don't just tell the problem but hint how to fix it. Change-Id: I9d079ee7d4ed61266e22a3fa21efe10366724645 Reviewed-on: https://gerrit.libreoffice.org/49471 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-09Use angle quotation marks (Guillemets) for [*-CH], tdf#115493 relatedEike Rathke
Source: https://en.wikipedia.org/wiki/Quotation_mark#French https://de.wikipedia.org/wiki/Anf%C3%BChrungszeichen#Schweiz,_Liechtenstein,_Frankreich Change-Id: I015e8d68aecdc7c7ca3620105b7a2685648438d5
2018-02-09add sft fuzzerCaolán McNamara
Change-Id: I0ee43e78b5366f2c23fb0bac9a103af987138411 Reviewed-on: https://gerrit.libreoffice.org/49372 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-09Pick up cell border colors when importing via orcus.Kohei Yoshida
Change-Id: Iee2d79930d0c917518b180fdd63fe30c6860b9b1 Reviewed-on: https://gerrit.libreoffice.org/49466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
generated by cgit (git 2.34.1) at 2024-07-12 13:49:43 +0000