summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-05-11suppress some leaks I don't want to deal withNoel Grandin
Change-Id: I66d39f3c4500ca75da62f023c80c8fe2851636a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-11fix leak in SalLayoutGlyphsNoel Grandin
we forgot to delete the extra impls vector Also make more use of std::unique_ptr Change-Id: I2c745c0ad2b7ad62d368e9702bd2c32c734442fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115375 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-11tdf#76258 Use correct icon size for color filter popup colorsSamuel Mehrbrodt
Change-Id: Icda5ee2cc4c02d6da5cc3f45c30416ad503eaa20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115378 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-05-11android: Don't crash trying to process non-existing file from recentsMichael Weghorn
When the "Recent files" list in Android Viewer contained an entry for an Uri that was no longer pointing to a valid file, a SecurityException was thrown trying to query the display name from it. Catch the SecurityException that is thrown and just return an empty string, the document is then not displayed in the "Recent files" list. One scenario: 1) open file located in the "Download" directory from within the app 2) close the app 3) delete the file 4) open the app again -> crash, with this backtrace in ADB log: 05-11 08:37:14.230 3892 4707 E DatabaseUtils: java.lang.SecurityException: Permission Denial: reading com.android.providers.downloads.DownloadStorageProvider uri content://com.android.providers.downloads.documents/document/msf%3A1091 from pid=6981, uid=10177 requires that you obtain access using ACTION_OPEN_DOCUMENT or related APIs 05-11 08:37:14.230 3892 4707 E DatabaseUtils: at android.content.ContentProvider.enforceReadPermissionInner(ContentProvider.java:804) 05-11 08:37:14.230 3892 4707 E DatabaseUtils: at android.content.ContentProvider$Transport.enforceReadPermission(ContentProvider.java:670) 05-11 08:37:14.230 3892 4707 E DatabaseUtils: at android.content.ContentProvider$Transport.query(ContentProvider.java:238) 05-11 08:37:14.230 3892 4707 E DatabaseUtils: at android.content.ContentProviderNative.onTransact(ContentProviderNative.java:106) 05-11 08:37:14.230 3892 4707 E DatabaseUtils: at android.os.Binder.execTransactInternal(Binder.java:1138) 05-11 08:37:14.230 3892 4707 E DatabaseUtils: at android.os.Binder.execTransact(Binder.java:1102) 05-11 08:37:14.230 6981 6981 D AndroidRuntime: Shutting down VM 05-11 08:37:14.231 6981 6981 E AndroidRuntime: FATAL EXCEPTION: main 05-11 08:37:14.231 6981 6981 E AndroidRuntime: Process: org.libreoffice, PID: 6981 05-11 08:37:14.231 6981 6981 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{org.libreoffice/org.libreoffice.ui.LibreOfficeUIActivity}: java.lang.SecurityException: Permission Denial: reading com.android.providers.downloads.DownloadStorageProvider uri content://com.android.providers.downloads.documents/document/msf%3A1091 from pid=6981, uid=10177 requires that you obtain access using ACTION_OPEN_DOCUMENT or related APIs 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3333) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3477) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2043) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:106) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.os.Looper.loop(Looper.java:216) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:7464) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:549) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:955) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: Caused by: java.lang.SecurityException: Permission Denial: reading com.android.providers.downloads.DownloadStorageProvider uri content://com.android.providers.downloads.documents/document/msf%3A1091 from pid=6981, uid=10177 requires that you obtain access using ACTION_OPEN_DOCUMENT or related APIs 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.os.Parcel.createExceptionOrNull(Parcel.java:2285) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.os.Parcel.createException(Parcel.java:2269) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.os.Parcel.readException(Parcel.java:2252) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:188) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.database.DatabaseUtils.readExceptionFromParcel(DatabaseUtils.java:140) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.content.ContentProviderProxy.query(ContentProviderNative.java:472) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.content.ContentResolver.query(ContentResolver.java:1112) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at org.libreoffice.ui.FileUtilities.retrieveDisplayNameForDocumentUri(FileUtilities.java:137) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at org.libreoffice.ui.LibreOfficeUIActivity.createUI(LibreOfficeUIActivity.java:206) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at org.libreoffice.ui.LibreOfficeUIActivity.onCreate(LibreOfficeUIActivity.java:147) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.app.Activity.performCreate(Activity.java:7990) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.app.Activity.performCreate(Activity.java:7979) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1309) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3308) 05-11 08:37:14.231 6981 6981 E AndroidRuntime: ... 11 more 05-11 08:37:14.233 2293 3174 W ActivityTaskManager: Force finishing activity org.libreoffice/.ui.LibreOfficeUIActivity Change-Id: I7a8e824e557dba8771cf1f210ae89d6f60498737 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115374 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-05-11gtk4: use GTK_POPOVER_MENU_NESTED to avoid crash on submenusCaolán McNamara
gtk_popover_menu_new crashes on submenus with: "signal 'action-added' is invalid for instance of type 'GtkActionMuxer'" Change-Id: I5d66b727dc45ac539b11e08665d69e019f5dded6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115362 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-11gtk4: centralize g_main_loop_run ifdefryCaolán McNamara
Change-Id: I1a984783cf4c39500ab6dfdb59e5d1c604de4b5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115361 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-11gtk4: avoid gtk_widget_show_allCaolán McNamara
Change-Id: Ib7151175e8f80def3d869330e1e6560e28e4c818 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115360 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-11gtk4: get context menus workingCaolán McNamara
Change-Id: I14fe637ce3539196cffba90851f57193afc9b76b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115359 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-11Related: tdf#138604 sw: don't advertise AS_CHAR as "to char"Miklos Vajna
Change-Id: Iff6726ef7b7f483e2bb407e9c2cd67427470645a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115358 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-05-11tdf#76258 Add OOXML import for color filterSamuel Mehrbrodt
Change-Id: I74cf4f56e0adf1cb8af8e6e932c14b30cce67c71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115168 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-05-11Fix style previews widget with multiple languagesSzymon Kłos
Broadcast also universal name (English identifier) for styles on change. This allows to select correct style without knowledge about all languages that other users use in other views. Fixes style previews widget in online with multiple sessions in different languages Change-Id: I9b9bcc92d96b5a5482a97a5947f148a638f257d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115093 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115298 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2021-05-11tdf#76258 Various fixes for color filterSamuel Mehrbrodt
Change-Id: Ifb4114597efcb7a957d2e42867d1bdc8abfe7730 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115340 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-05-11tdf#84502 CuiConfigGroupListBox Macros,Styles like category for SidebarJim Raykowski
Decks Change-Id: I4d41952547c98ba66c40c1aa1e9776cdf31304c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100455 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-05-11vcl: Don't just return OK when executing a dialog in AndroidTomaž Vajngerl
This was probably "ifdef-ed" out for Android because of some old assumptions and isn't true anymore today. This has prevented that the dialog for macro execution shows up on Android when the document is loading. Change-Id: I662d2deb1520f9a3b421dac05f858488aef825fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115307 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-11lok: move handleMacroConfirmationRequest to its own methodTomaž Vajngerl
Just refactor to make it similar to other requests. Change-Id: I1a76d3d4ecc02b0a223ab8e44b11047455280142 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115306 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-11lok: enable macros by default for AndroidTomaž Vajngerl
This enables macros execution for Android, so the user will be asked to execute macros (assuming the security level is set to 1, which is the default) if the document contains any macros to execute. Change-Id: I34dbd123c5b4ea7386096fd3a21766da3479be6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115305 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-11drawinglayer: move converter.hxx to public includeTomaž Vajngerl
Change-Id: I71a15c532ba161d69585bd47631b3a8e2f6ddd66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115304 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-05-11tdf#134490: sc_ucalc: Add unittestXisco Fauli
Change-Id: Iac75d72506eceb6d1104f607d32cdf82c68fb566 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115365 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-10speed up SfxExtItemPropertySetInfoNoel Grandin
Change-Id: I7fdf0395c40f1932cfa1fc6ada91accc1912851a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115352 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-10tdf#105650 different strikethrough offset for vertical writing.Mark Hung
Change-Id: I7f1a8753bb00972865625628baeff76ff5dc4699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115015 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-05-10vcl: use DWriteTextRenderer for vertical writing.Mark Hung
It's really not possible to support vertical writing with old ExTextOutW API, use DWriteTextRenderer in this case. This also get rid of the hacks to prepend '@' in front of the font name when it's for vertical writing. Change-Id: Icf594dd248be35fb101d6c1e296971f1acf56e39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115017 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2021-05-10tdf#138209 ODF export: work around forms problem in LO < 7.0Michael Stahl
LO without commit 519d96fd8b83ef4c61576d87b58f97b7e6e6e3c6 makes a mess when storing form documents it has loaded from ODF 1.3 documents: the XML parts are stored as ODF 1.2, but the storage (and therefore manifest entry) keeps version 1.3. To avoid this, store form documents as ODF 1.2 extended by default. Unfortunately a bunch of ODF export code accesses the global SvtSaveOptions variable; with this version override, only SvXMLExport::getSaneDefaultVersion() must be used. Change-Id: I5fa8e286f5103c578ed0d93da07a8a6cbe2f0ddd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115357 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-05-10gtk4: GtkPopoverMenu doesn't have "deactivate", try "closed"Caolán McNamara
Change-Id: Ia14944468ebe743999d8c283b96f60352589f82e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115351 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: use gdk_wayland_toplevel_set_application_id for dynamic icon changingCaolán McNamara
Change-Id: Ie1f903a9fa8bfdb94ec3fc0409b350a3e73c444d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115350 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: gtk_im_context_set_client_window->gtk_im_context_set_client_widgetCaolán McNamara
Change-Id: I21d3cd5daf77264f08c6864425c6d9ff37404325 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115349 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: use gtk_window_minimize to replace gtk_window_iconifyCaolán McNamara
Change-Id: I6c50e6f60e24dd5bd93e1ef5f62f3cd3845f9194 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115348 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: GDK_WINDOW_STATE_WITHDRAWN is goneCaolán McNamara
Change-Id: Ibeca97ca0ac849d69b3b32db6d6f27da7cf551b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115347 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: add some degree of support for minimized/maximized/default sizeCaolán McNamara
so we start up maximized instead of just a titlebar that needs to be expanded Change-Id: I60c8cdd22c5b2bb659ae10806ccde27e964d6733 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115342 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10reduce frequency of dynamic_castNoel Grandin
by checking cheaper things first Change-Id: I0c93021966ee09967f0ce2e265adafb279b669bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115356 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-10reduce cost of locking in SvtModuleOptionsNoel Grandin
Change-Id: If9e0c275822b733d339845d16edfbc5942b4aa6f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-10upload libmwaw 0.3.19David Tardon
Change-Id: Ibb26390e6cc13c925f499bf95cfc6177d8c9b735 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115355 Tested-by: Jenkins Reviewed-by: David Tardon <dtardon@redhat.com>
2021-05-10Test Kahan Sum. Will check Kahan sum stills work properly.dante
This test file contains summations wich won't work with a raw sum. However Kahan Summation can give a correct output. Change-Id: I6fb3ded287414e8a99964b838c63f52f9262576e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115256 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-10Resolves: tdf#142186 Accept 123.45 fractional input on weird formats like 0"."Eike Rathke
... or 0"."0 where the literal "." is also the decimal separator but can only occur in the integer part. Change-Id: I95093fdddf7759346f2869ee322222de3d130e55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115338 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-05-10update leak-suppressNoel Grandin
with some CPPUNIT stuff that is being deliberately leaked Change-Id: I7e3e3090877394f05e5bc9f270c456de7e7c57f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115333 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-10gtk4: add focus-in/outCaolán McNamara
Change-Id: Ia954b2b1cc0ea368a318549f39e2efab42a0ebb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: get the event state into the button press/releaseCaolán McNamara
Change-Id: I85b7e64cf8216a7abf18432bbf7bf659876ee07a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115337 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: add crossing eventsCaolán McNamara
Change-Id: I80adcb946a3f76b7a20fad381667a445e5927566 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: get motion eventsCaolán McNamara
Change-Id: I44f28891015cadf3714dbecd48bad73296d78b53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115335 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: add gesturePressed/gestureReleased support for basic clicksCaolán McNamara
some unknowns here still, but gets some clicks working Change-Id: Ib97a3b70baba5bcce70b71b6d030a1ad2a591724 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115331 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: enable the existing longpress and swipe gesturesCaolán McNamara
for what limited amount of use they have Change-Id: I86f35fde191c0864cdfe9b56176bd71bd488bc1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115330 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: new close-request looks equivalent to old delete-eventCaolán McNamara
Change-Id: I4176de9e8eb2029979f478e4a32e25e0314c7d99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: use GDK_ALT_MASKCaolán McNamara
define GDK_ALT_MASK as GDK_MOD1_MASK for gtk3 Change-Id: Iff6340956b83403af37b0416a234b6937f1bea18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115328 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10tdf#141613 sw: avoid possible crash when undoing header creationDaniel Arato (NISZ)
Move the ClearRedo() call to the very end of the undo process in order to avoid heap use after free. We still need to call ClearRedo() because there's no mechanism in place to Redo a header/footer change. Regression from commit 65e52cb61d74b0c71b45b63b2da131bc6b621104 "tdf#141613 sw: fix crash at header/footer undo". Change-Id: Ibd4604379c9791e85aef3d4dc6c29c9e3ecd5a28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115275 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-10gtk4: enable signalTooltipQueryCaolán McNamara
Change-Id: Ida3593b1e6ecc98425342f9059f0dcd65901823c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115327 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: enable signalMap and signalUnmapCaolán McNamara
Change-Id: I614296cfc2ccf78e45a9b9df04977c938e47dff4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115326 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10gtk4: enable partial signalRealizeCaolán McNamara
Change-Id: I17bc5d5c0250aea6852e9e82e3742fece4966b34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115325 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-10svx: fix crash with active text edit vs slide deleteMiklos Vajna
The problem is that SdrObjEditView::HideSdrPage() may delete SdrPaintView::mpPageView when it calls SdrGlueEditView::HideSdrPage(). But SdrObjEditView::pTextEditPV is a non-owning reference to that. GetTextEditBackgroundColor() in svx/ calls SdrObjEditView::GetTextEditPageView(), so in case SdrObjEditView::pTextEditPV is not cleared, we would access a deleted SdrPageView. Change-Id: I948bae8e0e8d557e38aa8f243e9eea522b21a043 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115324 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-10fix some leaks in basicNoel Grandin
Change-Id: I52c10cdbe9661974c908ee052336c779a40de402 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115323 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-10I suspect that we unlikely to use JRE older than 1.3.1_07Mike Kaganski
... and so possibly can rely on -Dfile.encoding=UTF8 now. This reverts 79ac0685de0b19d856db70a208a8372cb589646c and 3428bace79d64a10cfcabb79e4caa608ee5db233. Change-Id: Ia9e09025691b200c0f79427e0f4efe500f9c81f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115272 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-10tdf#142130 sw track changes: fix crossing out of neighboring imagesLászló Németh
Normal images got crossing out from the next deleted images. Fix it by using only the start position of the image in CheckLine() instead of the 1-character length range of the anchor point. Note: add unit test also for tdf#78864. Follow-up to commit d845b91bcc6eb885c55494d4d4fab4ec09577e1d (tdf#78864 sw track changes: cross out deleted images). Change-Id: I8894e625d479adea4b1003f55f24f292064ed7ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115255 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
generated by cgit (git 2.34.1) at 2024-07-02 13:27:48 +0000