summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-11-12use std::move when popping stuff off stacksNoel Grandin
Change-Id: I6ba0ee8afee1a9579045643cd0118cf19599d5b9 Reviewed-on: https://gerrit.libreoffice.org/82497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-12getPropertySetInfo is allowed to return nullCaolán McNamara
so the original state, without the assert, would be ok css.beans.XPropertySet::getPropertySetInfo is documented as "@returns NULL if the implementation cannot or will not provide information about the properties" Change-Id: Ia0230add8f6c1b22a639cd71ca3cc310e0f1d126 Reviewed-on: https://gerrit.libreoffice.org/82499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12Clarify loplugin:external behavior for const(expr) varsStephan Bergmann
Change-Id: I4a649f9c9ed2015ed9b32a153060df9770b20403 Reviewed-on: https://gerrit.libreoffice.org/82493 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-12toolkit: UnoEditControl::insertText() assert on invalid indexMichael Stahl
... in replaceAt(): if the selection that is passed in is invalid, throw an exception. This obviously isn't thread-safe but naively adding a GetMutex() guard quickly deadlocks against SolarMutex; why does it use its own mutex? Reproduces when installing APSO 1.2.5 and starting the Python REPL. Change-Id: I4fb16ab820641f1a031537b0c4d6f8664d67dc0c Reviewed-on: https://gerrit.libreoffice.org/82460 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-11-12Silence -Werror=sign-compare (--enable-cipher-openssl-backend)Stephan Bergmann
as found by <https://ci.libreoffice.org/job/lo_tb_random_config_linux/2039/> Change-Id: Ie698b7905bd2f25e74791f91f586479d1fc473dc Reviewed-on: https://gerrit.libreoffice.org/82488 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-11-12tdf#121239 give writer, calc and draw/impress the same underline optionsCaolán McNamara
uno:Underline is the "real" deal, and has multiple underline options uno:UnderlineSimple is "some underline on" vs no underline calc and writer had UnderlineSingle, UnderlineDouble and UnderlineDotted for that specific type of underline on vs not-on add those to draw/impress too and then use UnderlineSingle instead of Underline in the format menu so that when UnderlineDouble is applied, UnderlineSingle is not show as applied, instead of using Underline ot UnderlineSimple which would show as on if UnderlineDouble was applied Change-Id: I6f9fcf37c2c90d215ea52b536e4fa84734754850 Reviewed-on: https://gerrit.libreoffice.org/82469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12Revert "Drawing calc grid misses pixels on bottom and right."Michael Meeks
This reverts commit 4a3dab5a4cd5c7a7039b2cef9d5bb14c1fff49c9. Change-Id: I1ac1edca00e4d1d62f93de48561a3b6ce4a315aa Reviewed-on: https://gerrit.libreoffice.org/82221 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-11-12sc: pViewSh can be nullptr in the ScNavigatorDlg ctorMiklos Vajna
In case the nagivator dialog was enabled the last time the user exited from Calc, resulting in a crash-on-startup in subsequent runs. This avoids the need for a workaround to reset the user profile. Change-Id: I5041a9a258efb82051036d8404fde77c8985089a Reviewed-on: https://gerrit.libreoffice.org/82491 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-12tdf#128651 SdrObjCustomShape::NbcSetSnapRect needs logic rectRegina Henschel
SdrObjCustomShape::NbcSetSnapRect needs a logic rect in its parameter. A general change to snap rect as input in NbcSetSnapRect is not possible, if the transformation has to be kept. Therefore callers need to be adapted. This is done her for SdrUndoAttrObj. The error was that for a transformed custom shape with text, undo and redo had generated a wrong size of the shape. A least the following actions were affected: extrusion on/off, shadow on/off, and changes in line or fill properties. The unit test uses extrusion on. Change-Id: I8b6990d3d57d25f15f18e8690fc49dbe5e2a2728 Reviewed-on: https://gerrit.libreoffice.org/82367 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2019-11-12Related: tdf#121239 super/sub not shown as toggles in draw/impressCaolán McNamara
Change-Id: Ibb4a8a638bdba0ec0b2a859c685233d36b6c852e Reviewed-on: https://gerrit.libreoffice.org/82468 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12SvxOverlineItem probably should be SvxTextLineItem hereCaolán McNamara
Change-Id: I6d8a40f38a827c1f7644d3c9d6a3cad4481b5e7c Reviewed-on: https://gerrit.libreoffice.org/82456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12Related: tdf#121239 super/sub not shown as toggles in calcCaolán McNamara
Change-Id: Ida4c5014538454b845d19f74d27548c8f9540de8 Reviewed-on: https://gerrit.libreoffice.org/82470 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-12Update git submodulesAndras Timar
* Update translations from branch 'master' - Updated Slovenian translation Change-Id: If4695b9a50f7041ae44c0ea07bd33a8cff89cb0b
2019-11-12tdf#42949 Fix IWYU warnings in basic/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I325149be2ea7697b5b4a2ce4a662edd2f8be6e50 Reviewed-on: https://gerrit.libreoffice.org/82312 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-12tdf#128630 vcl PDF export: fix aspect ratio when scaling rotated imageMiklos Vajna
Regression from commit 68549e00d5e23aa22bc974a8151d93cd948444b3 (vcl, BitmapEx transformed draw: special-case simple rotations, 2019-10-10), the intention there was to fix an error on the last col/row of a bitmap, but that was only tested with input where the aspect ratio doesn't change on scaling. Fix the problem by going back to the original way in the "aspect ratio changes" case. Change-Id: I52bed503ddaadbbbdf64ac6fec2fe268153866f1 Reviewed-on: https://gerrit.libreoffice.org/82467 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-11-12Options Email Dialog fix alignment and paddingandreas kainz
Change-Id: I470d8fea036683c76badb856e2d6acc214734cb7 Reviewed-on: https://gerrit.libreoffice.org/82479 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-12Fix macro disabling in Basic IDESamuel Mehrbrodt
After 8d69ca60f3c8f53699986f924291a2acda5694a1 macros were always disabled as ScriptDocument::allowMacros always returned false when called from non-document context. Change-Id: Ibef4c7d561f4ee01cd44f5327e4ab948282bb07d Reviewed-on: https://gerrit.libreoffice.org/82444 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#128589 Add resolved comments in page Add Resolved comments in comments Help page, adjust View menu Change-Id: I4e1c0dbce35d71a72d08fe1940a7e76f80b55c4f Reviewed-on: https://gerrit.libreoffice.org/82464 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-11-11Fix copy/paste error that probably has had no ill effectTor Lillqvist
Change-Id: I062fef5f2316a3aa7560ecb42799496cd38362e9
2019-11-11Don't compile cpuid test with INTRINSICS_CXXFLAGSTomaž Vajngerl
This will compile test with maximal supported instruction set supported by the compiler, but the CPU might not support the instructions sets. As this tests some aspects of runtime CPU detection only we actually don't need to compile it with the INTRINSICS_CXXFLAGS flags. Change-Id: I612785949b42efbd08d1961a746025f66e99aebc Reviewed-on: https://gerrit.libreoffice.org/82422 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-11-11cid#1455326 MoveSticky always has a non-nullptr pDocCaolán McNamara
Change-Id: I84d9a81e9e8a544dbc50b9d6b40a7b9030f2a987 Reviewed-on: https://gerrit.libreoffice.org/82425 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11Calc Dataprovider Dialog updateandreas kainz
Change-Id: Ia8517cc14108cca0e404bbb957a7f6b8f599e4bf Reviewed-on: https://gerrit.libreoffice.org/82407 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-11unnecessary includeCaolán McNamara
Change-Id: Ia8db302de488cfa89311a258a57f8c595528088a Reviewed-on: https://gerrit.libreoffice.org/82443 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11add uitest for bug tdf#128593Zdeněk Crhonek
Change-Id: Icc0b22318406a92cf19843844e857d09dd9a4ba2 Reviewed-on: https://gerrit.libreoffice.org/82466 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-11-11return an empty PropertySetInfo instead of assertCaolán McNamara
e.g. seen with APSO extension Change-Id: Ia2eb636a7d27ca87062e7962eded06756ff4e333 Reviewed-on: https://gerrit.libreoffice.org/82457 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11GtkSalFrame toplevel might not be a GtkWindowCaolán McNamara
in the rare embedded case, e.g. ASPO extensions option window Change-Id: Iedacdbc6b795ee5fbe7471b9f19f8f7f6c746204 Reviewed-on: https://gerrit.libreoffice.org/82458 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11Related: tdf#121239 overline missing in draw/impressCaolán McNamara
where underline already exists Change-Id: I87df3f3965526266b94f10fa04448b32a81fd99a Reviewed-on: https://gerrit.libreoffice.org/82459 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11jsdialogs: send .uno:LineWidth updatesSzymon Kłos
Change-Id: I83856625d17910e5b9165c7a2ddae8b219650c8c Reviewed-on: https://gerrit.libreoffice.org/82455 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-11jsdialogs: send .uno:FillColor & XLineColor status updatesSzymon Kłos
Reviewed-on: https://gerrit.libreoffice.org/82307 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit c28ea22c5198c1162fc5a535d35b407762b8a865) Change-Id: I665ca45293fb3e98a7940e24c1f14a5963b8d073 Reviewed-on: https://gerrit.libreoffice.org/82309 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-11-11cid#1448492 Wrapper object use after freeCaolán McNamara
Change-Id: I4c5978b019549d1509c4c70b4cfa93a362395fed Reviewed-on: https://gerrit.libreoffice.org/82448 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11simplify OUString constructionNoel Grandin
Change-Id: Ib91d77c578aa21af02beaf299d16b5d8c2942f00 Reviewed-on: https://gerrit.libreoffice.org/82447 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-11Make base of loplugin::FunctionAddress more flexibleStephan Bergmann
(I'm planning to use it for a FilteringRewritePlugin.) And while at it, base its current uses on FilteringPlugin. Change-Id: I0acdcc6cb0b3a434b425405c8c438dbf65e4d3cb Reviewed-on: https://gerrit.libreoffice.org/82451 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-11reduce some ref-countingNoel Grandin
Change-Id: I7b372237c21c469f78be281eedbbdda217fd12c8 Reviewed-on: https://gerrit.libreoffice.org/82442 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-11fix move operatorNoel Grandin
introduced in commit a0ebc6f898992dbc0da9f252911da867dfdfd741 Date: Sat Nov 9 08:47:48 2019 +0200 missing move operator= Change-Id: I0607ad1afbcb1f2a86d1c7e0736e2549a5562b64 Reviewed-on: https://gerrit.libreoffice.org/82441 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-11sc: rowcol: tdf#50916 convert mark data structuresNoel Grandin
Change-Id: I9b706c9bcc2925f72cc024142ffe72af5ddea82a Reviewed-on: https://gerrit.libreoffice.org/82419 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-11-11tdf#128428 RTF: fix for different product versionsLászló Németh
at switching off longer space sequence mode. Change-Id: I87c265ad0ff5f7b44c92b1abebeb31f68749a1e7 Reviewed-on: https://gerrit.libreoffice.org/82434 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-11-11User interface languages: At least one is requiredSamuel Mehrbrodt
Reported here: https://twitter.com/erez/status/1193838467668697089 Change-Id: I96fdb82646e6b2e49b6032766195309a97da0fba Reviewed-on: https://gerrit.libreoffice.org/82439 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-11-11Chart Form Dialog Buttons use same widthandreas kainz
Change-Id: I50f3ec22119955b2fbb6848797e6393750ff9249 Reviewed-on: https://gerrit.libreoffice.org/82406 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-11Calc Define Dialog Distance between Buttons is from systemtheme 6andreas kainz
Change-Id: Id71fcb6a6e875aca36382c9dc3dbb71915261fff Reviewed-on: https://gerrit.libreoffice.org/82401 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-11Hyperlink Dialog Alignment similar in each tabandreas kainz
Change-Id: I670e94541e246ce8a71d2b45b598e924a43592a5 Reviewed-on: https://gerrit.libreoffice.org/82400 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-11-11cid#1455327 Dereference null return valueCaolán McNamara
Change-Id: I336659e820d46e8b23881fdf9d5f3b6fac072771 Reviewed-on: https://gerrit.libreoffice.org/82429 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11tdf#109219 MM: Decode all percent encodings in file namesMichael Weghorn
While decoding using 'INetURLObject::DecodeMechanism::Unambiguous' as introduced by commit 47708d533e1325032df55eb667ef0c47fa05e7e5 ("tdf#109219 Allow files with spaces in name as MM data source") makes sure that e.g. spaces in file names are properly decoded, 'INetURLObject::DecodeMechanism::WithCharset' is actually the more correct decoding mechanism to use here, since it also decodes some percentage encodings that 'INetURLObject::DecodeMechanism::Unambiguous' would leave unchanged. Using 'INetURLObject::DecodeMechanism::WithCharset' instead e.g. makes CSV files with '%' characters in their names work as data sources for mail merge as well. A big thanks to Stephan Bergmann for pointing this out in https://gerrit.libreoffice.org/#/c/82201/ . Change-Id: Iee50584299c82d5718e3210f048ed739818bd11b Reviewed-on: https://gerrit.libreoffice.org/82428 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-11-11Related: tdf#117658 PPTX import: ignore math text outside <m:t>Miklos Vajna
This way a pretty-printed bug document doesn't assert on import with: soffice.bin: /home/vmiklos/git/libreoffice/master/oox/source/mathml/importutils.cxx:335: void oox::formulaimport::XmlStreamBuilder::appendCharacters(const rtl::OUString&): Assertion `!tags.empty()' failed. Change-Id: Icf8b11f3c56076b1ad2dddad196260ee87540020 Reviewed-on: https://gerrit.libreoffice.org/82437 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-11-11cid#1455325 Dereference after null checkCaolán McNamara
Change-Id: I5fa2846be23bcdfe202dd7c96fad79aa4009ff4e Reviewed-on: https://gerrit.libreoffice.org/82430 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11cid#1455213 Dereference after null checkCaolán McNamara
Change-Id: I2f59ed3c94d3a27fe50ca99f511f9ba5b47ff5d1 Reviewed-on: https://gerrit.libreoffice.org/82426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11call GetSbData just onceCaolán McNamara
Change-Id: Idb63c169c7e39f27bc99e3c3aa9155583f2a65ab Reviewed-on: https://gerrit.libreoffice.org/82431 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-11-11jsdialogs: apply .uno:Color and CharBackColor to floating text framesSzymon Kłos
Change-Id: I1a6b997f1a857524c7a48434321ca10d97f5e5db Reviewed-on: https://gerrit.libreoffice.org/82311 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/82317 Tested-by: Jenkins
2019-11-11tdf#121090: Correct the last argument to HLOOKUP/VLOOKUP descriptionMike Kaganski
The argument is meant to define semantical meaning of the array's first column, not just define if it's sorted or not. Change-Id: I87ff172bcc13d6471ee4025e74962be89f1b0b50 Reviewed-on: https://gerrit.libreoffice.org/82376 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-11-11Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' - Related: tdf#121090: Rewrite descriptions for the last argument of HLOOKUP/VLOOKUP That parameter is not about telling the *functions* if the search column in the array is sorted or not, but about different semantical treatment of the array, i.e. whether it's the array of values or sorted ranges. The wording "Sorted" and "indicates whether the first column in the array is sorted in ascending order" is misleading, not providing the idea behind the argument, and create an impression that all sorted array lookups must have it ser to TRUE. Change-Id: I795c29f3c7d5632db6f72f7906bfdacaa372832e Reviewed-on: https://gerrit.libreoffice.org/82375 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-11-11Removed executable permission on fileAndrea Gelmini
Change-Id: I45174811c8e1ef80ddae97f206f2a5459540849f Reviewed-on: https://gerrit.libreoffice.org/82427 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-06-30 13:39:16 +0000