summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-02-01o3tl: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Id9d038d50d5b6335a2f354c759b2c1e5dd413cec Reviewed-on: https://gerrit.libreoffice.org/49037 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01odk: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Ie5957edb3954507505a7df9fad9f8da6b87b09d0 Reviewed-on: https://gerrit.libreoffice.org/49038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01oox: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I3b3f46be30fce0f9193ee8d52159b16d022d903f Reviewed-on: https://gerrit.libreoffice.org/49039 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01LibreOfficeKit: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Id8dd284a9db04eae458593d8e411b44223d16a8e Reviewed-on: https://gerrit.libreoffice.org/49040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01Use more specific tag in SAL_INFO and SAL_WARN hereTor Lillqvist
Surely we shouldn't be using the very generic "sw" for such a feature-specific part of the Writer code. Change-Id: Id8913b9121a419f5da1f46a552fab95c903a3b13
2018-02-01Fix typoAndrea Gelmini
Change-Id: Ib02367b1d93d15d32850a36375bfa5b83ef4f33d Reviewed-on: https://gerrit.libreoffice.org/49098 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-01Fix typosAndrea Gelmini
Change-Id: Id9d4f277ec684f4baaa9f16000da1b208d745e03 Reviewed-on: https://gerrit.libreoffice.org/49099 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-01ofz#3032 slk fuzzing timeouts on filling all rowsCaolán McNamara
which tells us that we're way too slow, which isn't really interesting news, set an arbitrary limit for number of rows to import Change-Id: Ie835088eab4e363a7deb19e9e5dbe43c1838520b
2018-02-01tdf#85940 Add basic list styles to context menuYousuf Philips
Change-Id: I9bdc3f1ba64ed47a6569b93e6685adad47c41718 Reviewed-on: https://gerrit.libreoffice.org/48238 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Yousuf Philips <philipz85@hotmail.com>
2018-02-01Avoid empty avoid name for SfxPrintingHintJulien Nabet
Create a brand new doc on Writer, click Print then Cancel button => warn:legacy.tools:2382:2382:sfx2/source/doc/sfxbasemodel.cxx:3071: Empty event name! Here's the bt 0 0x00007ffff1da379c in SfxBaseModel::postEvent_Impl(rtl::OUString const&, com::sun::star::uno::Reference<com::sun::star::frame::XController2> const&) (this=0x5555578f0630, aName="", xController=empty uno::Reference) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:3073 1 0x00007ffff1da134b in SfxBaseModel::Notify(SfxBroadcaster&, SfxHint const&) (this=0x5555578f0630, rBC=..., rHint=...) at /home/julien/lo/libreoffice/sfx2/source/doc/sfxbasemodel.cxx:2731 2 0x00007ffff12768d1 in SfxBroadcaster::Broadcast(SfxHint const&) (this=0x5555578e9420, rHint=...) at /home/julien/lo/libreoffice/svl/source/notify/SfxBroadcaster.cxx:49 3 0x00007ffff1eec7b6 in SfxPrinterController::jobFinished(com::sun::star::view::PrintableState) (this=0x55555c092d20, nState=com::sun::star::view::PrintableState::PrintableState_JOB_ABORTED) at /home/julien/lo/libreoffice/sfx2/source/view/viewprn.cxx:329 4 0x00007fffec314318 in Printer::FinishPrintJob(std::shared_ptr<vcl::PrinterController> const&) (xController=std::shared_ptr (count 2, weak 0) 0x55555c092d20) at /home/julien/lo/libreoffice/vcl/source/gdi/print3.cxx:519 5 0x00007fffec3143b1 in Printer::ImplPrintJob(std::shared_ptr<vcl::PrinterController> const&, JobSetup const&) (xController=std::shared_ptr (count 2, weak 0) 0x55555c092d20, i_rInitSetup=...) at /home/julien/lo/libreoffice/vcl/source/gdi/print3.cxx:529 6 0x00007fffec3128ef in PrintJobAsync::ExecJob(void*) (this=0x55555c09b940) at /home/julien/lo/libreoffice/vcl/source/gdi/print3.cxx:275 7 0x00007fffec3128c5 in PrintJobAsync::LinkStubExecJob(void*, void*) (instance=0x55555c09b940, data=0x0) at /home/julien/lo/libreoffice/vcl/source/gdi/print3.cxx:273 This behavior has been like this since: https://cgit.freedesktop.org/libreoffice/core/commit/?id=87dfa6dd336d596112c0beb6b42f082178461678 This patch will allow SfxBaseModel::postEvent_Impl to not return early See https://opengrok.libreoffice.org/xref/core/sfx2/source/doc/sfxbasemodel.cxx#3059 Change-Id: I77ff916c15944693f9f0848bf8f18659f9b519df Reviewed-on: https://gerrit.libreoffice.org/48936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01Fix typosAndrea Gelmini
Change-Id: I5cfa53bbe82fc3611770fdbe3b58d593f7a7c89f Reviewed-on: https://gerrit.libreoffice.org/49100 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-01osl: change osl_psz_removeFile() -> osl_unlinkFile()Chris Sherlock
Also a few cleanups. Change-Id: I3269d623917efda3a873f745dbce8bb25dce79be Reviewed-on: https://gerrit.libreoffice.org/48792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01connectivity: remove dead codeChris Sherlock
Change-Id: Ia968179d90978dc6c737effce5447efda60c1f66 Reviewed-on: https://gerrit.libreoffice.org/47490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01Updated coreMike Kaganski
Project: help 0f7a354db93f0affe218cae7e0ea294a4efe5891 Correct parameter syntax Change-Id: Ib9f805c33b1a2243197e5addfe9bf777b4e88ed5 Reviewed-on: https://gerrit.libreoffice.org/47889 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-02-01ofz#5872 Direct-leakCaolán McNamara
Change-Id: Id792ecc80dd3367f070c9a613f3999a8c3e386a1
2018-02-01tdf#42949 Remove unneeded helpids.h headers (3/3)Gabor Kelemen
A side effect of the .ui migration is that we use a lot less HIDs in the code. A lot of files still contain helpids.h includes even if no actual HID is referenced. This cleans up directory sw. Found with: git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_ | grep :0$ Change-Id: I100fd818b0e68eaaecbfaf7c7b58e95dea489aeb Reviewed-on: https://gerrit.libreoffice.org/46870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01tdf#42949 Remove unneeded helpids.h headers (2/3)Gabor Kelemen
A side effect of the .ui migration is that we use a lot less HIDs in the code. A lot of files still contain helpids.h includes even if no actual HID is referenced. This cleans up directories r* - svx*. Found with: git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_ | grep :0$ Change-Id: I81bdb80161b0207f5df651eb17c58caef44250d3 Reviewed-on: https://gerrit.libreoffice.org/46869 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01tdf#42949 Remove unneeded helpids.h headers (1/3)Gabor Kelemen
A side effect of the .ui migration is that we use a lot less HIDs in the code. A lot of files still contain helpids.h includes even if no actual HID is referenced. This cleans up directories b* - e*. Found with: git grep helpids.h | cut -d : -f 1 | xargs grep -c HID_ | grep :0$ Change-Id: I221d22f68584115d71660a97c4f108595625d12c Reviewed-on: https://gerrit.libreoffice.org/46868 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01Use std::maxStephan Bergmann
(with the nice side-effect of removing one more false -Wsign-compare from Android builds where USHRT_MAX is erroneously of type unsigned int) (the original cast of rMax (of some unsigned type) to (signed) long had probably originally been added to silence some signed-vs.-unsigned comparison warning, so would no longer be necessary when using std::max) Change-Id: I26212e731e26d885b848c7351a9ca5f9735e1f78 Reviewed-on: https://gerrit.libreoffice.org/49081 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-01sw: convert DELETEZ to std::unique_ptr in SwXFrameMichael Stahl
Change-Id: I1aa9d0fc8712773ea87ea8419c384f6f23258387
2018-02-01deps w/ hardlinks: don't create it as foo_ only to move it to fooChristian Lohmaier
this breaks with CCACHE_HARDLINK=1 on close-enough rebuilds, as there will be "foo" from previous run (hardlinked to ccache-dir), and foo_ will be hardlink to the same file, resulting in mv to barf out since foo_ and foo are the same file (and -f/force doesn't help in this case) Change-Id: Iaefcec05b34dad88f49477693e2157c1ca0623ac Reviewed-on: https://gerrit.libreoffice.org/42586 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01sd: Remove unused keywordsTakeshi Abe
Change-Id: I1a180aaca32cabc56a6d5a6a3f0b23680d60aaf3 Reviewed-on: https://gerrit.libreoffice.org/47760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01sw: convert DELETEZ to std::unique_ptr in SwUndoTableNumFormatMichael Stahl
Change-Id: Ia1123e2b5f4b3bb2d827d2cdbeff485c3c2a56da Reviewed-on: https://gerrit.libreoffice.org/49080 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01sw: convert DELETEZ to std::unique_ptr in unodraw.cxxMichael Stahl
Change-Id: I89aaf157ded42ea3e968c706e4431f03d8f19ed7 Reviewed-on: https://gerrit.libreoffice.org/49078 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01apparmor: fix @{HOME}/.mozilla/firefox access for XML signingRene Engelhard
the #include <abstractions/private-files-strict> bringing "audit deny @{HOME}/.mozilla/** mrwkl," in actually denies everything here. Use just <abstractions/private-files> and allow profiles.ini, secmod.db and cert8.db. At least opening the Digital Signatures dialog doesn't log apparmor DENIED now... Change-Id: Id557626fc26745841f0cca005d483fd1e6ac922d Reviewed-on: https://gerrit.libreoffice.org/48264 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01Pass also webdavs:// URLs directly to soffice binaryKatarina Behrens
instead of going via kioexec & temp file Change-Id: I48ed5de97a2914025f01884f5ed0d0edce452112 Reviewed-on: https://gerrit.libreoffice.org/48900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-01Support for webdav:// and webdavs:// schemes from command lineVasily Melenchuk
We have currently support for WebDAV schemes as vnd.sun.star.webdav:// but it is not user and tools friendly. Some related refactoring in ucb to reuse existing code instead of manual parsing of URLs. Change-Id: Ib14411796d6cf11afd80d5132abe67d4e46a42e1 Reviewed-on: https://gerrit.libreoffice.org/48585 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-02-01split out SFX_METRIC_ITEM into separate fieldNoel Grandin
instead of overloading the nMemberId field and thus fix various places that were effectively setting the METRIC flag and causing a warning in SvxUnoConvertToMM And fix bug in sw/source/core/unocore/unomap.cxx where the PropertyAttribute::READONLY was in the wrong place, ever since commit 84a3db80b4fd66c6854b3135b5f69b61fd828e62 Date: Mon Sep 18 23:08:29 2000 +0000 initial import Change-Id: Ifc2bf56709f19aea75300b2fda62ce551efc26af Reviewed-on: https://gerrit.libreoffice.org/48950 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01Change bitmap table to store XBitmap instead of GraphicObject URLTomaž Vajngerl
As we want to get rid of GraphicObject URLs for the more robust image life-cycle handling, it was necessary to change the way bitmap table stores and handles images, so that they always store a Graphic object (wrapped in UNO object that provides the XGraphic and XBitmap interface). In addition this changes loading and saving from ODF (xmloff) and OOXML (oox) filters so they don't depend on GraphicObject URL anymore, but load or save directly to / from XGraphic or XBitmap. Change-Id: I2b88e10056e7d6c920249d59188f86b1a5a32d21 Reviewed-on: https://gerrit.libreoffice.org/49074 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-01add XGraphicStorageHandler interfaceTomaž Vajngerl
This is a XGraphicObjectResolver (future) replacement as it will not be needed anymore. All resolving from URL to URL will be replaced by loading, saving and serialization of XGraphic objects (when appropriate), which is covered by this interface and implementation by XmlGraphicHelper - the same that implements the XGraphicObjectResolver. Change-Id: I227634e443ce336218c2a2effaf34f9ef3576382 Reviewed-on: https://gerrit.libreoffice.org/49073 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-01hash implementation for Graphic objects, for set/map useTomaž Vajngerl
Change-Id: I58547ad90d1aba6b1734a547c8138d1476c4b813 Reviewed-on: https://gerrit.libreoffice.org/49072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-02-01these TODOs have been doneNoel Grandin
Change-Id: I5457f38f4668175a8f3e1b0f24a90963ee9d585f Reviewed-on: https://gerrit.libreoffice.org/49076 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01Fix typosAndrea Gelmini
Change-Id: Icb4f4d9039278318d5f7f6302d57957b2c02bdb8 Reviewed-on: https://gerrit.libreoffice.org/49069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01Fix typosAndrea Gelmini
Change-Id: I455efa82de60b764a500e1cc092ae08e800ec824 Reviewed-on: https://gerrit.libreoffice.org/49068 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-01embedserv: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I0abd5662648b09f31164d919688e17a651bf78c8 Reviewed-on: https://gerrit.libreoffice.org/48976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01extensions: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I7bbb280810af51adc25595667f1c40aca0a8ae26 Reviewed-on: https://gerrit.libreoffice.org/48977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01external: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Ic17ffd6fc34504cf848d963e787e685ed2142080 Reviewed-on: https://gerrit.libreoffice.org/48978 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01fpicker: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Ifb05da6cf6d2084e80372440118883278738ea87 Reviewed-on: https://gerrit.libreoffice.org/48979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01helpcompiler: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I56298ee1962a4989bcc5446df2766d7aa30c28cd Reviewed-on: https://gerrit.libreoffice.org/48980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01i18nlangtag: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I88e2b2e68fbbc86639db986e8f430a90bd4b94f0 Reviewed-on: https://gerrit.libreoffice.org/48982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01i18npool: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Iacb0c1fba331aa76ea341bc21690f09109b14a0a Reviewed-on: https://gerrit.libreoffice.org/48990 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01EPUB export: can use std::move() hereMiklos Vajna
And get rid of an easy to avoid include if we are at it. Change-Id: I63cb4628a3a7038aab91c66f592920923a31d7a6 Reviewed-on: https://gerrit.libreoffice.org/49060 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-01USHRT_MAX -> SAL_MAX_UINT16Stephan Bergmann
...as nH needs to fit into the following SwPosSize::Height call's parameter of type sal_uInt16. And whatever the reason to check for < instead of <= USHRT_MAX... Change-Id: I0377d51e7411eef7913d951eb972214a8d8d5768 Reviewed-on: https://gerrit.libreoffice.org/49065 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-01loplugin:datamembershadow in XFCellStyleNoel Grandin
looks like the subclass member is never written to, so I'm going to assume this was a bug Change-Id: Ic56c4a30cd139415eb08c4d572273dad2411b514 Reviewed-on: https://gerrit.libreoffice.org/49001 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01loplugin:useuniqueptr in SfxModule_ImplNoel Grandin
Change-Id: I218cd34aefcf8bfbc8a52379fb1e15ec2ef3ac31 Reviewed-on: https://gerrit.libreoffice.org/48700 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-02-01embeddedobj: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Iefcaf1f5ae73050300879fff0855f709c5f8a30d Reviewed-on: https://gerrit.libreoffice.org/48975 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01dtrans: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I7a043bc152373e98635bf2bd3513113a8ea45958 Reviewed-on: https://gerrit.libreoffice.org/48974 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01desktop: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I61ed9700c904b7499166d32e4ffda69811d64a8b Reviewed-on: https://gerrit.libreoffice.org/48973 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01cppuhelper: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: Ib097ea1764d275a3123d0dccf05d52315b4858a1 Reviewed-on: https://gerrit.libreoffice.org/48971 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-02-01canvas: MSVC: pragma warning: make more specific, remove obsoleteMike Kaganski
Change-Id: I0d23c789dd3cbb21a18383988dd6b24318fda225 Reviewed-on: https://gerrit.libreoffice.org/48959 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-12 21:49:26 +0000