summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-01-18In vcl/unx/generic/print/, use OStringBuffer instead of fixed-size arraysStephan Bergmann
...to avoid potential overflow in psp::appendStr as reported by GCC with --enable-optimized: > vcl/unx/generic/print/psputil.cxx: In function ‘sal_Int32 psp::appendStr(const sal_Char*, sal_Char*)’: > vcl/unx/generic/print/psputil.cxx:127:13: error: ‘char* strncpy(char*, const char*, size_t)’ specified bound depends on the length of the source argument [-Werror=stringop-overflow=] > strncpy (pDst, pSrc, nBytes + 1); > ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~ > vcl/unx/generic/print/psputil.cxx:126:31: note: length computed here > sal_Int32 nBytes = strlen (pSrc); > ~~~~~~~^~~~~~ Most of the time the original code wrote at the "end" of its char array, so replacements with functionality based on OStringBuffer::append was straightforward. A few places needed to use OStringBuffer::insert to mimic the original code's writing at somewhat random positions in the char array. The functions now taking an OStringBuffer argument still return the amount of characters written. Even if that information would (indirectly) also be available as part of the OStringBuffer's state, keeping the (somewhat redundant now) counting of positions in the calling code should help avoid regressions. Some of the code may be simplified in follow-up commits, dropping the external counting. The original psp::getValueOfDouble is still used elsewhere, so leave it alone for now and add an OStringBuffer overload. Change-Id: I2bb5d51505ca70cba485e6843183496ea3a4ce18 Reviewed-on: https://gerrit.libreoffice.org/66564 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-18convert StockVariant to scoped enumNoel Grandin
and simplify naming Change-Id: Ieada4e83fcc2eafd03f65b1216bf5ad026ced4c7 Reviewed-on: https://gerrit.libreoffice.org/66567 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' - Python Help page for screen IO Change-Id: I0a1fc11a23c6f48eb058d42541e1f22c57ddb26d Reviewed-on: https://gerrit.libreoffice.org/66442 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#121781 Clarify TZ info in Calc functions Notify user that TZ are not considered in date & time functions and in date & time formatted cells. Change-Id: I684039ebcc095fe4eefc2bf573df18679dd7f9f3 Reviewed-on: https://gerrit.libreoffice.org/66468 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-18Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#122631 Describe Shift+F5 in Writer Change-Id: I2191fa502c0db26854c10cff4a6e5f2b094a8557 Reviewed-on: https://gerrit.libreoffice.org/66087 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-18Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - minor correction Change-Id: Ia986be35c2805f2ed82f9d148702a87fa5537d20 Reviewed-on: https://gerrit.libreoffice.org/66573 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-18convert some enums to scopedNoel Grandin
Change-Id: Ib381bb24abb4bf09c87d9fa372374ce133cb7848 Reviewed-on: https://gerrit.libreoffice.org/66566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18o3tl::make_unique -> std::make_unique in chart2...cuiGabor Kelemen
Since it is now possible to use C++14, it's time to replace the temporary solution with the standard one Change-Id: I2ba0b9b44971166bd79527b52745f3c40dc14387 Reviewed-on: https://gerrit.libreoffice.org/66490 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18PortionType::Url is unusedNoel Grandin
ever since commit 1b666235f6b0b0f0b13f473bf3b639f4f5f0b12f Date: Wed Jan 3 09:08:52 2018 +0200 loplugin:singlevalfields improve copy constructor check Change-Id: Ic17182c8abc29488ae2e1004d9fb4e8b8b7f623b Reviewed-on: https://gerrit.libreoffice.org/66515 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18tdf#42949 Fix remaining IWYU warnings in include/vcl/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Some new headers were added since I begun the cleanup here Also blacklist the header from commit 403e3c04420c4d20c77427c43df52d554d7329ff Change-Id: Ie2358d5e27297f873aeb4a4dfb2778e6fb95dfa5 Reviewed-on: https://gerrit.libreoffice.org/66255 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-18CppunitTest_xmlsecurity_pdfsigning: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: Ia1ed6989737b765f2e4332f402fb5c11ef7f0f31 Reviewed-on: https://gerrit.libreoffice.org/66553 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-18Add XDDELinks tests to ScDDELinksObjJens Carl
Change-Id: I9e6efbd5a1cd9e4787e8143dd4f8adbe6ab2cae7 Reviewed-on: https://gerrit.libreoffice.org/66561 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-18Add aCalcPageSize and aCalcPagePos properties to ScModelObj::getRendererMuhammet Kara
So that we can adjust page offset when outputting to GDIMetaFiles Change-Id: I1c28440a1ff62a879b6341748a6d3092f2bfda96 Reviewed-on: https://gerrit.libreoffice.org/66526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18update useunique_ptr lopluginNoel Grandin
with more exclusions Change-Id: I95e7376ecf9c479d05b85c71f863d9ba40417538 Reviewed-on: https://gerrit.libreoffice.org/66552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18use unique_ptr in SwAttrSetNoel Grandin
Change-Id: I8b30b76a0c45c8262bf03022c62639be86620bf9 Reviewed-on: https://gerrit.libreoffice.org/66551 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18use unique_ptr in starmathNoel Grandin
Change-Id: Ib9c555507d5271343424686f2321ae13efcbf41a Reviewed-on: https://gerrit.libreoffice.org/66550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18use unique_ptr in scNoel Grandin
Change-Id: I14ccb215e895b607c7244b420ee2cbaea8112b15 Reviewed-on: https://gerrit.libreoffice.org/66549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18convert POR constants to scoped enumNoel Grandin
Change-Id: Ia146f1f932cf4437e2e7e20722b0957a458979fd Reviewed-on: https://gerrit.libreoffice.org/66514 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-18Fix typoAndrea Gelmini
Change-Id: I80e83c04f3001fefad6cbdffc19ce8e05272dc88 Reviewed-on: https://gerrit.libreoffice.org/66562 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-18Base/Mysqlc: fix schemas retrievingJulien Nabet
Change-Id: Ib0bd600aed3c3394890a199d105aff17cd547200 Reviewed-on: https://gerrit.libreoffice.org/66554 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2019-01-18Add XServiceInfo tests to ScDDELinksObjJens Carl
Change-Id: Iacd44465e4b4b3a1a6657abcf274ffe7f8eb808b Reviewed-on: https://gerrit.libreoffice.org/66560 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-18tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScDDELinksObj. Change-Id: I91d8ea1b51cde36996847371a03406b899e23d79 Reviewed-on: https://gerrit.libreoffice.org/66559 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-18tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScDDELinksObj. Change-Id: I627a9f54257b9283aadcf7b6b0fbb403b69b4354 Reviewed-on: https://gerrit.libreoffice.org/66558 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-18tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScDDELinksObj. Change-Id: Ic67c2078b0e439d7209d142c7461a2f858e04ad3 Reviewed-on: https://gerrit.libreoffice.org/66557 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-18tdf#45904 Move XNameAccess Java tests to C++Jens Carl
Move XNameAccess Java tests to C++ for ScDDELinksObj. Change-Id: Ic36e78920b0a6649b2fc5a9298cea51615c5d5c6 Reviewed-on: https://gerrit.libreoffice.org/66556 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-17rename SwLinePortion::GetPortion -> GetNextPortionNoel Grandin
to make it obvious when reading the code that we have a linked list here Change-Id: Ia7b8592af36a87723e7ef7b301331dc71357002b Reviewed-on: https://gerrit.libreoffice.org/66513 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-17tdf#122516: fix timestamp in MariaDb/mysqlJulien Nabet
Change-Id: I9740e265c7f4c607bf871c5f12df149355ce6a61 Reviewed-on: https://gerrit.libreoffice.org/66495 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2019-01-17Resolves: tdf#122786 use weld::SpinButton::set_value() instead of set_text()Eike Rathke
... otherwise get_value() returns 0. Change-Id: I345d31e888e40f1fc191cef7dac802eb860a824f Reviewed-on: https://gerrit.libreoffice.org/66539 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-01-17Rework Ascii85Encoder::ConvertToAscii85 code somewhatStephan Bergmann
...making sure not to generate characters into the output that are ultimately discarded again. In preparation of eventually changing the output from a char array to something more flexible like OStringBuffer. Change-Id: I2fde3d02752d4e81ee1ee34188266e72d1d8b01d Reviewed-on: https://gerrit.libreoffice.org/66528 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-17WIN remove private-font fallback handlingJan-Marek Glogowski
The fallback code is from times, when FR_PRIVATE was not available (pre Win2k). So just remove this special global font handling. Change-Id: Ie54b0269513ab63d84e5c8bb4d4555a775161757 Reviewed-on: https://gerrit.libreoffice.org/66516 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-01-17tdf#122557 EMF+ Implement Shearing for DrawImage recordsBartosz Kosiorek
Change-Id: If16afb7e56002153c962c32ded2e1dd6edda36fb Reviewed-on: https://gerrit.libreoffice.org/66509 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-01-17Comment non-obvious Ascii85Encoder::ConvertToAscii85 codeStephan Bergmann
(see e.g. the "ASCII85Encode Filter" section on p. 129 of the PostScript Language Reference Manual, 2nd ed., Addison-Wesley 1990) Change-Id: Icfb6d64f67e40053ae8a0f292dd52bd72178ef36 Reviewed-on: https://gerrit.libreoffice.org/66522 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-17tdf#122393 move to overflow row on using left/right at end of other rowCaolán McNamara
and on ctrl+page_up/ctrl+page_down Change-Id: I3320abfb91655b7b4278886cc6fc4dceb637e4b1 Reviewed-on: https://gerrit.libreoffice.org/66510 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-17use unique_ptr in swNoel Grandin
Change-Id: I899d050e76f705002e943ae5384cc8c928789df9 Reviewed-on: https://gerrit.libreoffice.org/66512 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-17tdf#122761: Revert "Resolves tdf#122118 - Toolbar dropdown button triangles ↵Xisco Faulí
are too large" This reverts commit b56ad2a1292b01647c4ee1f4364f7c4aa20fc449. Change-Id: I0fa94c4a027a85a14e85c53a18443d97fa862a59 Reviewed-on: https://gerrit.libreoffice.org/66507 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org>
2019-01-17Resolves: tdf#122334 decorator missingCaolán McNamara
Revert "Resolves: tdf#119688 under X full-screen doesn't work before gtk_widget_show" This reverts commit 88fc17e473ce2d3e8a7eae4235446a75eb9e91a2. Change-Id: I5f2996c0d940eec459725cc91c5dee7fd7dee267 Reviewed-on: https://gerrit.libreoffice.org/66502 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-17Check OS_FOR_BUILD for behavior of sed executed during buildStephan Bergmann
Follow-up to d8106b6db488a4439f7bb781920c92a056b91ba6 "Non-standard sed -i option is different on macOS than with GNU sed", thanks to mst for spotting it. Change-Id: Ida51cfa7c4dd216a5164df4f8143ac89cf2c6b7f Reviewed-on: https://gerrit.libreoffice.org/66498 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-17Fix rtl_DoubleLocking::getValue_002 testStephan Bergmann
At least <https://ci.libreoffice.org//job/lo_tb_master_win/20394/> once failed with > Value in Thread #1 is 0 > Value in Thread #2 is 5 > C:/cygwin/home/tdf/lode/jenkins/workspace/lo_tb_master_win/sal/qa/rtl/doublelock/rtl_doublelocking.cxx:202:rtl_DoubleLocking::getValue::getValue_002 > assertion failed > - Expression: nValueOK != 0 > - getValue() failed, wrong value expected. and there is indeed no guarantee that either of the OGetThreads has already been through its while loop by the time the main thread calls terminate(). So make execution of the threads deterministic (and take out the sleeps that are no longer necessary, and use the now-deterministic expected values in the result checks). Change-Id: I61726906f646ffae7a21b1e08b1d973a4e51265b Reviewed-on: https://gerrit.libreoffice.org/66494 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-17upgrade to python 3.5.6Caolán McNamara
Change-Id: I6cdfc50b2385c426e20ce0e9b216b18c763249b8 Reviewed-on: https://gerrit.libreoffice.org/66506 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-17Resolves: tdf#122744 pt/% values not limited to historic limitsCaolán McNamara
Change-Id: I439bf27b3f57838d9d0ea19605fd1b684ad4f777 Reviewed-on: https://gerrit.libreoffice.org/66474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-17oox smartart, org chart: improve width of non-manager nodesMiklos Vajna
The default case is that all managers have assistants/employees, so nodes under a manager can only use the horizontal space under the manager to avoid overlapping. But in case the previous / next sibling of the manager have no child nodes (assistant/employee) then we can use that space to make the child nodes larger. This improves readability of the chart's text a lot and brings the layout closer to what PowerPoint does for the same input. Handle all this in the hierChild algorithm, i.e. the container for a list of assistants or a list of employees, which means "parent" in this context always refers to a manager node. Change-Id: Ib4125ea2a113339ab7bbcd78e43c5d204f442996 Reviewed-on: https://gerrit.libreoffice.org/66504 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-01-17Add tests for FREQUENCY() ReferenceOrForceArray, ForceArrayReturn, tdf#122301Eike Rathke
Change-Id: I36b2bda0fcb0bfd14e62c2529ecb79e11eab34f2 Reviewed-on: https://gerrit.libreoffice.org/66482 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-01-17Resolves: tdf#122346 get font features to stick in entry properlyCaolán McNamara
Change-Id: I56058a2069600a4c8acba861a38e7e5d84f44d81 Reviewed-on: https://gerrit.libreoffice.org/66499 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-17Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
Change-Id: I9400c8fa5b7763debc13274f7e001b6425d8392e Reviewed-on: https://gerrit.libreoffice.org/66496 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-17lok: We cannot skip duplicates of SELECTION_START / _END.Jan Holesovsky
The scenario is like this (see the unit test): * double-click a word to select it (the handles appear) * click somewhere else (the selection and handles disappear) * double-click the same word again (the handles did not appear in this case) The reason was that the old state was remembered and the now thought duplicate state was discarded. Change-Id: Ia49200f12907c520067258b7570d4e21b365a8dd Reviewed-on: https://gerrit.libreoffice.org/66171 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-01-17Non-standard sed -i option is different on macOS than with GNU sedStephan Bergmann
While with GNU sed the optional backup suffix is given directly as part of the -i[SUFFIX] (or --in-place[=SUFFIX]) argument, on macOS it must unconditionally be given as a (potentially empty) argument following the -i argument. That means that on macOS the -e that happens to follow the -i in these sed invocations (and that happens to not be necessary to introduce the following script in these invocations) was mistaken as the backup suffix, causing creation of pointless workdir/CustomTarget/*/generated/tokens.cxx-e backup files. Change-Id: Icd865c76139afa348d03813eb83653afd7221a0e Reviewed-on: https://gerrit.libreoffice.org/66491 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-17find-unneeded-includes: don't propose debug/bitset eitherGabor Kelemen
Found while checking include/vcl/fontcapabilities.hxx Change-Id: Ib598978672d08d3cae7bf6f96d1b874ca13fcb5f Reviewed-on: https://gerrit.libreoffice.org/66254 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-17sw: make members of RtfExportFilter privateMiklos Vajna
- also use std::make_unique - also avoid multiple declarations in a single statement Change-Id: Ib5429730fcf14131b7b68628a8724a812dcc018f Reviewed-on: https://gerrit.libreoffice.org/66479 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-17tdf#122557 EMF+ Implement proper rotation support of DrawImageBartosz Kosiorek
Change-Id: I2c32a47fac06b2026d61a0f369e6d569c9f57502 Reviewed-on: https://gerrit.libreoffice.org/66392 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2019-01-17convert ScChangeTrackMsgType to scoped enumNoel Grandin
Change-Id: Ie0baed90e3d0f51ec15c110dbd7ff41dcf7baa40 Reviewed-on: https://gerrit.libreoffice.org/66324 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-07 02:12:15 +0000