summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-07-04Fix typoAndrea Gelmini
Change-Id: I28a12befa0df6dcfcec7bad39c8691425b5b5d9d Reviewed-on: https://gerrit.libreoffice.org/56852 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-07-04tdf#115718 Fix Watch Window EditBoxAlex McMurchy1917
For KDE4 only: this change reintroduces QStyle::PE_PanelLineEdit for the EditBox/LineEdit widget. This allows the contents of the Watch Window EditBox to be amended as one would expect. Change-Id: Iffd7498d5f553ac0c9c612bf36b9f23d9eb8f86d Reviewed-on: https://gerrit.libreoffice.org/56447 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-04tdf#86612: impress: mark several statusbar elements as optionalVasily Melenchuk
support for "mandatory" property was introduced in d77f8eef165a7c6fd97cc06dcbc4ead55e7b633c but implementation was made only for Calc and Draw. decrease minimal width for "size" element: it is using too much horizontal space in small window. Change-Id: I184ac3a03ffa0a018f012d0f5da3c2da54f6c365 Reviewed-on: https://gerrit.libreoffice.org/56719 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-07-03Adapt compilerplugins/clang/store/deletedspecial.cxxStephan Bergmann
...to 322083e0cf1268bc5d40f0d49eb50f00f503ef15 "ScFormEditData copy functions can be deleted" Change-Id: Ic62c83b79e70a79d1d236b79140009a4212b6a43 Reviewed-on: https://gerrit.libreoffice.org/56878 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-03vcl: fontfeature test, decalre fonts the same was as in sw testsTomaž Vajngerl
Change-Id: If1b3e658c30d1ae0e254ed7d8035d107bd2892f7 Reviewed-on: https://gerrit.libreoffice.org/56900 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-07-03NB writer: add media section to tabbed_compactandreas kainz
Change-Id: Icbe25a95319806d8d45deb9d3d8a68ce8afc3721 Reviewed-on: https://gerrit.libreoffice.org/56895 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-03NB writer: add media section to groupedbar_compactandreas kainz
Change-Id: I65aa3bbabeb0bbff05ac9257539135c67b9bcf2e Reviewed-on: https://gerrit.libreoffice.org/56890 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-03NB writer: add media section to groupedbar_fullandreas kainz
Change-Id: I2b306813720205649a394f3a9bcb7b38f72eea94 Reviewed-on: https://gerrit.libreoffice.org/56889 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-03tdf#115671 vcl opengl: fix drawing of polylines with duplicate pointsMiklos Vajna
The bugdoc had a custom shape, the interesting part of it was a triangle with miter line join, where the last segment was missing. In that case RenderList::addDrawPolyLine() mishandled the polyline, as it does not expect duplicate points in it. Change-Id: I06d5c2d191bb6269a87da1f006f27a94205f5145 Reviewed-on: https://gerrit.libreoffice.org/56879 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-03UITest_writer_tests: split this into 4 partsMiklos Vajna
Before: make -sr -j2 UITest_writer_tests UITest_writer_tests2 -> 5m9,863s After: make -sr -j4 UITest_writer_tests UITest_writer_tests2 UITest_writer_tests3 UITest_writer_tests4 -> 2m21,734s Again just assuming that each .py file means the same amount of CPU cost (which may not be true exactly). Change-Id: I9c4144c40eb1116d4b999bbba68e2fbef440af7b Reviewed-on: https://gerrit.libreoffice.org/56880 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-03we still need a Archive::Zip test in configure.acRene Engelhard
since system-hsqldb uses it for checking the hsqldb version. This partly reverts 4e3dc8c141c2efd037c1f214b5edff071812b6a8 Change-Id: I60d333d5807404355dd8c8fc2763e76d3a7fa350 Reviewed-on: https://gerrit.libreoffice.org/56888 Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-07-03schema: add some simple things found in ODT exported from crashtestingMichael Stahl
Change-Id: I425eb8595793560e35918c3b17b0c56cfd8ecaf6 Reviewed-on: https://gerrit.libreoffice.org/56867 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-03const fixes for python3-devel-3.7.0-1.fc29.x86_64Stephan Bergmann
Change-Id: Ia16a8b828e11ce36e9bb77ecf9e8a1179bd9b90c Reviewed-on: https://gerrit.libreoffice.org/56841 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-03App icon updateandreas kainz
Change-Id: I3ac392f903644281c6a1ccb9183fbe1c72b78311 Reviewed-on: https://gerrit.libreoffice.org/56847 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-03Resolves: tdf#118221 whole cell kerning default is offEike Rathke
So set that at OutputDevice, there is no cell attribute for kerning, all kerning on is handled by EditEngine output. Change-Id: I23ac2b2cf59f3a4651cc9b614df03860a9cb9146 Reviewed-on: https://gerrit.libreoffice.org/56866 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-07-03schema: add README, as requested by NoelMichael Stahl
Change-Id: If3270ad1d20002dc39a5b4326b0cb42753112e93 Reviewed-on: https://gerrit.libreoffice.org/56868 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-07-03Small cleanup of redundant assert expressionsMike Kaganski
Change-Id: Ia529a6a9cf0ce75c612b8fc0fa1bc7dc8f1c2b5a Reviewed-on: https://gerrit.libreoffice.org/56853 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-07-03Read of uninitialized DrawViewShell::mbMouseButtonDownStephan Bergmann
... (introduced with 6fffd09833a5bd602b0117f48656afd07fd40f41 "tdf#109190 sd: only MakeVisible on mouseclick-up") during CppunitTest_sd_misc_tests, <https://ci.libreoffice.org//job/lo_ubsan/960/console>: > /sd/source/ui/inc/DrawViewShell.hxx:117:50: runtime error: load of value 190, which is not a valid value for type 'bool' > #0 0x2b20592e1a9c in sd::DrawViewShell::IsMouseButtonDown() /sd/source/ui/inc/DrawViewShell.hxx:117:50 > #1 0x2b20594e7c0c in sd::DrawViewShell::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drviewsh.cxx:61:11 > #2 0x2b2059074b41 in sd::DrawView::MakeVisible(tools::Rectangle const&, vcl::Window&) /sd/source/ui/view/drawview.cxx:501:9 > #3 0x2b207669a227 in SdrObjEditView::ImpMakeTextCursorAreaVisible() /svx/source/svdraw/svdedxv.cxx:1959:17 > #4 0x2b20766e4ea4 in SdrObjEditView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdedxv.cxx:2171:13 > #5 0x2b2076396e58 in SdrCreateView::SetAttributes(SfxItemSet const&, bool) /svx/source/svdraw/svdcrtv.cxx:868:16 > #6 0x2b203f8d7b36 in SdrView::SetAttributes(SfxItemSet const&, bool) /include/svx/svdview.hxx:192:81 > #7 0x2b203f8ab5a1 in SdMiscTest::testTdf99396TextEdit() /sd/qa/unit/misc-tests.cxx:215:9 > #8 0x2b203f934ad8 in void std::_Mem_fn_base<void (SdMiscTest::*)(), true>::operator()<, void>(SdMiscTest*) const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:600:11 > #9 0x2b203f9347e3 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::__call<void, , 0ul>(std::tuple<>&&, std::_Index_tuple<0ul>) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1073:11 > #10 0x2b203f9341f1 in void std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)>::operator()<, void>() /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1131:11 > #11 0x2b203f932bc9 in std::_Function_handler<void (), std::_Bind<std::_Mem_fn<void (SdMiscTest::*)()> (SdMiscTest*)> >::_M_invoke(std::_Any_data const&) /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:1871:2 > #12 0x2b203f935550 in std::function<void ()>::operator()() const /home/tdf/lode/opt_private/lib/gcc/x86_64-unknown-linux-gnu/5.2.0/../../../../include/c++/5.2.0/functional:2271:14 > #13 0x2b203f931265 in CppUnit::TestCaller<SdMiscTest>::runTest() /workdir/UnpackedTarball/cppunit/include/cppunit/TestCaller.h:175:7 > #14 0x2b1ff4edce7d in CppUnit::TestCaseMethodFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:32:5 > #15 0x2b20120c14d6 in (anonymous namespace)::Protector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /test/source/vclbootstrapprotector.cxx:48:14 > #16 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #17 0x2b20048ad7a6 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unobootstrapprotector/unobootstrapprotector.cxx:89:12 > #18 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #19 0x2b2000939e13 in (anonymous namespace)::Prot::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /unotest/source/cpp/unoexceptionprotector/unoexceptionprotector.cxx:63:16 > #20 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #21 0x2b1ff4e172df in CppUnit::DefaultProtector::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/DefaultProtector.cpp:15:12 > #22 0x2b1ff4e9b947 in CppUnit::ProtectorChain::ProtectFunctor::operator()() const /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:20:12 > #23 0x2b1ff4e91b70 in CppUnit::ProtectorChain::protect(CppUnit::Functor const&, CppUnit::ProtectorContext const&) /workdir/UnpackedTarball/cppunit/src/cppunit/ProtectorChain.cpp:86:18 > #24 0x2b1ff4f66ccb in CppUnit::TestResult::protect(CppUnit::Functor const&, CppUnit::Test*, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:182:10 > #25 0x2b1ff4ed9efd in CppUnit::TestCase::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestCase.cpp:91:5 > #26 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5 > #27 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #28 0x2b1ff4ee00b3 in CppUnit::TestComposite::doRunChildTests(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:64:5 > #29 0x2b1ff4edf01d in CppUnit::TestComposite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestComposite.cpp:23:3 > #30 0x2b1ff4fa6686 in CppUnit::TestRunner::WrappingSuite::run(CppUnit::TestResult*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:47:5 > #31 0x2b1ff4f64e19 in CppUnit::TestResult::runTest(CppUnit::Test*) /workdir/UnpackedTarball/cppunit/src/cppunit/TestResult.cpp:149:3 > #32 0x2b1ff4fa7b27 in CppUnit::TestRunner::run(CppUnit::TestResult&, std::string const&) /workdir/UnpackedTarball/cppunit/src/cppunit/TestRunner.cpp:96:3 > #33 0x515d6d in (anonymous namespace)::ProtectedFixtureFunctor::run() const /sal/cppunittester/cppunittester.cxx:315:13 > #34 0x51071f in sal_main() /sal/cppunittester/cppunittester.cxx:465:14 > #35 0x50e832 in main /sal/cppunittester/cppunittester.cxx:372:1 > #36 0x2b1ff6bdc444 in __libc_start_main (/lib64/libc.so.6+0x22444) > #37 0x433494 in _start (/workdir/LinkTarget/Executable/cppunittester+0x433494) Change-Id: Idff283298ee2fa11467ff4b8604da642e5a09a8f Reviewed-on: https://gerrit.libreoffice.org/56854 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-03NB writer: add media tab to notebookbar.uiandreas kainz
Change-Id: I83a094b88c3ac31dc200a152e83ad7b8329418ad Reviewed-on: https://gerrit.libreoffice.org/56848 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-07-03tdf#118412: DOC incorrect bottom page marginLuke Deller
Fix a silly typo when determining if the page has a bottom margin Change-Id: I96857951725d00978c43d850d0e1bc64ab61d965 Reviewed-on: https://gerrit.libreoffice.org/56602 Tested-by: Jenkins Reviewed-by: Luke Deller <luke@deller.id.au>
2018-07-03Draw button focus so that it doesn't obscure the actual buttonKatarina Behrens
Change-Id: I0df51b8dfd75dd966639d0893c379f2038c949ff
2018-07-03Use cairo's OVER operator to preserve transparencyKatarina Behrens
Change-Id: I1afae266a5308fa0dbf2488777ddb963e99199c7
2018-07-03Implement native modality for modal dialogsKatarina Behrens
instead of hack with hiding the window and showing it again (otherwise modality change has no effect and worse yet, weird things happen) it would be much easier to use QDialog Change-Id: Ie7029ca66380495c4aad246d02f4b96cb55eb01e
2018-07-03Traversing dialog controls backwards (Shift-Tab) works nowKatarina Behrens
Change-Id: If0e8d7307dd37436751e524d7ed24e89d5b72db3
2018-07-03Ignore closeEvent if user has vetoed closing the frameKatarina Behrens
Change-Id: Ib86ec0d297e23c02ad50ce1044859e029eae2ba9
2018-07-03Rearrange and annotate funcs by XInterfaceKatarina Behrens
Change-Id: Ie429074fdbe8fb4e28b1af47486bc70c5f8070e8
2018-07-03Implement getDirectory, signal+slotKatarina Behrens
also factor some shared code out into separate func Change-Id: I49d25eeb4eb647b72dae78c42301091d198eeff4
2018-07-03Folder picker is now really a folder pickerKatarina Behrens
and not a regular file picker with wrong title Change-Id: I849e7bb3d0cad197880fadd865f4d39f13245e97
2018-07-03Fix initial switch to folder in fileopen dlgKatarina Behrens
the argument passed is an URL, so using setDirectory wouldn't do the trick, setDirectoryUrl would Change-Id: I312f6e2a06b46777dc126f95f63ec0dbcb1f5799
2018-07-03tdf#109190 sd: cancel selecting status on new mousedownJustin Luth
It is possible to cancel a mouse-down without a mouse-up (for example with an ESC button). So, cancel an obsolete "MouseSelecting" on mouse-down. Change-Id: I37d641612cf2cd8099af8f04b12fdb364c4f9e24 Reviewed-on: https://gerrit.libreoffice.org/56857 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-07-03tdf#117757 sfx2 save-as: fix leftover temporary files for embedded objectsMiklos Vajna
This is really similar to c1676204447df942e766c0780c1580e1f0427b73 (tdf#117225 sfx2: fix leftover temp file when saving doc with embedded objects, 2018-05-14), just this is save as, not save. Change-Id: If78d91262bfbe97846287deb0794e4101ef7b4af Reviewed-on: https://gerrit.libreoffice.org/56842 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-07-03sc: Eliminate the case of MAXROWCOUNT_DEFINE <= 65536Takeshi Abe
It is 1024*1024 since b3579d71c6536ab1d03cc47249d582a574fd054a. Change-Id: I7f523f21229de8f4fa378aa85f124863a67b21c8 Reviewed-on: https://gerrit.libreoffice.org/56843 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-03sc: A micro optimization of PERCENTILE() for interpolation casesTakeshi Abe
As the leading std::nth_element() already partitions the vector, all we have to do is to pick the minimum in its latter part. Change-Id: I7767edc538819251c8fe9d26441ae57b06b2f865 Reviewed-on: https://gerrit.libreoffice.org/55575 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-07-03ScFormEditData copy functions can be deletedStephan Bergmann
Change-Id: Id6aad74198da68aa6475bcd3b17c993a51ccabe9 Reviewed-on: https://gerrit.libreoffice.org/56846 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-03ScAsciiOptions copy assignment op can be left implicitly definedStephan Bergmann
...which removes a -Wdeprecated-copy (because the copy ctor is already not user- declared) with GCC trunk towards GCC 9 (and makes SetColInfo unused). Curiously, the user-provided copy assignment op didn't copy the eLang member, but assume that was by accident rather than on purpose. Change-Id: I3116500b748f0625acf1368d0106ade94f0dfa26 Reviewed-on: https://gerrit.libreoffice.org/56845 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-07-03no need to switch models in the SvTreeListBoxNoel Grandin
since we're replacing it completely anyhow. which means we can remove DisconnectFromModel Change-Id: I2f31d93eb95a641f3364d715111e70817c7e5087 Reviewed-on: https://gerrit.libreoffice.org/56849 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03tdf#118452 Don't crash when multi thread calculation is disabledGabor Kelemen
...by default configuration. Change-Id: If6075ae66537f613434dd38766324436f2426517 Reviewed-on: https://gerrit.libreoffice.org/56840 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-07-03Removed executable permission on pptx filesAndrea Gelmini
Change-Id: I4c7cc0f462fdd3ee2d2b44bc73f0313e6cd4176a Reviewed-on: https://gerrit.libreoffice.org/56423 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-03Fix typosAndrea Gelmini
Change-Id: Ieacea4f6f53a0e55876a8b84d0dfeea8e308035d Reviewed-on: https://gerrit.libreoffice.org/56712 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-03Fix typoAndrea Gelmini
Change-Id: I8f2692a7f917b53c28783599b589fd0a39e3b880 Reviewed-on: https://gerrit.libreoffice.org/56835 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-07-03use std::unique_ptr for CreateObjectSpecificViewContactNoel Grandin
Change-Id: I0fed54d345a43fe0bc21ebbe424e6fdc7eac9523 Reviewed-on: https://gerrit.libreoffice.org/56823 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03loplugin:useuniqueptr in SwDropPortionPartNoel Grandin
Change-Id: I9aaaeb2b5cb05d350059554555ecb0c195c51a74 Reviewed-on: https://gerrit.libreoffice.org/56830 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03loplugin:useuniqueptr in ScHeaderFooterTextDataNoel Grandin
Change-Id: Ia359ee8e9e4876f6bbf86702c476c9f9602295a0 Reviewed-on: https://gerrit.libreoffice.org/56832 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03loplugin:useuniqueptr in SwWrongListNoel Grandin
and simplify, just use copy constructors and operator=, instead of special-case CopyFrom methods Change-Id: I3e14fa08e820cf7ae2c5424ae22ae95516933773 Reviewed-on: https://gerrit.libreoffice.org/56831 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03loplugin:useuniqueptr in SwGrfNumPortionNoel Grandin
Change-Id: I87f60bc3b6dc11246202801f39cbc7cf464e1890 Reviewed-on: https://gerrit.libreoffice.org/56829 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03loplugin:useuniqueptr in SwLayActionNoel Grandin
Change-Id: I0552a113a3eaf1265e65d32b2b04cc768571d9ff Reviewed-on: https://gerrit.libreoffice.org/56827 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03loplugin:useuniqueptr in ScFunctionAccessNoel Grandin
Change-Id: I678bfbc54a1c35540bb7f2b76f4f7e5c7c62b23c Reviewed-on: https://gerrit.libreoffice.org/56826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03loplugin:useuniqueptr in ScHeaderFieldsObjNoel Grandin
Change-Id: Ibf9251880e658605e83179c9de7ac2104d2c1c14 Reviewed-on: https://gerrit.libreoffice.org/56825 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03return by std::unique_ptr from CreateViewDataNoel Grandin
Change-Id: I83572646fb2ebe8afe8cff581e574375798e74f7 Reviewed-on: https://gerrit.libreoffice.org/56818 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-07-03move SvTreeList::*Sibling to SvTreeListEntryNoel Grandin
since they don't depend on SvTreeList at all Change-Id: If48c83976a95943e5cfa92490d68f74281cf4b5f Reviewed-on: https://gerrit.libreoffice.org/56819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>