summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-03-11V668 no sense in testing the result of new against nullCaolán McNamara
Change-Id: I4a33bd92fc8448638a4bfe1eab7e5041a4c5cc39
2015-03-11Ensure RTTI symbol visibility for Linux Clang -fsanitize=function,vptrStephan Bergmann
The problem being that any lib later loaded via osl_loadModule (e.g., libgcc3_uno.so) would not bind to the same global (RTTI-related) symbols as libsofficeapp.so and its dependencies (so, e.g., -fsanitize=function would erroneously assume that bridges/source/cpp_uno/shared/component.cxx's uno_initEnvironment is called with a different, non-matching uno_Environment type). Change-Id: I08b0cbc1f9eb74641eb617c46587a0a528a56c31
2015-03-11Use osl/thread.h abstractionStephan Bergmann
...which already takes care of things like increasing stack size under ASan Change-Id: I89f9a25a660aacd41e1125766b23f7be395e7af8
2015-03-11Fix copy/paste errorStephan Bergmann
Change-Id: I3fd9d6447adfa365a823ca6e87f0939670bcb39b
2015-03-11convert CHILD_ constants to enum classNoel Grandin
Change-Id: I1aca134fcc0384df4797cacafa9fbc1ed88d6617
2015-03-11convert tExternalDataType to enum classNoel Grandin
Change-Id: I3cf5670e8cc616e4284c5f4865d244ee4db2c628
2015-03-11convert SfxDockingConfig to enum classNoel Grandin
Change-Id: I2cfc9f2f165f970daa2dc42ec4d733dde968b55a
2015-03-11convert SfxChildIdentifier to enum classNoel Grandin
Change-Id: I7fb7b76d0642653efb9f3cfe2b55e3a7c5972c5e
2015-03-11convert SwMoveFlags and SwInsertFlags from enum to enum classNoel Grandin
Change-Id: I067656a47845c5d3fa143ce400b4ef0f8bf9ac5f
2015-03-11convert SetAttrMode to enum classNoel Grandin
Change-Id: If7dd0c49480756afb7d4eaaba597ecc305c35f64
2015-03-11SfxItemHandle is only used in one place, so inline itNoel Grandin
Change-Id: Ie54e0699312b6c072d2b162a068cffdf960be4d0
2015-03-11DocxAttribouteOutput::m_pHyperlinkAttrList: use unique_ptrMiklos Vajna
Change-Id: I7da23e7b7d35f2cf46c7dfbc8f251da2205925bb
2015-03-11const_cast -> mutableZolnai Tamás
Change-Id: Idedcb4a9add451fbdf39cad1429669a12b8c11b9
2015-03-11Make "Embedded Objects" frame expendable to fill space betterZolnai Tamás
Change-Id: I9b9335464c774bca13013576583877895d673592
2015-03-11Avoid casting SvxBrushItem:nShadingValueZolnai Tamás
Change-Id: Ida97950286bc69154d10cbc9b5ac699e7ad608ad
2015-03-11V668 no sense in testing the result of new against nullCaolán McNamara
Change-Id: I7783d96e40de7a8df794f143d2c7830bf3314218
2015-03-11slightly odd stuff hereCaolán McNamara
Change-Id: I715d49722ebe4658c108cb9b7bd6fa3934d973f8
2015-03-11tdf#89867: editeng: fix crash on shutdown after changing AutoCorrect optionsMichael Stahl
Since commit 5bff4b016c4b44f4123e0e6a4fd4c0c4dc0cfa2d the SvxAutoCorrCfg::pAutoCorrect is cleared by one terminate() listener but then another terminate() listener calls Commit() on all modified utl::ConfigItem and these two have a Commit() that does not clear the modified flag so they are always modified. Sadly there's no non-virtual Commit() wrapper that calls ClearModified() on the base class... Change-Id: I9ae220d78bb109c7bf0fdc544754a0686b357115
2015-03-11i18npool: fix spurious regex ^ matching in TextSearch::searchForward()Michael Stahl
Thanks to Eike for finding this: The anchors ^ and $ now anchor at the selection boundary because the only text the regex matcher gets passed is the selected text. This in two paragraphs aaa bbb aaa bbb aaa bbb aaa bbb when the selection spans from the second aaa to the third bbb, for "^aaa" finds the second aaa, where previously it found the third aaa at the real paragraph start. This may not be expected by the user, because the behavior of ^ is described as "Match at the beginning of a line" (or paragraph in our case), which the previous implementation did. (regression from 806ced87cfe3da72df0d8e4faf5b82535fc7d1b7) Unfortunately it's not obvious how to implement the same in searchBackward(). Change-Id: I07f7a8476b672d9511fa74ca473c32eea427698f
2015-03-11sw: s/eEnde/eEnd/Michael Stahl
Change-Id: I9ea963d09c2975b8e40856e3ba2d3896be9a1876
2015-03-10virtual ScTableRefToken::SetIndex(); of course..Eike Rathke
Change-Id: I4a43ea664e9db2bb44e0e7f089a71abf6f572b1e
2015-03-10replace an OSL_ENSURE() with assert(), tdf#89319 relatedEike Rathke
Commit 8e2293e06adba3f22e824acad99983fb5b997e4d changed STREAM_SEEK_TO_END logic, ensure that in a dbgutil build we catch unnoticed corner cases with assert() instead of just another fly-by warning. Change-Id: If6c4fb4d2467f7dc7b8177caf7353d0b0e56ed0d
2015-03-10Fix CppunitTest_libreofficekit_tiledrendering dependenciesStephan Bergmann
Remove the unnecessary ones, but make sure that e.g. the sofficeapp library is built (which was not covered by depending on services.rdb). Change-Id: I1adfa4aaaf60787c944d71cc289cdafba8351c1b
2015-03-10libGLU actually is not required anymore for masterChristian Lohmaier
Change-Id: I543a561fc7fa1213c8e319f227b761f6328a6eaa
2015-03-10V668 no sense in testing the result of new against nullCaolán McNamara
Change-Id: I1cff71d15f4d1b5ee47cc734b3fc2168d7f99201
2015-03-10tdf#53861 - add libGLU.so.1 and libXinerama.so.1 to rpm/deb requirementsChristian Lohmaier
only used for upstream packages/when epm is used (any auto-dependency creation is disabled for those). Add two that might be missing in barebone installations Change-Id: I97c3af8cc8622c63ac831701e509097711822098
2015-03-10Avoid undef use of null ptr, use offsetof insteadStephan Bergmann
Change-Id: I47b1d8e7b119e50406b50f580ee06f9f1b5f8401
2015-03-10Spare extra call stackTakeshi Abe
This also drops an unnecessary lock. Change-Id: Ia5eb459adf3cb585aa2484866670949120315780 Reviewed-on: https://gerrit.libreoffice.org/14765 Tested-by: Michael Stahl <mstahl@redhat.com> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-03-10Fix signature overflow check in the NSS caseTor Lillqvist
We didn't actually check this correctly at all, but gladly overwrote the allocated part of the output PDF, thus obviously rendering it invalid. The parameter passed to PORT_NewArea is a default chunk size, not a maximum anything, so it was misleading, even if not wrong as such, to pass MAX_SIGNATURE_CONTENT_LENGTH to it. Use 10000 instead. No need to do the overflow check twice in the Win32 case. Change-Id: Ifa796dbb74b32e857f7184c1e8ada97ba124b020
2015-03-10Idle/Timer: reverted idle to timerTobias Madl
This task waits for user io. Change-Id: Id5b3725b316f1bbd73e94d5368bc0d5c7d057189
2015-03-10make SvpSalGraphics::getBitmap more readableCaolán McNamara
Change-Id: I4eb896813d6cec49bf5f1c8ac2ee8fafc06fbf52
2015-03-10I don't think we should clip when using getBitmapCaolán McNamara
this solves the bug of icons in the standard toolbar under gtk3 of getting rendered with a black background on first render Change-Id: I73bae4cd0b9f38c9e9caef8019d773d42b5e8f10
2015-03-10Avoid calls on null mpSalTimer on OS XStephan Bergmann
all three addressed places hit frequently now during "make check", likely related to recent changes to timer/idle code? Change-Id: I75963c707807c29db7865b11f9ed532b779765d8
2015-03-10Replace boost::noncopyable with use of SAL_DELETED_FUNCTIONTakeshi Abe
Change-Id: Id657299322ddefb095a2f192df818a873498e411 Reviewed-on: https://gerrit.libreoffice.org/14825 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2015-03-10external/poppler: Work around -fsanitize=shiftStephan Bergmann
Change-Id: I5d9734f302ff58637f69c1574bc39ca85ff992e7
2015-03-10avmedia: avoid passing an empty any to InitPropertySequence()Miklos Vajna
Regression from b1534edf523a405b91ad04c5351735e745ceb7ee (tdf#89592 Using initializer_lists to populate Sequence<PropertyValue>, 2015-03-07). Additionally, avoid makeAny() on the Any, the original code didn't do that. Thanks to lgodard/sberg for noticing these. Change-Id: Icb3a6039885c582ba9f789c5c4768b865b593aee
2015-03-10V668 no sense in testing the result of new against nullCaolán McNamara
Change-Id: I85993df91bd14966f9175c356966fbd8eb1a927d
2015-03-10Missing dependencyStephan Bergmann
since 44337a1fdae8cdc68b6cf539166e60feea879a9b "Unit tests for PDF import" Change-Id: I6c7746814af669dd0eb45b1013577cacc109a014
2015-03-10tdf#89592 Using initializer_lists to populate Sequence<PropertyValue>Swachhand Lokhande
Change-Id: Idef9dd55eb1719eaf592bc4a86440cbd5aa4fb32 Reviewed-on: https://gerrit.libreoffice.org/14781 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2015-03-10Add unit test for bb0c05cebed131805d04919fac2b83030087451bTor Lillqvist
Change-Id: I2b21a488a7f597603b65fac0ff3c6b05c3660994
2015-03-10Revert "Ifdef out testSharedFormulaXLS() for now, fails for me with ..."Tor Lillqvist
"... OpenCL on CPU" I can't reproduce the problem any more. It was likely fixed by fa4ce83f567cfb735bdfd2319458585ded4cd554. This reverts commit 219f2dc83f40afb7470bffc307371925e8fae018. Change-Id: Ib6d3a42137bcf21b0edec2173cf483ade6104b0b
2015-03-10sigh, collisionCaolán McNamara
Change-Id: I2d56b0ddf0b7e076ea570879b0ab33390306f3b2
2015-03-10fix windows buildCaolán McNamara
Change-Id: If7351b2fb37b68ea2838cf442ca440a01587d66a
2015-03-10DocxAttributeOutput::m_pParagraphSpacingAttrList: use unique_ptrMiklos Vajna
Change-Id: I4d8d0ee853e93c8620295e0598de358e66b4f730
2015-03-10attempt to fix windows buildNoel Grandin
after commit 924b2923b8b1515a4c37079e72a2a9cc6010a4f4 "V801: Decreased performance" Change-Id: I32af1195f6e7e1fc4b94487bfbfab669bcad3951
2015-03-10Scheduler: replaced max cast with SAL_MAX_UINT64Tobias Madl
Change-Id: I9e8d5863c31187b373ff93d5a6e992a1281220b4
2015-03-10loplugin:passstuffbyrefStephan Bergmann
Change-Id: Ic45e42d5ce7e0509cd2afc8be018f78cd6083aae
2015-03-10Fix issue in re-use of ScTokenArray objects from a TokenPoolTor Lillqvist
The TokenPool::operator[] is used to initialise and take into use an object from the pool. Which is a fascinating thing as such and probably not entirely in good style. Anyway, the objects in the pool are of type ScTokenArray, a class derived from FormulaTokenArray. The operator[] called the FormulaTokenArray::Clear() function to initialise the object. This left the fields added in ScTokenArray uninitialised, having whatever value the previous use of the object had set. Which of course is bad. In practice, this showed up in the handling of formulas in the .xls input filter. If an earlier (or the first?) formula had happened to be one for which we don't want to use OpenCL, the meVectorState of its ScTokenArray object in the pool had been set to FormulaVectorDisabled. When the same pool object was later re-used for another formula, it kept that same meVectorState, even if there was no reason to. Thus formula groups that should have been OpenCL accelerated weren't. This can have a significant impact on performance of document loading and recalculation for large documents. I added a function to ScTokenArray to clear (initialise) such an object, both the FormulaTokenArray part and the ScTokenArray-specific part, and call that instead. This fixes the issue. I named the added function ClearScTokenArray() to make it clear that it is a separate function. Sure, possibly Clear() should be made into a virtual of FormulaTokenArry and overridden in ScTokenArray, and the overriding Clear() would first call the base class's Clear(). But I can't be sure that there aren't other calls of FormulaTokenArray::Clear() that *must* mean the base class one. Better safe than sorry. And of course, I did *not* want to name the function in ScTokenArray also "Clear()", like in the base class, without it being virtual. That is horrible style in my opinion, even if there certainly is precedence for such even in the very same classes, i.e. the Clone() function... Change-Id: I0e0e13e5ca705603005a1e0a46866f095cd2ac4d
2015-03-10Also relative row references need to wrap around, like fdo#84556 for columnsTor Lillqvist
Change-Id: I07400d6dead66ec437436b5ea8b49491f8048335
2015-03-10GridWindow: change pNoteMarker to unique_ptrTomaž Vajngerl
Change-Id: I1e141632172f53ddbd2f5f434206646c9a1e9cf0
generated by cgit (git 2.34.1) at 2024-08-19 02:23:39 +0000