summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-06-26fix typoCaolán McNamara
Change-Id: I0ebf8dd5a4e5f55504b9dd9a9ef8b966e497cd41 Reviewed-on: https://gerrit.libreoffice.org/74721 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-26tdf#50530 Make text edit outliner view show cursorJim Raykowski
Change-Id: I73b4dcacdf068daff02b8fe8156c58debfcdf704 Reviewed-on: https://gerrit.libreoffice.org/74613 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-06-26NB impress tabbed compact add context-multi and 3d stuffandreas kainz
Change-Id: I4356863ea9b0fff4187e8234fdadb980d416bc71 Reviewed-on: https://gerrit.libreoffice.org/74722 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-25Simplify Sequence iterations in unoxmlArkadiy Illarionov
Use range-based loops or replace with STL functions Change-Id: Ib1c49834a2c5c67a73ec05ba8f30c1d39a5c019c Reviewed-on: https://gerrit.libreoffice.org/74600 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-06-25Simplify Sequence iterations in uuiArkadiy Illarionov
Use range-based loops or replace with STL functions Change-Id: I36ca6016d23360d121935d9f25e8cc8d2dad08c3 Reviewed-on: https://gerrit.libreoffice.org/74625 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-06-25use common WeldEditViewCaolán McNamara
Change-Id: I873cb64a167027030c9eeef61344e6f6f885a924 Reviewed-on: https://gerrit.libreoffice.org/74705 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-25Initialize the font list before querying itJan-Marek Glogowski
And the vcl_fontmetric test must depend on more_fonts. This way there should never be a missing font, so just assert on it. Change-Id: If3b71d7c3e52f1beeda73197c56f5efc6a83dbb4 Reviewed-on: https://gerrit.libreoffice.org/74717 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-25help compilerplugins generator find clang shared libs, if neededLuboš Luňák
Change-Id: I892aa42bc1e94823ab52cdfd6a855bf90106306d Reviewed-on: https://gerrit.libreoffice.org/74681 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-06-25try to find out CLANGDIR automaticallyLuboš Luňák
Change-Id: I21fbcdc947c9ce5d99b14c1aba8fb4e1fb2d9c00 Reviewed-on: https://gerrit.libreoffice.org/74680 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-06-25do not use -g unconditionally for building the clang pluginLuboš Luňák
The generated files are ~700MiB here, compared to ~85MiB without. Change-Id: I76bafc59ff89fd7eb8ffbc4b9ad79bc63da8f064 Reviewed-on: https://gerrit.libreoffice.org/74678 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-06-25tdf#126017 sw: do not restore SwFormatContent in SwUndoFormatAttrMichael Stahl
This is a very unusual item that only contains a SwNodeIndex, which may "go stale" because the node it's pointing to may be deleted, moving it to whatever node may be next. Restoring such a moved item causes crashes like this, where the SwSectionFormat's item does not point to its SwSectionNode. (crash is a regression from 4f0b568ef35353b276ae560fb43502b6f6b2bfdb, previously the Undo stack was cleared so you couldn't Undo) Change-Id: I41a9ed9acc72df5b4b3852875a50e51c29eabe95 Reviewed-on: https://gerrit.libreoffice.org/74693 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-06-25tdf#126054 uses after free when menubutton and menu torn down during executionCaolán McNamara
Change-Id: Ib79da121941863421bc12afa27e27cdd7e2e81e3 Reviewed-on: https://gerrit.libreoffice.org/74695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-25factor out to a common WeldEditViewCaolán McNamara
Change-Id: Ife7b6f57c80d310bd11a8ed89e36fdc99742d158 Reviewed-on: https://gerrit.libreoffice.org/74698 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-25tdf#120873 Qt5 invert checked state on triggerJan-Marek Glogowski
SalMenu's event handling is not really compatible with QAction. LO expects to get something like an activate event, which happens without any menu state update. The item handler will then update the item state, as expected by LO. I'm not sure how this could be implemented in a good way in Qt, so this patch is just a hack. If the item is checkable, we invert its state before handling it. This just works correctly for single items, not radio groups, but it does the trick for this bug. And since setChecked() just emits toggled(), triggered() won't run twice. Maybe someone can come up with a better way using event filters, if ever needed. Change-Id: Ic32d07525ce8f394b83d04f53689d1669ddc9d83 Reviewed-on: https://gerrit.libreoffice.org/74590 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-06-25uitest Tweak calc RowHeight test - add cancel button pressZdeněk Crhonek
Change-Id: I95a9a150a4c3a8a6e890305f95807bde7b6568da Reviewed-on: https://gerrit.libreoffice.org/74654 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-06-25loplugin: simplifyconstructCaolán McNamara
Change-Id: I57b667384813b0f6d8412da17c83877a9deed5b1
2019-06-25SmartArt: move setting shape aspect ratio to alg atom visitGrzegorz Araminowicz
it allows to correctly follow if/else nodes instead of using once assigned alg atom Change-Id: I8c321b638524df3ca68242da6300bc8c2a838bbf Reviewed-on: https://gerrit.libreoffice.org/74648 Tested-by: Jenkins Reviewed-by: Grzegorz Araminowicz <grzegorz.araminowicz@collabora.com>
2019-06-25tdf#125892 improve time to export PDF, use int ops for scalingNoel Grandin
The time here is all in the nice rescaling we do these days. Speed it up by using int ops instead of float ops. This takes the time from 5m to 1m30 for me. Change-Id: Ic1dcd9e49eef1894f4a4fdb416015b69c6ef96da Reviewed-on: https://gerrit.libreoffice.org/74689 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-25improve loplugin:simplifyconstructNoel Grandin
Change-Id: If863d28c6db470faa0d22273020888d4219e069e Reviewed-on: https://gerrit.libreoffice.org/74559 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-25weld HyperLink DialogCaolán McNamara
Change-Id: Ic861b0a593505828a900fe2163125d6f5584a956 Reviewed-on: https://gerrit.libreoffice.org/74634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-06-25remove Fraction pretty-printerNoel Grandin
no longer necessary after commit 31589bf0239679d73417902655045c48c4868016 Date: Mon Jun 24 15:02:55 2019 +0200 tdf#94677 Calc is slow opening large CSV, improve tools::Fraction Change-Id: I1c9ee043a51216f7005bf8a4bf60bb4b4e39ab61
2019-06-25tdf#94677 Calc is slow opening large CSV, improve tools::FractionNoel Grandin
Flatten the tools::Fraction class. Shaves 1s off a load time of 49s Change-Id: I7cbee9892831a1e47704a283351fa97eda262343 Reviewed-on: https://gerrit.libreoffice.org/74639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-25Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
Change-Id: Ied8f181e3fa2411a7203043f2dab786338ae6619 Reviewed-on: https://gerrit.libreoffice.org/74684 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-25tdf#94677 Calc is slow opening large CSV, avoid std::shared_ptrNoel Grandin
Shaves 2s off a load time of 48s Change-Id: I616d8b4280bee64e7c25eda8523a13cb80b121ad Reviewed-on: https://gerrit.libreoffice.org/74640 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-25tdf#94677 Calc is slow opening large CSV, avoid reset SetUpdateModeNoel Grandin
Avoid resetting SetUpdateMode in CreateFieldEditEngine while calculating row height. This takes the time from 1m25 to 49s for me. Change-Id: If406eac1a8b031f1734d9c2376c413dfa22d89f8 Reviewed-on: https://gerrit.libreoffice.org/74630 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-25Fix typoAndrea Gelmini
Change-Id: I3a7d636d822f8f3e51c91ada359c4ef47bce763c Reviewed-on: https://gerrit.libreoffice.org/74667 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Fix typoAndrea Gelmini
Change-Id: I0b1e92daa83d1bc5aadeb70a730521198571a5d8 Reviewed-on: https://gerrit.libreoffice.org/74663 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Fix typoAndrea Gelmini
Change-Id: I3e78077d6a86537020798adb90fee2d45a844325 Reviewed-on: https://gerrit.libreoffice.org/74662 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Fix typoAndrea Gelmini
Change-Id: I0efc8f2d50e825878bc41d7eca055095a9308fce Reviewed-on: https://gerrit.libreoffice.org/74669 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Fix typoAndrea Gelmini
Change-Id: I26015136d5c5bbfae9cf2d61d7db1f23f960d78a Reviewed-on: https://gerrit.libreoffice.org/74666 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Fix typoAndrea Gelmini
Change-Id: I5d9b5f8990b81a50684cebeb726f61115133f053 Reviewed-on: https://gerrit.libreoffice.org/74674 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Fix typoAndrea Gelmini
Change-Id: I07f236ce2f90d05d971f8cf208a4cc62062b8a54 Reviewed-on: https://gerrit.libreoffice.org/74670 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Fix typoAndrea Gelmini
Change-Id: I553f11391c22c8b9089903c6c55ffc569f7ff553 Reviewed-on: https://gerrit.libreoffice.org/74671 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Fix typoAndrea Gelmini
Change-Id: I8e38025a07db839cf36e606186fb255e2c26e168 Reviewed-on: https://gerrit.libreoffice.org/74673 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Fix typoAndrea Gelmini
Change-Id: Ib844eafd0c717c2c3c65d3a0428eccb5e42f912d Reviewed-on: https://gerrit.libreoffice.org/74668 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Fix typoAndrea Gelmini
Change-Id: Ib6a89a7362a63eff8ecbf59653126cf324b5bbf9 Reviewed-on: https://gerrit.libreoffice.org/74672 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Fix typoAndrea Gelmini
Change-Id: I8a50c7c40c1d90fec25ec6ecd73d4aeb4da0fd9e Reviewed-on: https://gerrit.libreoffice.org/74665 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-06-25Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Remove duplicated HID bookmarks in shared Also remove a few obsolete bookmarks and fix ahelps Duplicates found with: for i in $(find source/text/shared -name "*xhp") ; do grep branch=\"hid/.uno: "$i" | cut -d ":" -f2 | cut -d \" -f 1 | uniq -c | grep -v "1 " ; if [ $? -eq 0 ] ; then echo "Above HID branches are redundant in: $i" ; fi done Change-Id: Ie7cde338aa210ef81d1e15ecc8087d8f67f77b27 Reviewed-on: https://gerrit.libreoffice.org/74655 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-25Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Remove duplicated HID bookmarks in scalc Also remove a few obsolete bookmarks and fix ahelps Duplicates found with: for i in $(find source/text/scalc -name "*xhp") ; do grep branch=\"hid/.uno: "$i" | cut -d ":" -f2 | cut -d \" -f 1 | uniq -c | grep -v "1 " ; if [ $? -eq 0 ] ; then echo "Above HID branches are redundant in: $i" ; fi done Change-Id: I5a6a817065257ebffe7d0ed88f37c67ede86fb41 Reviewed-on: https://gerrit.libreoffice.org/74656 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-25Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Remove duplicated HID bookmarks in simpress Also remove a few obsolete bookmarks and fix ahelps Duplicates found with: for i in $(find source/text/simpress -name "*xhp") ; do grep branch=\"hid/.uno: "$i" | cut -d ":" -f2 | cut -d \" -f 1 | uniq -c | grep -v "1 " ; if [ $? -eq 0 ] ; then echo "Above HID branches are redundant in: $i" ; fi done Change-Id: Id8811f2f1ecee89ddc9b86b57ef6b04e40b25d28 Reviewed-on: https://gerrit.libreoffice.org/74657 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-25Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Remove duplicated HID bookmarks in swriter Also remove a few obsolete bookmarks and fix ahelps Duplicates found with: for i in $(find source/text/swriter -name "*xhp") ; do grep branch=\"hid/.uno: "$i" | cut -d ":" -f2 | cut -d \" -f 1 | uniq -c | grep -v "1 " ; if [ $? -eq 0 ] ; then echo "Above HID branches are redundant in: $i" ; fi done Change-Id: I39c9eed29db7612e2000912112f1629e20fd5774 Reviewed-on: https://gerrit.libreoffice.org/74658 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-25NB impress add tabbed compact layoutandreas kainz
Change-Id: Ia1aab531967644ac6f7cd21210a87a30082de42a Reviewed-on: https://gerrit.libreoffice.org/74660 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-06-24Colibre: Fix for tdf#122924, tdf#126044rizmut
- Clean unecessary extra outline - Update Gallery, Paste, EPUB, language - Sync extra large AutoFormat - Update table formula in Writer's Navigator - Update DB Form, Query, Report, Table - Update Draw/Impress master, Handout, Outline, Notes, Master Notes Change-Id: I1faabab504010c584f7a480ed6c521c47584df38 Writer: Re-enable some icons in menubar Reviewed-on: https://gerrit.libreoffice.org/74591 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-06-24tdf#89709 Make statusbar page number/bookmarks control tool tip showJim Raykowski
Change-Id: I6e78d144971d59f9c8c9706f9ce8f45b9492a5c4 Reviewed-on: https://gerrit.libreoffice.org/72715 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-06-24tdf#119571 fix style & numbering at tracked deletionLászló Németh
and direct paragraph formattings after partially deleted paragraphs. Clean-up and extension of the previous workaround, now with Undo. See also commit b69c518df68ce673b28d589da6626bd3d860f309 "tdf#54819 keep style & numbering at tracked deletion". Change-Id: Icc4d21e3fd0496442329c65e379522f4b7fdc6b4 Reviewed-on: https://gerrit.libreoffice.org/74633 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-06-24Drop sw::GetSupportedServiceNamesImplArkadiy Illarionov
Use braced initializer lists and std::transform. Change-Id: I5d1a57d766e39663a55f4921f486210d41fa917d Reviewed-on: https://gerrit.libreoffice.org/74588 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-06-24Don't prematurely convert nEscapement from double to sal_Int16Stephan Bergmann
...before it is clamped to -MAX_ESC_POS..MAX_ESC_POS, anyway. That avoids some -fsanitize=float-cast-overflow > writerfilter/source/dmapper/DomainMapper.cxx:2833:39: runtime error: -327680 is outside the range of representable values of type 'short' when loading caolan/swfntobj_drawtext_heap_buffer_overflow.sample (from the crashtestdata files). Change-Id: I42c23fe30723280410f3afc0ecbe40f1f31b7f96 Reviewed-on: https://gerrit.libreoffice.org/74645 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-06-24tdf#109158 slow AutoCorrect table, speedup switching away from languageNoel Grandin
Switching from the large table to another language could result in freezing up for some time, so use the nice weld::TreeIter API here too Change-Id: I28f422dcdbc762b282ed6bd1dffc8140ee77900f Reviewed-on: https://gerrit.libreoffice.org/74646 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-06-24Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Some examples of Basic macros Change-Id: I20f0693dfb1e965f50be875565d505021bcb9d4a Reviewed-on: https://gerrit.libreoffice.org/73861 Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-06-24Don't convert from double to sal_Int32 when target is longStephan Bergmann
...which avoids, at least for platforms where long is larger than sal_Int32, some -fsanitize=float-cast-overflow when loading caolan/sw_ww8graf_mungetextintodrawbox_null_ptr_deref.sample (from the crashtestdata files), which reads huge (crafted?) values for some of l, o, r, u. (The casts to sal_Int32 had been there ever since at least d2000efb31f864e912c6cf52760eea0e602b6893 "#i106421#: move msfilter to filter", but there appears to be no good reason for that.) Change-Id: I1c8a874af6f0a0db7707612fe22bf06dfe832877 Reviewed-on: https://gerrit.libreoffice.org/74638 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>