summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-05-30loplugin:unusedmethodsNoel Grandin
Change-Id: I08e9bb65b2530148b80c67f01d51e594fc698acb Reviewed-on: https://gerrit.libreoffice.org/25543 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30loplugin:unusedmethods SfxLinkUndoActionNoel Grandin
Change-Id: I1ad7c2452dd9bc80e7404f41484b9667adbcfa7b Reviewed-on: https://gerrit.libreoffice.org/25542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-30tdf#99870 writer: don't delete selection with delete-commentJustin Luth
When using the keyboard to select text and then deleting a comment, all the text between the cursor and the comment would also be deleted. (Not necessarily the selected text, but everything from the point or the mark would be included in the delete.) Change-Id: Id15a00d112d118227bc4a34b5102bb09d8d167b0 Reviewed-on: https://gerrit.libreoffice.org/25216 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-30starmath: Drop redundant IsFormulaArranged() checkTakeshi Abe
as ArrangeFormula() itself checks bIsFormulaArranged, and does nothing if it's on. Change-Id: Icc76208f6881d4de99e88feae5f19d7e8890e4e9 Reviewed-on: https://gerrit.libreoffice.org/25570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-30cid#1362174, 1362177: USE_AFTER_FREE+resource leak due to copypastaJulien Nabet
Change-Id: Icd903335fdef3921781e2f16e98a0e10bda31e3f Reviewed-on: https://gerrit.libreoffice.org/25641 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-29coverity#1362173 Dereference after null checkCaolán McNamara
Change-Id: I75c6f6fba947ac56c198afdef9b5ad078a76cdc5
2016-05-29coverity#1362175 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ia2da9cc6a2e2f6c5f3f85c2ad3d95fb1adad6225
2016-05-29coverity#1362019 Uninitialized scalar variableCaolán McNamara
Change-Id: I18d913fc6e0131f0c31c9d0cfe0f39e1161035eb
2016-05-29loplugin:unreffunStephan Bergmann
Change-Id: I31e62926ddfddc8bbdab681a55cdc381d3275794
2016-05-29Resolves: tdf#97839 a single character may be more than 1 utf-16 code pointsCaolán McNamara
Change-Id: Iba2460bfb9335615796db3f5e233b870a8d63339
2016-05-29loplugin:simplifyboolStephan Bergmann
Change-Id: I4a07ec3eb9ab3d01c6104346a9bd9654bdcb1efe
2016-05-29tdf#100115: _nColId is sal_uInt16Julien Nabet
like the other methods, so fix it in canCopyCellText + copyCellText Change-Id: I3395f8823602f0a1791908945e3dec5034d3d612 Reviewed-on: https://gerrit.libreoffice.org/25605 Tested-by: Lionel Elie Mamane <lionel@mamane.lu> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-05-29add DAYS360 test caseZdeněk Crhonek
Change-Id: If670fcbf870d96e2328c02bc0f42beb5cd8e60ff Reviewed-on: https://gerrit.libreoffice.org/25583 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-29tdf#100080 set unused shader attribs with values, fixes GL on AMDTomaž Vajngerl
AMD drivers don't work well if a shader has a defined but not enabled shader attributes. For this reason we need to make sure that all attributes are set to some value even if the shader doesn't use that attribute. Intel drivers, on the other hand, crash if you enable an attribute and don't set it (set it to null) - so we can't use this workaround. Change-Id: Ic076cf8a5fac8ef048d0054e6e4340b47b4d5188 Reviewed-on: https://gerrit.libreoffice.org/25591 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2016-05-29bccu#1851 - CTRL+A in Writer comments shows selection at top-left cornerAshod Nakashian
Change-Id: Ia87b86a45a38449d59eb7bcea7f8cb4068655a17 Reviewed-on: https://gerrit.libreoffice.org/25571 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit b736ea1b02346ba190f280f254714bb6e1983858) Reviewed-on: https://gerrit.libreoffice.org/25572 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-29bccu#1843 - Calc copy/paste chart tile invalidation problemAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/25489 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 28795d0faabd1e1be124fa90bef06d7f47a63311) Change-Id: I2f0bf28e87f4188abd81eb6c42bae915b2a046a8 Reviewed-on: https://gerrit.libreoffice.org/25490 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2016-05-29bccu#1781: Impress/Comments - selection not updated on deleteAshod Nakashian
Change-Id: I694d76785fcf6ec9c158c34cbe07f4d1f2c7a41d Reviewed-on: https://gerrit.libreoffice.org/25219 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit b95e4e8681c9cefb4e1d4177192164e041baf9d9) Reviewed-on: https://gerrit.libreoffice.org/25428 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28LOK: don't filter cursor visibility during paintingAshod Nakashian
Change-Id: Ia44ffe08dc8f46e0d10a73db374a283eb032f771 Reviewed-on: https://gerrit.libreoffice.org/25120 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit f805637353e4463d5b64f1b010bb580e191bd3aa) Reviewed-on: https://gerrit.libreoffice.org/25427 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28LOK: ensure KeyInput is handled with the correct MapModeAshod Nakashian
The MapMode is set explicitly to make sure the coordinates of the comment widget is in absolute terms. However PostItMgr::MakeVisible invalidates it. This is to ensure that the MapMode is restored after MakeVisible is called when LOK is active. Change-Id: I2adf749488e6eb46d29a0b29c4dfd644606c92ab Reviewed-on: https://gerrit.libreoffice.org/25015 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 0b223bac012fae1af2d2bf1fe9c038cbe88846ed) Reviewed-on: https://gerrit.libreoffice.org/25426 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28LOK: invalidate annotation window upon showingAshod Nakashian
Change-Id: Ib2624c55759c8ac81986bf3b516fd17cbde19ec9 Reviewed-on: https://gerrit.libreoffice.org/25014 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit 4523f78312bd07449fa205301d99a81ef0f69420) Reviewed-on: https://gerrit.libreoffice.org/25425 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28LOK: improved event handling and fixesAshod Nakashian
During painting, when notifications are disabled, we could still receive notifications that are imporatant and cannot be suppressed. So certain events are let through during painting. A comment describes this better in the code. Some widgets (notably postit/comment control) emits events in relative (local) coordinates instead of absolute. This is patched in many cases but some cases still exist that are rather hard to patch due to the complex interaction with other parts of the code. These supurious local coordinate updates (notably cursor invalidation) are supressed to avoid the bad side-effects they cause in LOOL. Change-Id: Ie22a316d54ea163c6976ed04314d6ced8247824c Reviewed-on: https://gerrit.libreoffice.org/25013 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> (cherry picked from commit b5c2a3fdbbf4161b0699ba515f63f98d7607ddf2) Reviewed-on: https://gerrit.libreoffice.org/25424 Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28Estonian localization of aboveWord and belowWordMihkel Tõnnov
Change-Id: Ie872c593c531b99360efe7fcf807e76cb88acb79
2016-05-28notebookbar: sw ui adjustmentSzymon Kłos
Change-Id: I89d1a1fe20a617155a11dc59c49454bcd24e3e3d
2016-05-28Improve alignment and use of space in Document Properties dialogAdolfo Jayme Barrientos
Change-Id: Id4da1138931ef1601541b7108a4e90b3656a5ccb
2016-05-28sax2/ unit tests.Mohammed Abdul Azeem
Test xml files are added, string is built for each file and namespaces are handled. Change-Id: I0ab799ca5c9de7311ccca2a6033a96e02598064f Reviewed-on: https://gerrit.libreoffice.org/25468 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2016-05-28Updated coreAdolfo Jayme Barrientos
Project: help a9a0e8625655eabdf702cfc754412488a79c0513 Misused word: “strait” → “straight” Change-Id: I9129c1d493ef47087fc3d39a58cc5142b4df8e38
2016-05-28Revert "add DAYS test case"Markus Mohrhard
This reverts commit 75e4c582828d1706664f4582be2f6589aef48df3. Change-Id: I52a4bc79790ce479ad3b9762942d6bbc49d4b294 Reviewed-on: https://gerrit.libreoffice.org/25573 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins <ci@libreoffice.org>
2016-05-28lok: add uno command AssignLayoutHenry Castro
Change-Id: I959d1a57945a3b5aa3f2c273c4b885ed5f628f6e Reviewed-on: https://gerrit.libreoffice.org/25569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2016-05-28add DAYS test caseZdeněk Crhonek
Change-Id: I6720a1cfaf5f7463b839ba5ef59e4479ed3781c1 Reviewed-on: https://gerrit.libreoffice.org/25564 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-28add DAY test caseZdeněk Crhonek
Change-Id: I010be093e84107d2b0cd46a90f32ce6df081744e Reviewed-on: https://gerrit.libreoffice.org/25560 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-05-28starmath: Make some functions of SmDocShell publicTakeshi Abe
so that SmModel is no longer required to be a friend of SmDocShell. Change-Id: I7153a9ef13ae829710acf580ff0a9c30705aeb25 Reviewed-on: https://gerrit.libreoffice.org/25528 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-27shortcut the signal handler during batch testNorbert Thiebaud
Change-Id: I7848555743e8d54e755dc82cbf0148eeed54110f Reviewed-on: https://gerrit.libreoffice.org/25178 Reviewed-by: Norbert Thiebaud <nthiebaud@gmail.com> Tested-by: Norbert Thiebaud <nthiebaud@gmail.com>
2016-05-27notebookbar: working border style dropdownSzymon Kłos
Change-Id: I37d140d50d37b682617051bed56b850f4f2a00a5
2016-05-27strip 0 argument only if not part of an expression, tdf#70806Eike Rathke
Change-Id: Ia1f986a594194a1c564d815bbe2faa987eea971a
2016-05-27tdf#98666: Don't cache progress bars eitherTor Lillqvist
Fixes the bug only partially, though. Change-Id: I262f671659e8ad0a3ecd735f5b36362c4119b26c Reviewed-on: https://gerrit.libreoffice.org/25557 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-05-27Get rid of unnecessary directory levels $D/inc/$DTor Lillqvist
Change-Id: Ibf313b8948a493043006ebf3a8281487c1f67b48 Reviewed-on: https://gerrit.libreoffice.org/25532 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2016-05-27omit DCOUNT or DCOUNTA 2nd argument if 0 when writing ODFF or OOXML, tdf#70806Eike Rathke
Change-Id: I2833a1005c6941e66a09172b337e23b0bf7f2002
2016-05-27tdf#93403 check for changed DataSource on all Controls on form reloadLionel Elie Mamane
1) OBoundControlModel: when reload() asks us to connect to database column, redo it even if it was previously done. 2) FmXGridPeer: when getting Reloaded event that we subscribed to (and specifically from frm::ODatabaseFrom), pass along the event to all columns before we treat it. The columns (controls) are themselves subscribed to it, but they may get the event after us, which means our treatment still uses stale data, which we continue to display. The column controls should continue to subscribe by themselves for the case that they are not in a grid, but direct children of the form. Change-Id: I0cbcf2dc792e8650157a69ddc414d755de0e549a
2016-05-27tdf#96516 do not increment position counter when an entry is removedLionel Elie Mamane
Change-Id: I81a4455df1fd5962d0362f4e5fa3396764a0ae5a
2016-05-27Template Manager: Option to rename categoryAkshay Deep
Change-Id: I7a9a0a42afbf5f8a293a130a0b84e72a54540579 Reviewed-on: https://gerrit.libreoffice.org/25539 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-27Convert GRAPHIC to scoped enumNoel Grandin
Change-Id: I1fd09a729cbda00f99841532e0dd3fa66bce7bea Reviewed-on: https://gerrit.libreoffice.org/25534 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-27Revert "Remove more RSC_DOCKWINDOW related stuff"Michael Stahl
This reverts commit 538a217263230765961f6cabbc8d8e168b3eaac0. Depends on the previous reverted commit Change-Id: Ie3cdef43e746712beab31af2abaaede4e53d5506
2016-05-27Revert "remove unused RSC_DOCKWINDOW flags"Michael Stahl
This reverts commit c8754b38ce205845aad5cde3c5ad4070ce38f7d5. This causes toolkit.AccessibleDropDownListBox to fail with: LOG> ImplementationName Unknown, does not implement XServiceInfo Exception while getting Environment Couldn't create a test object
2016-05-27Typo fixTor Lillqvist
Change-Id: Ibf279e723c11a4a5f62ce082938e723a46e40f6d
2016-05-27Updated coreEike Rathke
Project: help 5b1cb4f0bfbae734818ae791165cd1ea7ac5fdcb tdf#70806 DCOUNT and DCOUNTA DatabaseField argument can be omitted Change-Id: I340142fedd2239ff318c8f70fe228e696540cfdd
2016-05-27Remove more RSC_DOCKWINDOW related stuffNoel Grandin
Change-Id: I89f929c32a71be4fb2f7a867940de4c008079518
2016-05-27sw: these all look like intended fall-throughsMichael Stahl
Change-Id: Idfea426b69d07dc6d8eb8d0edb59b0ec0f4ecdf9
2016-05-27Move accessibility relations to .ui files tdf#87026Muhammet Kara
Get rid of SetAccessibleRelationLabeledBy and SetAccessibleName in C++ files by moving the relations to .ui files. Change-Id: I8b425a0c7d923ff6f99540f0a6c18112f6f4d0c0 Reviewed-on: https://gerrit.libreoffice.org/25518 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-27Fix gradient angle spinbox in Area sidebar tabRishabh Kumar
Regression introduced by commit - 3c99f8500f657ed84b316390d5175a6f5e56bc69 Change-Id: I65a56b44f851d374e0a6aac8b7c544f4156b67f2 Reviewed-on: https://gerrit.libreoffice.org/25524 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2016-05-27remove unused RSC_DOCKWINDOW flagsNoel Grandin
Change-Id: I2e2d82760b10876a7cf2a8cfb375926eb24d23e4 Reviewed-on: https://gerrit.libreoffice.org/25462 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>