summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-26TSCP: paragraph classification dialogAshod Nakashian
Change-Id: I3a5f201f9ed28452ee7392cb30aebf21955f3620 Reviewed-on: https://gerrit.libreoffice.org/42737 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26tdf#49634 Fix positioning of focus rectangle in Navigator content treeJim Raykowski
https://bugs.documentfoundation.org/show_bug.cgi?id=49634 Change-Id: I3beb41142281b2cda337b457ed287a2cc1f665a6 Reviewed-on: https://gerrit.libreoffice.org/42364 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-09-26sw: refactor updating paragraph signatureAshod Nakashian
Change-Id: If86e4b1664f88c9e51ab4ac2d819f8726991fa98 Reviewed-on: https://gerrit.libreoffice.org/42736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26sw: refactor inserting paragraph signatureAshod Nakashian
And move signatures to the end of the paragraphs. Change-Id: I56cb501451a52a89dc256432823d10856a6e73dd Reviewed-on: https://gerrit.libreoffice.org/42735 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26sw: move paragraph signature field to the endAshod Nakashian
This is both more readable (esp. at a glance) and for undoing. Change-Id: I817699b4eed15e05b0578d0f08ac451633b1d0dd Reviewed-on: https://gerrit.libreoffice.org/42734 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26sw: improve undo handling of Paragraph SignatureAshod Nakashian
Change-Id: I46f395d5f9105d1d3dac6d2af6e9b43ae95ec78e Reviewed-on: https://gerrit.libreoffice.org/42733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26tdf#112288 Clarify Reschedule implementationsJan-Marek Glogowski
Application::Reschedule(true) must just process all currently pending events and ignore all new events generated while processing them. In contrast to Scheduler::ProcessEventsToIdle, this way it can't busy-lock the application with background jobs. This way we also can drop nMaxEvents from the Windows backend. This limit was also never implemented on OSX and for the KDE4 backend it's actually impossible to handle single events, and a call to QAbstractEventDispatcher::processEvents works like this. Also changes various call sites to just process all pending events instead of some made up number of times. Change-Id: I1ab95df89b079cc8c6319a808194fe3127144d1c Reviewed-on: https://gerrit.libreoffice.org/42659 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-26tdf#100065 Fix scale of transformationPaul Trojahn
The shape needs to be flipped to compensate the change of mbFlipH/mbFlipV. Change-Id: I7b680497fee6ae9ed7bbd6f4ed9089d1a25a1deb Reviewed-on: https://gerrit.libreoffice.org/42766 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-26tdf#39468: Translate some random German comments and termsJens Carl
Change-Id: I5499676506a7570482388eb153f4667785b016ed Reviewed-on: https://gerrit.libreoffice.org/42770 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2017-09-26close sc and sw docshells tooCaolán McNamara
Change-Id: I2cf06762d50736debd63f385dcae3022412ac0c0
2017-09-26ofz#3483 Floating-point-exceptionCaolán McNamara
Change-Id: I3c8dc5e4ec9ce342d2da39459c49eeb0459f76d8
2017-09-26improve unnecessarycatchthrow pluginNoel Grandin
it is not legal to eliminate a catch/re-throw where the re-throw expliciting mentions the exception variable and the exception variable is a non-final class Change-Id: I7fd88b0d004d2efa66aef2c0876e07f203da3c28 Reviewed-on: https://gerrit.libreoffice.org/42782 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26oom in fodpfuzzerCaolán McNamara
Change-Id: Iba6ce63f21f9dfe7187eea81c6d76fad12ccc498
2017-09-26Blind fix for Xcode 9Stephan Bergmann
...which started to run into the same undefined reference issue as 5a55bef38b047b9c60d1b219c572287938265610 "Temporary fix for Clang on F26". (Unfortunately, Apple's Xcode Clang uses version numbers that can be confused with upstream Clang version numbers, so this patch will also affect users of upstream Clang 9.0 on macOS, when that eventually gets released.) Change-Id: I721f01f76d93c044fdbc02e68002b60b17b5e9fb
2017-09-26tdf#112211 RTF import: fix unwanted direct formatting for left indentsMiklos Vajna
Commit f528f9499bd91b700c549575e88fa102cfffede9 (tdf#106953 RTF import: fix missing paragraph left margin, 2017-05-16) fixed a problem around inheriting indents from numbering styles vs paragraph styles, but it turns out that document was rather special and in general the old behavior was correct. So fix that bug in a different way again, this time without less side-effects. The trick is that in case the level numbers group in a list definition ends with \u59 (instead of an ASCII ';'), then that group is considered to be invalid by Word. RTF import already was aware of this, but it wasn't known that when this invalid state is reached, that also means that the indents of the list level definitions should be ignored. So in general not putting direct formatting on a paragraph is a good thing: that way in case the paragraph style and the number style both has indent infos, then the numbering style wins, and that is what we want -- but in case \u59 appears in the list definition, then the indentation from the numbering style should be ignored. So fix up the tokenizer to import the indentation from list levels in general, ignore it for invalid list levels, and then we can remove the direct formatting from the paragraphs, which fixes this bug and keeps the old one fixed as well. This required fixing up two poor testcases, which tested paragraph properties, but in fact are interested in the real source of indentation, which is now the numbering style. Visually both bugdocs are unchanged. Change-Id: I6390aa870659a8ad02ba5512d84dea34dba29e9f
2017-09-26Don't pessimize to RTL_TEXTENCODING_DONTKNOWStephan Bergmann
...when aTextEncodingOrg can't represent all chars, but getBestMSEncodingByChar doesn't know any better encoding, either. (This happened during CppunitTest_sw_rtfexport, where it caused OUStringToOString to be called with RTL_TEXTENCODING_DONTKNOW from WMFWriter::WMFRecord_Escape_Unicode.) Change-Id: Ia975a2907f519172e7da4a370d97e1f4317b78b3
2017-09-26Map RTF codepage 0 to osl_getThreadTextEncoding()Stephan Bergmann
...instead of RTL_TEXTENCODING_DONTKNOW. (A file actually using that codepage is sw/qa/core/data/rtf/pass/CVE-2014-6357.rtf, processed by CppunitTest/sw_filters_test, where it caused OStringToOUString to be called with RTL_TEXTENCODING_DONTKNOW from writerfilter::rtftok::RTFDocumentImpl::resolveChars.) Change-Id: I41081c5df5c3aa80b4f1c7d52b158e73ef68cf38
2017-09-26Silence macOS 10.13 -Werror,-Wdeprecated-declarationsStephan Bergmann
Change-Id: Idde11cd740dd67b5df06945557e5580c7d16b1e3
2017-09-26loplugin:redundantcast: cstyle_cast within reinterpret_castStephan Bergmann
Change-Id: Ie31c9dd6d8741aa856553b798bb5b7f695a3fe0f Reviewed-on: https://gerrit.libreoffice.org/42776 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-26Silence macOS 10.13 -Werror,-Wdeprecated-declarationsStephan Bergmann
Change-Id: I84e9d3fc344fdc9fcf90ab63303d86e7a1cb20da
2017-09-26WIN run main thread redirects ignoring SolarMutexJan-Marek Glogowski
This way we can drop all the special nReleased handling. Instead we use the same mechanism as on Mac, where we keep the lock, but disable it for the main thread. As a security measure we assert on duplicate redirects, which should not happen. As a result we can't use SendMessage on the main thread itself, which would normally just call the WinProc directly. This could be accomplished by converting the redirect bool into a counter, which should be safe, as no other thread could acquire the SolarMutex, as we don't release it. Change-Id: Icd87b3da37a2489f3cad2bc80215bf93fc41d388 Reviewed-on: https://gerrit.libreoffice.org/42583 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-26Remove double 'using' statementMuhammet Kara
Change-Id: I103f8d267b1f34f9e3d1fe03e395c8d444150204 Reviewed-on: https://gerrit.libreoffice.org/42772 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26loplugin:flatten in scNoel Grandin
Change-Id: I40653af2d90ef123cf77d7223c520cba0e5a3aca Reviewed-on: https://gerrit.libreoffice.org/42661 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-26external/libmspub: Update config.{guess,sub}Stephan Bergmann
...with versions of those files from the latest <http://ftp.gnu.org/gnu/automake/automake-1.15.tar.xz>. The current versions would fail for Flathub aarch64 builds. Change-Id: I4b42fa7c04f0570b31170b72d8a42786ae1dc252
2017-09-26Revert "tdf#106894 Rewrite packimages.pl in Python (pack_images.py)"Samuel Mehrbrodt
This broke the build: https://ci.libreoffice.org/job/lo_tb_master_win/14994/console This reverts commit 423ee1020afe1bca896f2ecfc67ffbd49db5081c. Change-Id: I05e6fd68f2bbec189236cbe265f6510731327997 Reviewed-on: https://gerrit.libreoffice.org/42778 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-26EPUB export: add testcase for EPUBExportUIComponent::setPropertyValues()Miklos Vajna
Making sure python produces sequence<PropertyValue> and not sequence<any> is a bit tricky. Change-Id: I1f3ee4664202576ab6777b719b3712b164c5002d Reviewed-on: https://gerrit.libreoffice.org/42759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-26tdf#106894 Rewrite packimages.pl in Python (pack_images.py)Jens Carl
Change-Id: Id627d9295edc77e561f15e0886fdcf9fb64fe68d Reviewed-on: https://gerrit.libreoffice.org/41667 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-09-26loplugin:cstylecast (clang-cl)Stephan Bergmann
Change-Id: Ic61a2d58e260e11f3698524891201e8b761c97fc
2017-09-26external/firebird: Update config.{guess,sub}Stephan Bergmann
...with versions of those files from the latest <http://ftp.gnu.org/gnu/automake/automake-1.15.tar.xz>. The current versions would fail for Flathub aarch64 builds. Change-Id: Id53754e989244134bdc533eb7f37e08c598b03e0
2017-09-26sw: make paragraph signature fields read-onlyAshod Nakashian
Change-Id: Ib0218e2a92cdde81030c517b0826bd6062a333f3 Reviewed-on: https://gerrit.libreoffice.org/42732 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-09-26tdf#111739 fix Selecting a custom character as a bullet symbol insertionDaniel
Change-Id: I638ef2467f27bd6214cde092be5a3055fd539ebc Reviewed-on: https://gerrit.libreoffice.org/42727 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-26we should be able to dispense with the intermediate vectorCaolán McNamara
as since commit 58d8d8ac67aa9b907f1304a48efa0f7a473d9de4 Author: Noel Grandin <noel@peralex.com> Date: Thu Dec 10 12:27:50 2015 +0200 tdf#69977: uno::Sequence is expensive the uno::Sequence Primitive2DSequence was replaced with a std::deque Primitive2DContainer Change-Id: I4d2a293967717f9070121ab6740abf620b941ead Reviewed-on: https://gerrit.libreoffice.org/42767 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-26check sot multiplyCaolán McNamara
Change-Id: I9d1e86834af87cd92c2792f66ac722ba94dff040 Reviewed-on: https://gerrit.libreoffice.org/42768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-25pptfuzzer timeoutCaolán McNamara
Change-Id: I0d537da3dd7f979a087d7534459bf6e5cabbb2e0 Reviewed-on: https://gerrit.libreoffice.org/42758 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-25Improve resizing chevrons so the control point is a fixed distance from endCaolán McNamara
during resizing, because... "If I want to use LibreOffice Draw to illustrate process steps with chevrons (which I do a lot, working on for example customer project roadmaps), I always get stuck if the steps I want to illustrate are not equal lengths, because the sizes/angles of the chevron "arrow heads" are proportional to the length of the chevron, rather than being fixed, and thus don't "fit" together. Which makes for an incredibly ugly diagram." Change-Id: Ib8b5e0ea7db5383cae754127023f7ab12d748537 Reviewed-on: https://gerrit.libreoffice.org/42754 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-25Reorganization of impress's slide and pane context menusYousuf Philips
Change-Id: Ia69fd25daa6a7e7ea42a5c3d84dd0fde274fa58d Reviewed-on: https://gerrit.libreoffice.org/42718 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-25tdf#106781 Updates to tango icons in writer styles toolbarYousuf Philips
Change-Id: I2fc2f0bf562ec1bbc7548bdba60422fd5af519e7 Reviewed-on: https://gerrit.libreoffice.org/42731 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-25Shrink master slide checkboxes in Slide content panelYousuf Philips
Change-Id: I238ff579da86bd3ac41f76f62d97b07a3ca29d80 Reviewed-on: https://gerrit.libreoffice.org/42761 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-25speed up ppt fuzzingCaolán McNamara
Change-Id: I68474b3ed40ce61484e8e9cda8809105bc12ef4f Reviewed-on: https://gerrit.libreoffice.org/42757 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-25Enable addition of page size group control to toolbarsYousuf Philips
Change-Id: Ibcc8b7f91b3d5bfd9ea9834ef25a91fc8847e531 Reviewed-on: https://gerrit.libreoffice.org/40367 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-25Make two slightly mysterious static local variables thread_localTor Lillqvist
IRC discussion about them: tml_: erAck: any idea why in ScFormulaCell::GetMatrixEdge those nC and nR are static? tml_: seems to have been since initial import in 2000 (then in a different file, and of type USHORT) tml_: let's assume it is just random insanity tml_: hmm, no, making them non-static actually breaks a unit test. wow erAck: tml_: they are reused when the call is for the same matrix origin as the last one to not have to recalculate the same thing tml_: erAck: ah ok Change-Id: Ib0fe322492917b5224937ec6ef527707ca2e07f7 Reviewed-on: https://gerrit.libreoffice.org/41658 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-09-25-Werror,-Wint-to-void-pointer-cast, loplugin:cstylecast (clang-cl)Stephan Bergmann
Change-Id: Ib06849499e46eb76f8049fea304f80c771e94098
2017-09-25Missing #include <tools/time.hxx> (--disable-pch)Stephan Bergmann
Change-Id: I30d8998b5f9ff29b8a3e8012f6112de597933d10
2017-09-25vcl: [loplugin:badstatics] rename xDefaultImplFontCharMapMichael Stahl
It looks harmless. Change-Id: Ibe54b9059f46ced95602914bf852d342aef89905
2017-09-25vcl: [loplugin:badstatics] X11OpenGLDeviceInfoMichael Stahl
class X11OpenGLDeviceInfo actually looks harmless but it has an out-of-line destructor so the plugin can't see that it's harmless, so use default destructor instead. Change-Id: I50de6916360a944cbda3a85f4062e72e4c6d3768
2017-09-25vcl: [loplugin:badstatics] aDocumentFocusListenerMichael Stahl
Move it into class GtkSalData; have to use 2 variables because the class is only defined in atkutil.cxx but the ~GtkSalData is in gtkdata.cxx. Change-Id: I3b12f02a1a5454f39206cbd0fe224d3f08a44c73 Reviewed-on: https://gerrit.libreoffice.org/42673 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-25tdf#106781 Copy style-focused toolbar to writer master docYousuf Philips
Change-Id: Icb07748be6f0603e2229809be19f3fe44d0edebb Reviewed-on: https://gerrit.libreoffice.org/42730 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-25-Werror,-Winconsistent-missing-overrideStephan Bergmann
Change-Id: I1d6d315cea33ba19a7d61f532c9d968d582b476f
2017-09-25tdf#95947 rename handout label in display mode controlYousuf Philips
Change-Id: Icfab4040cba8f3ffab739c873c83dfc830d238cf Reviewed-on: https://gerrit.libreoffice.org/42729 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
2017-09-25tdf#56731 correct label from snap lines to helplinesYousuf Philips
Change-Id: Ibd196af1e4e02f411d0da55d20ead402cae365c7 Reviewed-on: https://gerrit.libreoffice.org/42725 Reviewed-by: Yousuf Philips <philipz85@hotmail.com> Tested-by: Yousuf Philips <philipz85@hotmail.com>
generated by cgit (git 2.34.1) at 2024-07-20 00:37:21 +0000