summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-12-13Revert "verify SolarMutex when ref-counting VclPtr" seriesNoel Grandin
This reverts the following commits: commit 722f4e1d86710f2facd37d7e040df9e1fd585e26 tdf#104573 - Assertion failed: SolarMutex not locked commit f04ec99f5e6a543b8191ced61db4710c3c0de356 tdf#104573 - Assertion failed: SolarMutex not locked commit 71b1e3ff6374c23e65200d3bcafca387d29af04f tdf#104573 - Assertion failed: SolarMutex not locked when trying commit e794ce1eef6730e5a46d5fb0aa6db2895ede85e7 verify that we hold the SolarMutex when ref-counting VclPtr IRC discussion: <noelgrandin> sberg, maybe I should revert this whole "VclPtr assert" series, I don't have mental bandwidth to sort this out properly now <sberg> noelgrandin, what I fear is that you'll end up adding lots of SolarMutex locks to small places, where the proper fix would be to add it further out; and once such a dreaded recursive SolarMutex lock is in place (but needlessly so, once the proper fix is done), it's hard to clean that up again <noelgrandin> sberg, yeah, in that case I'll just remove all of this, leave it for another day Change-Id: Ie4f84b72b79a1b7e80164b5c7693af398c2c569a Reviewed-on: https://gerrit.libreoffice.org/31946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13missing EGL/eglplatform.h error -> install mesa-libEGL-develCaolán McNamara
Change-Id: I689fd6d4f90dd46b71803517bbe2df73486dc9ec
2016-12-13tdf#95416 Fix an include for sfx2Adam Kasztenny
This .hrc file was used in multiple places. Change-Id: I603c6d35da2e870d8586f081ccd2672065ade5db Reviewed-on: https://gerrit.libreoffice.org/31928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-13tdf#95416 Fix includes for xmloffAdam Kasztenny
Move a header file into inc/ Change-Id: If337720fbd5af43fc7ec32518058a1c7d43b8d18 Reviewed-on: https://gerrit.libreoffice.org/31879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-13tdf#97361 Fixed check_cross_references.pykerem
Change-Id: Iedc586f0d10d0a87416c86ef8d52abb629df42b3 Reviewed-on: https://gerrit.libreoffice.org/31872 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2016-12-13tdf#97361 Fixed check_flies.pykerem
Change-Id: I8b2090ea714cd9103e1823d2a48f624e6c54fbe1 Reviewed-on: https://gerrit.libreoffice.org/31873 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-12-13tdf#104228 RTF import: fix override of style left/right para marginMiklos Vajna
See commit 1be0a3fa9ebb22b607c54b47739d4467acfed259 (n#825305: writerfilter RTF import: override style properties like Word, 2014-06-17) for the details, this bug was about the same, just for two more paragraph properties. Specify the default values for them, so override of style value as direct formatting works as expected. Change-Id: I353cc3ae8c35baf1b5ed5a83a8bd131c7bfbbe64
2016-12-13gtk3: implement opengl support for slideshowCaolán McNamara
all of them work, except "Fall" doesn't look right, but it has the exact same problem under gtk2/gen to. Change-Id: I73cb9c0fb8211f727198be78d90d4f80a4f8c7c8 Reviewed-on: https://gerrit.libreoffice.org/31214 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13change from glew to epoxyCaolán McNamara
because that works under wayland out of the box and gtk3 uses it already Change-Id: Iefaac31e325534a81a5389f752804af917c1baef Reviewed-on: https://gerrit.libreoffice.org/31213 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-13Don't leave WW8AnchorConvResult::m_bConverted uninitializedStephan Bergmann
Presumably inadvertently dropped from d505b5d884fd42e063c709125e0e28e0a56045c4 "add relative to tablecell as state". Caused e.g. CppunitTest_sw_globalfilter to fail under ASan/UBSan with > sw/source/filter/ww8/wrtw8esh.cxx:2682:21: runtime error: load of value 152, which is not a valid value for type 'bool' > #0 0x7f7494a13f8b in WinwordAnchoring::ConvertPosition(SwFormatHoriOrient&, SwFormatVertOrient&, SwFrameFormat const&) sw/source/filter/ww8/wrtw8esh.cxx:2682:21 > #1 0x7f7494a388e2 in WinwordAnchoring::SetAnchoring(SwFrameFormat const&) sw/source/filter/ww8/wrtw8esh.cxx:2703:32 > #2 0x7f7494a3ad15 in SwEscherEx::WriteFrameExtraData(SwFrameFormat const&) sw/source/filter/ww8/wrtw8esh.cxx:2830:23 > #3 0x7f7494a2b00b in SwBasicEscherEx::WriteGrfFlyFrame(SwFrameFormat const&, unsigned int) sw/source/filter/ww8/wrtw8esh.cxx:1737:5 > #4 0x7f7494a361d4 in SwEscherEx::WriteFlyFrame(DrawObj const&, unsigned int&, std::__debug::vector<DrawObj*, std::allocator<DrawObj*> >&) sw/source/filter/ww8/wrtw8esh.cxx:2854:28 > #5 0x7f7494a33a33 in SwEscherEx::SwEscherEx(SvStream*, WW8Export&) sw/source/filter/ww8/wrtw8esh.cxx:2346:36 > #6 0x7f7494a24b3b in WW8Export::CreateEscher() sw/source/filter/ww8/wrtw8esh.cxx:1510:25 > #7 0x7f7494c33c40 in WW8Export::StoreDoc1() sw/source/filter/ww8/wrtww8.cxx:2950:5 > #8 0x7f7494c3eb83 in WW8Export::ExportDocument_Impl() sw/source/filter/ww8/wrtww8.cxx:3304:5 > #9 0x7f7494c39335 in MSWordExportBase::ExportDocument(bool) sw/source/filter/ww8/wrtww8.cxx:3139:5 > #10 0x7f7494c45150 in SwWW8Writer::WriteStorage() sw/source/filter/ww8/wrtww8.cxx:3468:17 > #11 0x7f752cb38d3b in StgWriter::Write(SwPaM&, SotStorage&, rtl::OUString const*) sw/source/filter/writer/writer.cxx:512:22 > #12 0x7f752cb33863 in Writer::Write(SwPaM&, SvStream&, rtl::OUString const*) sw/source/filter/writer/writer.cxx:255:23 > #13 0x7f7494c45ad7 in SwWW8Writer::Write(SwPaM&, SfxMedium&, rtl::OUString const*) sw/source/filter/ww8/wrtww8.cxx:3485:33 > #14 0x7f752c80c3d0 in SwWriter::Write(tools::SvRef<Writer>&, rtl::OUString const*) sw/source/filter/basflt/shellio.cxx:867:28 > #15 0x7f752ccfcd6c in SwDocShell::ConvertTo(SfxMedium&) sw/source/uibase/app/docsh.cxx:756:27 > #16 0x7f75048bddd4 in SfxObjectShell::SaveTo_Impl(SfxMedium&, SfxItemSet const*) sfx2/source/doc/objstor.cxx:1542:19 > #17 0x7f75048d83c6 in SfxObjectShell::PreDoSaveAs_Impl(rtl::OUString const&, rtl::OUString const&, SfxItemSet&) sfx2/source/doc/objstor.cxx:2813:39 > #18 0x7f75048d5c07 in SfxObjectShell::CommonSaveAs_Impl(INetURLObject const&, rtl::OUString const&, SfxItemSet&) sfx2/source/doc/objstor.cxx:2683:9 > #19 0x7f7504897ea5 in SfxObjectShell::APISaveAs_Impl(rtl::OUString const&, SfxItemSet&) sfx2/source/doc/objserv.cxx:310:19 > #20 0x7f750498e0ce in SfxBaseModel::impl_store(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, bool) sfx2/source/doc/sfxbasemodel.cxx:3030:46 > #21 0x7f7504993862 in SfxBaseModel::storeToURL(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) sfx2/source/doc/sfxbasemodel.cxx:1666:13 > #22 0x7f753767c657 in Test::testLinkedGraphicRT() sw/qa/extras/globalfilter/globalfilter.cxx:170:20 Change-Id: Ic1d7731b80a14751b3cc1dd0c009bfdb43b722c2
2016-12-13-Werror,-Wunused-macrosStephan Bergmann
Change-Id: Idc81dd30502a1968f2f65386575cac1e029f8c64
2016-12-13Reuse existing sal.osl log areaStephan Bergmann
Change-Id: Ib1fc80c79355322489b7ebd37cbbbbb6614ec67a
2016-12-13tdf#104573 - Assertion failed: SolarMutex not lockedNoel Grandin
Change-Id: I91d95e73a7e0831f6667f440dd43567ac55b0529
2016-12-13cui.screenshot: Show full path when failing to create itSamuel Mehrbrodt
Change-Id: Ic5196e90d7a25665cf9b5a2b039492195b0f00c2
2016-12-13fix mac build after OSL_TRACE->SAL changes (2)Noel Grandin
Change-Id: I978e45207cd9ba96d487da92a51aaab24258855b
2016-12-13fix mac build after OSL_TRACE->SAL changesNoel Grandin
Change-Id: I811d4b4be5ed20a90f405900b9f8a81b5381dd7c
2016-12-13loplugin:sallogareasStephan Bergmann
Change-Id: I25f793d88a87d94925026fc3de97d02086a0c855
2016-12-13tdf#104573 - Assertion failed: SolarMutex not lockedNoel Grandin
Change-Id: Ie46f0e2b60b99aea1c322c7891a41a2e7603c9e9
2016-12-13tdf#46941 docx: don't balance columns before page-break-sectionJustin Luth
Pleasantly surprised to see we already don't balance before regular page-breaks or at the end of the document. This adds not balancing before a page-break-section. Change-Id: Ifedff5cc45b154a005f13b3212154c443727e286 Reviewed-on: https://gerrit.libreoffice.org/31826 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-13SafeMode: Restart goes into safe mode againSamuel Mehrbrodt
Looks like the XRestartManager keeps all command line arguments when restarting, so it also keeps --safe-mode. Solution is to add a flag file when restarting from safe mode, to prevent going into safe mode again. Change-Id: I9820d3ccbddf98b0bf6132f254c989f52ea5e808 Reviewed-on: https://gerrit.libreoffice.org/31913 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-12-13fix windows build after OSL_TRACE->SAL changesNoel Grandin
Change-Id: I345343f84f66299e8b91b31af0290ed0c622bf8d
2016-12-13OSL_TRACE->SAL in avmedia..canvasNoel Grandin
Change-Id: Id9077ea29e7028c12f40abfd4c57756c863e3cd9
2016-12-13OSL_TRACE->SAL in chart2..ooxNoel Grandin
Change-Id: I133a6441824bfbefcfcda130119b5c5d706f86b2 Reviewed-on: https://gerrit.libreoffice.org/31907 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13OSL_TRACE->SAL in framework..salNoel Grandin
Change-Id: I9a897af88aa9f6f7ca98ce521c69b5a4ee8462e9 Reviewed-on: https://gerrit.libreoffice.org/31903 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13OSL_TRACE->SAL in sc..scriptingNoel Grandin
Change-Id: I389d8cb733a5ee24d3119a1ebac5a5b70daff04e Reviewed-on: https://gerrit.libreoffice.org/31900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-13accessibility: cleanup AccessibleBrowseBoxBase implementationArnaud Versini
Change-Id: I5c9b96e2ebd2ac98dfa610346c1da89fbf56e2d2 Reviewed-on: https://gerrit.libreoffice.org/31916 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12Calc function tests - move text function to new dirZdeněk Crhonek
Change-Id: I3a47c0e90e93050419326303c175cdc2adef6796 Reviewed-on: https://gerrit.libreoffice.org/31925 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-12-12dbaccess: fix testCloneMovesPlusDeletions testMichael Stahl
JunitTest_dbaccess_complex spuriously fails 1% of the time with: 1) testCloneMovesPlusDeletions(complex.dbaccess.RowSet) java.lang.AssertionError: moving to the next record after |deleteRow| and clone moves failed at complex.dbaccess.RowSet.testCloneMovesPlusDeletions(RowSet.java:756) The problem is that line RowSet.java:750 deleteRow() manages to delete the last row in the set, because the positionRandom() is tricked to position itself on the last row (which it tries not to do), becuase the RowSet is currently positioned past-the-end on a deleted row and the ORowSetBase::impl_getRowCount() is a lying bastard that adds 1 to the result in this special case. Funnily both the ORowSetBase::impl_getRowCount() and the test using positionRandom() were added in CWS rowsetdel. Yay for randomized tests! Change-Id: Ic8c7bfa190f6a5269604cf5b3c338f2d0b64205e
2016-12-13Fix lossage with --disable-cairo-canvasTor Lillqvist
Change-Id: I9e822cfc1447fcd49c80c56df8ba37959555396a
2016-12-12tdf#104540: AccessibleEventNotifier AccessibleBase (editeng)Julien Nabet
See https://bugs.documentfoundation.org/attachment.cgi?id=129537 for bt For the remind, it follows a replace of OSL_ENSURE by an assert, see: https://cgit.freedesktop.org/libreoffice/core/commit/?id=8228227168a7eb3ebf14629bec87f01536c23970 Change-Id: Id05eeb6e6669232e9b5cc2ef2989827fef3025d0 Reviewed-on: https://gerrit.libreoffice.org/31918 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-12-12Resolves: tdf#101588, do not prevent color de-selection tdf#96382 follow-upEike Rathke
Comparing colors to determine whether to set one in the result item set does not work if the color previously was set before SaveValue() was called unconditionally even for the "undetermined" color state. Actually we want to know whether the user selected a color instead. Change-Id: I508f791684ebd79ba4af9cb654f9aa0bb25bff5d
2016-12-12Add rules to gitignoreJaskaran Singh
Rule for ctags: Sublime generated(or otherwise) ctags look like sc/abc/xyz/tags. The present rule cannot look after tags which are more than 1 directory deep. Hence this change. Other rules added : Jetbrains Clion, cscope, sublime text specific Change-Id: I1dbbe4904f3d15bbf198cd372591b464efb3896a Reviewed-on: https://gerrit.libreoffice.org/31874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jaskaran singh <jvsg1303@gmail.com>
2016-12-12Don’t return false for blank glyphsKhaled Hosny
CTFontCreatePathForGlyph() will return NULL for blank glyphs causing CoreTextStyle::GetGlyphOutline() to return false which propagated as error all the way to OutputDevice::GetTextOutlines() causing it to needlessly enter into fallback code. Other implementations just return true and an empty polygon here. Change-Id: Ib20ebff00f7cb3aae22f1c6b4c3a0e9d7a429987 Reviewed-on: https://gerrit.libreoffice.org/31902 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-12-12Prevent use of ORowSetValue with sal_Bool as TINYINTStephan Bergmann
sal_Bool and sal_uInt8 are typedefs for the same underlying type, so any use of ORowSetValue with sal_Bool instead of bool, apparently intending to treat the value as a boolean, actually treated it as a TINYINT. (See e.g. recent 7b0c57b2faec875c790051d233d1e9abaed2a3bc "some compilers don't like implicit bool-to-ORowSetValue conversion".) Now that there's no way to create a sal_uInt8 ORowSetValue, getUInt8 and the m_uInt8 union member can probably go away, too. Change-Id: Ia27554f76e7e9edce6410284b578064573e54fd3 Reviewed-on: https://gerrit.libreoffice.org/31909 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-12Updated coretagezi
Project: help 47ad5a2f2102740bda4cf02dcd73562da79f67a9 tdf#100836 "Starting the LibreOffice Software With Parameters" help update rewritten cmdHelp in accordance with the attached document in bug tdf#100836 Change-Id: I6061dab2ed83a2be0653fbbd422e3193386d9d98 Reviewed-on: https://gerrit.libreoffice.org/31595 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2016-12-12-Werror,-Wimplicit-fallthroughTor Lillqvist
Change-Id: I7ea9c1af7568ce37f29df14f8dc4345031c20eb8
2016-12-12tdf#97361: Changed naming convention to Python type, object factories ↵n5xgdh
implemented Change-Id: Id42e9a2e2cfd7c95140411123e8702dfdb4054da Reviewed-on: https://gerrit.libreoffice.org/31676 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-12-12tdf104532 handle constraints for NEGBINOM.DIST correctly.Winfried Donkers
Also changed variable names for easier understanding of their meaning. Change-Id: Iab558d7d1d9533f2a0c42e3d5f4acecead2e818e Reviewed-on: https://gerrit.libreoffice.org/31807 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-12-12Revert "loplugin:refcounting"Tor Lillqvist
Bah, the reverted change actually of course breaks the compilation, I had missed that accidentally. More intrusive chnages are needed to change css::uno::Reference to rtl::Reference, also in parameters to constructors and other calls here. This reverts commit 073f8cdbb77d62a6838c78ff63fca73896b86c79. Change-Id: I2d0f9db9cef8dfbfe7d8a409eb09375c45b9e49f
2016-12-12loplugin:stringconstantTor Lillqvist
Change-Id: I5bf8adf86da9d2e9c53341cdbc94aba05557abfc
2016-12-12Whitelist aLogger, in FormulaLogger& FormulaLogger::get()Tor Lillqvist
To avoid this: sc/source/core/tool/formulalogger.cxx:55:26: error: bad static variable causes crash on shutdown [loplugin:badstatics] static FormulaLogger aLogger; ~~~~~~~~~~~~~~~~~~~~~^~~~~~~ sc/inc/formulalogger.hxx:42:31: note: ... due to this member of 'FormulaLogger' [loplugin:badstatics] const ScFormulaCellGroup* mpLastGroup = nullptr; ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ sc/inc/formulacell.hxx:66:20: note: ... due to this member of 'ScFormulaCellGroup' [loplugin:badstatics] ScFormulaCell *mpTopCell; ~~~~~~~~~~~~~~~^~~~~~~~~ sc/inc/formulacell.hxx:114:21: note: ... due to this member of 'ScFormulaCell' [loplugin:badstatics] ScDocument* pDocument; ~~~~~~~~~~~~~~~~^~~~~~~~~ sc/inc/document.hxx:312:27: note: ... due to this member of 'ScDocument' [loplugin:badstatics] VclPtr<SfxPrinter> pPrinter; ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ Change-Id: I533e45f655ca928a801188aa48ee818d89a962ac
2016-12-12loplugin:staticmethodsTor Lillqvist
Change-Id: Ia470ed848c5c27de1b0ae3fa89a59f6cb2ae38fe
2016-12-12loplugin:unreffun and loplugin:externandnotdefinedTor Lillqvist
Change-Id: I69f11aa5dd81834aa916a66437d8c091cdf245f3
2016-12-12loplugin:overrideTor Lillqvist
Change-Id: I7ef42d66a0ffbbd8f2754bd4aba0e77659c9ae83
2016-12-12loplugin:nullptrTor Lillqvist
Change-Id: I6ab405e7e9a0c8ac3a323fd2484e334c500280ae
2016-12-12loplugin:unnecessaryoverrideTor Lillqvist
Change-Id: I45d7e14cef0058c4bfca4a3466e31d64e29bdfae
2016-12-12loplugin:unreffunTor Lillqvist
Change-Id: If538d5d5347f58e18869cab2b687af26a39a89eb
2016-12-12loplugin:staticmethodsStephan Bergmann
Change-Id: Ic8e00ab8961811044c26eb237f283617ddeb5cb6
2016-12-12unwind RID_OUTLINEBITMAPS imagelistCaolán McNamara
Change-Id: I44a03f557d7a7aafeb17e5d662797203f975672f
2016-12-12sw: prefix members of SwClientMiklos Vajna
Change-Id: If35981bce951dfab4a784d4cb54ac911249572ed
generated by cgit (git 2.34.1) at 2024-08-11 15:49:48 +0000