summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-12Avoid superfluous directory levelTor Lillqvist
Don't bother with a 'userinstallation' subdirectory. It is a subdirectory called "user" of the UserInstallation value that will be used for our stuff anyway. Change-Id: Idb6b5992bfda73ed7af80274b0de8ad7b43c241c
2018-10-12Make sure the UserInstallation/user directory exists on iOS (and Android)Tor Lillqvist
If it doesn't exist lots of things go very badly. Took a while for me to understand the mechanism, sigh. Change-Id: I40300587a5f422876cbda68c5aa98a23ed707135
2018-10-11tdf#119580 sc: Use the regular object popupmenu for chartsMaxim Monastirsky
Context menu of a chart is supposed to be the same as for other ole objects, except the additional .uno:ExportAsGraphic. Given that .uno:ExportAsGraphic is hidden when non-chart object is selected, we can just place it in the regular ole object popupmenu (done already), and use that menu also for charts. Discussion is in https://gerrit.libreoffice.org/60128 . Change-Id: I8a07c550998e1db0d2af7f87c625dbd258454bdd Reviewed-on: https://gerrit.libreoffice.org/61678 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-10-11Remove superfluous separatorMaxim Monastirsky
Change-Id: I12f7ebf8cb40c5c1ea40509ac38ae977e1abca89 Reviewed-on: https://gerrit.libreoffice.org/61677 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-10-11tdf#120528: check for empty mpMouseEvent in ScDataTableView::MouseButtonUpMike Kaganski
The preceeding mouse button down event could happen in a different (closing) window, like context menu. Change-Id: I630b827fb5fe05399ca8436ea79210f4642a56d4 Reviewed-on: https://gerrit.libreoffice.org/61691 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-11ofz#10853 no config available during fuzzingCaolán McNamara
Change-Id: Ice48111756d2e5950093fabc28359f7a4e490220 Reviewed-on: https://gerrit.libreoffice.org/61693 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11weld DlgFilterCrit and DlgOrderCritCaolán McNamara
Change-Id: Icb96b47cb20a1a80877f693156a3395aba4c70d5 Reviewed-on: https://gerrit.libreoffice.org/61685 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11Further SAL_INFO("sal.file",...) tweaksTor Lillqvist
Now it should be fairly close to the (IMHO) ideal: One SAL_INFO("sal.file") per file system system call. (Not read() and write().) Sure, on Linux one could just use strace, but my interest at the moment is debugging what goes on on iOS. Change-Id: I19ec0404c0c15a957de96d98376b4338b48a8cbd Reviewed-on: https://gerrit.libreoffice.org/61687 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-10-11elementary: update existing /add 32px fontworkshapes, form icons, etcRizal Muttaqin
Change-Id: Ie6545844546dc78d14e1fabdf28f4e1938cf2dd3 Reviewed-on: https://gerrit.libreoffice.org/61642 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2018-10-11loplugin:simplifyboolTor Lillqvist
Change-Id: Icb25fd00296f0584fdd503ad0e840870f8bc6774
2018-10-11Resolves: tdf#120476 need to be resizable if number of tabs is variableCaolán McNamara
across runs Change-Id: Ie77512557c10f564ed9d2dab837b134e9b4834a1 Reviewed-on: https://gerrit.libreoffice.org/61672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11Resolves: tdf#120487 postit losing focus triggering recreation of postitCaolán McNamara
Change-Id: Idde6b740bc94de62bbd528b656841ab37e3f3786 Reviewed-on: https://gerrit.libreoffice.org/61681 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11Revert "tdf#120158: fix ImplGetParameterString for typename"Stephan Bergmann
This reverts commit 40e22f1e1bd44a1aa56ff77b82f1306ed1076ebf. See the commit message of <https://gerrit.libreoffice.org/61684> "tdf#120158: Base CMimeContentType on INetMIME::scanContentType" why that change is considered a superior fix compared to the reverted one. Change-Id: I1a0d77edee5bb18a98890d2021c777bc4c148a26 Reviewed-on: https://gerrit.libreoffice.org/61686 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-11tdf#120158: Base CMimeContentType on INetMIME::scanContentTypeStephan Bergmann
...instead of using yet another local implementation of parsing media types. CMimeContentType is the implementation of the UNO css.datatransfer.XMimeContentType interface. One observable change in behavior is that type, subtype, and parameter names will now always be reported in lower case instead of with the casing from the input preserved (but those differences in casing are functionally equivalent per the media type specification). Also, parameter names supplied to the hasParameter and getParameterValue functions are now also treated case-insensitive. The upside of this change is that INetMIME::scanContentType (via "The encoding of rMediaType should be US-ASCII, but any Unicode values in the range U+0080.. U+FFFF are interpreted 'as appropriate.'") already implicitly supports RFC 6532 "Internationalized Email Headers" extensions for media types, allowing quoted- string parameter values to contain non-ASCII Unicode characters. That means that tfd#120158 "Impossible to paste special in Writer from Calc in Libreoffice 6.1.x in some UI languages - the dialogue caption says 'unknown source'" can be fixed by just allowing non-ASCII typename parameters being generated in ImplGetParameterString in svtools/source/misc/transfer.cxx, and reverting the problematic (see the comments there) previous fix <https://gerrit.libreoffice.org/61601> "tdf#120158: fix ImplGetParameterString for typename". (Which will be done in a follow-up commit, to ease potential backporting, as that previous fix has already been backported to some versions but not to others.) Change-Id: I5d4d3586e8046f288a97605b000e262a8db5a4e9 Reviewed-on: https://gerrit.libreoffice.org/61684 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-11It's the developer's choice whether to use --enable-werrorTor Lillqvist
It belongs in an autogen.input, not in a distro-configs file. Change-Id: I2e22f94fe9e11986fa40a632e12a272193172bac
2018-10-11Restore explicit _WIN32_WINVER in the ODK exampleJan-Marek Glogowski
Change-Id: I01855c37955dcae13dbb3c6f028d4030dc48945a Reviewed-on: https://gerrit.libreoffice.org/61657 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2018-10-11No reason to have --disable-dependency-tracking here ffsTor Lillqvist
Change-Id: Ia42daaf0dbb8fcd0230c7cee21a0f5d560885c22
2018-10-11Don't just log the file name, at least say what we are doing with itTor Lillqvist
Change-Id: I9ff0b4287c5be0dfc83740b75d58cab78dc990f7
2018-10-11Change {read,write}FileAt() SAL_INFO calls to use a separate log areaTor Lillqvist
Keep sal.file for the SAL_INFO logging of file system calls (open, close, rename, etc), and use sal.fileio for the (very verbose) file I/O. Change-Id: I0e166d83e20921696a8a0880f9fcbbdec55053dd
2018-10-11Don't use GetDBManager() without checking it for nullnessTor Lillqvist
Change-Id: Idb7b16a6976df62a1beea8a01c812206a0b8b85a
2018-10-11Initialise m_pDBManager to nullptr in the !HAVE_FEATURE_DBCONNECTIVITY caseTor Lillqvist
Change-Id: Id18bafaaf8f5315a0590687d98ea97952bdf883b
2018-10-11Skip the backup dance on iOS for nowTor Lillqvist
The code is much too convoluted for my little brain. We can't create a backup copy of a file from outside the sandbox in the same folder as the original file. At least not using just normal Unix APIs. And if we store it somewhere else, how would the user find it anyway? Let's just skipt this mess for now. No idea how the code manages to create backup files in the same folder as the actual document in a sandboxed LibreOffice on macOS. Or does it? Maybe we do some similar bypassing of the backup dance at some other place in the code already, and I should just have made that happen for iOS, too? Change-Id: I0c90edf9e72f54cce78b2cd325e67c710b6df745
2018-10-11Do the SAL_INFO() for the fsync() call only when we know the resultTor Lillqvist
Change-Id: I4bea64f959a6d6f3010809261804748b4fcd7718
2018-10-11uitest findReplace; tdf#116242; tdf#98417; tdf#39022Zdeněk Crhonek
Change-Id: I03efe36dac946dd00c91af44a2f6401d56c23214 Reviewed-on: https://gerrit.libreoffice.org/61630 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-11add id column to modelCaolán McNamara
Change-Id: I0c62ef3c296f8aa1ce8b924cf88f569c48dc198f Reviewed-on: https://gerrit.libreoffice.org/61666 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11Resolves: tdf#120503 fix border paddingCaolán McNamara
a) SetFirst doesn't imply SetMin b) ModifyFlag and SaveValue are orthogonal Change-Id: Ibe637ec5d33af030af068fcf8690191a775a6460 Reviewed-on: https://gerrit.libreoffice.org/61670 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11On iOS, don't create temp files in the folder where a document being edited isTor Lillqvist
That folder typically is not inside the app sandbox, and the process has access only to the one file that they have selected for editing there. Trying to create other files in that folder is doomed to fail. Change-Id: Ib4ff5c7c60aa372eb412e87dc8bbce48ec6d6b54
2018-10-11Do the SAL_INFO() also in the special 'good' ENOENT caseTor Lillqvist
Change-Id: I66c3fb02f4c44adec5c8f663d8845658adfe803f
2018-10-11Add SAL_INFO for the open() call in oslDoCopyFile()Tor Lillqvist
Change-Id: I1fde453d5d37481aedec152a1a4da8a85fc6c99b
2018-10-11Tweak check for nonexistent file on iOSTor Lillqvist
Calling stat() on a non-existent file outside the sandbox fails with EPERM on iOS, not ENOENT. (Presumably calling stat() even on an existing file, but one you don't have been granted access to, also fails, because that is after all a point of sandboxing, you shouldn't even be allowed to figure out whether arbitrary files exist outside the sandbox.) Not sure why this change hasn't been necessary also for a sandboxed LibreOffice on macOS. Change-Id: I67c768e9c34fd17fa35f08232284210ff4a71b98
2018-10-11Make editeng_core test depend on more_fontsJan-Marek Glogowski
CppunitTest_editeng_core explicitly request the "Liberation Sans" font. Change-Id: I810bddda26498252985f1869df58610e79ebc5ef Reviewed-on: https://gerrit.libreoffice.org/61658 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-11Add more SAL_INFO("sal.file", ...) calls to trace actual file operationsTor Lillqvist
As we already do SAL_INFO logging for some low-level file operations, surely we should try to do it for all such operations. Change-Id: I252bbb2149c1dc7aaeaa9ea15674e1f87547f249 Reviewed-on: https://gerrit.libreoffice.org/61659 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2018-10-11sw: fix invalid cast in SwEditWin::RequestHelp()Michael Stahl
This results in a garbage OUString. Change-Id: I03b8030a812d7016df5c29f1341749fbdedf1729 Reviewed-on: https://gerrit.libreoffice.org/61652 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-11weld OParameterDialogCaolán McNamara
Change-Id: I46b38a4adb4e1e825918029c7b4aba1d267a6e62 Reviewed-on: https://gerrit.libreoffice.org/61665 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11don't show_all null popoverCaolán McNamara
Change-Id: Id918a413febc39a8f147bd1b65b7204433d91ae1 Reviewed-on: https://gerrit.libreoffice.org/61663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11forward to treeviewCaolán McNamara
Change-Id: Icd0f854ee9480f98684f8254a542b671c12960d1 Reviewed-on: https://gerrit.libreoffice.org/61662 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11Related: tdf#120371 relax tabs on leftCaolán McNamara
Allow on-top if tabs would fit, even when > 6. Some themes have much smaller tabs where more can fit comfortably. Change-Id: Ia9de9059bd5af4de0e6d6a8b8817f87226e2066a Reviewed-on: https://gerrit.libreoffice.org/61661 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11tdf#119065 fix the style of two connected paragraphs.Mark Hung
Invoke ImpConnectParagraphs with bSpecialBackward set to false by default in DeleteLeftOrRight(). Old design connect backward when pressing backspace to connect two paragraphs. The former paragraph of the two ( or the remain one ) adopt the paragraph style ( bullet on/off status, color, etc. ) from the later paragraph. It's hard to understand the intention of the original design, and the design was not activated until LibreOffice6.1, hence just don't connect backward anymore. Change-Id: I3697acc01d718d7a769fb8d0bd573084c4fe2969 Reviewed-on: https://gerrit.libreoffice.org/61537 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-10-11Resolves: tdf#90698 catch list (1;2) of non-references as errorEike Rathke
Change-Id: Icc6f93bbf85df245ba332ce89791a1c8d266b1c6 Reviewed-on: https://gerrit.libreoffice.org/61639 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-11tdf#117721 draw ui: add .uno::SetMinimal[RowHeight|ColumnWidth]Justin Luth
Minimize column width: Adjusts the width of the selected columns to fit the selected content. The table can shrink if necessary, but will not grow. (Previously no way to minimize columns. Since minimizing really can mess up merged cells, enhance my new calcPreferredColumnWidth function.) Minimize row height: Adjusts the height of the selected rows to fit the content, causing the table to shrink. (The new optimize action functioned as minimize. So this change tweaks optimize so that it does not reduce the table size. A followup commit will make it distribute based on largest minimized row (still without reducing table size), and change distributed rows to work the way the document states - based on the largest row. Change-Id: I807a9cc9e9441a1215539e817b87158afe5a0604 Reviewed-on: https://gerrit.libreoffice.org/61472 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-11tdf#111980 oox optionbutton autoGroup inside GroupBoxJustin Luth
The area of a GroupBox indicates which radio buttons are considered to be part of the same group. The button needs to be fully inside of the groupbox in order to participate. This patch resolves the last worry of commit 9f969799629fe6bdf8b922d8cb922846aa646ece Change-Id: Ie6057337c63bf9eb173a0615e30c8d4e4d0c7a19 Reviewed-on: https://gerrit.libreoffice.org/61131 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-11tdf#64242 sw optimal row height, not minimizeJustin Luth
The previous optimal implementation was cloned as a new uno:MinimalColumnWidth function. Optimal should try to keep the table the same size, but ultimately the ideal row/table height will be balanced, so grow to achieve that if necessary. Optimize row height: Adjust the height of the selected rows to match the height of the tallest row in the selection (fit to content), without shrinking the table. This option is the same as minimizing row height and then distributing rows evenly except that it adds the benefit of preventing the table from shrinking. Change-Id: Ib772ae4943127d17a915cdae8cd6000db3a9d164 Reviewed-on: https://gerrit.libreoffice.org/60903 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-11tdf#64242 sw add minimize table col/row UIJustin Luth
A followup commit will modify the optimize functions, which currently function as a minimize, so lets make sure that the ability to minimize is still available. Minimize column width: Adjusts the width of the selected columns to fit the selected content. The table can shrink if necessary, but will not grow. (This is how Optimize column width worked in LO <= 6.1.) Minimize row height: Adjusts the height of the selected rows to fit the content, causing the table to shrink. (This is how Optimize row height worked in LO <= 6.1.) Change-Id: I2c0b8c7b7a05c31328f2feef464ef0e131318ff8 Reviewed-on: https://gerrit.libreoffice.org/60902 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-11xmlsec: replace xmlsec1-vc.patch.1 with backportMiklos Vajna
Change-Id: I2d40b1512420b5601c0ea6db42f319caf7c4170f Reviewed-on: https://gerrit.libreoffice.org/61634 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-11tdf#120478: fix wrong icon when JDBC driver test failsJulien Nabet
Change-Id: I1d96e4a5e091caddf46131385ff5274521844fa9 Reviewed-on: https://gerrit.libreoffice.org/61637 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-11Add support for LXQt as a Linux desktop environment.Simon Quigley
This change makes LXQt use the Breeze icon theme, and adds it as a desktop environment along the other supported DEs. Change-Id: I482d85620986c8fc4e33b4722b887b81c77c23bf Reviewed-on: https://gerrit.libreoffice.org/61641 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-11Avoid error with old ClangStephan Bergmann
<https://ci.libreoffice.org/job/lo_ubsan/1065/console>: > [build CXX] chart2/source/controller/dialogs/tp_Wizard_TitlesAndObjects.cxx > /home/tdf/lode/jenkins/workspace/lo_ubsan/sd/qa/unit/dialogs-test.cxx:430:41: error: default initialization of an object of const type 'const std::vector<OUString>' without a user-provided default constructor > const std::vector<OUString> aPageNames; > ^ > {} > 1 error generated. Change-Id: I543ba3420e1997f21bc2c83c632fbd93ef016459 Reviewed-on: https://gerrit.libreoffice.org/61638 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-11-Werror,-Wdeprecated-declarations (--with-macosx-version-min-required=10.14)Stephan Bergmann
These are all the cases where the warning suggests a direct replacement. This is a companion to 2f2c9df8e270ede0fd71b146380c3883b75d8f0d "-Werror,-Wdeprecated-declarations (--with-macosx-version-min-required=10.14)" which covered all the other cases (via SAL_WNODEPRECATED_PUSH/POP) that offered no direct replacement. Change-Id: If22a3f8cec1ff22fd1ac4b9d2f2bffde50e11e86 Reviewed-on: https://gerrit.libreoffice.org/61633 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-11related tdf#120225 ww8export: save PROTECT_FORMJustin Luth
Change-Id: I20664f8c2dc2c49feec17ee6a1df72776d43cc40 Reviewed-on: https://gerrit.libreoffice.org/61635 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-11tdf#120225 ww8import: keep textform nameJustin Luth
A bookmark cross-reference was trying to access the textform field by name, but an autogenerated __Fieldmark__ name obviously wasn't matching. Change-Id: I1018fecf44fda5d947b214c599f1a405f311e2ee Reviewed-on: https://gerrit.libreoffice.org/61565 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
generated by cgit (git 2.34.1) at 2024-07-20 13:38:04 +0000