summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-04-17loplugin:constparamsNoel Grandin
Change-Id: I3d1b88dbd0ff73fddc08d52f50e0efb42daab89b Reviewed-on: https://gerrit.libreoffice.org/52756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-17Clarify checking o_pbLink directly, versus missing dereferencingStephan Bergmann
But given 18ab7abaa9426cd27092125637fdf5fb849b4a04 "MediaWindow::executeMediaURLDialog: add link button" documents that parameter as "if not 0, this is an 'insert' dialog", it looks plausible that all these places indeed want to check the pointer-to-bool for non-nullness, rather than checking the dereferenced bool. Change-Id: Ifbd5e4b711bee97f3ba0b6aab556f533574d21c6 Reviewed-on: https://gerrit.libreoffice.org/52992 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-17external/firebird: Better workaround for Clang alignment expectationsStephan Bergmann
8ea07101c1613d213fd7cea17f094a947b14cd00 "external/firebird: Work around operator new alignment violations" had misused DEBUG_GDS_ALLOC to work around the problem that recent Clang on Linux x86-64 assumes some storage allocated via Firebird's global operator new replacement to be 16-byte aligned, while Firebird only provides 8-byte alignment. This problem now also appears on macOS x86-64, at least with Apple's Clang version "Apple LLVM version 9.1.0 (clang-902.0.39.1)" from Xcode 9.3 (as well as with recent plain Clang trunk, towards Clang 7), when building --enable- optimized. However, while the DEBUG_GDS_ALLOC hack would still cause ICU_convert_init (workdir/UnpackedTarball/firebird/temp/Release/intl/cv_icu.o) to not use movaps on erroneously assumed to be 16-byte aligned memory, it would cause strange failures on macOS (pos being out of bounds in traRpbList::PopRpb, workdir/UnpackedTarball/firebird/src/jrd/rpb_chain.cpp, in the invocation of isql during the build of external/firebird) that I haven't tracked down further. As it happens, the recently added 14955ed91b282ccbb395cb47c6d76e3b42b34748 "external/firebird: Support Clang ASan" provides a different workaround for the underlying problem that appears to work well on both Linux and macOS x86-64, reusing USE_ASAN also in these cases to shut down most of Firebird's own memory management. I assume that affected Clang are plain Clang >= 4 (as I'd mentioned in my <https://sourceforge.net/p/firebird/mailman/message/35671804/> "Re: [Firebird- devel] alloc.h global operator new replacement violating alignment requirements") and Apple Clang >= 9 (for which __apple_build_version__ is defined). Because DEBUG_GDS_ALLOC is no longer passed in from the outside, its setting in external/firebird/asan.patch can be simplified (cf. commit message of 14955ed91b282ccbb395cb47c6d76e3b42b34748). (The given scenario in ICU_convert_init involves an allocation of 24 bytes, where Clang may or may not be allowed to assume 16-byte alignment, see <http://lists.llvm.org/pipermail/cfe-dev/2018-April/057669.html> "Re: [cfe-dev] operator new alignment assumptions". However, as reported at <https://sourceforge.net/p/firebird/mailman/message/35671750/> "Re: [Firebird- devel] alloc.h global operator new replacement violating alignment requirements", Firebird only supports 8-byte alignment, which would definitely be wrong in a similar scenario where the requested allocation was a multiple of 16 bytes.) Change-Id: I48884f9d008eaeaea369850e24f05b8806f9b676 Reviewed-on: https://gerrit.libreoffice.org/52956 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-17Remove dummy "Support help number" under Windows' "Apps and Features"dennisroczek
section. The OOO_ARPURLINFOABOUTTEMPLATE is simply missleading as the caption in Windows itself is "Supportlink". As the help states that the product homepage can be used, switch to libreoffice.org, see documentation at https://msdn.microsoft.com/en-us/library/aa367752 Additionally switch some links to https. Change-Id: I8d6d871130d2a50a5ce9aa3e80687601e3038c4e Reviewed-on: https://gerrit.libreoffice.org/52193 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-17MoveErrorMarkTo already sets the m_nErrorStart and m_nErrorEndMike Kaganski
Change-Id: I1016a0e6787af7bbf4415356ae565ffc9c1ab0ef Reviewed-on: https://gerrit.libreoffice.org/52967 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-17Updated coreOlivier Hallot
Project: help 49375fa3358ea5bf8cb8ba0f1bf4f5ab0ada40c3 Helpcontent2 housekeeping Deleted spurious file in source/ Change-Id: Ia7417413e615635496398c223a0d95911c994123 Reviewed-on: https://gerrit.libreoffice.org/53012 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-17Updated coreOlivier Hallot
Project: help 22691f35eea6bf031fe271790d9b19093a12f8f4 Fix index in sidebar The last commit of online_transform.xsl instrpduced a bug in index search on the left. This one fixes it. Change-Id: I8055389a324d1fc5fde90ac2b76ff6f0a4a42493 Reviewed-on: https://gerrit.libreoffice.org/53011 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-17tdf#113197 Add MaskPrimitive (clip) to EMF/WMF if neededArmin Le Grand
Added code to quartz vcl implementation that takes care when BitmapPalette.count != (depth^^2)-1 - which may be the case anytime. If then a bitmap value exists that goes beyond that count, a invalid access was executed Change-Id: Iab332c91b8753aab85e9d365323f5c9e531efab2 Reviewed-on: https://gerrit.libreoffice.org/44058 Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-16Fix typosAndrea Gelmini
Change-Id: Ife28cd9399cfcb375bad764dac7424eda50d430d Reviewed-on: https://gerrit.libreoffice.org/52198 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-04-16sd lok: Impress: Right-click menu on misspelled word locks up sessionTamás Zolnai
Change-Id: Ib554eea7049c1ea244bc4789ee3d7d2adf87e283 Reviewed-on: https://gerrit.libreoffice.org/52977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-04-16tdf#113624 EMF+ Add support for different units conversionBartosz Kosiorek
With previous implementation only Pixel unit was supported. Other units (eg. inch, milimeters, points, world) was treated as Pixel. With this patch the correct unit conversion was implemented to following records: - FontObject - PenObject - SetWorldTransform As a result records are properly scaled. Tested with DrawString record from: https://bugs.documentfoundation.org/attachment.cgi?id=140287 Change-Id: I77435ad8f1bbac08f298a03d91d0c7f1f1734e5c Reviewed-on: https://gerrit.libreoffice.org/52699 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-04-16tdf#55058 Properly close shapes with close shape method.Bartosz Kosiorek
With previous implementation of closing shapes, we are adding new line between last and first point. It was causing wrong border shape during displaying. With this patch proper method was used to fix that. Change-Id: If0a084700401edd9d3b8a57cb27154079828e6ed Reviewed-on: https://gerrit.libreoffice.org/52843 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Patrick Jaap <patrick.jaap@tu-dresden.de> Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2018-04-16Defer grammar checker thread creation until use.Michael Meeks
Avoid this thread being started and stranded in the forkit. Change-Id: Ia79cdac729a85960c2b5a83af265d67af07b74aa Reviewed-on: https://gerrit.libreoffice.org/52980 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-04-16tdf#117034 right click crashCaolán McNamara
Change-Id: I91aa9f24904948987f31c9df5211c694f943188e Reviewed-on: https://gerrit.libreoffice.org/52976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-16sal_uInt16 -> sal_Int32Mike Kaganski
Change-Id: I756206aacabe53d85b7a6f397bf08abd5892ca76 Reviewed-on: https://gerrit.libreoffice.org/52969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-16Take care of E3DObjListArmin Le Grand
E3DObjList is not needed, remove. Remove memeber from E3DObject, derive E3DScene directly from SdrObjList, some cleanups in SdrObject, too Change-Id: Ifa4620a800c14faf21f8b80fd4dc1d39f71be804 Reviewed-on: https://gerrit.libreoffice.org/52740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-04-16weld SwInsFootNoteDlgCaolán McNamara
Change-Id: I54849e2336d093e9044d4b32275387fa04e3bab9 Reviewed-on: https://gerrit.libreoffice.org/52963 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-16missing mnemonicsCaolán McNamara
Change-Id: I0e28cbd915cd65489965eab6fa35be50de364b13 Reviewed-on: https://gerrit.libreoffice.org/52965 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-16tdf#78777 - Keyboard shortcut for number formatting on macOSheiko tietze
Shortcuts moved from MOD2 to MOD3 Change-Id: I5e038916b7c607b7cae06a297f57f7c75b790c4c Reviewed-on: https://gerrit.libreoffice.org/52966 Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-16tdf#37074 - Customization of MOD3 missing on macOSHeiko Tietze
Shortcuts added likewise for MOD1 Change-Id: I506897500b4e22349aecdf5231e80c84a0f3a878 Reviewed-on: https://gerrit.libreoffice.org/52964 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-04-16tdf#117033 - Tooltips show the wrong symbol for MOD3 combinationsheiko tietze
Symbol for MOD3 added Change-Id: Idb76199fbff240fe39c96ed837db098a4283d70b Reviewed-on: https://gerrit.libreoffice.org/52957 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-16Use different properties in Upgrade tableMike Kaganski
Change-Id: I7e2cc08a1312da629e4644be97ebc7ed40250702 Reviewed-on: https://gerrit.libreoffice.org/52995 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-16-Werror,-Wunused-variableStephan Bergmann
Change-Id: Iefddde5ceb37e4489222dec1114110e587cccdaf
2018-04-16-Werror,-Wunused-variableStephan Bergmann
Change-Id: I7b3a350d12c10d61a75ab6b2061da3b6926696cb
2018-04-16Nitpick: a pointer is p...Eike Rathke
Change-Id: I14a9fd8eb794fb23271174b83910deca58f6607a
2018-04-16Resolves: tdf#116003 check presence of subtotal in group, tdf#107267 follow-upEike Rathke
Change-Id: Ifed6e28926c689dd17914b8b1cbf47b58e2ffcdc
2018-04-16Updated coreSophia Schröder
Project: help 7809c5f562f2adb28f36f3f5625e757f238a8d5f Help Files Cleanups Remove newly introduced double space Change-Id: I339d42f6a0305d5381f5d045cefc51cf30c0f125 Reviewed-on: https://gerrit.libreoffice.org/52539 Reviewed-by: Sophia Schröder <sophia.schroeder@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-16Use https instead of httpGulsah Kose
Use "https://cgit.freedesktop.org/libreoffice/core" instead of "http://cgit.freedesktop.org/libreoffice/core" Change-Id: Ic7248eeb2a9452da7236eeee08414a77714dd234 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/52926 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-04-16weld SvxPostItDialogCaolán McNamara
Change-Id: I0aa88270aa604180223f2b35829b45e5828f792a Reviewed-on: https://gerrit.libreoffice.org/52896 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-16Fix --enable-qt5Stephan Bergmann
...after b36ea44dcbdb862b0ac6e6cdaf27225b43dc0c7e "push logic from ImpBitmap::ImplReleaseBuffer down" Change-Id: I781a79146880686b2396e783da6ed2d1304c7e38
2018-04-16Revert "sw-table-join-fix-i99267.diff:"Michael Stahl
This reverts commit 6b1204329ad365a46214472bcff335e63c51bdf4. The comment has nothing to do with the code around it, and it turns out the commit is utter nonsense: The actual intended change was done in CWS sw32bf02 at a different place in SwTabFrame::MakeAll(), see commit 4439427aadeaa0cb611011b46f0fa14bfa196f33. This was then apparently extracted as a patch and added to ooo-build: https://cgit.freedesktop.org/libreoffice/build/commit/?id=d33db589f6e7814df84f71506539f6f89448d9fd And then there was a rebase on top of a DEV300 that includes the CWS and that moved the patch to apply in this incorrect location: https://cgit.freedesktop.org/libreoffice/build/commit/?id=d91410b81a02ce9b970ebd838fda0b28f6d8a5f8 Change-Id: I89db4ea0d1b06450c8fd8618cc824612e225fffe Reviewed-on: https://gerrit.libreoffice.org/52945 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-04-16rename ImpBitmap methodsNoel Grandin
to match underlying SalBitmap methods, in preparation for getting rid of ImpBitmap Change-Id: I14200ef53b1fdb8c1fa94d7d09319187cdfb3996 Reviewed-on: https://gerrit.libreoffice.org/52949 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-16Updated coreStanislav Horacek
Project: help 1a61eb0cdbba234e1da0a98a097b9d894557ad68 fix menu path to Page Setup dialog in Impress and Draw Change-Id: I43d6427f549f4d4e355b3caf1d05102c2222cba7 Reviewed-on: https://gerrit.libreoffice.org/52918 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-16Resolves: tdf#116999 fix reading cgm text at record boundsCaolán McNamara
Change-Id: Ibbff7b0a3c3447135e0f6c585914dc6018e51765 Reviewed-on: https://gerrit.libreoffice.org/52951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-16Updated coredennisroczek
Project: help b7ecf6294f9caa8454ebcc9c2d6f33ac64ff9e78 replace http links with https equivalents * mainly http://wiki.documentfoundation.org * http://en.wikipedia.org * http://api.libreoffice.org Change-Id: I3587d8d5e6a6de4a7c7013920b9e135e4adc977c Reviewed-on: https://gerrit.libreoffice.org/52354 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-16Updated coreOlivier Hallot
Project: help d5ca87f12819b669646bb6f0978f79ebb5d3f035 tdf#116150 Review XHP <switch> style transform implement <switch> and <switchinline> with HTML and Javascript, for 'sys' and 'appl'. Change-Id: I6056e787146bb92617c2ce639acab16d16d6f765 Reviewed-on: https://gerrit.libreoffice.org/52929 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-04-16More -Werror,-Wreturn-std-moveStephan Bergmann
Change-Id: I21eeabf94c29d6eb67c18baf8cc3ed8f52903710
2018-04-16More -Werror,-Wreturn-std-moveStephan Bergmann
Change-Id: I3d5be4c140e79c019dfc0c577bc57a63207df722
2018-04-16NB Calc: update tabbed notebookbarandreas kainz
Change-Id: I44cf1195a6e202c993a39e53249120b44b866f3d Reviewed-on: https://gerrit.libreoffice.org/52943 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-16Resolves: tdf#116138 insert special char problem in chapter numberingCaolán McNamara
Change-Id: If79d23d7c5e99a88d0026295db002c25c1b07ff3 Reviewed-on: https://gerrit.libreoffice.org/52942 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-04-16rename ImpBitmap::ImplConvert to ConvertToGreyscaleNoel Grandin
in preparation for removing ImpBitmap Change-Id: I1d56f2a4698559e3ff3b321577c29272ab050482 Reviewed-on: https://gerrit.libreoffice.org/52940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-16push logic from ImpBitmap::ImplReleaseBuffer downNoel Grandin
in preparation for removing ImpBitmap Change-Id: Icae48c081d821518103d08a7b62bcb4d64654c35 Reviewed-on: https://gerrit.libreoffice.org/52939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-16tdf#117028 sw: conditionally consider fill of shape for in-textbox auto colorMiklos Vajna
Commit f966767e1ccfa432da33e1a0fd6de69e17a36bc3 (tdf#116925 sw: consider fill styles of shape for in-textbox auto color, 2018-04-10) did this unconditionally, but there are two cases: 1) Shape (with textbox) has a fill, in that case auto text color of textbox should consider the shape fill. 2) Shape has no fill, in that case the shape fill should not be considered when counting the background of a transparent fly frame. Fix 2) without breaking 1) by making the change to SwFrame::GetBackgroundBrush() opt-in, and only use it for auto font color, not in other cases. Change-Id: I761a1b7d6ecf47586edbe5641ec012f22f6a53d7 Reviewed-on: https://gerrit.libreoffice.org/52941 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-04-16Pass gb_SYMBOL into external/firebirdStephan Bergmann
Change-Id: I91e68dfe770aaa906abac107c3e56bc5e4782512 Reviewed-on: https://gerrit.libreoffice.org/52937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-04-16NB Implementation: show menubar in NBShortcutsandreas kainz
Change-Id: I44acbdd96a7ede1fc89bbafbd1eb7c5bf25fc193 Reviewed-on: https://gerrit.libreoffice.org/52936 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-04-16follow on for tdf#116981Noel Grandin
the previous commit 235d61890512894e27f4f81e38a325eee3c67b30, fixed just exactly the problem reported in tdf#116981. This commit fixes similar issues that may exist elsewhere. To recap, this started as a regression from commit 433fc2214c980abd82fa6240f45e634a53a3c61c (patch) sal_uIntPtr->sal_Int32 in MultiSelection Previously, MultiSelection stored it's values internally as sal_uIntPtr, but returned them as long in FirstSelected(), NextSelected(), and SFX_ENDOFSELECTION was defined to be ULONG_MAX. On 64-bit Linux, sal_uIntPtr is typedefed to sal_uInt64, and ULONG_MAX is 2^64, which means that previously, the SFX_ENDOFSELECTION value was being converted from 2^64 to -2^63 when it was returned, which was why these loop worked. So convert SFX_ENDOFSELECTION to SAL_MIN_INT32, so we get a large negative value which can never be a valid index, and which works more like it did before the regression. Also fix as many loops as I can find, to check against SFX_ENDOFSELECTION explicitly. Change-Id: I947d43dbe23a08105be3d849e33d7e774a8a19fa Reviewed-on: https://gerrit.libreoffice.org/52934 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-04-1632-bit installer must search both for 32- and 64-bit redistMike Kaganski
Change-Id: I343b731878c5ebbe61dc8b01fecf3be36b9a35c3 Reviewed-on: https://gerrit.libreoffice.org/52933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-04-16tdf#42949 Remove unnecessary localization headers from scGabor Kelemen
Found by searching for the header names and the localization function: git grep -l -e \<scresid.hxx\> -e \<strings.hrc\> sc | xargs grep -c ScResId | grep :0$ | grep -v /pch and git grep -l -e \<globstr.hrc\> sc | xargs grep -c GetRscString | grep :0$ | grep -v /pch since global.hxx contains so much more, it's omitted from this round. This also gives some false positives used in ErrorMessage() calls or just untranslated strings. Also translate some stray German comments Change-Id: Icfea2b2942d12c3c134d419cb7c9a84534c04a86 Reviewed-on: https://gerrit.libreoffice.org/52932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-04-16-Werror,-Wreturn-std-move (recent Clang trunk)Stephan Bergmann
An explicit std::move would be needed in the return statements, as there's a conversion from VclPtrInstance to base class VclPtr involved. One more reason to better get rid of VclPtrInstance completely in favor of VclPtr::Create, as already mentioned in <https://lists.freedesktop.org/archives/libreoffice/2017-May/077756.html> "VclPtr some improvements ?" Change-Id: Id96a58b425749b9be07b422bb4161a3af864ff6c
2018-04-16tdf#116486 Consider upper margin in paragraph positioning with flysPatrick Jaap
The problem was the following: There is a paragraph with an upper margin defined. Also, there is a flyframe intersecting this upper margin. The desired behavior is to reposition the parapgraph, such that it (including it's upper margin) is located below the flyframe. This patch increases the bounding rectangle of the paragraph by the upper margin. For compatibility, there is a compat-flag query. I re-used a related one. Change-Id: I9dbc75e07e2ba0658fdbbfa9989be24a68660713 Reviewed-on: https://gerrit.libreoffice.org/52685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-01 13:47:21 +0000