summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-02Fix typosAndrea Gelmini
Change-Id: Ie183c445bf8a545f59aac7b0e29f72ab679a6cf3 Reviewed-on: https://gerrit.libreoffice.org/76852 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-02Revert "fix some accessibility warnings"Noel Grandin
This reverts commit 885ae69174cf717edd00526e5cf8f1585c505c95. <caolan> noel_grandin, wrt the accessibility labelled-by and label-for. If the label really is a GtkLabel then setting its mnemonic target (in glade, general tab, and use underline and select a target) is the most straight forward thing to do and implies those a11y relations <caolan> the painful manual a11y labelled-by/label-for are typically for using something weird, like a checkbutton, as a label for something Change-Id: I13db8ec65d10248aa46cb6b01398ec302dd06b59 Reviewed-on: https://gerrit.libreoffice.org/76837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-02weld OGeneralSpecialJDBCConnectionPageSetupCaolán McNamara
Change-Id: Ie4c2a34127a79d290105f0f032b4edf22d5871cd Reviewed-on: https://gerrit.libreoffice.org/76838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02build fails with libxmlsec version 1.2.27Lionel Elie Mamane
Due to indirect inclusion of C++ headers in scope of an 'extern "C"'. Possibly it works with version 1.2.24 to 1.2.26. Change-Id: I12bd43b51b1cf829bfe91d4ab1eb5470b86ec18e Reviewed-on: https://gerrit.libreoffice.org/75349 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-02Fix typosAndrea Gelmini
Change-Id: I3d1dd03022eb37609ee0dd62c4ee9cec93ac0717 Reviewed-on: https://gerrit.libreoffice.org/76813 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-02tdf#123702 RTF/DOCX default 1" left/right page marginsLászló Németh
since MSO 2007: now 1440 twips = 2540 1/100 mm (it was 1800 twips = 3175 1/100 mm). Changing the default value fixes the layout of the documents based on RTF templates without explicit margins. Change-Id: I0395fb7cdd6ba176f266c8f0a9309ba48a047da3 Reviewed-on: https://gerrit.libreoffice.org/76812 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-02fix some accessibility warningsNoel Grandin
Change-Id: I18f9a71ac4e2ef5c159e13bc3cb0e36cf7c550a5 Reviewed-on: https://gerrit.libreoffice.org/76834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-02weld OAuthentificationPageSetupCaolán McNamara
Change-Id: Ib5de669f22abeaae3716918702066ce608910874 Reviewed-on: https://gerrit.libreoffice.org/76830 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02DrawButtonFlags::NoText never setCaolán McNamara
Change-Id: I23531adc0798ec4a97538a8002ba0866535677a3 Reviewed-on: https://gerrit.libreoffice.org/76829 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02DrawButtonFlags::NoImage never setCaolán McNamara
Change-Id: I7ad7dbadad3bff1fe60b4aa9950bf1ec6a902835 Reviewed-on: https://gerrit.libreoffice.org/76828 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02tdf#126243 DOCX change tracking: pStyle needs simplified style idLászló Németh
in reject data to import style names correctly in MSO, too. Change-Id: I1cf346eaf36f6d949ea7abf9d9af3bae85c7ce0e Reviewed-on: https://gerrit.libreoffice.org/76799 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2019-08-02sw btlr writing mode: RTF filter of Writer tbrl textframesMiklos Vajna
Fix both import and export. Values 1 and 3 seems to be the same. Accept both on import, but write 3, as DOCX only has a single value and Word uses 3 when doing DOCX->RTF conversion. Change-Id: Ic5420091ffee9eb20c6aaac61a127e93289aa9fe Reviewed-on: https://gerrit.libreoffice.org/76823 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-02-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: Icdb749d46249ea29badbe523320b17312e077684 Reviewed-on: https://gerrit.libreoffice.org/76811 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-02Fix typosAndrea Gelmini
Change-Id: Ic7b6014e09e3ee1a1b4917008a267b8fa2dbc1f5 Reviewed-on: https://gerrit.libreoffice.org/76814 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-02tdf#126643: avoid unnecessary asking for JRE in script organizer dialogMike Kaganski
Use two-pass search for the needed language node; if it fails with Java interaction disabled, only then repeat the search with it enabled, like in commit f3ce30ec75a4d7116b9cd4d7b21d9aaa0e237eeb. Change-Id: Icde5dbeb552a6837af02182f7b8cbbc90765c5a5 Reviewed-on: https://gerrit.libreoffice.org/76831 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-01Make QR Code callable in calc and writerShubham Goyal
Change-Id: I73793100478c34a7721821cec1f8ccec0174d20c Reviewed-on: https://gerrit.libreoffice.org/74598 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-08-01Fix typosAndrea Gelmini
Change-Id: I2238961a7b124652e90e948e27a6ca9d98dc54ac Reviewed-on: https://gerrit.libreoffice.org/76826 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-01drop newly unused EnableImageDisplay + EnableTextDisplayCaolán McNamara
Change-Id: I534c5fcfe2e8b55d0f01075b62e7168a10e805a9 Reviewed-on: https://gerrit.libreoffice.org/76819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OMySQLIntroPageSetupCaolán McNamara
Change-Id: I8378860bfc5cb087b5c04a73e99965afdee4c23f Reviewed-on: https://gerrit.libreoffice.org/76822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01some missed vcl::Window->TabPageParent opportunitiesCaolán McNamara
Change-Id: Ie5e66723ad497f927bc26bbe01c8194712455caf Reviewed-on: https://gerrit.libreoffice.org/76821 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OFinalDBPageSetupCaolán McNamara
Change-Id: Ie05e086c393ef6572c92e7c4975b1c9dd9e3ad48 Reviewed-on: https://gerrit.libreoffice.org/76818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld OGeneralPage and OGeneralPageWizardCaolán McNamara
Change-Id: I7caa08a5e060371c9b80ff83b141c27af09246bf Reviewed-on: https://gerrit.libreoffice.org/76817 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01no point in using a map anymoreCaolán McNamara
seeing as we want alphabetical sort now, there's no point in calling GetLineRange and using a map and only need to set the widget as sorted in the ctor, it remains always sorted Change-Id: Ieb5e5c8d9e36375a723376b0009062d6313c8779 Reviewed-on: https://gerrit.libreoffice.org/76810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01Resolves: tdf#126661 unexpected sort between freeze+thawCaolán McNamara
Change-Id: Ibb6b404d32e38c72fb1ff4be73f3a5f116d55692 Reviewed-on: https://gerrit.libreoffice.org/76809 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01sort outside thawCaolán McNamara
Change-Id: Ifafae5f4ddba816ef3b11d4babd54ae6495a487f Reviewed-on: https://gerrit.libreoffice.org/76816 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01Resolves: tdf#126282 add English (Sri Lanka) [en-LK] locale dataEike Rathke
Change-Id: I0a678a3599c43e5158c843d7781a0f55a3b03261 Reviewed-on: https://gerrit.libreoffice.org/76808 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-08-01tdf#126282 add English (Sri Lanka) [en-LK] 0xA409 to language listEike Rathke
Change-Id: I2b02498684c952f9a6bf8f6bc17a3355c3607aac Reviewed-on: https://gerrit.libreoffice.org/76807 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-08-01remove some resolved ui suppressionsNoel Grandin
and enhance the script to make finding the unused ones easier Change-Id: I937246e98d93fb999a23f2283b6794eaaa6dfa99 Reviewed-on: https://gerrit.libreoffice.org/76806 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01skip some indirectionNoel Grandin
these don't need to use std::unique_ptr Change-Id: I03140c7957fd59443db932c37890a6742c6d3bec Reviewed-on: https://gerrit.libreoffice.org/76800 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01tdf#126544 writerfilter: check parent style exists before assigningJustin Luth
If you set the parent style to a style that is not yet created, then it silently fails, and thus inherits from nothing! Change-Id: Ibb85235643dd5b1eb9b0bd43f701580f24b2b7fa Reviewed-on: https://gerrit.libreoffice.org/76805 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-08-01sw comments on frames: improve doc coordinates -> doc model pos conversionMiklos Vajna
In case an as-char image at the end of a paragraph was commented and the user clicked past the end of the paragraph, we defaulted to extending that comment, rather appending content. (The cursor was placed between the as-char image and the comment anchor, not past the comment anchor.) This doesn't seem to be useful, probably the expectation is that if the user clicks before the comment anchor then we extend the comment range, and if the click is after the comment anchor, then we don't. In both cases we used to *select* the comment anchor, so typing a character deleted the comment instead. This commit is a step in the direction of never selecting the comment anchor: now if you click past the comment anchor, then we place the cursor after the comment anchor. (But clicking before the comment anchor results in unchanged behavior for now.) Change-Id: I6c36ec4344591fdf330a73bcd3cdd6fd0610e339 Reviewed-on: https://gerrit.libreoffice.org/76803 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-01clean up ViewCallback nicely in sw and sdNoel Grandin
Change-Id: I471768083e46b43df37b500bb51dfa13a1b54b75 Reviewed-on: https://gerrit.libreoffice.org/76797 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-08-01weld SvxDefaultColorOptPageCaolán McNamara
Change-Id: I5741ee4d0df724e9f1df72ce668f9f2e53541280 Reviewed-on: https://gerrit.libreoffice.org/76802 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01Resolves: tdf#126496 - "Page Fields" in pivot table unclearHeiko Tietze
Renamed to Filters Change-Id: I512a06830635a8b6c62ca8a0ad64683f9824b9e0 Reviewed-on: https://gerrit.libreoffice.org/76777 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-08-01remove unnecessary code in doc_registerCallbackNoel Grandin
after commit 98c0cefb18d8af7aa4732708ba0ae6be2e808d6f Date: Wed Jul 31 12:40:29 2019 +0200 desktop: fix UB in DesktopLOKTest::testCommentsCallbacksWriter() Change-Id: I254d8413e707d4525efbfb2050e5b29f70c4bed7 Reviewed-on: https://gerrit.libreoffice.org/76796 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01drop some resolved ui suppressionsCaolán McNamara
Change-Id: Ie717e13ba703149ab563c3930d5174fdd5e5d6c7 Reviewed-on: https://gerrit.libreoffice.org/76794 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#126623 Correct URL for Mysql JDBC page Change-Id: I326e123ec446aa818c0761ed172f2c4cfd09bbd0 Reviewed-on: https://gerrit.libreoffice.org/76801 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-08-01drop newly unused OptHeaderTabListBoxCaolán McNamara
Change-Id: I08926e91a61e7bdd4de4ac96083e970268801d6f Reviewed-on: https://gerrit.libreoffice.org/76789 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01weld SvxPathTabPageCaolán McNamara
Change-Id: If9b982d9e73adbb55e940ae12e5d894dd803f7f3 Reviewed-on: https://gerrit.libreoffice.org/76788 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01should toggle all others to false, not trueCaolán McNamara
regression since... commit 5c32ba63163d9556ff89782a8074924cdf9dc554 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Apr 4 14:30:03 2019 +0100 weld OTableSubscriptionPage Change-Id: Iec3bec1b49af3e60b80301665ff3834f24f72222 Reviewed-on: https://gerrit.libreoffice.org/76787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-01tdf#126641: don't fail on file URLs with fragmentMike Kaganski
This only fixes part that the URL refuses to open the target file. Honoring fragment isn't fixed here, since it's the system call to ShellExecuteExW that in this case internally converts the file URL into a system path, and strips the fragment from it. Regression from commit d59ec4cd1660410fa1b18c50d2d83b1417a82ddc. Change-Id: I6c9ed27e9a5bd7f2780dd3be96f816a6e825e043 Reviewed-on: https://gerrit.libreoffice.org/76778 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-01missing includeStephan Bergmann
Change-Id: I9c3d551d2053b53bde3b032036bc531a02217300 Reviewed-on: https://gerrit.libreoffice.org/76782 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-01tdf#126168: sw undo/redo crash fixedVasily Melenchuk
After undo of style creation we have a dangling pointers to deleted style in SwUndoSetFlyFormat. So instead of keeping pointers to SwFrameFormat which can be invalidated, we could keep style name and find style by name. Change-Id: I9a60d6b3311278d7391d676010c31c862189fd08 Reviewed-on: https://gerrit.libreoffice.org/76351 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Jenkins
2019-08-01Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Update page with video on 6.3 New Features Change-Id: If9819fc8a3c324f3c4a5d6acff9f5edab3a69833 Reviewed-on: https://gerrit.libreoffice.org/76795 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-08-01Notify the client when we close the sidebarAshod Nakashian
Reviewed-on: https://gerrit.libreoffice.org/71844 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 60c048e665c7e8dc32c378f0364931b6e26a9ca2) Change-Id: I4879d65285e01cf2fd99233d226f4201997b4dd7 Reviewed-on: https://gerrit.libreoffice.org/76784 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01Silence -Wunused-function on AndroidMike Kaganski
after commit bf6bde2da134dad60ecbf8f3e97674abadb7349e Change-Id: Iaf6f1457f95e5b821879b735c16a692cca7515db Reviewed-on: https://gerrit.libreoffice.org/76791 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-08-01clean up ViewCallback nicelyNoel Grandin
Change-Id: Idb882460092642bc77804560cd8fd6432a590323 Reviewed-on: https://gerrit.libreoffice.org/76776 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01LOK: support sidebars in writer and calcAshod Nakashian
[ Miklos: added code to release LOK notifiers in SfxWorkWindow::DeleteControllers_Impl() during shutdown. ] Reviewed-on: https://gerrit.libreoffice.org/71843 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 5ddf630222241bec4deda56d10992c35ae4efe06) Change-Id: I3a3bd1fb6922e435599f604328f558be60594729 Reviewed-on: https://gerrit.libreoffice.org/76556 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-08-01mysqlc: Add test for textual blob typesTamas Bunth
Test setting and querying the following data types: TINYTEXT, TEXT, MEDIUMTEXT, LONGTEXT Test them using prepared statements. Change-Id: I43387034ad8c32c3731cde70a22cc8b3dd652b78 Reviewed-on: https://gerrit.libreoffice.org/76747 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2019-08-01Unify some code across platforms to use static initializersMike Kaganski
Static initializers were used for the environment strings since commit d19c40f45dc8e8bcd9db4c6b83bdcf6367f6fbe7 to workaround thread-unsafe getenv. The special case for Android was initially introduced in commit 60628799633ffde502cb105b98d3f254f93115aa, to allow modifying the environment in the code; then was fixed in commit 4fbf6df784529d48cf194a2d9c495ffb47933d59. That was relying on the functions being called each time their results were used. But commit 9f027559557cb132835d8a13cdc0281ad4e757ae changed that, making the results static, thus only calling the functions once on all platforms. This was effective more than a year already, so presumably the special-casing for Android isn't needed anymore. Thus, this patch unifies all platforms to use the same approach (calling getenv once, storing copies of result in static variables. Also this stores flags used in maybeOutputTimestamp to static variables, too, to avoid parsing strings each time the function is called. Change-Id: I84bdbfb900c15b407fb555296d2613bd3d62da7e Reviewed-on: https://gerrit.libreoffice.org/76573 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-12 03:30:09 +0000