summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-08-03Fix typosAndrea Gelmini
Change-Id: Iaf2691b60796300f6c3acf56f60dcc526685eeb9 Reviewed-on: https://gerrit.libreoffice.org/76855 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-03Fix typosAndrea Gelmini
Change-Id: I5c95e180681220fc592400435d90e4d46603d41c Reviewed-on: https://gerrit.libreoffice.org/76883 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-02calc: simplify getDocumentSize calculation.Michael Meeks
Change-Id: Iee2ebf2c6ed74651556647264f519caa9c59dad7 Reviewed-on: https://gerrit.libreoffice.org/76492 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-08-02clipboard: add profile zones.Michael Meeks
Change-Id: I2c005e78884fbe35c3045f76c203a7a369e97646 Reviewed-on: https://gerrit.libreoffice.org/76885 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-08-02clipboard: elide string constructor.Michael Meeks
Change-Id: I1f476d981989296138ab9b9b58075919da4c09b8
2019-08-02clipboard: elide string constructor.Michael Meeks
Change-Id: I18c01e77e0ddf4b86f2f5ba610509555160f96c3
2019-08-02XTransferable2 - add missing 'since' tag on isComplex.Michael Meeks
Change-Id: Ib8165edb4d87fb5bbb115fe26b8dbbe5a70bd59a
2019-08-02Removed duplicated includeAndrea Gelmini
Change-Id: Ic54fab581f34f385f5a6395bb39020299fbf2bde Reviewed-on: https://gerrit.libreoffice.org/76882 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-08-02Use implicit OString constructor and cleanup casts.Michael Meeks
Change-Id: I686c32d3666bceb23dd86a4220428fa319ffdf45
2019-08-02clipboard: repair unit test so that it runs in the lok mode.Michael Meeks
SwTransferable::AddSupportedFormats needs the kit to be active. Change-Id: Id84210eb2e526785f35dfae609d861c310885314
2019-08-02clipboard: log before erasingAshod Nakashian
Change-Id: I6d59cdd31c62bbc7db81ccb8985745f68d19cd28
2019-08-02clipboard: check for null.Michael Meeks
Change-Id: I07060035a9744642c98d4a0946695408dc0f6b42
2019-08-02lok: share more of the clipboard mime-type handling code.Michael Meeks
Change-Id: I98fc9fa0fd1b5afa00c33b642d2d504eab0b62ba
2019-08-02clipboard: encourage paste to show up by having some dummy content.Michael Meeks
Having an empty system clipboard is a hyper-unusual state, but this is quite common for new lok instances. If we populate some dummy state we can hide that. Allows context-menu paste into new documents. Change-Id: Ia180dd370c180d2d666cc57330db6c1385578a36
2019-08-02Try harder to generate HTML from text.Michael Meeks
Change-Id: I5b4778cceefc652274a72b779cd6c060a50bf06c
2019-08-02lok: minimal implementation of isComplex for calc for now.Michael Meeks
Change-Id: Ic4141d30a0ff48a9ec5ecc8e6119d9d779c4a0fc
2019-08-02lok: vital to quote nested JSON inserted into a json property.Michael Meeks
Somehow this managed to work fine in most browsers, but when the Kit/Poco tried to parse JSON to extract viewID it could explode. Change-Id: I39d2ecc9ee95b7e6f67a23c8b15f9a1d01769ddc
2019-08-02Set clipboard for a window when createdSzymon Kłos
This allows to paste in dialogs input using tunneled context menu. Change-Id: Ie6cc6f1a6cd453734c8f6084b0bd50d1d7ab6c09
2019-08-02LOK: Copy Graphics as embedded PNG in HTMLAshod Nakashian
Change-Id: Id8c14d7304d30bfcd956b126dfe291ef044f62bf
2019-08-02lok: cleanup clipboards associated with a view on destruction.Michael Meeks
Also defer destruction potentially indefinitely for bad users who quit without destroying views, documents, shutting down nicely etc. Change-Id: Ieea6ad00b2983d372b745179bfe3b884c3c64eb0
2019-08-02LOK: Improved selection complexity detectionAshod Nakashian
Only Graphics and OLE now unconditionally trigger 'complex' case, and for all others, we actually tally the number of text characters. Currently anything above 512KB is flagged as 'complex'. Change-Id: I19fbef72f2eb725648b2a18c1ee41b1612d2bac0
2019-08-02LOK: Enable embedding images in text/html format outputAshod Nakashian
Change-Id: Ibd8bed796678ee26de2ceb6e434dce24da4eab05
2019-08-02LOK: detect Graphics in isComplex for WriterAshod Nakashian
Change-Id: I814d71a21fa5352a9a1051f5477cb452a0dc5c2f
2019-08-02LOK: Implement getSelectionTypeAshod Nakashian
Detects all complex scenarios, except for Graphics. DesktopLOKTest::testComplexSelection() has commented out check that currently fails due to the missing detection of Graphics nodes. Change-Id: Ifce17192d26daba218d2c3d38577cccec0699e99
2019-08-02clipboard: get view setting correct before setClipboard.Michael Meeks
Change-Id: If8e9b057b819074f035c598569e3bf6d3d2fff00
2019-08-02lok: clipboard: per view clipboard creation.Michael Meeks
A bit brutal, but the mess around clipboard instantiation is awful. Change-Id: I62d6af8bf6813e6bab81123417ea8bfb28394e29
2019-08-02lok: clipboard: per view clipboard creation.Michael Meeks
A bit brutal, but the mess around clipboard instantiation is awful. Change-Id: I62d6af8bf6813e6bab81123417ea8bfb28394e29
2019-08-02build fix: missing #include <ndgrf.hxx>Andras Timar
Change-Id: I72caa16d3c5b5698226cc7d3f07d3d32820032d8
2019-08-02Fix build: unused argumentSzymon Kłos
Change-Id: Id79d9c093da21b9f68bb38a51ac5f142a69364ed
2019-08-02LOK: Support detecting complex selectionsAshod Nakashian
Includes unit-test, but is otherwise not complete implementation. Change-Id: I5fdcd543358caab1858f6351238c21312665839c
2019-08-02lok: use utf-8 for text/plain always.Michael Meeks
Change-Id: Ie91f89b3dc6ba3eddcf8383948dddc7878eae4d8
2019-08-02Add more powerful selection fetch & clipboard set methods.Michael Meeks
Change-Id: I6633356d13480377a83a006588ec69ebcb56a93f
2019-08-02Avoid odd crash where OLE object can't generate an image preview.Michael Meeks
Change-Id: Ib77eca6907aa09383a96f3c9de6f7a7c4799c3bc
2019-08-02lok: disable calc char-set dialog for HTML when pasting.Michael Meeks
Change-Id: I3ec9e98549d06ae3e6b4ede89215a5137d01ccab
2019-08-02lok: don't be prejudiced against a single missing mime-type.Michael Meeks
Change-Id: Ic5004c306cbd01071c397ed1a61ef094b439a48f
2019-08-02weld OGeneralPageDialogCaolán McNamara
Change-Id: I1a5342f9f009234b2c8b1231155a11c9283c4ec8 Reviewed-on: https://gerrit.libreoffice.org/76856 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02sw comments on frames: no overlay in the LOK API, either: insert caseMiklos Vajna
This is similar to commit 28fcb7d86765194b4015e7023449333f43aba0c5 (sw comments on frames: no overlay in the LOK API, either, 2019-07-16), but that one handled the initial fetch of comment states, while this one does the incremental updates. With this, there is no overlay on commented images right after inserting them. Change-Id: I060303806a6611b113b4813300ed1cafd0b654fa Reviewed-on: https://gerrit.libreoffice.org/76859 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-08-02Fix typoAndrea Gelmini
Change-Id: Idaaec17114aa2b03c00da075f5accc4c0c0e69b4 Reviewed-on: https://gerrit.libreoffice.org/75768 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-02dispose MySQLNativePageCaolán McNamara
Change-Id: I2506d08b8c2e5b501bccb8b5ef2e6d829a912852 Reviewed-on: https://gerrit.libreoffice.org/76854 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02remove newly unused OGenericAdministrationPage ctorCaolán McNamara
Change-Id: Ibb1353e5b14648253cb455664693271fd4482c51 Reviewed-on: https://gerrit.libreoffice.org/76850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop some newly unused functionsCaolán McNamara
Change-Id: I2ee32a9fdac6ff85927a5755ce341a591a462544 Reviewed-on: https://gerrit.libreoffice.org/76849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02void* -> weld::Widget*Caolán McNamara
Change-Id: I1341fa27fd184ff1302b867aea6c215c22fb477d Reviewed-on: https://gerrit.libreoffice.org/76847 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02rename DBMySQLNativeSettings back to MySQLNativeSettingsCaolán McNamara
Change-Id: I00d6de729a1d650d479663b6e1d05f8087e7fe9a Reviewed-on: https://gerrit.libreoffice.org/76846 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop newly unused MySQLNativeSettingsCaolán McNamara
Change-Id: I11801ea43d69b3f79d8fba1305d4d9c8c199d29b Reviewed-on: https://gerrit.libreoffice.org/76845 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld MySQLNativeSetupPageCaolán McNamara
Change-Id: Ie27649de602241936378f1e937100718d0c95d5e Reviewed-on: https://gerrit.libreoffice.org/76844 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02drop newly unused LayoutHelperCaolán McNamara
Change-Id: I602c9a3f9df79ad8c268c6902adac9046abd34ea Reviewed-on: https://gerrit.libreoffice.org/76841 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02weld OLDAPConnectionPageSetupCaolán McNamara
Change-Id: Id1b5becb2e9978cf4713a35d4f89125658d3de17 Reviewed-on: https://gerrit.libreoffice.org/76840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-08-02Avoid -fsanitize=signed-integer-overflow within m_pFrame->GrowTst( LONG_MAX );Stephan Bergmann
`--convert-to pdf doc/ooo70429-1.doc` (i.e., the attachment Whole Book.odt at <https://bz.apache.org/ooo/show_bug.cgi?id=70429#c2>) failed with > sw/source/core/layout/wsfrm.cxx:2659:27: runtime error: signed integer overflow: 9223372036854775647 + 9254 cannot be represented in type 'long' > #0 in SwLayoutFrame::GrowFrame(long, bool, bool) at sw/source/core/layout/wsfrm.cxx:2659:27 > #1 in SwFrame::Grow(long, bool, bool) at sw/source/core/layout/wsfrm.cxx:1493:35 > #2 in SwContentFrame::GrowFrame(long, bool, bool) at sw/source/core/layout/wsfrm.cxx:2147:37 > #3 in SwFrame::Grow(long, bool, bool) at sw/source/core/layout/wsfrm.cxx:1493:35 > #4 in SwTextFrame::GrowTst(long) at sw/source/core/inc/txtfrm.hxx:815:12 > #5 in SwTextFrameBreak::IsInside(SwTextMargin const&) const at sw/source/core/text/widorp.cxx:156:34 [...] when frame 5 calls nHeight += m_pFrame->GrowTst( LONG_MAX ); As various places along the code path between frames 5 and 0 already clip values at LONG_MAX, it looks reasonable to similarly clip the increased nReal here. Change-Id: I27202ad47a397f8f57cfccfb3cb85a5dc0ac17cb Reviewed-on: https://gerrit.libreoffice.org/76851 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-08-02Fix typosAndrea Gelmini
Change-Id: I8e2f3104f3ae9d20e520d357e61c02afde0cedf4 Reviewed-on: https://gerrit.libreoffice.org/76858 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-08-02Fix typo in codeAndrea Gelmini
Change-Id: Ie32bb0cf7f987ab57dc03d1485535a1019fd111a Reviewed-on: https://gerrit.libreoffice.org/76853 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins