summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-30loplugin:finalclasses svxNoel Grandin
Change-Id: If55e51b8627083ba3ece2b3270adb47668b25e9d Reviewed-on: https://gerrit.libreoffice.org/81705 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-30-Werror,-Wunused-private-fieldStephan Bergmann
Change-Id: I33d664873ddc6d061309c8858918f852f3ad60d6 Reviewed-on: https://gerrit.libreoffice.org/81708 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-30Fix Plugin::containsPreprocessingConditionalInclusionStephan Bergmann
...which had been broken since dfc0dc4801707b2d8080af1540625b43bd463e17 "loplugin:casttovoid: fix containsPreprocessingConditionalInclusion()", and, when range.getEnd() was a macro loc, would typically have wandered off past the end of the intended range, until it would have encountered some #if etc. and erroneously returned true. Fixed the fallout across the code base. While at it, added a clarifying comment and made the "lexing fails" cases that should never happen fail with a fatal error in debug mode. Change-Id: Ieff44548384426d7716b6fc6c836c9069d878729 Reviewed-on: https://gerrit.libreoffice.org/81721 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-30loplugin:finalclasses svtoolsNoel Grandin
Change-Id: I17f4fd3960a23132916ea64b21cc8869a94eaed4 Reviewed-on: https://gerrit.libreoffice.org/81704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-30loplugin:finalclasses sot..svlNoel Grandin
Change-Id: I0814e98c82822752dd4410d595d35acb67d5a1d1 Reviewed-on: https://gerrit.libreoffice.org/81703 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29tdf#127927 Character Dialog effect tab updateandreas kainz
Change-Id: I46ad6a54ae86ab010c1747808bdf77b1da243efa Reviewed-on: https://gerrit.libreoffice.org/81052 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-10-29tdf#49813 make autofilter popup at least the width of its columnCaolán McNamara
Change-Id: Idbcf3cdb62fb2886c3b05da721e8d326e0187588 Reviewed-on: https://gerrit.libreoffice.org/81690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29tdf#127994 stabilize tip of the day widthCaolán McNamara
Change-Id: I26bdb7bc3fc7ad2037438f4fceba51388e4121eb Reviewed-on: https://gerrit.libreoffice.org/81685 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29can move iconviewimpl.hxx beside iconviewimpl.cxxCaolán McNamara
Change-Id: I48d5df7d6ebf8e22a265e163caaf759ac703f616 Reviewed-on: https://gerrit.libreoffice.org/81681 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29TreeListBox doesn't need a factory anymoreCaolán McNamara
Change-Id: Ice5891e39b0fe4e8d2e5d0f26f0e06069494a785 Reviewed-on: https://gerrit.libreoffice.org/81680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29Resolves: tdf#127645 fix crash on revisit to check updatesCaolán McNamara
Change-Id: I64474d014754e6a58aa8a9b037c336997c44daf2 Reviewed-on: https://gerrit.libreoffice.org/81693 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29loplugin:finalclasses jvmaccess..o3tlNoel Grandin
Change-Id: Iadb8621d7490b55ee6dbcadffb3c7e2527958424 Reviewed-on: https://gerrit.libreoffice.org/81655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29loplugin:finalclasses sfx2Noel Grandin
Change-Id: I77330d53adb5c6ec66750e57fdc539353b4c9725 Reviewed-on: https://gerrit.libreoffice.org/81657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29loplugin:finalclasses in ooxNoel Grandin
Change-Id: I95f69d99194f91851b2ef86bebf20006fa32fef3 Reviewed-on: https://gerrit.libreoffice.org/81656 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29tdf#128399 sw btlr: fix clicking to lower rotated cellMiklos Vajna
In case a table has more than 1 btlr cells in multiple rows, the first captured the mouse. This was because SwFrame::GetPaintArea() assumed that left and right edges can be compared directly, without going via the SwRectFnSet abstraction. This works for hozizontal and plain vertical directions, but not for btlr. Change-Id: Ia3bd7623a5d8d9ad3bdfabceb10adc0dbf105059 Reviewed-on: https://gerrit.libreoffice.org/81688 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-29SvxNumValueSet doesn't need a builder anymoreCaolán McNamara
Change-Id: I57ba416605bec1ddebf05ab65f7209a4bd51bca7 Reviewed-on: https://gerrit.libreoffice.org/81678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29return value from IDocumentLinksAdministration::SetData unusedNoel Grandin
since initial commit Change-Id: If104670adc57501f6712c3c060590251c266118a Reviewed-on: https://gerrit.libreoffice.org/81649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29remove unnecessary includesCaolán McNamara
Change-Id: Ia4a622b34ff3f71963cff7a1aa8658a4df12f04f Reviewed-on: https://gerrit.libreoffice.org/81676 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29SvTreeListBox doesn't need a factory anymoreCaolán McNamara
Change-Id: Iada22d8300a3189e9b1eacee7042523686acb60b Reviewed-on: https://gerrit.libreoffice.org/81679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29svimpbox.hxx now only included by vclCaolán McNamara
Change-Id: I0dd7691d0be8a3f54a7bcace17a36dce0ed17931 Reviewed-on: https://gerrit.libreoffice.org/81677 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29tdf#42949 Fix IWYU warnings in ucb/*/*cxxGabor Kelemen
Also recheck hxx files after recent changes in f-u-i Note: to build ucb/source/ucp/webdav one needs to use the --with-webdav=serf configure option Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I69c3a869394b0667b4d51e18e5293000872227a5 Reviewed-on: https://gerrit.libreoffice.org/81496 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-29sw: makeMark(): check position of point fieldmarksMichael Stahl
A new point fieldmark must have an empty range, which is expanded when the CH_TXT_ATR_FORMELEMENT is inserted. A copied point fieldmark must contain exactly its CH_TXT_ATR_FORMELEMENT. Change-Id: Iaf3cdad058539300199fe159d215b7aa37dae35d Reviewed-on: https://gerrit.libreoffice.org/81672 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-29writerfilter: assert that start position is before end positionMichael Stahl
As seen in fdo34663-1.docx; should find more bugs hopefully. Change-Id: Id38fdebe3ab4f48af298e2ef76ad66051cee5bcf Reviewed-on: https://gerrit.libreoffice.org/81671 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-29writerfilter: need to always import form-fields with their ffDataMichael Stahl
The generic field import path ignores ffData, becuase it's a separate element and not part of the field command. Change-Id: Ie7c622aff01e4f1a63269b46aa7b06f4f18db8c4 Reviewed-on: https://gerrit.libreoffice.org/81670 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-29writerfilter: fix handling of checkbox/dropdown fieldmarksMichael Stahl
The InsertFieldmark()/PopFieldmark() isn't necessary for these because they can only be a point/single CH_TXT_ATR_FORMELEMENT anyway. For example fdo34663-1.docx goes quite wrong with InsertFieldmark() doing stuff but then PopFieldmark() isn't called because it doesn't have a ffData, and then the TextAppendStack is messed up. Change-Id: I0af7c2577070e903b6f87d2fe47a40a1365198fa Reviewed-on: https://gerrit.libreoffice.org/81669 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-29writerfilter: use insert position in PushFieldContext()Michael Stahl
Don't hardcode end of text; see mangled nested fields in e.g. sw/qa/core/data/ooxml/pass/fdo79838.docx Change-Id: I1b77e7a0c0d2a7d52b5facbb43a0ed0747d74cea Reviewed-on: https://gerrit.libreoffice.org/81668 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2019-10-29lok: simplify the function "SlideBackground::DumpAsPropertyTree"Henry Castro
Change-Id: I288bcfa2f6ba82e83c541430d3782f2001645396 Reviewed-on: https://gerrit.libreoffice.org/81544 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2019-10-29add script for finding public symbols that can be privateNoel Grandin
Change-Id: I0b4928cf0ff8300ea00f6d902be1a80fe11b6111 Reviewed-on: https://gerrit.libreoffice.org/81673 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29jsdialogs: set .uno:BackgroundColor in CalcSzymon Kłos
Change-Id: Ic887a8a0f6dc0509ec848c0f4e405633c1900fcb Reviewed-on: https://gerrit.libreoffice.org/81660 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-29SvtURLBox not used in any .ui files anymoreCaolán McNamara
Change-Id: I03802d3345ce29f52d026f2638cb19d6209cd9e2 Reviewed-on: https://gerrit.libreoffice.org/81495 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29sc: rowcol: tdf#50916 convert core/toolNoel Grandin
Change-Id: I0fe5a7ef4a79d0832802945ce1b9da4752f1d5fc Reviewed-on: https://gerrit.libreoffice.org/81598 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29use activate-link instead of clickedCaolán McNamara
so we can return true to consume the event and not continue to the default url dispatch handler Change-Id: I66400363a57d528a25d68a7f9314a8bc7d95876e Reviewed-on: https://gerrit.libreoffice.org/81555 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29weld fpicker clusterCaolán McNamara
Change-Id: I6566263809ff0032388a0b56571f0cf7428058d7 Reviewed-on: https://gerrit.libreoffice.org/81334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29Remove unused XMouseMotionListener from PresenterControllerSamuel Mehrbrodt
Change-Id: I0b29f3dc300f71b13bc5c7844f1bcf34591dba19 Reviewed-on: https://gerrit.libreoffice.org/81651 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-29loplugin:finalclasses filter..frameworkNoel Grandin
Change-Id: Ic4d0a2946c925035d60defc4d25caea05535adbc Reviewed-on: https://gerrit.libreoffice.org/81654 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29this help case doesn't arise anymoreCaolán McNamara
Change-Id: I844f3b310e74652e3b310053a1254e06045c4506 Reviewed-on: https://gerrit.libreoffice.org/80334 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix wrong/obsolete embeds Change-Id: I59e5a18c403caef79b1f08a8575c310faa724f08 Reviewed-on: https://gerrit.libreoffice.org/81659 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-29Remove unused XFocusListener from PresenterControllerSamuel Mehrbrodt
Change-Id: If953ae5cbe74d918d435c9f90189a9f228181ccc Reviewed-on: https://gerrit.libreoffice.org/81650 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-29loplugin:finalclasses in editengNoel Grandin
Change-Id: Ie9da2c57fa9cd355dc5826cf5afd1c5b84cd22d7 Reviewed-on: https://gerrit.libreoffice.org/81648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29Remove unused XMouseMotionListener from PresenterButtonSamuel Mehrbrodt
Change-Id: I2ee99fa24fa949aedcd8d94fff68449441b9da6d Reviewed-on: https://gerrit.libreoffice.org/81646 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-29Remove unused XWindowListener from PresenterButtonSamuel Mehrbrodt
Change-Id: I98da5679e108f3684243ce4cca03ad54b9fee84a Reviewed-on: https://gerrit.libreoffice.org/81645 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-29loplugin:finalclasses in drawinglayerNoel Grandin
Change-Id: I24e5187f603f66ef87f10a1b197907c5b869cfd1 Reviewed-on: https://gerrit.libreoffice.org/81644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29cid#1453992 Dereference after null checkCaolán McNamara
presumably pInputHdl cannot be null Change-Id: If7fe7b43a23c5d917a18b09f46226c5b8e6009a1 Reviewed-on: https://gerrit.libreoffice.org/81626 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29Resolves: tdf#128410 wrong size request for dialogCaolán McNamara
Change-Id: I880b00680723c7f8bac52dedc9aa7a1a6ba49e52 Reviewed-on: https://gerrit.libreoffice.org/81627 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29Related: cid#1448329 call GetSbData() just onceCaolán McNamara
rather than every time its result it needed to deconvolute this a layer Change-Id: I1a611ed2bd74e682501cf8cbd64a5e285ec1c7e9 Reviewed-on: https://gerrit.libreoffice.org/81628 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29cid#1448471 Wrapper object use after freeCaolán McNamara
Change-Id: I4a6f31491f857280623302569afa982b37c16e89 Reviewed-on: https://gerrit.libreoffice.org/81629 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29cid#1455158 Explicit null dereferencedCaolán McNamara
Change-Id: Icdf6dd9bee5f917a6a6b26b3d80c0502a656948b Reviewed-on: https://gerrit.libreoffice.org/81625 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-29loplugin:finalclasses fix checkNoel Grandin
need to check after we generate the inherited-from set, not before Change-Id: Ic66deeb680f4a2505d66f99872ac7a5bc263cda9 Reviewed-on: https://gerrit.libreoffice.org/81636 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-29tdf#104017 DOC export: be less aggressive with merging page stylesMiklos Vajna
Regression from commit 7146d8bcd96f844dc0239a5b29a6b36c3cb5a2cc (MSWordExportBase::OutputSectionBreaks: avoid fake section breaks, 2014-07-28), the problem was that we merged two separate page styles just because they were similar. This resulted in merging two independent tables into a single one. Fix the problem by merging the first and follow page style only in case the first page style is RES_POOLPAGE_FIRST, this resolves the current problem and keeps the original problem fixed, too. (Long-term, a better fix would be to not split the page styles in writerfilter/, similar to how the DOC import doesn't do that anymore: and then the merging can be avoided unconditionally.) Change-Id: I357f1337cb0abc7fa1d88aa44ff87b4b464af81c Reviewed-on: https://gerrit.libreoffice.org/81630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-29Adapt commentStephan Bergmann
external/icu/clang-cl.patch has been dropped by 398e1e6ae83999eea8fb8c845190667695ac115f "Upgrade to ICU 64.2" Change-Id: Ic1ab2b02820cc15f9b14bdaab4554e1da5234623 Reviewed-on: https://gerrit.libreoffice.org/81638 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-18 01:52:14 +0000