summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-10avoid usually needless large allocation for formula token arrayLuboš Luňák
Change-Id: I855af060e1aeb91bccfc923ca567ad34d64be757 Reviewed-on: https://gerrit.libreoffice.org/60861 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-10-10tdf#42949 Fix IWYU warnings in include/jvmaccess/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I404b1ff3c312e5168a6dfec0133092dda640e155 Reviewed-on: https://gerrit.libreoffice.org/61508 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-10Make LibreOfficeLight build againTor Lillqvist
(And it actually works now again, as far as I see, after the recent fix to LibreOfficeKit's iOS code.) Adapt to earlier changes: The generated files are now in workdir, not in the ios source directory. Use org.libreoffice.ios.LibreOfficeLight for the PRODUCT_BUNDLE_IDENTIFIER instead of janI's own. (Additionally the DEVELOPMENT_TEAM was reset to the one I use; apparently there is no way to make sure that developer-specific setting is in a file not in version control?) Change-Id: I575561583f584b5ac3c759d115b1c9c6dc97ef94
2018-10-10Set up our own libxslt security context in xmlhelp, as per #i117643.Damjan Jovanovic
Patch by: me (cherry picked from commit ae1f34be5c9a49fae1eacdb3c1e5267acea53441) Change-Id: I0e5277b17243f6b8f5f4303206cf446b10dd0aef Reviewed-on: https://gerrit.libreoffice.org/61597 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-10Removed executable permission on odt fileAndrea Gelmini
Change-Id: I142c86e8add935bf8e0cc384921332d4aed3e591 Reviewed-on: https://gerrit.libreoffice.org/61578 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-10checkbox missing its indicatorCaolán McNamara
Change-Id: I09ec02e8148479edf45fb10d8b9261a435bedc64 Reviewed-on: https://gerrit.libreoffice.org/61600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-10pdfium: remove not needed FPDFImageObj_GetBitmapBgra() patchMiklos Vajna
Last usage was removed in commit 45c753aff6468b9761e68bc0bf48ab161cd0cba6 (svx: pdfium's FPDFImageObj_GetBitmapBgra() is not needed after all, 2018-09-28). Change-Id: I2412fa24859ad5bcd3ced634d3c4f41d2f35aebe Reviewed-on: https://gerrit.libreoffice.org/61599 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-09elementary:^/+ bezier, glue point, star shape, symbol shape, etcRizal Muttaqin
Change-Id: Ie6545844546dc78d14e1fabdf28f4e1938cf2dd7 Reviewed-on: https://gerrit.libreoffice.org/61458 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-09filling the language list just to replace it entirelyCaolán McNamara
Change-Id: I1f79038f2a5cc455a50a532870c4042588c3e446 Reviewed-on: https://gerrit.libreoffice.org/61595 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09bruteforce typeahead into combobox menusCaolán McNamara
Change-Id: I2cf75773f380c3a53d3e091e7e72beb62a4ff119 Reviewed-on: https://gerrit.libreoffice.org/61593 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09use freeze/thawCaolán McNamara
Change-Id: I7ffe52cd96f147956da30d551a30b9170c632383 Reviewed-on: https://gerrit.libreoffice.org/61588 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09We want the function pointer here, not call it (yet)Tor Lillqvist
Change-Id: I20c7c1e82b12a2d20baa673e8b7aeb3d0e1fa58c
2018-10-09tdf#101629: Handle invalid urls and search strings for PersonasMuhammet Kara
Change-Id: I9666aa9f323e53ef394121acdef146866d2cc696 Reviewed-on: https://gerrit.libreoffice.org/61529 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-09Resolves: tdf#66545 display URL fields non-shaded in CalcEike Rathke
This disables shading of URL and email address fields when displaying cell content and still preserves shading in the Input Line and when editing cell content to indicate that it is actually a field content value. Change-Id: I8737045168646b6cd446bd357713ec9ac4631b31 Reviewed-on: https://gerrit.libreoffice.org/61594 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-09Bin some no longer needed dbgutil codeTor Lillqvist
It was used to initialize a virtual device pixel buffer to an "interesting" pattern, in case actual rendering to it failed. Change-Id: Iacdd86382dfa8c9ed1ea9d213fa489515b2b217d
2018-10-09Bin horribly verbose image saving on iOS for debug purposesTor Lillqvist
Not really that useful any longer. Change-Id: Idf29b9c3eeafd1b1cc7a2baa87205f7064681a23
2018-10-09make --enable-kde5 imply --enable-qt5Rene Engelhard
And explicitly fail if --enable-kde5 and --disable-qt5. Change-Id: Ifa0cef6b065ca0825b1cb42922f6fcf676e457f1 Reviewed-on: https://gerrit.libreoffice.org/61571 Tested-by: Jenkins Reviewed-by: Rene Engelhard <rene@debian.org> Tested-by: Rene Engelhard <rene@debian.org>
2018-10-09tdf#120371 follow GNOME HIG on tab placement on mega tab notebooksCaolán McNamara
tradionally we do double/triple decker tab dialogs when there are a lot of tabs, that option isn't available with native gtk3 notebooks. Instead follow https://developer.gnome.org/hig-book/unstable/controls-notebooks.html.en#controls-too-many-tabs and when there are > 6 tabs position them at-left Change-Id: I8e6ca78abeec3c1fa9f616c21f21fd7367be2ec9 Reviewed-on: https://gerrit.libreoffice.org/61487 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09use freeze/thawCaolán McNamara
Change-Id: Ia5e24c6eab1f33d8a9ef8232095cd95c68386a43 Reviewed-on: https://gerrit.libreoffice.org/61592 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09use freeze/thawCaolán McNamara
Change-Id: I14f808864ec99258731e12879acffdd130ab0613 Reviewed-on: https://gerrit.libreoffice.org/61586 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09add some more pluralized form examplesCaolán McNamara
Change-Id: I7163577fb43f28c8c9c138ebf3a9d36586247a32 Reviewed-on: https://gerrit.libreoffice.org/61587 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09support typeahead for entryless unpopped up comboboxCaolán McNamara
Change-Id: I14ecd4d4a967a7c49aef77a423ea17b3fc46fe76 Reviewed-on: https://gerrit.libreoffice.org/61583 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09tdf#120264 - Access to "Get Involved"heiko tietze
UNO command SID_GETINVOLVED added with access to the website from all main menus under Help Dispensable ellipsis removed from other UNO commands around Help Change-Id: I79536be3de31f55a7b208bcdd5a243e05b3d3668 Reviewed-on: https://gerrit.libreoffice.org/61238 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-09bodge not needed when it has an entryCaolán McNamara
Change-Id: I790703790e49bd9e5b4ad0d5f357681f56db5121 Reviewed-on: https://gerrit.libreoffice.org/61582 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09tdf#120377 weld cluster of animation pages and dialogCaolán McNamara
Change-Id: Ia5a9880c1e6d88141bd654a9cc761b289f27c249 Reviewed-on: https://gerrit.libreoffice.org/61542 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09Extend loplugin:redundantinline to catch inline functions w/o external linkageStephan Bergmann
...where "inline" (in its meaning of "this function can be defined in multiple translation units") thus doesn't make much sense. (As discussed in compilerplugins/clang/redundantinline.cxx, exempt such "static inline" functions in include files for now.) All the rewriting has been done automatically by the plugin, except for one instance in sw/source/ui/frmdlg/column.cxx that used to involve an #if), plus some subsequent solenv/clang-format/reformat-formatted-files. Change-Id: Ib8b996b651aeafc03bbdc8890faa05ed50517224 Reviewed-on: https://gerrit.libreoffice.org/61573 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-09loplugin:unusedmethodsNoel Grandin
Change-Id: Icd7a0f9909f36363b307b4fe7ee920183881afbb Reviewed-on: https://gerrit.libreoffice.org/61576 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09tdf#120387 get lock to use ImpEditView::CutCopyJan-Marek Glogowski
ImpEditView::CutCopy releases the SolarMutex to handle clipboard access. So lock the SolarMutex when accessing this function through OutlinerView::Copy(). Now all paths effectively need the SolarMutex, so remove all the intermediate locking. I guess the explicit release for the xTransferable.is() test isn't needed. Change-Id: Ib2a69a520bbf0ef7ba4ccb893c6489b292207f2a Reviewed-on: https://gerrit.libreoffice.org/61580 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-09-Werror,-Wimplicit-fallthroughStephan Bergmann
("fallthrough annotation in unreachable code") Change-Id: I858937b439333b851942de9ca8f50ec228e77a76
2018-10-09cppcheck: redundantAssignmentRéka Csékei
Change-Id: I1efdffb92e09f83be7052b8a28ddbfb22f17defa Reviewed-on: https://gerrit.libreoffice.org/61581 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-10-09tdf#42949 Fix IWYU warnings in chart2/source/tools/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I804895a4dd2d98707f0d1bbbc9bb78782b07a397 Reviewed-on: https://gerrit.libreoffice.org/61505 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-09loplugin:unusedfieldsNoel Grandin
Change-Id: Iacce8e12a85f857192dc0520b795e1990a3612db Reviewed-on: https://gerrit.libreoffice.org/61575 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09use unique_ptr in SfxUndoManager::AddUndoActionNoel Grandin
Change-Id: I11483e3cece12a7373f4276972b4c899edf1ce15 Reviewed-on: https://gerrit.libreoffice.org/61566 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09sc: Enhance binary search for ScAttrArraySerge Krot
Change-Id: Idf417c452dbbadbede0e3f0860cce7a8a6fd308e Reviewed-on: https://gerrit.libreoffice.org/61517 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-09Fix typosAndrea Gelmini
Change-Id: Ia2aca4e87054d2f5cc0462e07ac0717278d3c98c Reviewed-on: https://gerrit.libreoffice.org/61577 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-09Resolves: tdf#120370 should check gradientgrid sensitivityCaolán McNamara
rather than whether listbox first entry is not selected Change-Id: Ic3dc574f6f1a476929e89e695849756437024cee Reviewed-on: https://gerrit.libreoffice.org/61559 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09tdf#111718 Fix interaction between bitmap and pattern settingsJim Raykowski
Change-Id: I1c68b9f1f51cb15a30f56eef08dc384d10355bf1 Reviewed-on: https://gerrit.libreoffice.org/58805 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-10-09loplugin:constfields in scriptingNoel Grandin
Change-Id: I1484d920649817680f70de4ca00a3d46e1faf42a Reviewed-on: https://gerrit.libreoffice.org/61554 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in sdextNoel Grandin
Change-Id: Ief438d98b8117a7759282323e47c8b5283d6762a Reviewed-on: https://gerrit.libreoffice.org/61552 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09Related: tdf#83128 support translation of plural formsCaolán McNamara
Change-Id: Id3d41099a895ca5423be2ac3d497851bc65eaff7 Reviewed-on: https://gerrit.libreoffice.org/61426 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-09tdf#120318: remove autofilter for the momentJulien Nabet
Before adding it the entry again, please implement it and test it. See comments of the tdf. Change-Id: I64a5729baf589dbd188b6e8fcd5075112e5a7da7 Reviewed-on: https://gerrit.libreoffice.org/61558 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-09tdf#120341 OOXML export: fix export of Pie Chart Wall BorderlineBalazs Varga
Export LineStyle_NONE instead of default linestyle of PlotArea border, because LibreOffice make invisible the Wall shape properties in case of PIE/NET/FILLED_NET charts. Or other solution in the future is set the default LineStyle of these charts to LineStyle_NONE. Change-Id: I59e6f18058713f4a0d4c77da8760a319f9c25152 Reviewed-on: https://gerrit.libreoffice.org/61547 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-10-09tdf#119993 sw: clear the font cache text glyphs on table col changeMiklos Vajna
This helps not storing pre-computed vcl text layouts which are most probably never re-used anymore. Approximate numbers for memory usage with 10 column resizes for the bugdoc: - old: 310MB -> 454MB - new: 309MB -> 310MB Change-Id: Ifb88b88e1bffe2c2670089930fc2d22ff19576ce Reviewed-on: https://gerrit.libreoffice.org/61562 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-09cppcheck: useInitializationList in editeng ...Jochen Nitschke
and remove some indirections Change-Id: I94088030084683c1a24f904da1c42a01f24f47ce Reviewed-on: https://gerrit.libreoffice.org/61561 Tested-by: Jenkins Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2018-10-09loplugin:constfields in scaddins,sccompNoel Grandin
Change-Id: I4d21cfcc65c099fbddbe5146fc1b8a6257971e32 Reviewed-on: https://gerrit.libreoffice.org/61555 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in sdNoel Grandin
Change-Id: Ia072401c71dacf089b9f5213957c2cd25bb1a1b3 Reviewed-on: https://gerrit.libreoffice.org/61553 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in shellNoel Grandin
Change-Id: Ib30c45bddcc58fcd0fec8b160eb925349e801df7 Reviewed-on: https://gerrit.libreoffice.org/61551 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in sfx2Noel Grandin
and we find that bSplitable in SfxDockingWindow is always true, ever since commit 4bd28a2fee0d36c67911019eeb7d934838e27cad Date: Tue Jan 29 15:27:40 2008 +0000 INTEGRATION: CWS fwk82_SRC680 (1.45.138); FILE MERGED so we can remove all of the non-splittable code there. ` Change-Id: Ia7fe607ed02d1a7c69a92bab57e220b19f0e6e87 Reviewed-on: https://gerrit.libreoffice.org/61550 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in smoketest..sotNoel Grandin
Change-Id: I59ceda8ff85cc7b348882a6e1c62491b74297801 Reviewed-on: https://gerrit.libreoffice.org/61549 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-09loplugin:constfields in slideshowNoel Grandin
Change-Id: Ieeda808ad8e7fe500a2142c779529ca190725f6a Reviewed-on: https://gerrit.libreoffice.org/61548 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>