summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-15Use auto/for range loops in PostItMgr (first pass)Julien Nabet
+ fix a loop by adding the increment Change-Id: I27add28e03dee4c882931e0c173ec0c23b44d198 Reviewed-on: https://gerrit.libreoffice.org/44743 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-15silence coverity#1362777 Explicit null dereferencedCaolán McNamara
Change-Id: I49089cfac207f67e03c19a09a95c4c7325276b53
2017-11-15Resolves: tdf#113615 wrong SwXShape from three possibilities returnedCaolán McNamara
There is the group object itself and the two subobjects all registered with this SwFrameFormat and the right line is randomly returned instead of the wanted one. Its possibly the presence of working a11y under gtk3 causing it to be the only platform apparently with this trouble with a11y querying for details of the grouped object Change-Id: I4d1bd3f826b630dd7734eb1decaf0211cd896894 Reviewed-on: https://gerrit.libreoffice.org/44729 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-15ofz#4213 Integer-overflowCaolán McNamara
Change-Id: Ice22ad92a82971f34c01d2c16fc3d4805b1fd5f3 Reviewed-on: https://gerrit.libreoffice.org/44742 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-15Resolves: tdf#113826 use brush vs background conversion mode of dialogCaolán McNamara
Change-Id: If33e1672048c570887c2c53da646f86852bc6a6c Reviewed-on: https://gerrit.libreoffice.org/44740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-15update license header on new fileNoel Grandin
I just copied the license header from a nearby file, which is wrong, so update from template. Change-Id: I96d2a8a29eff9020a23b1ccded8642d2f5d0968b
2017-11-15Make sure there is a org.libreoffice.LibreOffice.desktop again in the FlatpakStephan Bergmann
...after 1b85d725663a7d7546549e6b78ea43bea1cde7b9 "Include all .desktop files in the Flatpak". org.libreoffice.LibreOffice.appdata.xml references that in its <id>org.libreoffice.LibreOffice.desktop</id> which is at least used to find an icon for the AppData (see <https://github.com/flathub/org.libreoffice.LibreOffice/issues/1> "No icon shown on flathub.org"). On #flatpak it was deemed impossible to change that id to point at the the LibreOffice-startcenter.desktop file, so rather change that one desktop file's name. Change-Id: I78c3ae131be213e41cc4fcdeddae1b6c9e6c29df
2017-11-15Adpat external/harfbuzz/harfbuzz-rtti.patchStephan Bergmann
...to 7e56dce9efa7184e522c83130dcf79d894488657 "tdf#105992: Upload HarfBuzz 1.7.0" Change-Id: Ia13d406ae78edb3b431716ae7e2044c483430c6e
2017-11-15tdf#45904 Move _XSheetAnnotationsSupplier Java test to C++Jens Carl
Change-Id: I18143d96f49ea4f4b80ae89df33d2963bb20e125 Reviewed-on: https://gerrit.libreoffice.org/44747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-15TypedWhichIdNoel Grandin
use a strong-typedef template to give which IDs a type, which we can carry around to do a (a) little bit more convenience when Get()'ing them and (b) a little bit of enforcement of which PoolItem subclass each ID uses Fix a bug in casting EE_PARA_BULLETSTATE to the wrong subclass in AccessibleEditableTextPara::_correctValues Change-Id: I015ce8b3b0f6d21308af182afa3caf122c877a5b Reviewed-on: https://gerrit.libreoffice.org/44587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15Fix typosAndrea Gelmini
Change-Id: I8bdced3fa572074aedabdcfce841adf525ae8b81 Reviewed-on: https://gerrit.libreoffice.org/44710 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-15Make checkIdenticalDefaultArguments more preciseStephan Bergmann
...when creating objects involves copy/move constructors Change-Id: I0c7ccb85b7dcb584502a48817d7d2abfde25aaf2 Reviewed-on: https://gerrit.libreoffice.org/44733 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-15Related tdf#113652: fix crash when closing Data providerJulien Nabet
Test also mpScrollBar to know if should keep on with RecalcAll bt: 5 0x00007fffec06b6f0 in vcl::Window::Hide() (this=0x0) at /home/julien/lo/libreoffice/include/vcl/window.hxx:948 6 0x00007fffec2eb344 in ListControl::RecalcAll() (this=0x555558b25090) at /home/julien/lo/libreoffice/vcl/source/control/listctrl.cxx:76 7 0x00007fffec2eb6ec in ListControl::queue_resize(StateChangedType) (this=0x555558b25090, eReason=StateChangedType::Layout) at /home/julien/lo/libreoffice/vcl/source/control/listctrl.cxx:110 8 0x00007fffec24c6b0 in vcl::(anonymous namespace)::queue_ungrouped_resize(vcl::Window const*) (pOrigWindow=0x555558b06620) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1343 9 0x00007fffec24c799 in vcl::Window::queue_resize(StateChangedType) (this=0x555558b06620, eReason=StateChangedType::Layout) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1362 10 0x00007fffec14a701 in VclContainer::queue_resize(StateChangedType) (this=0x555558b06620, eReason=StateChangedType::Layout) at /home/julien/lo/libreoffice/vcl/source/window/layout.cxx:179 11 0x00007fffec24c6b0 in vcl::(anonymous namespace)::queue_ungrouped_resize(vcl::Window const*) (pOrigWindow=0x555558b287b0) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1343 12 0x00007fffec24c799 in vcl::Window::queue_resize(StateChangedType) (this=0x555558b287b0, eReason=StateChangedType::Layout) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1362 13 0x00007fffec14a701 in VclContainer::queue_resize(StateChangedType) (this=0x555558b287b0, eReason=StateChangedType::Layout) at /home/julien/lo/libreoffice/vcl/source/window/layout.cxx:179 14 0x00007fffec24c6b0 in vcl::(anonymous namespace)::queue_ungrouped_resize(vcl::Window const*) (pOrigWindow=0x555558b26fd0) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1343 15 0x00007fffec24c799 in vcl::Window::queue_resize(StateChangedType) (this=0x555558b26fd0, eReason=StateChangedType::Visible) at /home/julien/lo/libreoffice/vcl/source/window/window2.cxx:1362 16 0x00007fffec25f2d5 in vcl::Window::StateChanged(StateChangedType) (this=0x555558b26fd0, eType=StateChangedType::Visible) at /home/julien/lo/libreoffice/vcl/source/window/window.cxx:1940 17 0x00007fffec2675ae in vcl::Window::CompatStateChanged(StateChangedType) (this=0x555558b26fd0, nStateChange=StateChangedType::Visible) at /home/julien/lo/libreoffice/vcl/source/window/window.cxx:3696 18 0x00007fffec260548 in vcl::Window::Show(bool, ShowFlags) (this=0x555558b26fd0, bVisible=false, nFlags=ShowFlags::NONE) at /home/julien/lo/libreoffice/vcl/source/window/window.cxx:2200 19 0x00007fffec06b6f0 in vcl::Window::Hide() (this=0x555558b26fd0) at /home/julien/lo/libreoffice/include/vcl/window.hxx:948 20 0x00007fffec256f11 in vcl::Window::dispose() (this=0x555558b26fd0) at /home/julien/lo/libreoffice/vcl/source/window/window.cxx:394 21 0x00007fffec2b1395 in Control::dispose() (this=0x555558b26fd0) at /home/julien/lo/libreoffice/vcl/source/control/ctrl.cxx:68 22 0x00007fffec289da8 in Button::dispose() (this=0x555558b26fd0) at /home/julien/lo/libreoffice/vcl/source/control/button.cxx:109 23 0x00007fffec3ef640 in VclReferenceBase::disposeOnce() (this=0x555558b27240) at /home/julien/lo/libreoffice/vcl/source/outdev/vclreferencebase.cxx:42 24 0x00007fffca047c8a in VclPtr<PushButton>::disposeAndClear() (this=0x555558b068c0) at /home/julien/lo/libreoffice/include/vcl/vclptr.hxx:208 25 0x00007fffca0432a6 in ScDataProviderBaseControl::dispose() (this=0x555558b06620) at /home/julien/lo/libreoffice/sc/source/ui/miscdlgs/dataproviderdlg.cxx:104 Change-Id: Ie1f2b156a5743354f39e95048e50bb0709095fd0 Reviewed-on: https://gerrit.libreoffice.org/44697 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-15tdf#105992: Upload HarfBuzz 1.7.0Khaled Hosny
This release supports old-style kern table in the code path we are using in CommonLayout. Change-Id: Id20e6fe1cfe98ef65b8fa4a5627f6246cbac54a6 Reviewed-on: https://gerrit.libreoffice.org/44693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2017-11-15sd lok: ensure default viewHenry Castro
In Tiled rendering case, the only default view is supported Change-Id: Ia6df85dba28f8ebb41bdc20ae48916b0437ea185 Reviewed-on: https://gerrit.libreoffice.org/44737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-11-14ofz#4211 Integer-overflowCaolán McNamara
Change-Id: I4e0f2c16d47639362d28d126a399b52d5180f16a Reviewed-on: https://gerrit.libreoffice.org/44741 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-14related tdf#113807: Clean up Links dialog: remove useless hidden buttonSerge Krot
Change-Id: I0e8f9d7b538dd094d53cda69517e94fbafd0d752 Reviewed-on: https://gerrit.libreoffice.org/44725 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-14clang-format fixStephan Bergmann
Change-Id: I09db5eeee5734f980a794e9adee70b6b634dfd99 Reviewed-on: https://gerrit.libreoffice.org/44732 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-14ofz: if parsing failed we keep reparsing itCaolán McNamara
Change-Id: I656eb1144a652addbc4a0b07b5d5dd435b68bf2c Reviewed-on: https://gerrit.libreoffice.org/44714 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-14Translate German comments and debug stringsJohnny_M
Change-Id: I12c92ecc270e65cb99e38e9179cf354a8c0708aa Reviewed-on: https://gerrit.libreoffice.org/44633 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-14Fix typosAndrea Gelmini
Change-Id: Id2f90d4798ded8f10ef559f434977870e2eab07a Reviewed-on: https://gerrit.libreoffice.org/44709 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-14Translate German variable namesJohnny_M
Change-Id: I980d9e36c2175b1010a7d020e71d59a79e11dc36 Reviewed-on: https://gerrit.libreoffice.org/44631 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-14Updated coreEike Rathke
Project: help 008c845819cd34a02fba16ee89c784d02d6740fa Related: tdf#113768 VDB change Type parameter opposite to NoSwitch Change-Id: I9a603cb70f5922c83482da55fa797441bffab93c
2017-11-14Resolves: tdf#113835 add Fon [fon-BJ] to language listEike Rathke
Change-Id: Iee741421d8f6a9a2b9b14439612890426cdf4712
2017-11-14Only do kashida insertion with fonts that have non-zero width kashidasMartin Hosken
Change-Id: I54f51432531072a8ec3cde832003369b23cb6eaf Reviewed-on: https://gerrit.libreoffice.org/44704 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Martin Hosken <martin_hosken@sil.org>
2017-11-14Use proper ucontext_t in external/breakpadStephan Bergmann
SUSv4 merely claims that ucontext_t is defined as a structure type (in <signal.h>), and at least /usr/include/sys/ucontext.h in glibc-headers-2.26-15.fc27.x86_64 now defines it as typedef struct ucontext_t { ... } ucontext_t; instead of as typedef struct ucontext { ... } ucontext_t; as was done in older glibc, so referring to it as "struct ucontext" (C/C++) or "ucontext" (C++) no longer works. Change-Id: I3d515a4ce7e5a49d0277136cad2b982bdf799ac5
2017-11-14Add clarifying comment about shell scripts in Contents/MacOSTor Lillqvist
Change-Id: I0f0bda04cc94705e44d78456756905fd6a821561
2017-11-14Distinguish single/multiple cell copy for plain text, tdf#113571 follow-upEike Rathke
A single cell may contain embedded line breaks and tabs, copy/pasting multiple cells may not. Change-Id: Iae58f5c6b5330b327acfb50a37e9d210e72de7c7
2017-11-14Don't bother with unoinfo either in the sandboxed app bundleTor Lillqvist
Note: Only for the ENABLE_MACOSX_SANDBOX case. Does not affect a regular signed build. Change-Id: I296ebdd5de075c1efbd198c671a3ec082681deb4
2017-11-14Make checkIdenticalDefaultArguments more preciseStephan Bergmann
...when creating objects of the same derived type Change-Id: I109b614473a2fb5b08dddd07a4fbe757086141a1 Reviewed-on: https://gerrit.libreoffice.org/44716 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-14LibreOffice.natvis: update visualizersMike Kaganski
Change-Id: I48e13a16deb14869a2fb37822650f44ca7162406 Reviewed-on: https://gerrit.libreoffice.org/44727 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-14tdf#113037 DOCX Watermark correct ratioSzymon Kłos
Import and export Watermark with padding like MSO does. Shape is scaled to save correct ratio. Change-Id: Iebd8eb5f168e0030320406d4fd6b287e451267bd Reviewed-on: https://gerrit.libreoffice.org/44319 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-11-14tdf#113790: skip charfmt grabbag items existing in autofmt grabbagMike Kaganski
Change-Id: Icc0065c1da9471cb36bfef0da45e2f67381a1a31 Reviewed-on: https://gerrit.libreoffice.org/44706 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-14Add comment and @since LibreOffice 5.2Eike Rathke
Change-Id: Iee7b0a6cd6f6f83f88b836e4efd7e7d6f17e6197
2017-11-14Adapt solenv/flatpak-manifest.in to recently added Noto fontsStephan Bergmann
b97e713e76c88141d26f6e19a74db80a105cb911 "tdf#103080 Add Noto fonts into default installation" Change-Id: I4e2bb52b533321dc2a9ca32ca548bda5a2ad9a02
2017-11-14gtktiledviewer downgrade min gtk+ to 3.16Ashod Nakashian
Change-Id: Ieb964ec1bbdeb632bd771db9b773f64b78107fc5 Reviewed-on: https://gerrit.libreoffice.org/44724 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-14Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
Change-Id: Id3b856cce8b6182dfcc433b2b633977b7445703d
2017-11-14Fix typosAndrea Gelmini
Change-Id: Id8df807bb96e036f0cef07cd1095b2d3336efe36 Reviewed-on: https://gerrit.libreoffice.org/44711 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Page <aptitude@btconnect.com>
2017-11-14Changed encoding from cp1252 to UTF-8Andrea Gelmini
In [54]: open("sc/qa/unit/pivottable_filters_test.cxx",'r').readlines() --------------------------------------------------------------------------- UnicodeDecodeError Traceback (most recent call last) <ipython-input-54-39091a82db4d> in <module>() ----> 1 open("sc/qa/unit/pivottable_filters_test.cxx",'r').readlines() /usr/lib/python3.6/codecs.py in decode(self, input, final) 319 # decode input (taking the buffer into account) 320 data = self.buffer + input --> 321 (result, consumed) = self._buffer_decode(data, self.errors, final) 322 # keep undecoded input until the next call 323 self.buffer = data[consumed:] UnicodeDecodeError: 'utf-8' codec can't decode byte 0xe1 in position 1648: invalid continuation byte In [55]: open("sc/qa/unit/pivottable_filters_test.cxx",'r',encoding="cp1252").readlines() Out[55]: ['/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */\n', '/*\n', ... Change-Id: Iad48bdf3502fcb6340e358249781a39d50f80c85 Reviewed-on: https://gerrit.libreoffice.org/44708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-14tdf#113807 Enable clicking on pathfile-names in "Links" dialogSerge Krot
Improved: * Very long pathfilename now do not overwrite its label on the dialog * Full pathfilename could be clicked to show attachment/image with default viewer. Change-Id: I6e5398ed2a2013aae0d9b51a719e694b3206dcce Reviewed-on: https://gerrit.libreoffice.org/44689 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-11-14ofz: stop at min of end of record and end of streamCaolán McNamara
Change-Id: I61c7cf74ea75ec56b6ccb3661f6fdd54a1ff12e1 Reviewed-on: https://gerrit.libreoffice.org/44705 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-14Another workaround for "xargs: environment is too large for exec" errorsStephan Bergmann
...on Windows, similar to df9edbcd2883cec2d0596133131cfbc220dee91f "Work around 'xargs: environment is too large for exec' errors on Windows" Change-Id: Ibc23960bbe2b8001eb7e08ed4cff12e4726df01b
2017-11-14Two more functions that are private to vcl and not even VCL_DLLPUBLICTor Lillqvist
... and thus don't need to be declared in a public include file. Change-Id: Ia59040d3ef3ebf73b2372531bef086b0847911ce
2017-11-14Fix ASan "alloc-dealloc-mismatch (operator new [] vs operator delete)"Stephan Bergmann
...e.g. during CppunitTest_smoketest, after be2d9d3407ddae22797879e93778513be30ec5aa "Clean up m_generatedRttis at exit" Change-Id: Ife4b07927ba11cf5b99e987b3bb9af068652ba62
2017-11-14Adapt Library_vclplug_qt5Stephan Bergmann
...to 8f54136caa786523fd224f6c98fc8e7c45cd805d "use std::unique_ptr for SalLayout" Change-Id: Ibf8962de1b43881c70a1bad1881df61bf4b551a4
2017-11-14Fix typosAndrea Gelmini
Change-Id: I53b47cab5cbc603bf11adcda8ac2a8373eef26a8 Reviewed-on: https://gerrit.libreoffice.org/44695 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-14RTF import: add odd section break testcaseMiklos Vajna
lcov points out this was not covered so far. Change-Id: I7c5047b75f6548e7738e6118f8d3c0eb9ed76045 Reviewed-on: https://gerrit.libreoffice.org/44702 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-11-14use std::unique_ptr for SalLayoutNoel Grandin
to make the ownership passing around more obvious Change-Id: I147ec6d9cfe7566cf3600685e0730ed741c2d90d Reviewed-on: https://gerrit.libreoffice.org/43454 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-14ofz: further limit exttextout to record size is smaller than stream sizeCaolán McNamara
Change-Id: I5f59db9e0c32f601537860d7574044b713d1c39d Reviewed-on: https://gerrit.libreoffice.org/44696 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-14No need for bestmaxFrameSizeForScreenSize to be declared publiclyTor Lillqvist
It is used only inside vcl, and it should stay that way. Change-Id: Ia1a14ab13cb7d3580771c880f959abb2b695b032 Reviewed-on: https://gerrit.libreoffice.org/44698 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-11 11:16:39 +0000