summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-11-16Delete test*.odb filesStephan Bergmann
...that are created in java.io.tmpdir (e.g., /tmp on Linux) by connectivity.tools.HsqlDatabase.createDBDocument() during e.g. JunitTest_dbaccess_complex. This revealed that connectivity.tools.AbstractDatabase.delete() (even if it would have been called by the test) would have been non-effective at deleting the file, as the java.io.File constructor used takes a pathname not a file URL as argument, so the call to java.io.File.delete() would not have deleted the relevant file (and returned false, rather). Change-Id: I268e1d1732ac7a0db9ccde7d4ac4f09aa3811e11 Reviewed-on: https://gerrit.libreoffice.org/44801 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-16Add comment to eventually remove __float128 workaroundStephan Bergmann
Change-Id: I9f786bb34d05febe6c7393bde8ca9d9ce18f41c9
2017-11-16ofz#4243 TimeoutCaolán McNamara
Change-Id: Ib1d06c966d10cef2016522a63272bf5c1670977f Reviewed-on: https://gerrit.libreoffice.org/44808 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16ofz#4243 TimeoutCaolán McNamara
Change-Id: I00767cfd99634f0ccd22e63cf0d635a2f75bc224 Reviewed-on: https://gerrit.libreoffice.org/44806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16Straighten use of MAXSTRLEN to be maximum string lengthEike Rathke
... plus limiting 0-character, and not buffer length in (only) some cases where max len then was MAXSTRLEN-1, accompanied by a mix of >= and > comparisons. Change-Id: I5b8452db52b1d464eb1410e31990043f7997af20
2017-11-16Make checkIdenticalDefaultArguments more preciseStephan Bergmann
...by structurally comparing complex constexpr exprs that use template functions that happen to not have been instantiated, so Expr::EvaluateAsRValue et al would fail. (Which happened with SFX_PRINTER_ALL in SfxViewShell::SetPrinter, include/sfx2/viewsh.hxx.) Now all of the LO code base should compile without causing checkIdenticalDefaultArguments to return Maybe. Change-Id: I2b103418c2c68f6d2242535c9cca3222a2508778 Reviewed-on: https://gerrit.libreoffice.org/44773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-11-16Access2Base - FIX AllDialogs() should run when no active documentJean-Pierre Ledure
Stopped erroneously with error message "No active connection"
2017-11-16ofz#4079 check for error earlierCaolán McNamara
Change-Id: I141417811b0d64dbf1ad898f9f3a00e4e02d33c8 Reviewed-on: https://gerrit.libreoffice.org/44826 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16Avoid infinite loops in lopluginStephan Bergmann
...introduced with cab6e6836973a9ddfc5ed9df757e07138328c1c3 "Make checkIdenticalDefaultArguments more precise", causing older Clang to hang when compiling specific LO source files. Change-Id: I99cfcad2f0cd9adccd5aa84d21502f586762217f
2017-11-16fail earlierCaolán McNamara
Change-Id: I8a4f93eea723075103ccdc21e894f44d3bdb7c06
2017-11-16ofz#2977 TimeoutCaolán McNamara
Change-Id: Ib7c00120b97b0d387048a5d8d9d36954e98ffee7 Reviewed-on: https://gerrit.libreoffice.org/44825 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16ofz#3002 set a limit to how broken a jpeg is to give up recoveringCaolán McNamara
take ImageMagicks 1000 warnings as the starting point Change-Id: Id685764404d27b151daf031a4860055f64dd0915 Reviewed-on: https://gerrit.libreoffice.org/44818 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16ofz: limit depth of hwp parsingCaolán McNamara
Change-Id: Iba38cdea1fa9f3df4340988184adb1e8058ae931 Reviewed-on: https://gerrit.libreoffice.org/44816 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16iOS, add tile sizing functionjan Iversen
Added function to calculate needed tiles. Change-Id: Ie598f6a5f438dea72c298e769bdba8fd00bbb4bf
2017-11-16iOS, update LibreOfficeLight versionjan Iversen
Getting close to a realistic beta state Change-Id: I30dddce6b52f622a3295b905d781b6c0543f45f7
2017-11-16tdf#113875: Properly export 1bpp greylevel (but not B&W) PNG images to PDFTor Lillqvist
No idea whether 1bpp non-greylevel (i.e. with two palette entries that aren't shades of grey) PNG images are mishandled. Change-Id: I72173c7398db7f0e93c19679e3e392949bf1f4d2
2017-11-16ofz#4245 Abrt add more servicesCaolán McNamara
Change-Id: I0241ab5a96b0ba2a458eb34c37ea76e23efe839b
2017-11-16related ofz#4243 TimeoutCaolán McNamara
Change-Id: I6734c1df06ce1b2cd0fcca488bc5d2fe333ad55b
2017-11-16silence coverity#1399176 Uncaught exceptionCaolán McNamara
and probably a bunch of others Change-Id: If4556e8914c770456f9de729426c52d5e27cb691 Reviewed-on: https://gerrit.libreoffice.org/44777 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16silence coverity#1421123 Copy-paste errorCaolán McNamara
Change-Id: If340824c749dda0668fabba9d417f4a2c2acc3ff Reviewed-on: https://gerrit.libreoffice.org/44774 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16coverity#1421111 Useless callCaolán McNamara
since commit 1c46621b4b7d73537a8cf7d07237ff682278d7ee Date: Tue May 22 15:35:06 2007 +0000 INTEGRATION: CWS chart2mst3 (1.85.12); FILE MERGED Change-Id: I1af5fbaf4ed0bceb2062a9ed2de9ea5703cfbb97 Reviewed-on: https://gerrit.libreoffice.org/44776 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16coverity#1421095 Useless callCaolán McNamara
and coverity#1421110 Useless call coverity#1421127 Useless call coverity#1421082 Useless call just returns aDocument member, so this isn't testing anything Change-Id: I556d84c89128bbc652b0cc417e60a1a77ad0dfc9 Reviewed-on: https://gerrit.libreoffice.org/44775 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16ofz#4230 Integer-overflowCaolán McNamara
Change-Id: If7c7591780fe7fa8d6fde3d17b606a4ab0acbf56 Reviewed-on: https://gerrit.libreoffice.org/44794 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-16Warn when commit touches new files, but no suitable clang-format is foundStephan Bergmann
Change-Id: Ifd254c30b8aecf6e7aec00bbfc8522a91bfa0909
2017-11-16loplugin:useuniqueptr in hwpfilterNoel Grandin
Change-Id: If6e8dfcec2842a329229e5c57417ca3f00ef74b3 Reviewed-on: https://gerrit.libreoffice.org/44763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-16use implict conversion operator in TypedWhichIdNoel Grandin
instead of spreading calls to Which() everywhere. Change-Id: Ie32d106e44f5cb583908eeebe254ab8b8168ae61 Reviewed-on: https://gerrit.libreoffice.org/44760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-16Removed duplicated includeAndrea Gelmini
Change-Id: Ic59458337966b35f46279e653a73ab601787d7b9 Reviewed-on: https://gerrit.libreoffice.org/44764 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-16tdf#106370 Android: add ability to insert picturesXimeng Zu
Added ability to insert pictures to Android Viewer. You can take photo or select photo from device or the cloud (Google photos, Dropbox). You can also compress the picture before inserting it with multiple compress grades. So far, inserting doesn't work for Writer due LO native library issues (I think). Change-Id: If6841ba04fe18585703c8b85909cf39747dbbc2f Reviewed-on: https://gerrit.libreoffice.org/41150 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-16[Android] Add address/formula barsXimeng Zu
Added address bar and formula bar to Calc. Change-Id: I7cc7047d6d07629ab564261d294e481ae585fd29 Reviewed-on: https://gerrit.libreoffice.org/40842 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-11-16ofz: special case max index for cSymbolCaolán McNamara
Change-Id: Ia5fb036196b0cff0739789e691a36d294660540b Reviewed-on: https://gerrit.libreoffice.org/44759 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-11-15drop now unused ToolPanelOptCaolán McNamara
Change-Id: I26c93567f58b7b459eedbad85b5f3bfe554c8557 Reviewed-on: https://gerrit.libreoffice.org/44769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-15remove now unused ToolPanelModuleCaolán McNamara
Change-Id: I30c91acf28fc8c9d1815796b0a0d7924b42a06f8 Reviewed-on: https://gerrit.libreoffice.org/44767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-15Add ColorConfigCtrl to glade catalogTamás Zolnai
Change-Id: I8c6740bf6249f32eaeace1452073f8451d0df978 Reviewed-on: https://gerrit.libreoffice.org/44770 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-11-15tdf#45904 Move _XScenariosSupplier Java test to C++Jens Carl
Change-Id: I152f6358e505d7a480e157bd49613e0bb496e163 Reviewed-on: https://gerrit.libreoffice.org/44748 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2017-11-15impress constantly trying to create an internal SidebarViewCaolán McNamara
I think since the sidebar was integrated that this is dead code belonging to the sidebars impress-only ancestor Nothing creates the SidebarView[1], so attempt fails, a failed attempt is scheduled in to try again on a configuration update timer configuration update timer fails to load missing SidebarView but broadcasts configuration update on each attemp when the presenter console gets a configuration update it refreshes its ui by loading the current slide if the current slide has notes and those notes are long enough to be scrolled and the user has scrolled to the end, then when the slide is reloaded the notes are at the top again. So presenter console notes scroll to the top after 5 seconds because the configuration update fired, because the previous configuration update didn't work. This is old lady that swallowed a fly level stuff [1] and I think its a typo here anyway and msSidebarViewURL should have been msSidebarPaneURL Change-Id: Ibfff16bb1092a49a8a54ca9697b5dc3819448af3 Reviewed-on: https://gerrit.libreoffice.org/44766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-11-15Assert all FormulaToken::Set...() virtual dummy methodsEike Rathke
Attempting to set on a wrong token type can never be right. Change-Id: I788221505a628f40dfbb9c2ee7c92ac789529303
2017-11-15Fix typoAndrea Gelmini
Change-Id: Ia22202a2ce3557301ce7397f009b9b3ffff8cef3 Reviewed-on: https://gerrit.libreoffice.org/44765 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2017-11-15crashtesting: assert on export of fdo59645-3.odt to docxCaolán McNamara
probably since... commit 3f2e84b4bd0bbd936e0af845ba7cbf68cb2803d6 Date: Tue Oct 31 23:39:26 2017 +0100 tdf#38778 Fix output of the font in DOC run The font information should be output before field declaration. Added unit test. tdf#38778 DOCX output: no double output of the font info need to also not double output the complex script font info as well as the western and ctl info I misread hAnsi as Asian the last time so thought CJK was already handled, handle it for real this time Change-Id: If57a3ca3f96a7b76f1fb8702a0d5071c0b3e5cd9 Reviewed-on: https://gerrit.libreoffice.org/44771 Reviewed-by: Serge Krot (CIB) <Serge.Krot@cib.de> Tested-by: Serge Krot (CIB) <Serge.Krot@cib.de>
2017-11-15upload libmwaw 0.3.13David Tardon
Change-Id: I9af801efd81bbe64117de52359491c05069c1947 Reviewed-on: https://gerrit.libreoffice.org/44736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-11-15Don't pollute /tmp with vba_debug* filesStephan Bergmann
...put them at workdir/CppunitTest/oox_vba_compression.test.user/debug/ instead. Change-Id: I067a82c05e2f91969d70cb582d69c4c1de13951c
2017-11-15lokdialog: Expose cursor visible statusPranav Kant
Change the notifyDialog API a bit. Use a std::vector to keep track of each payload item that needs to be fed to the resulting JSON. Change-Id: If3229a88d2df5368e14290a0e80ebe6206780639 Reviewed-on: https://gerrit.libreoffice.org/44722 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-11-15lokdialog: Callback for dialog cursor invalidationPranav Kant
Change-Id: Iecadb68737ed7b1a425d9ea633976fb24d1055c6 Reviewed-on: https://gerrit.libreoffice.org/44721 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-11-15tdf#108144: tabbed notebookbar add margins to seperatorsandreas kainz
Change-Id: I374873eed5e89c0788869150187219078d22f986 Reviewed-on: https://gerrit.libreoffice.org/44757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2017-11-15sc: disable context menu of the language status bar itemHenry Castro
Change-Id: Ifa4de8abff37179aca57b3890337f2475e5775eb Reviewed-on: https://gerrit.libreoffice.org/44745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Henry Castro <hcastro@collabora.com>
2017-11-15loplugin:flatten in xmloffNoel Grandin
Change-Id: I782278b8a633094b96788f81ae7066a45d45b5fe Reviewed-on: https://gerrit.libreoffice.org/44750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-15loplugin:flatten in vclNoel Grandin
Change-Id: I3527477277a9ae96eaf9fd068232f672da7c28c3 Reviewed-on: https://gerrit.libreoffice.org/44753 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-11-153813dd1315 follow-up: revert incorrect loop changesMike Kaganski
Change-Id: Ifdccf64630e76f6189668aa7f7412c41a6af04c2 Reviewed-on: https://gerrit.libreoffice.org/44756 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-11-15coverity#1421163 Unchecked dynamic_castCaolán McNamara
and coverity#1421165 Unchecked dynamic_cast Change-Id: Iabd9560d41ec3ddbdb7a560b7839024b7749f917
2017-11-15coverity#1421071 Uninitializer scalar fieldCaolán McNamara
Change-Id: I6b52c62574013ba242922227c2cbd7bfceea0e29
2017-11-15sw: document SwRootFrame -> SwLinePortion encapsulation chainMiklos Vajna
Change-Id: I4c8b7ce0375c97b6947f201aa2389c00089b8f5a Reviewed-on: https://gerrit.libreoffice.org/44751 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>