summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-10-27Improve an snprintf printing css::util::DateTime membersStephan Bergmann
...to avoid GCC 12 trunk > extensions/source/logging/csvformatter.cxx: In member function ‘virtual rtl::OUString logging::{anonymous}::CsvFormatter::format(const com::sun::star::logging::LogRecord&)’: > extensions/source/logging/csvformatter.cxx:241:70: error: ‘%02i’ directive output may be truncated writing between 2 and 5 bytes into a region of size between 0 and 14 [-Werror=format-truncation=] > 241 | snprintf( buffer, buffer_size, "%04i-%02i-%02iT%02i:%02i:%02i.%09i", > | ^~~~ > extensions/source/logging/csvformatter.cxx:241:44: note: directive argument in the range [0, 65535] > 241 | snprintf( buffer, buffer_size, "%04i-%02i-%02iT%02i:%02i:%02i.%09i", > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > extensions/source/logging/csvformatter.cxx:241:44: note: using the range [-2147483648, 2147483647] for directive argument > extensions/source/logging/csvformatter.cxx:241:21: note: ‘snprintf’ output between 30 and 49 bytes into a destination of size 31 > 241 | snprintf( buffer, buffer_size, "%04i-%02i-%02iT%02i:%02i:%02i.%09i", > | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 242 | static_cast<int>(record.LogTime.Year), > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 243 | static_cast<int>(record.LogTime.Month), > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 244 | static_cast<int>(record.LogTime.Day), > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 245 | static_cast<int>(record.LogTime.Hours), > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 246 | static_cast<int>(record.LogTime.Minutes), > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 247 | static_cast<int>(record.LogTime.Seconds), > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > 248 | static_cast<int>(record.LogTime.NanoSeconds) ); > | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I426fd6c54b69c7dcc2153167961295c3bc5cf91f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126116 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 33a7e65502857687e778444c9b55500b40b4df19) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141849 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2022-10-25vcl: re-exporting broken pdfs -> empty pagesDennis Francis
Certain pdf documents when loaded in LO_IMPORT_USE_PDFIUM=1 mode even if pdf-version < v1.6 sometimes has missing objects referred by other objects for determing its stream length for instance. As a result parsing fails and results in a pdf with empty pages. A round trip through pdfium and exporting to v1.6 seems to cure the issue. Possibly it does some repairing work to determine the length of the stream in a independent pass through the file. Change-Id: Id09f67eddab4163ed12a3a3f3a73baf92e2912aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141495 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-10-23sw: fix crash in SwViewShellImp::AddPendingLOKInvalidation()Miklos Vajna
Fatal signal received: SIGSEGV code: 1 for address: 0x0 program/libswlo.so SwViewShellImp::AddPendingLOKInvalidation(SwRect const&) sw/source/core/view/viewimp.cxx:167 program/libswlo.so Notify(SwFlyFrame*, SwPageFrame*, SwRect const&, SwRect const*) sw/source/core/layout/frmtool.cxx:3299 program/libswlo.so SwFlyNotify::~SwFlyNotify() sw/inc/anchoredobject.hxx:204 program/libswlo.so SwFlyFreeFrame::MakeAll(OutputDevice*) sw/source/core/layout/flylay.cxx:141 (discriminator 3) Change-Id: I01a64c6e0c2ad4c72cf1a9edeca2aa22e08441b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139466 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 625b43530b5a8348635092086427288fc8c0f0fe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141575 Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-10-11Bump version to 21.06.34.1cp-21.06.34-1Andras Timar
Change-Id: I609828dba06db29628d5e9c8b2a2f9db4b523313
2022-10-10SVG export: don't loose tab portionsMiklos Vajna
Impress slides are exported to SVG via a metafile. In case shape text has a string like "A\tB", that was exported as "AB", loosing the tab character. The relevant shape is exported as a metafile, with two text array metafile actions (one for "A", one for "B") and the tab needs no explicit action as both "A" and "B" has an explicit position. The SVG contained no explicit position for "B", so the tab was lost visually. Fix the problem by detecting when the doc model has a "\t" without a matching metafile action and emitting the explicit position in that case. An alternative would be to use implWriteTextPortion() to write a <tspan> for the tab, but that doesn't guarantee that the width of the tab in the SVG is the same as in Impress. (cherry picked from commit e7ca10a35fd665722c67eea85e15f71c11c66248) Change-Id: Ie21bffce9d09194159e460fb28ab23fbefd52102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141026 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com> (cherry picked from commit cd04f3973c33e081fb0feb176e7c5e4f11759d77) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/141065 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-09-29sw: fix format brush to override old formatSzymon Kłos
It should not only add attributes but replace old direct formatting with new one (character format). Change-Id: Ieac5c3d8c00b93ee08c74a36ea2ce4938915a2b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139216 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 2515ada695e9dbb92c3a228d0466d76b23a6185d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140380 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140708
2022-09-29sw: fix format brush to reset the font strikeout attributeHenry Castro
The format brush always inserts attributes to a set, it should be intersected. For a special use case, ugly hack to reset the font strikeout attribute. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I94c172e61b3d6d3339b1243a9344952b5c59d872 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138839 Tested-by: Jenkins Reviewed-by: Gökay ŞATIR <gokaysatir@collabora.com> (cherry picked from commit 576ba26d09448f8bc332acdf6d17061e8ad552a3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140376 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-09-21lok: create sidebar on demandSzymon Kłos
Change-Id: I5393bba647aa4667643262e77acc6b6873afb571 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139729 Reviewed-by: Ashod Nakashian <ash@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/140035 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2022-09-16Bump current iOS SDK to 16.0Tor Lillqvist
Change-Id: Id44c90b5077e2ac4addb814e1089ed5d0d95df8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139860 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2022-09-15upgrade openssl-1.1.1qco-21.06.33-1Taichi Haradaguchi
Change-Id: I2317e734f074cf7301a6081cf3d2221beeaf5ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139497 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139498
2022-09-15make_installer: convert Win to Unix path for cygwinThorsten Behrens
Usual cygwin auto-conversion magic doesn't work for PATH variable, which requires proper /cygdrive/foo/bar entries. Change-Id: Ic07ffcdf7cb28c5e5702964c331f337ee811c063 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135032 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-09-15Reduce cmd line length for make_installer callsThorsten Behrens
Seems on Windows, we're hitting the 8k character max cmd line length, on setups with slightly deeper src tree path locations. Shorten length of expanded call_installer calls by putting shell script into PATH locally. Change-Id: If1cddab9e4e07a7c5ebfae7a4e88e43b1bc8b907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134938 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-09-15[cp] Collabora Office do not have langpacks on macOSAndras Timar
Change-Id: I5ad3ea78fcc27e2c786f4264e941da8d8b94fec5
2022-09-14Bump version to 21.06.33.1Andras Timar
Change-Id: I6e05aadb9b0afc02414275d1a532250befda03b2
2022-09-07check impress/calc IFrame "FrameURL" targetCaolán McNamara
similar to commit c7450d0b9d02c64ae3da467d329040787039767e Date: Tue Aug 30 17:01:08 2022 +0100 check IFrame "FrameURL" target Change-Id: Ibf28c29acb4476830431d02772f3ecd4b23a6a27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139495 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-09-07These commands are always URLs alreadyStephan Bergmann
Change-Id: I5083765c879689d7f933bbe00ad70bb68e635a21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139042 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit e61701e1ee6763de72b397e6ade1124eca9400f3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138980 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 5b4025bb56999f5c895c6f7e0b52f521800d65b0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139505 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-09-07Filter out unwanted command URIsStephan Bergmann
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139225 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 27d29f7df428885865a8e2313283839b20f2a34b) Conflicts: desktop/source/app/cmdlineargs.cxx Change-Id: I0b7e5329af8cc053d14d5c60ec14fe7f364ef993 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139182 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit da291e2960b75153f41d440a1b41961567432e8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139506 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-09-07check IFrame "FrameURL" targetCaolán McNamara
similiar to commit b3edf85e0fe6ca03dc26e1bf531be82193bc9627 Date: Wed Aug 7 17:37:11 2019 +0100 warn on load when a document binds an event to a macro Change-Id: Iea888b1c083d2dc69ec322309ac9ae8c5e5eb315 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139059 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit c7450d0b9d02c64ae3da467d329040787039767e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139117 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139527 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2022-09-01jsdialog: send action not update for spin button valueSzymon Kłos
This will help us to reduce payload and fix bug where in Chrome regenerated spin field always focused "arrow down" button after click on the "arrow up". Use value from formatter - the same as generated in widget update JSON. Change-Id: I6ace90eb532e894daacb563bc9fb93332fd755ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138700 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Rashesh Padia <rashesh.padia@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/139120
2022-08-31lok: make sure flushPendingLOKInvalidateTiles() is calledLuboš Luňák
SwViewShellImp::AddPendingLOKInvalidation() collects invalidations, but this was relying on something eventually calling flushPendingLOKInvalidateTiles(), which wasn't guaranteed. If e.g. a spellchecker caused an invalidation from in idle callback and nothing else changed, then the LOK callback handling code didn't know there was something pending. So add an explicit call to ensure to notify about these pending invalidations. Change-Id: I0a9cb0d5aba2fdbbac126cd8a4a3412bef1cab25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136533 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-08-19added nullptr guardPranam Lashkari
solves the segfault introduced in d365da2c4 Change-Id: Ic9ab0c9e18a562cdc2120b1e1300c9b44e3f0900 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138513 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
2022-08-18sw: online: make sure commment removal notification is sentPranam Lashkari
problem: when comment is added inside a table in online, and entire table is deleted, comments were not removed due to notification not being sent. Another failed case was when some text with comment is copy pasted, and then pasted text is undoed, text was removed but comment stayed. This patch will notify comment removal before actaully distroying the comment/note Signed-off-by: Pranam Lashkari <lpranam@collabora.com> Change-Id: I70aad7eb421b4bde52b9e54855e2360c59807852 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138398 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/138464
2022-08-11ofz: don't register style if hbox load failedCaolán McNamara
Change-Id: I4d9d5d76f0c2385871003720e933ed1926f66c70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130771 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit 3ac009bfec614ece98313c6444b4c1183ff14954)
2022-08-11ofz: glyph data must be at least 10 bytes long to be usefulCaolán McNamara
Change-Id: I312c33c598013feced15c6f2dbcc66e493b703e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130767 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit b228045cf3fb50128fd40a8f26376443ad22f874)
2022-08-11ofz: measure maximum possible contoursCaolán McNamara
Change-Id: Ie039abd835fef06514edde12b99e17360f5481a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130774 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 26abdb564dad2011a298fc1253279232cb8b59cf)
2022-08-11lastPoint might be 0xFFFFCaolán McNamara
LIBREOFFICE-KYYAZMB9 Change-Id: Ic0d95bd39a01dc1e5e0fec83dcc2c40b3f23b747 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130462 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 21ea1eacd214dbaac8d0ce7f437580d535871415)
2022-08-11fail more gracefully if m_aTmpPosition is emptyCaolán McNamara
LIBREOFFICE-N4LA0OHZ Change-Id: I7f863151f753ad5605c4f1f280cfd79aa4c6bce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130772 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 02837024ea8d3d52c92420858327b309f2e96487)
2022-08-11ofz#44991 keep paragraph's that failed to load until import is completeCaolán McNamara
to avoid dangling references to them Change-Id: Ic8710f63a8cf6a6a665348c7c84bf0b43f0e2c83 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130643 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 4836ac408b04225b66246671e29a54cd0d6703cf)
2022-08-11ofz#44991 don't skip over terminatorCaolán McNamara
Change-Id: Ibc942705a788db60c104d00916a45d595596285e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130560 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 4ac060fce70a4b116207d061efbb6185e6162d04)
2022-08-11ofz#45081 check font lengthCaolán McNamara
Change-Id: Ib8cea70652ae90403db3546c07d24a517b1ec93e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130635 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 568753f4d867c4681b762b63f9b1254f56865da4)
2022-08-11ensure null terminatorCaolán McNamara
LIBREOFFICE-WB8DT2Q9 Change-Id: I98529325bbd3ff475ba84b4991eb17240440df4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130668 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit 4b6956ca146f25b746f63c176b377d3c15d204ff)
2022-08-11ofz#44991 keep within legal ArrowShape rangeCaolán McNamara
Change-Id: I6bf70f27a66ba9b355a3f7ae0c68a696a7284871 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130562 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 7171ec3e400505fbeead152718eebd5cc6c624d7)
2022-08-11add to suffix denylistCaolán McNamara
mostly https: //support.google.com/mail/answer/6590?hl=en#zippy=%2Cmessages-that-have-attachments but see also: https://www.howtogeek.com/137270/50-file-extensions-that-are-potentially-dangerous-on-windows Change-Id: Ibe3abbdcdb6f82a73d245318ef97d86789d00523 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130394 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130382 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 8b72ddb734e0f4457d0233ae9e56dd76526f1dc9)
2022-08-11keep paragraph's that failed to load until import is completeCaolán McNamara
LIBREOFFICE-509JU93T Change-Id: I526edb182fed4fa023cce58e78a650a7c2046ed3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130326 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 32e8d3e45698a3cc09f66460b460db1d10ac50b5)
2022-08-11fix range checking in calls like ScDocument::GetNote()Luboš Luňák
Change-Id: I5612e765b3484b0515f4a16030ee19133ae3126a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130076 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 957d99a539df6e21fd40370938ca5dab1613cf8c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130105 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 77bef67094579e7d0d2a515f5f8a5def8abe49e8)
2022-08-11clear ScDocumentImport position cache if iterators are invalidCaolán McNamara
SheetDataBuffer::finalizeArrayFormula calls ScCellRangeObj::setArrayTokens ScDocFunc::EnterMatrix ScDocument::InsertMatrixFormula and InsertMatrixFormula calls the variant of ScColumn::SetFormulaCell which doesn't take a sc::ColumnBlockPosition& param when SetFormulaCell adds a cell to the column so any iterators belonging to ScDocumentImport are invalid. Change-Id: Ic2814ecbeafdeb99632d2a255ed6c1dedf7376b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130151 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit fea55f5ef8dba16706033c9efdd33c45477eb333)
2022-08-11Better handling of msiRenwa Hiwa
LIBREOFFICE-SK4E5D8N Change-Id: I44f25a47ab6ffeb9d2b679874c8c96af1319eb2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130317 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit ccaabe8e8100a3a0600456c5a65221ca2b263c95)
2022-08-11avoid dangling tmp files in hwp importCaolán McNamara
if there is embedded data use office-binary-data to transport it instead of a temp file https: //issues.oasis-open.org/browse/OFFICE-3933 Change-Id: Ia1cebf0770c99210df09f03dbb507451d9cf7764 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129076 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit e95d5d5666505cb05e9660f24f6c7ae039451ef8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129759 (cherry picked from commit bfff5c7dadf9628926fbb5cd0394fcfc4464eb0b)
2022-08-10use our own tempfile mechanismCaolán McNamara
Change-Id: Ie7853ea8bd083d1056872cfad4323ff6cede235f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129071 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 45c15e1112e03b8b211ed0968ed1b16d5ed4ddfe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129758 (cherry picked from commit 63fcec3105b060cffde5e94fe688c8a59418e4c0)
2022-08-10limit style export to words max style countCaolán McNamara
and use std::vector LIBREOFFICE-U78X8I5G Change-Id: I436b4c13a4ce07f5e9e5d374163bc4de55cd2cde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129766 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 8e94ec9d93fe3e1057fb1aaa2f0419114c4ea11c)
2022-08-10tdf#145842 canceling remote file delete makes file disappear from treeviewCaolán McNamara
we remove the selected entries from the treeview, so the user cancel's the deletion of an entry we should unselect it from the candidates to remove. and... Related: tdf#145842 fix a crash after deleting an entry delete an entry in remote files dialog and go one level up and crash, ownership of the SvtContentEntry is not with the entry, but belongs to mpImpl->maEntries Change-Id: Ieb2258960fc647ad15d8f315a18454a0dae8a420 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125793 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit 9d13202243b26d507b61eb4a787d1df2ce037e21)
2022-08-10Resolves: tdf#145840 call ToggledDavsHdl on setting checkbox stateCaolán McNamara
Change-Id: Ia2a735255b94fd3a097081950e2145e07b4b3b63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125723 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit b23a16ff513369b6bf1f534a387d911b6336c9c8)
2022-08-10hwpfilter: why isn't that path string null terminatedMichael Stahl
Change-Id: Iaedc23bd91d0d46e34d55dcc65760b73c5772b7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131559 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 4c86ed851bc1c0a2414e254082064760c99437f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131593 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit eb84cf3f406808658f3efd9320e0a047c90be12f)
2022-08-10ofz: Too many hatch pointsCaolán McNamara
Change-Id: I08cb9d09a9bb48ab31763f50bc2fa23cf723330f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131014 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit bee0950a4c5bd996a8df0185b03c0f98e7a3de9c)
2022-08-10ofz#45524 string is presumed to be at least length 1Caolán McNamara
Change-Id: If8a86e399109b414cf53f6e2bffdd3c7c6faa490 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131468 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit eca150aeb9254a3c04d15be5a6278c2c65bf3fb0)
2022-08-10read of width/height uses wrong record sizezhutyra
this initially went wrong at: commit b4fb7a437bb0ce987702b12008737756623618ac Date: Mon May 23 21:38:40 2011 +0100 fix up some more endian LIBREOFFICE-SBQ5TJRS Change-Id: Ie418f530f55288351f73f3c0cbab9ac48e6b6964 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129259 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 6694e3ea9c2f05a20245d94c5c1eda955cb3aacc)
2022-08-10ensure bounds checkingzhutyra
LIBREOFFICE-SBQ5TJRS Change-Id: I71f35bc120fdd70298685131f29a6bb822d50f11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129261 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 17dd787a4ca9c17883e0bdfc75c89c2fa7ec169e)
2022-08-10ofz#43577 valid reclen must be >= 20Caolán McNamara
Change-Id: I454bff4acfcd85701a7f094a8bd76898825e9ce2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128388 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 444477a07bcaf59181dbbc719b913566091deadc) ofz: Use-of-uninitialized-value Change-Id: I6b768b80d972c5379005efecfb803463ca648b4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 7b37a1a5144a3a4c8b0803b7e2da81e9e108bf66) ofz: Undefined-Shift Change-Id: Ib935359071ef9e390aa3d6c9713ed48241ad18e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129066 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e863b90a0e5fc90c3b824e4b0012f9389b87a3ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/129183 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 7c8b41bc322720dc9434fbef1f10a6740913165e) (cherry picked from commit afeb3af6b990e59e4e81f74d0a68d479fdfcc862)
2022-08-10ofz: Use-of-uninitialized-valueCaolán McNamara
Change-Id: Ic5f41e4f1f6b20a8cd8887807296f33adb48b728 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128439 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit bb03203848ef1c30786ad084440b5d317a466127)
2022-08-10ofz#44080 throw exception on a negative lengthCaolán McNamara
Change-Id: I3e2286cea69908fae3a2dd177d10fca2b7f0c877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128956 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit af8709defeb90464c8724d3fe5fb8cbbf6efc2b8)