summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-09-22Version 7.6.2.1, tag libreoffice-7.6.2.1libreoffice-7.6.2.1Christian Lohmaier
2023-09-22bump product version to 7.6.2.1Christian Lohmaier
Change-Id: I7161b702a6162f27da9a04aec5d2524d931a5ded
2023-09-22Branch libreoffice-7-6-2Christian Lohmaier
This is 'libreoffice-7-6-2' - the stable branch for the 7.6.2 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.6.x release, please use the 'libreoffice-7-6' branch. If you want to build something cool, unstable, and risky, use master.
2023-09-22tdf#125543 Fix window size in GTK3 pluginAmin Irgaliev
When importing a csv file, the size of the main window Calc in windowed mode were not set because of erroneous check for widget visibility in gtk3. Now it isn't the visibility of the widget that is checked, but whether the checked widget is a window. A similar problem was observed in Base Change-Id: I48f882f407ba17c6c983c5b0939b9ff789ee59f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153670 Tested-by: Jenkins Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 431dc963a0d18341c9b4869a2a64009b7ff7f699) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157119 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-09-22update creditsChristian Lohmaier
Change-Id: I376459b1bee20e819ba3ee8fa6776d79fe84e8b8 (cherry picked from commit 7d6ca465224e5e839055e9607deeb2a80a93621b)
2023-09-22Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-6' to b20fc28cbc0a5354ced3dc4c796e811779ed9314 - update translations for 7.6.2 rc1 and force-fix errors using pocheck Change-Id: I4d67bc1f9fd00a8f5f2018365cc9af3c2c03a985
2023-09-22Update git submodulesQuentin PAGÈS
* Update dictionaries from branch 'libreoffice-7-6' to 9fc97adb6e81018a560527b8969b997dab4f48c1 - Update of Occitan spellchecker (more words and up-to-date licence Change-Id: Icf0cb0e4e00460116db7ac68d91c587e5715f85c Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/151730 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 37935d20de99a065b8660d334a53d7b969446714) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/156007 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-09-22Update git submodulesAndras Timar
* Update dictionaries from branch 'libreoffice-7-6' to 554cc0e77f36474a2b449721046816762d78ca6e - Updated Slovak dictionaries (v2.4.7 2023-08-29) Change-Id: Id35b971fdb7a0391cc75623b176d8bb47fd6d3d4 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/156265 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 14689ec8caaecc2e58281e1876beb2800285be14) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/156218 Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-09-22tdf#157312 Don't change priorityPatrick Luby
Instances of this class are constructed with TaskPriority::POST_PAINT, but then it was set to TaskPriority::HIGHEST when reused. Flushing seems to be expensive (at least with Skia/Metal) so keep the existing priority when reused. Change-Id: Ieb40cd6122f543f76e66456cc92a8643e2320d73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157162 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit daa4a29c993df2e137b222ac3e60aa4b417a2d2d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157122
2023-09-21tdf#55160 sw floattable, nested DOCX imp: fix inner tables at cell startMiklos Vajna
The trouble was that in case two floating tables start at an (outer) cell start, then everything up to the end of the first inner table ended up in the body text, not in the outer table. This happens because the table depth of the inserted dummy character was incorrect. Fix the problem by comparing what model.xml does at <w:p> start and what OOXMLFastContextHandlerTextTable::lcl_startFastElement() did in the dummy paragraph case, and sending the table depth in the dummy case as well. With this the bugdoc has the expected 19 floating tables in Writer and is of 1 page, both matching Word. Change-Id: I604956f28fdc01943ab913c5aa30365376c4d2b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157006 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit a33316afa4a20499159b8c900e56658512deb74a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157112 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-21tdf#157129 sw: fix wrong cursor position after pasteMichael Stahl
This asserts in SwUndoInserts::UndoImpl(): index.cxx:234: virtual SwContentIndexReg::~SwContentIndexReg(): Assertion `!m_pFirst && !m_pLast && "There are still indices registered"' failed. Because there is a bookmark still registered, because the content was inserted wrongly into a fly frame that contains a SwGrfNode, because earlier the cursor was in a hidden text node and SwCursorShell::UpdateCursorPos() moved it into an as-char anchored image. UpdateCursorPos() should put the cursor only onto a text node. (somehow regression from commit bb733957dd39e6f0b9d80bb59eb0177188794797) Change-Id: If00d1e09a612849a44bb3e2d3bd7bac6fa9ac05f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157071 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit b20ca8d951e8205c8b963c6b7407f984053b4094) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157110 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-21Revert "tdf#117118 - Saves data automatically in Firebird embedded database"Juan C. Sanz
This reverts commit 9227fbabe0a33134f56aefdd8ec16024f006a659. Reason for revert: This patch generate a new bug, so I revert it until further investigation Change-Id: I4d613db8cef5363c6b276b8646147443871c312a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157117 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-20tdf#156842 increase scale for external PDF dataPatrick Luby
For some unknown reason, the scale is 8 times larger than for non-external PDF XObjects. This fix also allows the CppunitTest_vcl_pdfexport to run successfully on macOS. Change-Id: I166914e6ac575c50985efba3fb7a38ec758dea1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157090 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit c2d7c8e5c616980d5fa77ac48babbf27342b2f0a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157113 Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-09-20attempt to fix macos jenkins hangs - part 3Patrick Luby
oox::xls::WorkbookFragment::finalizeImport() calls AquaSalInstance::DoYield() with bWait set to true. But since unit tests generally have no expected user generated events, we can end up blocking and waiting forever so don't block and wait when running unit tests. Change-Id: I14cfdb88f04b82f49e8c15e554e5c4b4053e77b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156826 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org> (cherry picked from commit 26313599b0eae3b397bb341c63d185f8771af82d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157115
2023-09-20Related: tdf#55160 sw floattable, nested DOCX imp: fix inner tbl at cell startMiklos Vajna
The bugdoc has an outer table and also two inner tables: the problematic one is the floating table anchored at the start of B1, which should float but does not. This special-casing was added in commit c1eebcdac9f2b289fd363399130c485ca5ff444c (tdf#79329 DOCX import: fix missing outer table with floattable at cell start, 2016-11-08), because there was no easy way to make sure that an inner floating table at cell start keeps the outer table import working, and having 2 inline tables is better than having an inner floating table and no outer table at all. The root of the problem is that in case an SwXParagraph tracks the outer cell start and we have an inner floating table, then the inner conversion to text frame will invalidate that SwXParagraph, so the outer table conversion will fail. Fix the problem by creating a cursor at cell start, moving it away, performing the inner table resolution. And in case the cell start SwXParagraph is now invalid, then move the cursor back and work with that position. The original bugdoc has 2 floating tables at cell start, which is still broken, but this approach allows fixing that in a later commit; while the old approach simply didn't notice that the 2nd floating table is also at cell start. Change-Id: Iedad7b2f023e88dfc5de7875ebc00320c2e6ad65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156937 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 2d43c34333076fad092f0cdc0f60f81580acdbee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157054 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-19Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-6' to ebbf9880f2320e0966309a4f3bc8f72492bce13a - update translations for 7.6.2 rc1 and force-fix errors using pocheck Change-Id: I335530380b57b0a29a9f74d9bdbcaa549282d9e8
2023-09-19Related: tdf#55160 sw floattable, nested DOCX exp: fix inner tbl at cell startMiklos Vajna
A cut-down bugdoc had an inline table, and an inner floating table, anchored in the start of the C1 cell. Exporting to DOCX resulted in a layout that looks like the floating table is not anchored inside the outer table anymore. Checking the markup, the floating table was written between row 1 & row 2, which is not a valid position for a floating table. Probably the intention was to write the floating table before the first paragraph in C1. Fix the problem by still writing the floating table in DocxAttributeOutput::StartParagraph(), before opening <w:p>, but do this after opening table/row/cell, which is late enough to have a correct anchor but is early enough to be still outside the paragraph. The import side of this still needs fixing. Change-Id: I1827b2def1faaf53312522f5a8415fbe697fcb8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156904 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit d50e5d6d53c94124f825758a74e186b934fc2a4e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157052 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-19tdf#157304 Use normalized selection indices as string indicesMichael Weghorn
The start index of the selection can be larger than the end index. Take that into account when using these indices to calculate the index and character count to copy the relevant substring using `OUString::copy`. Without this, running the tdf#157304 macro would trigger an assert due to invalid indices being used. Backtrace: soffice.bin: .../libreoffice/sal/rtl/strtmpl.hxx:890: void rtl::str::newfromsubstring(rtl_tstring**, const rtl_tstring*, sal_int32, sal_int32) [with rtl_tstring = _rtl_ustring; sal_int32 = int]: assertion `false' failed. Thread 1 "soffice.bin" received signal SIGABRT, Aborted. __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 44 ./nptl/pthread_kill.c: No such file or directory. (gdb) bt #0 __pthread_kill_implementation (threadid=<optimized out>, signo=signo@entry=6, no_tid=no_tid@entry=0) at ./nptl/pthread_kill.c:44 #1 0x00007ffff78a814f in __pthread_kill_internal (signo=6, threadid=<optimized out>) at ./nptl/pthread_kill.c:78 #2 0x00007ffff785a462 in __GI_raise (sig=sig@entry=6) at ../sysdeps/posix/raise.c:26 #3 0x00007ffff78444b2 in __GI_abort () at ./stdlib/abort.c:79 #4 0x00007ffff78443d5 in __assert_fail_base (fmt=0x7ffff79b8dc8 "%s%s%s:%u: %s%sAssertion `%s' failed.\n%n", assertion=assertion@entry=0x7ffff7f6f2ec "false", file=file@entry=0x7ffff7f6be70 ".../libreoffice/sal/rtl/strtmpl.hxx", line=line@entry=890, function=function@entry=0x7ffff7f6f260 "void rtl::str::newFromSubString(rtl_tString**, const rtl_tString*, sal_Int32, sal_Int32) [with rtl_tString = _rtl_uString; sal_Int32 = int]") at ./assert/assert.c:92 #5 0x00007ffff78533a2 in __assert_fail (assertion=0x7ffff7f6f2ec "false", file=0x7ffff7f6be70 ".../libreoffice/sal/rtl/strtmpl.hxx", line=890, function=0x7ffff7f6f260 "void rtl::str::newFromSubString(rtl_tString**, const rtl_tString*, sal_Int32, sal_Int32) [with rtl_tString = _rtl_uString; sal_Int32 = int]") at ./assert/assert.c:101 #6 0x00007ffff7eee8b7 in rtl::str::newFromSubString<_rtl_uString>(_rtl_uString**, _rtl_uString const*, int, int) (ppThis=0x7fffffffae40, pFrom=0x55555e7af450, beginIndex=6, count=-6) at .../libreoffice/sal/rtl/strtmpl.hxx:890 #7 0x00007ffff7ee91ca in rtl_uString_newFromSubString(rtl_uString**, rtl_uString const*, sal_Int32, sal_Int32) (ppThis=0x7fffffffae40, pFrom=0x55555e7af450, beginIndex=6, count=-6) at .../libreoffice/sal/rtl/ustring.cxx:1219 #8 0x00007ffff1697b52 in rtl::OUString::copy(int, int) const (this=0x7fffffffae88, beginIndex=6, count=-6) at .../libreoffice/include/rtl/ustring.hxx:2229 #9 0x00007ffff1814180 in svt::EntryImplementation::GetSelected(LineEnd) const (this=0x55555ed5e660) at .../libreoffice/include/svtools/editbrowsebox.hxx:371 #10 0x00007ffff180d61b in FmXEditCell::getSelectedText() (this=0x55555ed5d500) at .../libreoffice/svx/source/fmcomp/gridcell.cxx:3739 #11 0x00007fffdc1496f5 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) (pThis=0x55555ed5d600, nVtableIndex=8, pRegisterReturn=0x7fffffffb2f0, pReturnTypeRef=0x555555743db0, bSimpleReturn=false, pStack=0x7fffffffb020, nStack=0, pGPR=0x7fffffffb180, pFPR=0x7fffffffb1b0) at .../libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:75 #12 0x00007fffdc1481a0 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, typelib_TypeDescriptionReference*, sal_Int32, typelib_MethodParameter*, void*, void**, uno_Any**) (pThis=0x55555e7b0490, aVtableSlot=..., pReturnTypeRef=0x555555743db0, nParams=0, pParams=0x0, pUnoReturn=0x7fffffffb2f0, pUnoArgs=0x7fffffffb2e0, ppUnoExc=0x7fffffffb3d0) at .../libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233 #13 0x00007fffdc148cdd in bridges::cpp_uno::shared::unoInterfaceProxyDispatch(uno_Interface*, typelib_TypeDescription const*, void*, void**, uno_Any**) (pUnoI=0x55555e7b0490, pMemberDescr=0x55555cccccc0, pReturn=0x7fffffffb2f0, pArgs=0x7fffffffb2e0, ppException=0x7fffffffb3d0) at .../libreoffice/bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413 #14 0x00007fff5beb45f2 in stoc_corefl::(anonymous namespace)::IdlInterfaceMethodImpl::invoke(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) (this=0x55555ed792f0, rObj=uno::Any("com.sun.star.uno.XInterface": ...), rArgs=empty uno::Sequence) at .../libreoffice/stoc/source/corereflection/criface.cxx:590 #15 0x00007fff68020606 in (anonymous namespace)::IntrospectionAccessStatic_Impl::getPropertyValueByIndex(com::sun::star::uno::Any const&, sal_Int32) const (this=0x55555cc55910, obj=uno::Any("com.sun.star.uno.XInterface": ...), nSequenceIndex=13) at .../libreoffice/stoc/source/inspect/introspection.cxx:588 #16 0x00007fff68020161 in (anonymous namespace)::IntrospectionAccessStatic_Impl::getPropertyValue(com::sun::star::uno::Any const&, rtl::OUString const&) const (this=0x55555cc55910, obj=uno::Any("com.sun.star.uno.XInterface": ...), aPropertyName="SelectedText") at .../libreoffice/stoc/source/inspect/introspection.cxx:498 #17 0x00007fff68022522 in (anonymous namespace)::ImplIntrospectionAccess::getPropertyValue(rtl::OUString const&) (this=0x55555f4211a0, aPropertyName="SelectedText") at .../libreoffice/stoc/source/inspect/introspection.cxx:1014 #18 0x00007ffff4edb132 in SbUnoObject::Notify(SfxBroadcaster&, SfxHint const&) (this=0x55555e7b0530, rBC=..., rHint=...) at .../libreoffice/basic/source/classes/sbunoobj.cxx:2059 #19 0x00007ffff39c55f6 in SfxBroadcaster::Broadcast(SfxHint const&) (this=0x55555e7b07d0, rHint=...) at .../libreoffice/svl/source/notify/SfxBroadcaster.cxx:40 #20 0x00007ffff505a52b in SbxVariable::Broadcast(SfxHintId) (this=0x55555e7b09d0, nHintId=SfxHintId::BasicDataWanted) at .../libreoffice/basic/source/sbx/sbxvar.cxx:155 #21 0x00007ffff5054564 in SbxValue::Get(SbxValues&) const (this=0x55555e7b09d0, rRes=...) at .../libreoffice/basic/source/sbx/sbxvalue.cxx:289 #22 0x00007ffff50568fe in SbxValue::Compute(SbxOperator, SbxValue const&) (this=0x55555f441ac0, eOp=SbxCAT, rOp=...) at .../libreoffice/basic/source/sbx/sbxvalue.cxx:809 #23 0x00007ffff4fd4fb9 in SbiRuntime::StepArith(SbxOperator) (this=0x55555f43f5d0, eOp=SbxCAT) at .../libreoffice/basic/source/runtime/runtime.cxx:1305 #24 0x00007ffff4fd580d in SbiRuntime::StepCAT() (this=0x55555f43f5d0) at .../libreoffice/basic/source/runtime/runtime.cxx:1418 #25 0x00007ffff4fd2fb8 in SbiRuntime::Step() (this=0x55555f43f5d0) at .../libreoffice/basic/source/runtime/runtime.cxx:795 #26 0x00007ffff4f1c85f in (anonymous namespace)::RunInitGuard::run() (this=0x7fffffffbb40) at .../libreoffice/basic/source/classes/sbxmod.cxx:1017 #27 0x00007ffff4f1d2f5 in SbModule::Run(SbMethod*) (this=0x55555cc779e0, pMeth=0x55555f435130) at .../libreoffice/basic/source/classes/sbxmod.cxx:1177 #28 0x00007ffff4f1b907 in SbModule::Notify(SfxBroadcaster&, SfxHint const&) (this=0x55555cc779e0, rBC=..., rHint=...) at .../libreoffice/basic/source/classes/sbxmod.cxx:775 #29 0x00007ffff39c55f6 in SfxBroadcaster::Broadcast(SfxHint const&) (this=0x55555f4305d0, rHint=...) at .../libreoffice/svl/source/notify/SfxBroadcaster.cxx:40 #30 0x00007ffff4f221e4 in SbMethod::Broadcast(SfxHintId) (this=0x55555f430500, nHintId=SfxHintId::BasicDataWanted) at .../libreoffice/basic/source/classes/sbxmod.cxx:2121 #31 0x00007ffff5054564 in SbxValue::Get(SbxValues&) const (this=0x55555f430500, rRes=...) at .../libreoffice/basic/source/sbx/sbxvalue.cxx:289 #32 0x00007ffff4f21e88 in SbMethod::Call(SbxValue*, SbxVariable*) (this=0x55555f430500, pRet=0x55555f42fff0, pCaller=0x55555f441b60) at .../libreoffice/basic/source/classes/sbxmod.cxx:2077 #33 0x00007fff60031152 in basprov::BasicScriptImpl::invoke(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) (this=0x55555eddeae0, aParams=uno::Sequence of length 1 = {...}, aOutParamIndex=empty uno::Sequence, aOutParam=empty uno::Sequence) at .../libreoffice/scripting/source/basprov/basscript.cxx:252 #34 0x00007ffff440c3e8 in SfxObjectShell::CallXScript(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&, rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Any&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&, bool, com::sun::star::uno::Any const*) (_rxScriptContext=uno::Reference to (SwXTextDocument *) 0x55555c8acf20, _rScriptURL="vnd.sun.star.script:Standard.Module1.TestFocus?language=Basic&location=document", aParams=uno::Sequence of length 1 = {...}, aRet=uno::Any(void), aOutParamIndex=empty uno::Sequence, aOutParam=empty uno::Sequence, bRaiseError=true, pCaller=0x7fffffffc670) at .../libreoffice/sfx2/source/doc/objmisc.cxx:1439 #35 0x00007ffff440c8ea in SfxObjectShell::CallXScript(rtl::OUString const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Any&, com::sun::star::uno::Sequence<short>&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&, bool, com::sun::star::uno::Any const*) (this=0x55555794e5c0, rScriptURL="vnd.sun.star.script:Standard.Module1.TestFocus?language=Basic&location=document", aParams=uno::Sequence of length 1 = {...}, aRet=uno::Any(void), aOutParamIndex=empty uno::Sequence, aOutParam=empty uno::Sequence, bRaiseError=true, pCaller=0x7fffffffc670) at .../libreoffice/sfx2/source/doc/objmisc.cxx:1468 #36 0x00007ffff1904e37 in svxform::(anonymous namespace)::NewStyleUNOScript::invoke(com::sun::star::uno::Sequence<com::sun::star::uno::Any> const&, com::sun::star::uno::Any&) (this=0x55555e778920, _rArguments=uno::Sequence of length 1 = {...}, _rSynchronousResult=uno::Any(void)) at .../libreoffice/svx/source/form/fmscriptingenv.cxx:831 #37 0x00007ffff1905461 in svxform::FormScriptingEnvironment::doFireScriptEvent(com::sun::star::script::ScriptEvent const&, com::sun::star::uno::Any*) (this=0x55555c8e5f10, _rEvent=..., _pSynchronousResult=0x0) at .../libreoffice/svx/source/form/fmscriptingenv.cxx:905 #38 0x00007ffff1904264 in svxform::FormScriptListener::impl_doFireScriptEvent_nothrow(std::unique_lock<std::mutex>&, com::sun::star::script::ScriptEvent const&, com::sun::star::uno::Any*) (this=0x55555c8e80e0, _rGuard=..., _rEvent=..., _pSynchronousResult=0x0) at .../libreoffice/svx/source/form/fmscriptingenv.cxx:684 #39 0x00007ffff190469f in svxform::FormScriptListener::OnAsyncScriptEvent(void*) (this=0x55555c8e80e0, p=0x55555e778870) at .../libreoffice/svx/source/form/fmscriptingenv.cxx:744 #40 0x00007ffff19045eb in svxform::FormScriptListener::LinkStubOnAsyncScriptEvent(void*, void*) (instance=0x55555c8e80e0, data=0x55555e778870) at .../libreoffice/svx/source/form/fmscriptingenv.cxx:733 #41 0x00007fffeddb80ed in Link<void*, void>::Call(void*) const (this=0x55555e7788c8, data=0x55555e778870) at .../libreoffice/include/tools/link.hxx:111 #42 0x00007fffeddb51aa in ImplHandleUserEvent(ImplSVEvent*) (pSVEvent=0x55555e7788c0) at .../libreoffice/vcl/source/window/winproc.cxx:2287 #43 0x00007fffeddb70d7 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) (_pWindow=0x555556c6da40, nEvent=SalEvent::UserEvent, pEvent=0x55555e7788c0) at .../libreoffice/vcl/source/window/winproc.cxx:2851 #44 0x00007fffe2e98caa in SalFrame::CallCallback(SalEvent, void const*) const (this=0x555556c6f760, nEvent=SalEvent::UserEvent, pEvent=0x55555e7788c0) at .../libreoffice/vcl/inc/salframe.hxx:310 #45 0x00007fffe2eb8973 in QtInstance::ProcessEvent(SalUserEventList::SalUserEvent) (this=0x55555573db20, aEvent=...) at .../libreoffice/vcl/qt5/QtInstance.cxx:484 #46 0x00007fffee46593b in operator()() const (__closure=0x7fffffffcc20) at .../libreoffice/vcl/source/app/salusereventlist.cxx:119 #47 0x00007fffee465c0f in SalUserEventList::DispatchUserEvents(bool) (this=0x55555573db58, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/source/app/salusereventlist.cxx:120 #48 0x00007fffe2eb8458 in QtInstance::ImplYield(bool, bool) (this=0x55555573db20, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt5/QtInstance.cxx:410 #49 0x00007fffe2eb8603 in QtInstance::DoYield(bool, bool) (this=0x55555573db20, bWait=true, bHandleAllCurrentEvents=false) at .../libreoffice/vcl/qt5/QtInstance.cxx:432 #50 0x00007fffee5221a8 in ImplYield(bool, bool) (i_bWait=true, i_bAllEvents=false) at .../libreoffice/vcl/source/app/svapp.cxx:377 #51 0x00007fffee522f46 in Application::Yield() () at .../libreoffice/vcl/source/app/svapp.cxx:461 #52 0x00007fffee521e9b in Application::Execute() () at .../libreoffice/vcl/source/app/svapp.cxx:355 #53 0x00007ffff7a36296 in desktop::Desktop::Main() (this=0x7fffffffd720) at .../libreoffice/desktop/source/app/app.cxx:1601 #54 0x00007fffee541f42 in ImplSVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:204 #55 0x00007fffee542077 in SVMain() () at .../libreoffice/vcl/source/app/svmain.cxx:236 #56 0x00007ffff7aa1b81 in soffice_main() () at .../libreoffice/desktop/source/app/sofficemain.cxx:94 #57 0x00005555555549d4 in sal_main () at .../libreoffice/desktop/source/app/main.c:51 #58 0x00005555555549ba in main (argc=2, argv=0x7fffffffd948) at .../libreoffice/desktop/source/app/main.c:49 Change-Id: Ib6989cc302419bf44a59bd2fff159257f647726d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157017 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 2632ce875f9a9c3b0a7861112dbfc48fe17bc2a5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156961 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-19tdf#156683 a11y: Handle both disposing variants in context wrapperMichael Weghorn
commit db0044242a897e447988169630ff74e4c8bfecf9 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Sep 6 09:12:23 2023 +0200 tdf#156683 a11y: Forward when wrapped a11y context is disposing switched from overriding `disposing()` to overriding `disposing(const css::lang::EventObject&)` in `OAccessibleContextWrapperHelper` in order to make sure that the corresponding entry in the `AccessibleEventNotifier` client map is removed and event listeners for the wrapper get notified (via `AccessibleEventNotifier::revokeClientNotifyDisposing`) when the wrapped object is disposing. As Noel points out in [1], the `disposing()` case should probably still be overriden/handled and make sure that the wrapped object etc. get disposed, so disposing one object via the other works both ways. (If the wrapped object is disposed, so is the wrapper. If the wrapper gets disposed, so is the wrapped object.) Therefore, add back `OAccessibleContextWrapper::disposing()` and extract the logic to a separate helper method that is called from both `disposing` variants. [1] https://gerrit.libreoffice.org/c/core/+/156592/comments/bb7c24bc_94033649 Change-Id: If15fd1839b222ad94fcbc569842dc43b517d3574 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156620 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit d9e31f3c82082226dbc5afa697d0f0ac7e4214a2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156602 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-19tdf#156683 a11y: Forward when wrapped a11y context is disposingMichael Weghorn
`OAccessibleContextWrapper` wraps an `XAccessibleContext` held in the `m_xInnerContext` member and forwards calls to its own methods to that one. The lifecycle of the wrapper should match that of the wrapped context, so handle when the wrapped context is disposing by overriding `XAccessibleContext::disposing` (that takes a `css::lang::EventObject&` parameter) instead of overriding `WeakComponentImplHelperBase::disposing` (the `disposing` method not taking a param) that's meant to be called when/right before the object itself gets disposed (but wasn't called at all e.g. for the `OToolBoxWindowItemContext` case in tdf#156683). This makes sure that the corresponding entry in the `AccessibleEventNotifier` client map is removed and event listeners for the wrapper get notified (via `AccessibleEventNotifier::revokeClientNotifyDisposing`) when the wrapped object is disposing and fixes the tdf#156683 crash on exit with gtk3 observed in the libreoffice-7-6 branch: /usr/include/c++/13/debug/vector:450: In function: std::debug::vector<_Tp, _Allocator>::const_reference std:: debug::vector<_Tp, _Allocator>::operator[](size_type) const [with _Tp = com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>; _Allocator = std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> >; const_reference = const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>&; size_type = long unsigned int] Error: attempt to subscript container with out-of-bounds index 0, but container only holds 0 elements. Objects involved in the operation: sequence "this" @ 0x561465d8e510 { type = std::debug::vector<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>, std::allocator<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> > >; } warn:desktop:197113:197113:desktop/source/app/crashreport.cxx:61: minidump generated: /home/michi/development/git/libreoffice-WORKTREE/instdir/program/../program/../crash//e338ad13-2338-4cd0-8d5c069d-c28f5cf5.dmp Backtrace: 1 comphelper::OInterfaceContainerHelper4<com::sun::star::accessibility::XAccessibleEventListener>::disposeAndClear interfacecontainer4.hxx 397 0x7f2c39915cdc 2 comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing accessibleeventnotifier.cxx 204 0x7f2c39913c75 3 comphelper::OAccessibleContextWrapper::disposing accessiblewrapper.cxx 610 0x7f2c3992f033 4 cppu::WeakComponentImplHelperBase::dispose implbase.cxx 104 0x7f2c3947491b 5 cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::accessibility::XAccessibleContext>::dispose compbase.hxx 90 0x7f2bf8b31c70 6 cppu::WeakComponentImplHelperBase::release implbase.cxx 79 0x7f2c39474664 7 cppu::PartialWeakComponentImplHelper<com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::accessibility::XAccessibleContext>::release compbase.hxx 86 0x7f2c3993133c 8 comphelper::OAccessibleContextWrapper::release accessiblewrapper.cxx 475 0x7f2c3992e536 9 com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>::clear Reference.hxx 231 0x7f2c26929685 10 atk_object_wrapper_dispose atkwrapper.cxx 1074 0x7f2c26928a2e 11 atk_object_wrapper_finalize atkwrapper.cxx 670 0x7f2c26927677 12 g_object_unref 0x7f2c3418c48c 13 AtkListener::~AtkListener atklistener.cxx 57 0x7f2c26900547 14 AtkListener::~AtkListener atklistener.cxx 58 0x7f2c2690057e 15 cppu::OWeakObject::release weak.cxx 230 0x7f2c39556056 16 cppu::WeakImplHelper<com::sun::star::accessibility::XAccessibleEventListener>::release implbase.hxx 115 0x7f2c2690a92e 17 com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>::~Reference Reference.hxx 114 0x7f2c39921b9f 18 std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener>> stl_construct.h 151 0x7f2c399217af 19 std::_Destroy_aux<false>::__destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> *> stl_construct.h 163 0x7f2c39920bd5 20 std::_Destroy<com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleEventListener> *> stl_construct.h 196 0x7f2c3991f10b ... <More> Reverse-debugging to the start of `atk_object_wrapper_dispose` (s. frame 10 above), shows that the the `mpContext` is`: uno::Reference to ((anonymous namespace)::OToolBoxWindowItemContext *) 0x5637df79f1b8 Also, call the base class implementation of the same method, i.e. `OAccessibleContextWrapperHelper::disposing` instead of directly disposing via `OAccessibleContextWrapperHelper::dispose`. The former will call `dispose` via its base class implementation if it hasn't been disposed yet, s. `OComponentProxyAggregationHelper::disposing`. Change-Id: Ief66ffbe075af40f10c5fafa62063bda55f66b2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156610 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit d3acb84c23e8894a51459c4faa6907b0d030fc17) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156592 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-19tdf#157085 Make doc title dialog modalSamuel Mehrbrodt
Change-Id: I7a7574c3ffaa45aeb9bb97d9a1963c52d5619d99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156658 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 48129cabb9a5636207d3b8f4f9fa4e4abac61b8a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156732 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-19tdf#153034: Three wrong Greek characters in WordPerfect 5 importJulien Nabet
Retrieve of the commits of upstream, waiting for libwpd 0.10.4 release. Change-Id: Ie7ef425d1a25e0cb77a00c75c13bc392c30aae12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156768 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit c7588fe795178641bd986df34758887ea247a262) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156736 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-19tdf#157173 Enlarging Fontwork shape replaces used fontNoel Grandin
regression from commit b153d147c9d813f78dd551fc186c261f52c929a1 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Apr 28 15:27:14 2021 +0200 remove support for BITMASK in vcl backends So the code that I removed had if (meFormat == DeviceFormat::BITMASK) SetAntialiasing( AntialiasingFlags::DisableText ); in the VirtualDevice::ImplInitVirDev method. Possibly we will need to make similar fixes in other places that used BITMASK, but this looks like the only spot that really needs it. No idea exactly how this line of code relates to the observed bug though. Change-Id: I858f15cf70a452568128d5ccccb365d9a11f7062 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156815 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 819dec3533750a3a8f483351febe40aae85ca0b7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156740 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-19sw floattable, nesting: add DOCX importMiklos Vajna
There were two problems here: 1) writerfilter/ didn't even try allowing split floating tables for the inner case, because layout didn't support that previously. 2) CppunitTest_writerfilter_dmapper's test3NestedFloatingTables crashed because we expected that in case a fly+table is not toplevel, then the parent is also a fly+table frame, but in this case the parent was just a table frame. Fix this by checking for a table parent instead of a fly parent when deciding if we handle the split as a nested case or a toplevel one. Change-Id: I4c58636ef80371b8ec51a96fe436fa6379c795d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156865 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 5127b1961b762643d47a26704556fd9b8664c6fc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156957 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-19tdf#157187 sw tracked table column: fix DOCX exportLászló Németh
DOCX export of tracked table column changes could result dummy content boxes and missing tracked table column changes in MSO, i.e. lost interoperability. As a workaround, skip exporting content boxes within tracked table cells. Note: bad 0x01 characters and incomplete w:sdt export in table cells since commit b5c616d10bff3213840d4893d13b4493de71fa56 "tdf#104823: support for sdt plain text fields". See also commit 4697d2bda1b37f9cf8b301f5bf044c2390f56333 "tdf#157011 sw tracked table column: fix DOCX import of empty cell". Change-Id: I32f77c7532a9cc6bf5d88a626ac3c62a5c02a34a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156895 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit a388a0d245314182694ea7d7f16c71290a3e4ba2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156881 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-19tdf#157254: CLucene: fix pure virtual call in destructorMike Kaganski
When HelpIndexer::indexDocuments creates lucene::index::IndexWriter with a long path like C:\lo\src\build\workdir\longPathTest_123456789012345678901234567890123456789012345678901234567890\instdir\program\..\program\..\user\extensions\bundled\registry\com.sun.star.comp.deployment.help.PackageRegistryBackend\lu149121qyy8a.tmp\da\help.idxl then CLucene's FSDirectory::FSIndexOutput::FSIndexOutput may fail and throw, which would unwind, and call FSIndexOutput destructor, then procede to inherited BufferedIndexOutput destructor, which calls close(), which calls flush(), which finally calls flushBuffer; and that one was pure virtual in BufferedIndexOutput, which meant, that in BufferedIndexOutput destructor, that was a pure virtual function call, crashing the process. Patch CLucene to have a default implementation of the function, usable in its destructor. Change-Id: I6f84c8cf2bd24b9bb92a71da485089ebf832530a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156944 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157008
2023-09-19sw: fix crash when moving nodes into undo arrayMichael Stahl
In SwUndoSaveContent::MoveToUndoNds() a node is split and in sw::OnlineAccessibilityCheck::runAccessibilityCheck() we get: sw/inc/ndindex.hxx:99: bool SwNodeIndex::operator<(const SwNode&) const: Assertion `&GetNodes() == &rNd.GetNodes()' failed. Try to make sure that OnlineAccessibilityCheck doesn't touch nodes in the undo array. Change-Id: Iaeb0d36c341c05948cdfcce08009b0430a78f214 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156970 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit d19fb1dd668473f2d4f8dbde8bac1fcb34042a6a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156968 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-19Related: tdf#157254 Shorten paths by removing relative partsMike Kaganski
E.g., a path like C:\lo\src\build\instdir\program\..\program\..\user\extensions\bundled\registry\com.sun.star.comp.deployment.help.PackageRegistryBackend\lu149121qyy8a.tmp\da\help.idxl would become 22 characters shorter: C:\lo\src\build\instdir\user\extensions\bundled\registry\com.sun.star.comp.deployment.help.PackageRegistryBackend\lu149121qyy8a.tmp\da\help.idxl Change-Id: Id6d397fdd7a1771225eef2e7e49ddb80802685b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156947 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157009 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-19Sync flatpak-manifest.in with FlathubStephan Bergmann
...including <https://github.com/flathub/org.libreoffice.LibreOffice/commit/c4535c99d165fe22f4ae0dcc59a505f1e96a6f72> "Update gvfs-1.50.6.tar.xz to 1.52.0" Change-Id: I5554a832efc03cfaf35d18f99b459ac2147c4d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157015 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 7365dcd4adce628e60d92161bf226dded0059d91) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156958 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-18Update git submodulesMartin Srebotnjak
* Update translations from branch 'libreoffice-7-6' to b7256e31b601e52fb57dd8e2c713f1cb26b2226c - Updated Slovenian translation Change-Id: I659ec47d800cf28c4f8a87e8465b5a48ebe17f6c
2023-09-18sw floattable, nesting: fix DOCX exportMiklos Vajna
There were two problems here: 1) DocxAttributeOutput::StartParagraph() didn't try to export an inner floating table as a floating table, resulting in writing a shape that can't span over multiple pages. Dropping the !pTextNodeInfo check should be OK, we'll just now clear the m_aFloatingTablesOfParagraph list at the end of the outer table. 2) Once we tried to export the inner fly, the actual table/row/cell start was missing, because m_tableReference.m_nTableDepth wasn't reset, so DocxAttributeOutput::StartParagraph() didn't know it has to emit a table definition before the first para of the table. Fix this by stashing away the table state before the inner fly's export and restoring it after the inner fly export, similar to how this is done in e.g. DocxExport::WriteHeaderFooter(). This is related to tdf#55160. Change-Id: Ib860283d32e392e2906aa12bc9eb61b5af5ca8de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156833 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 2887e6b8edbb4fdb093515a3a68269ed40e42116) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156744 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-18sw floattable, nesting: fix overlap supportMiklos Vajna
The bugdoc had a nested, split floating table with overlap=never and that lead to a layout loop. The root of the trouble seems to be that the inner fly will obviously overlap with its outer fly but we tried to prevent that and we failed. Fix the problem by ignoring inner flys in SwToContentAnchoredObjectPosition::CalcOverlap(). This also allows removing special handling of nested split flys in lcl_ArrangeLowers() and special handling of split flys at an other place in the same function, because now the non-bDirectMove case works out of the box. Change-Id: Icf3a8f776aa758ef4ae2c2994a7216c5a6142a62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156810 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit e20bacc209a8e8483209cb4ec51c9e0b55423cdb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156739 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-18tdf#157096 sw: layout: fix UAF crash from stale mpFlyDestory entryMichael Stahl
It doesn't make sense that mpFlyDestory entries survive exit from SwLayAction. Call DeleteEmptyFlys() whenever DeleteEmptySct() is called. (reportedly crashes since commit c303981cfd95ce1c3881366023d5495ae2edce97 although i'd rather blame commit f6fbd9d5ff5b049112e6ca7a8943c156b3e4f411) Change-Id: Ie03e91a7d089c8aae8a1db65df835841f985771f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156949 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 5a33420923c76d3e282f6d4ce0f3a63616ca3cff) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156953 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-17tdf#157277: fix Writer crash when hiding Sidebar + using bookmark in NavigatorJulien Nabet
Relevant part of bt (from exception thrown): 1 0x00007f00b5398a34 in SfxUnoDecks::getByName(rtl::OUString const&) (this=0x559ce97aff60, aName="NavigatorDeck") at /home/julien/lo/libreoffice/sfx2/source/sidebar/UnoDecks.cxx:45 2 0x00007f00b5398edf in non-virtual thunk to SfxUnoDecks::getByName(rtl::OUString const&) () at /home/julien/lo/libreoffice/instdir/program/libsfxlo.so 3 0x00007f008bc016a5 in SwContentTree::GotoContent(SwContent const*) (this=0x559ce849e850, pCnt=0x559ce4b8cc10) at /home/julien/lo/libreoffice/sw/source/uibase/utlui/content.cxx:5463 See full bts (initial + from exception thrown) here: https://bugs.documentfoundation.org/attachment.cgi?id=189632 Test if xDecks has "NavigatorDeck" before trying to retrieve it since it seems it's not the case when sidebar disabled. Change-Id: Ia0aa64ebf26ad06fd4fe4b14f949453ae7948456 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156978 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 18380cbe922730265cac17d2b710911a2db8f631) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156954 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-09-16Update git submodulesMartin Srebotnjak
* Update translations from branch 'libreoffice-7-6' to 004e780cb193bce41dc2bd1c827f54804f4951b7 - Updated Slovenian translation Change-Id: Ide174c2593927fe870ef57bef1921e3a31b37784
2023-09-16tdf#157174: fix crash when clicking "Print Preview"Julien Nabet
Don't call Reformat method when treating a virtual SdrObject bt: 4 0x00007fd7ff446eb4 in SdrObject::GetBroadcaster() const (this=0x4) at /home/julien/lo/libreoffice/svx/source/svdraw/svdobj.cxx:698 5 0x00007fd7ff48eaee in SdrEdgeObj::Reformat() (this=0x564e82ef22d0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdoedge.cxx:1666 6 0x00007fd7ff551bd9 in SdrObjList::ImplReformatAllEdgeObjects(SdrObjList const&) (this=0x564e82a371e0, rObjList=...) at /home/julien/lo/libreoffice/svx/source/svdraw/svdpage.cxx:760 7 0x00007fd7ff551b38 in SdrObjList::ReformatAllEdgeObjects() (this=0x564e82a371e0) at /home/julien/lo/libreoffice/svx/source/svdraw/svdpage.cxx:744 8 0x00007fd7ff3d8d1c in SdrModel::ImpReformatAllEdgeObjects() (this=0x564e7f79dc50) at /home/julien/lo/libreoffice/svx/source/svdraw/svdmodel.cxx:752 9 0x00007fd7ff3dda3b in SdrModel::setLock(bool) (this=0x564e7f79dc50, bLock=false) at /home/julien/lo/libreoffice/svx/source/svdraw/svdmodel.cxx:1618 10 0x00007fd7c58a9a76 in SwView::~SwView() (this=0x564e82e7bb00) at /home/julien/lo/libreoffice/sw/source/uibase/uiview/view.cxx:1163 11 0x00007fd7c58a9f99 in SwView::~SwView() (this=0x564e82e7bb00) at /home/julien/lo/libreoffice/sw/source/uibase/uiview/view.cxx:1122 12 0x00007fd801835308 in SfxViewFrame::SwitchToViewShell_Impl(unsigned short, bool) (this=0x564e82b17680, nViewIdOrNo=1, bIsIndex=true) at /home/julien/lo/libreoffice/sfx2/source/view/viewfrm.cxx:2528 See complete bt here: https://bugs.documentfoundation.org/attachment.cgi?id=189470 Change-Id: I4de5127686c01a40c1666f6089efa4fe7a114cd0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156934 (cherry picked from commit 17cd1dacf6a4b587b524edc7384ff26990208132) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156950 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-09-15crashreporting: apparent null deref at SwFEShell::IsShapeDefaultHoriTextDirR2LCaolán McNamara
https: //crashreport.libreoffice.org/stats/crash_details/73028951-19a0-409b-89d2-a080495df925 Change-Id: I440465a3c7d5b98ecdd1c5f1973a2b8f64d6772e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156888 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-14tdf#157223 get sequence name before toggling checkboxesCaolán McNamara
The expectation is that setting state/values on widgets from code doesn't trigger any callbacks, which are assumed to be from user interaction only. But explictly toggling on a radio implicitly toggles off the other radio, and while there is no callback from the explicit toggle on, there is from the implicit toggle off. Just move the explicit toggles to the end, after where the values are read which the callback affects. Change-Id: Icfc2c94950be671d6fc23789584b4d3c6e5395d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156879 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2023-09-14crashtesting: fix PDF export of forum-mso-de-118466.docxMiklos Vajna
This went wrong in commit 19a559b0ec9b806519c405651d6d2b2e14712b4a (sw: SwSubFont::GetTextSize_() assert on presumably dead code, 2019-10-14): - as the bugdoc shows, it's not dead code after all, so downgrade the assert to a warning - SwDrawTextInfo::SetText/Idx/Len asserts that the index and length are valid for the text, so set / restore these together Change-Id: I967605324bde757ca11e6684ba6f40c578a211fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156891 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 297e0b6bdd6fb682974f9e3201c7842dd76e31c8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156885 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-14tdf#157112: fix off-by-one error in /LastChar of PDF Type 3 fontsKhaled Hosny
It should be the index of the last glyph in the subset, so nGlyphs - 1. Change-Id: I62853a27b602d7b3e6b6265555542dd417438fcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156630 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org> (cherry picked from commit d93f3243d51438e2492ca6f450ae3f1f63b617b1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156603 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-14tdf#157148 ensure we auto-scroll to current location to make it visibleCaolán McNamara
Change-Id: I03286c10e488adf3a882fa7fe2813724f27c66f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156745 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-14tdf#157088 a11y: Dispose list items with listMichael Weghorn
Don't only clear, but also dispose the list items when the `VCLXAccessibleList` gets disposed. Interestingly, there was already a comment saying // Dispose all items in the list. , but that wasn't done so far... Fixes a crash on exit with the below backtrace after using the font color toolbox item with the qt6 VCL plugin and Orca running: 1 __pthread_kill_implementation pthread_kill.c 44 0x7fe2a2ea80fc 2 __pthread_kill_internal pthread_kill.c 78 0x7fe2a2ea815f 3 __GI_raise raise.c 26 0x7fe2a2e5a472 4 __GI_abort abort.c 79 0x7fe2a2e444b2 5 __assert_fail_base assert.c 92 0x7fe2a2e443d5 6 __assert_fail assert.c 101 0x7fe2a2e533a2 7 (anonymous namespace)::implLookupClient accessibleeventnotifier.cxx 140 0x7fe2a21138a4 8 comphelper::AccessibleEventNotifier::revokeClientNotifyDisposing accessibleeventnotifier.cxx 185 0x7fe2a2113bb8 9 VCLXAccessibleListItem::disposing vclxaccessiblelistitem.cxx 164 0x7fe26870cb58 10 cppu::WeakAggComponentImplHelperBase::dispose implbase.cxx 230 0x7fe2a1c755e3 11 cppu::WeakAggComponentImplHelperBase::release implbase.cxx 204 0x7fe2a1c75312 12 cppu::WeakAggComponentImplHelper6<com::sun::star::accessibility::XAccessible, com::sun::star::accessibility::XAccessibleContext, com::sun::star::accessibility::XAccessibleComponent, com::sun::star::accessibility::XAccessibleEventBroadcaster, com::sun::star::accessibility::XAccessibleText, com::sun::star::lang::XServiceInfo>::release compbase6.hxx 142 0x7fe26870fc0c 13 com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>::~Reference Reference.hxx 114 0x7fe28f2428a7 14 QtAccessibleWidget::~QtAccessibleWidget QtAccessibleWidget.hxx 39 0x7fe28f262cf9 15 QtAccessibleWidget::~QtAccessibleWidget QtAccessibleWidget.hxx 39 0x7fe28f262dd0 16 QAccessibleCache::deleteInterface qaccessiblecache.cpp 173 0x7fe28e0c8e4b 17 QAccessibleCache::~QAccessibleCache qaccessiblecache.cpp 31 0x7fe28e0c845c 18 QAccessibleCache::~QAccessibleCache qaccessiblecache.cpp 32 0x7fe28e0c84e2 19 cleanupAccessibleCache qaccessiblecache.cpp 24 0x7fe28e0c83c8 20 qt_call_post_routines qcoreapplication.cpp 327 0x7fe28e9a4593 21 QApplication::~QApplication qapplication.cpp 663 0x7fe28cf9dff6 22 QApplication::~QApplication qapplication.cpp 717 0x7fe28cf9e2f4 23 std::default_delete<QApplication>::operator() unique_ptr.h 99 0x7fe28f2cf3ae 24 std::__uniq_ptr_impl<QApplication, std::default_delete<QApplication>>::reset unique_ptr.h 211 0x7fe28f2cf7f6 25 std::unique_ptr<QApplication, std::default_delete<QApplication>>::reset unique_ptr.h 509 0x7fe28f2cd72d 26 QtInstance::~QtInstance QtInstance.cxx 273 0x7fe28f2c614f 27 QtInstance::~QtInstance QtInstance.cxx 274 0x7fe28f2c6226 28 DestroySalInstance salplug.cxx 389 0x7fe299a62611 29 DeInitVCL svmain.cxx 600 0x7fe299b41226 30 ImplSVMain svmain.cxx 229 0x7fe299b3f9f7 31 SVMain svmain.cxx 236 0x7fe299b3fa53 32 soffice_main sofficemain.cxx 94 0x7fe2a30a1b5d 33 sal_main main.c 51 0x55c86565c9d4 34 main main.c 49 0x55c86565c9ba Change-Id: I42ddcf5501ddfb363aeae10a86f1c38251e6793b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156522 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 51de048ae97cbd371457dbc07120e30db9ee4187) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156537 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-14tdf#157088 a11y: No need to use WeakReference for list childrenMichael Weghorn
`VCLXAccessibleList` is the owner of the `VCLXAccessibleListItem`s held in that vector, so I see no reason to hold them by weak reference, which according to the doc in `udkapi/com/sun/star/uno/XWeak.idl` is to avoid affecting the lifetime of the objects: > <p>The sense of weak references is to hold a reference to an object > without affecting the lifetime of the object. That means that a weak > reference may become invalid, at any time, if the referenced object dies. > </p> Quite the contrary, it is actually responsible for the lifecycle of the list item a11y objects and should dispose them when itself gets disposed, which will be added in a subsequent commit. Change-Id: I57fe3367f1199cd0c24f006f6e25a1e9c930c154 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156521 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit bfa9d01920e7e042a83627d7fa4e78c70bc7ece5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156536 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-14tdf#154875 "Use slide background" is only for ImpressSamuel Mehrbrodt
Change-Id: I078437a1cff58b868f4db4b482ad2aff335dc965 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156514 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit d4cebb60c7757086fd737e7a2134326209bd4190) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156535 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-14fix use of referenceNoel Grandin
where we may end up with a reference to a different element of the queue than we want. regression from commit 31e66bd07c1082bb375be8aaf7835f019351d9bb Author: Michael Stahl <Michael.Stahl@cib.de> Date: Mon Aug 6 19:03:22 2018 +0200 sw: fix ignored frames in AppendAllObjs() Change-Id: I94801df84b4b130315f67292851fbd129b2fe7d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156919 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit e2a0530a26b5c5b5f48d3e3c695b839d0e5c0164) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156887
2023-09-14fix "variable 'nRow' set but not used [-Werror,-Wunused-but-set-variable]"Christian Lohmaier
as seen on non-debug builds with compiling for x86_64 with XCode 14.3.1 Change-Id: Ib0b97cfcf15cc58d08a90bc0b4aaf43fc1be3c05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156614 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 7f5a9096be8518aff99c3a227d78f36c6dc124fb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156600 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-14Related tdf#156116 - A11Y - fix goto textframes after renaming objectBalazs Varga
Only give one warninig message (Anchor Frames/Text boxes “As Character“.) per floating textframes. Fix goto after renaming textframe. Follow-up of: bac847ded67941c6db21a2f041a0b9dad9d2b0bd 069569e4a095f2fe42e94c2dad15356e2038727a cherry-picked from commit: b4b2f1a58a888855a03a3d4d5c2104350e05b1a9 (Related tdf#156116 - A11Y - fix goto textframes after renaming object) - part 2 Change-Id: Icc2a9cc90fcb948821a5420b8a1dab61a3a977ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156303 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156500 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-09-14Related tdf#156116 - A11Y - show only one warning/textframesBalazs Varga
Only give one warninig message (Anchor Frames/Text boxes “As Character“.) per floating textframes. cherry-picked from commit: bac847ded67941c6db21a2f041a0b9dad9d2b0bd (Related tdf#156116 - A11Y - show only one warning/textframes) - part 1 Change-Id: I6cff4022a30de9734d6afc592f52c7ad4297c18a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156200 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156499
2023-09-14tdf#157231 CVE-2023-4863 upgrade to libwebp-1.3.2.tar.gzCaolán McNamara
Change-Id: Ib60466a59069b59fa884654167f33ccc58e59330 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156882 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-09-13tdf#157101 Make Area dialog narrowerGabor Kelemen
by turning off the homogeneous setting of the top button bar Change-Id: I1e2e4f4db04c4a061c4e699a32b51997495880a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156804 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 7a02d8fffcdcd4d17b52e5bc3e1fa2b5be56a94d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156743 Reviewed-by: Gabor Kelemen <kelemeng@ubuntu.com>
generated by cgit (git 2.34.1) at 2024-07-16 02:31:52 +0000