summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-10-03Bump version to 5.3-28cp-5.3-28Andras Timar
Change-Id: I1e51225f681e68fecf5c3a0fa2c9f2be889dd47d
2017-10-03lok: temporary workaround: disable formula mode for onlineMarco Cecchetti
- Start empty spreadsheet, open it with two users (let's call them A & B). - Type "=" with user A. - Start moving around to different cells with user B. => Cell name of user B's selected cell is entered in user A's formula. This is due to the fact that ScModel::GetInputHandler() returns always the input handler which is handling the edited formula and not the input handler of the current view. That really messes up collaborative editing, so better to disable it, until we implement an alternative solution. Change-Id: I6e779cba3f377d12b7a4a19a6ee53c924fc9ba20 Reviewed-on: https://gerrit.libreoffice.org/43036 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-10-03lok: Fix declaration of ‘xContext’ shadows a global declaration.Jan Holesovsky
Change-Id: Iab3c142cd85ca54bf3c37a0710ce7da7a5d77a35 Reviewed-on: https://gerrit.libreoffice.org/43067 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-10-03lok: handle .uno:LanguageStatus commandHenry Castro
Contains also: LOK: getSpellLanguages() is not necessary in comphelper in the end. Change-Id: I3828113bce3b7d32e90e461a299986e363115a83
2017-10-03framework, lok: It's okay to have valid non-existent user inst. pathPranav Kant
Change-Id: I3b9f00adb76fc702e1847d9fab866b7796cfd942 Reviewed-on: https://gerrit.libreoffice.org/43061 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 9127d1a89cbfba89eb9df6755ea7b9e161cfc67a) Reviewed-on: https://gerrit.libreoffice.org/43064 Tested-by: Jan Holesovsky <kendy@collabora.com>
2017-09-30Bump version to 5.3-27cp-5.3-27Andras Timar
Change-Id: I0451f31e08a77543e4ff3f7f1dba3e9fc12c2597
2017-09-29tdf#112679 sw: fix copying of fieldmarksMichael Stahl
Aha, now we know that the reason for the defensive programming in lcl_AssureFieldMarksSet() was that there are actually 2 different use-cases for it: usually a new mark is inserted, so there are no dummy characters and they must be inserted. However when copying text, the dummy characters are copied too, so they must not be inserted, or we get duplicate fieldmarks. This also reverts commit d4036d3a89b65a4912f62e3930eb1a31cd90a16b which fixed the problem only for CHECKBOX_FIELDMARK in a different way. (regression from bb069fe7b8b6a24f9ff4df4c7052961e17ea3a8c) (cherry picked from commit 421a23bb36bbf51edfabc58b7d2cd28ad37719d0) Change-Id: I3c99b8c6d720951655198e682018794337859373 Reviewed-on: https://gerrit.libreoffice.org/42938 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-28Revert "tdf#112486 Do not force GDI in no OpenGL"Andras Timar
This reverts commit b62fd70ad353da26c74d993bef8d884c2b3a73b7.
2017-09-28Revert "tdf#106990 set cleartype setting / force to use GDI render mode"Andras Timar
This reverts commit a3c9704f4c0cf2a0c6a4982bfb8124af63a506b0.
2017-09-28tdf#112486 Do not force GDI in no OpenGLXisco Fauli
See: http://nabble.documentfoundation.org/Re-Minutes-of-ESC-call-2017-09-21-tt4223238.html Patch only for 5.3 branch Change-Id: I19bb4b58d2260fd23c32a687a9f504540c229985 Reviewed-on: https://gerrit.libreoffice.org/42898 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 5440837e02dee8bc884e02be697bfd4def621d26)
2017-09-28Avoid API present from macOS 10.13 if building to run on olderTor Lillqvist
utimensat() and futimens() are new in 10.13. Change-Id: If0828388607069c8249a45c05fa4ed872f8ec51d Reviewed-on: https://gerrit.libreoffice.org/42874 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 42b8e2e5a76a310c7cf0f29379fe33b52127d16f)
2017-09-28connectx() is available only on Mac OS X 10.11 and newerTor Lillqvist
Compiling against the 10.13 SDK with --with-macosx-version-min- required set to 10.8, 10.9, or 10.10 (or defaulted, meaning 10.8) causes a compilation error now. Earlier SDKs did not catch it if you were using connectx() even if targeting pre-10.11. Try the approach from https://github.com/curl/curl/pull/1336/commits . Change-Id: Id33f4ddd2aae70488f383535225bd6045a1efeec Reviewed-on: https://gerrit.libreoffice.org/42870 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 31991ee5ad2481458b2ba9d53cf91fa47e40a6f8)
2017-09-28Accept macOS 10.13Tor Lillqvist
Change-Id: I9dfc9e8ec6906e0fee4314410d970e02c881e94d Reviewed-on: https://gerrit.libreoffice.org/42869 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 208008c9dd928c9b2ec375594f9a5b66c3f8d9ff)
2017-09-28tdf#86083 Restore old operation buttons but have them hiddenYousuf Philips
Change-Id: I7d006d3d5e22ade59ddfe46f21fbc777a1c75dac Reviewed-on: https://gerrit.libreoffice.org/42684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Yousuf Philips <philipz85@hotmail.com> (cherry picked from commit 7dc82cc2e424b6acddb1aa06338f51db20e6a21e) Reviewed-on: https://gerrit.libreoffice.org/42687 Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 8a808dcb220e068f224266c0dab3fe8dd16a2964)
2017-09-28update creditsChristian Lohmaier
Change-Id: I1f87134063f3a503069cc08bec362a988b8a72ce (cherry picked from commit 1880373663888bfefcb9beb48f71ac14a9da2f34) (cherry picked from commit b59d0d305731d597653f301617a5b6c646be4633)
2017-09-28tdf#112574 sw: don't insert RES_ANCHOR into style item setsMichael Stahl
Styles don't have anchors, only frames have anchors. When using "New Style from Selection", clear the RES_ANCHOR from the style item set. Also, don't insert it in SwFramePage::DeactivatePage(). This was always broken and reportedly crashes since commit e07feb9457f2ffb373ae69b73dda290140e4005f Change-Id: I9320dbbcae980dfa0b00459b8cd808553d1a04f4 (cherry picked from commit 17fe1e19e01f8b23bcd23cc7c1789e8f7064d06e) Reviewed-on: https://gerrit.libreoffice.org/42819 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 2f1ef1d7e3caa806e5f5abddb3ac3761538b935b)
2017-09-28tdf#112634 Don't remove embedded database before closeSzymon Kłos
Change-Id: Iaa60160d40b0f7b5dceba319bc3813d124c34cc1 Reviewed-on: https://gerrit.libreoffice.org/42762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 79a425900e31bda83cde1bee150c1234931cb8bd) Reviewed-on: https://gerrit.libreoffice.org/42844 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-28tdf#112086 PPTX export fltValue, ppt_w, ppt_hSzymon Kłos
Change-Id: Ie77a2f5d9b0179d81c81704d7d760fdceecaa6e1 Reviewed-on: https://gerrit.libreoffice.org/42521 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42843 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-28tdf#111863: Animations turned from out to in during PPTX exportAron Budea
animEffect element's transition attribute was filled from XTransitionFilter's Direction attribute, while it should have been Mode. Reviewed-on: https://gerrit.libreoffice.org/42261 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 1ea4496f3b2defaf51391e816d159717c55f2929) Change-Id: I40be0311a7b7ffc64ac3a97a92a3ea835faa5293 Reviewed-on: https://gerrit.libreoffice.org/42825 Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2017-09-26tdf#112647: Fixed line spacing is saved incorrectly to PPTXTamás Zolnai
The values were not converted to the right unit. Also the spcPts attribute means an exact value not a minimum one. Reviewed-on: https://gerrit.libreoffice.org/42763 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit ef2e9b19a52e04ae0ed45900bcf64bf375a910ef) Change-Id: Ia49683e66153611e96a830f821e3a2487adec505 Reviewed-on: https://gerrit.libreoffice.org/42812 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-26tdf#112334 unit testSzymon Kłos
Reviewed-on: https://gerrit.libreoffice.org/42628 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit f10d5eb1435952052447fcb09dc1ece25202a48a) Signed-off-by: Andras Timar <andras.timar@collabora.com> Change-Id: Ie041595ba604d4563d7ff356eee18ff3e50fef41
2017-09-26tdf#112334 PPTX export style.colorlbenes
Change-Id: I6a5779cee379b82d81cc73a0d0c154e6caa51424 Reviewed-on: https://gerrit.libreoffice.org/42613 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 9bcf000b49252a2293d05135a1a3d62bca5a5dc8) Signed-off-by: Andras Timar <andras.timar@collabora.com>
2017-09-26tdf#112089 add charts to the ShapeMapSzymon Kłos
Charts weren't added to the collection what resulted in missing ids during export (target field). Change-Id: Ie96a4e33a52c5448342a3c3dcec0d8e8b244e270 Reviewed-on: https://gerrit.libreoffice.org/42552 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-26tdf#112333 PPTX export animClrSzymon Kłos
Change-Id: Ibf230a6c4ddac4806dab235c3394778db26da38c Reviewed-on: https://gerrit.libreoffice.org/42476 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42584 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-26tdf#112333 PPTX export fill.type & fill.onSzymon Kłos
Change-Id: I2407d0227e10204354ee69fd9a2af9ca93077221 Reviewed-on: https://gerrit.libreoffice.org/42432 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42526 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-26tdf#112088 gradient stop map -> multimapSzymon Kłos
When two gradientstops were set to position 50% only one was stored and the exported file was detected as broken by MSO. Change-Id: I5fd1acde6051f734a5f3e4cff9bde01b675e1984 Reviewed-on: https://gerrit.libreoffice.org/42210 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42473 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-26Watermark: apply to existing styles (also not used)Szymon Kłos
Change-Id: Ic57418f3191cc3c30a348db3e784d4cfbeffae79 Reviewed-on: https://gerrit.libreoffice.org/42576 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42755 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-26Watermark: apply when new page style is createdSzymon Kłos
Change-Id: I0d0103f8cc351ec87f7c3bf936ef4725a166d315 Reviewed-on: https://gerrit.libreoffice.org/42581 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 22e94ab1860b1bdea8d107d4e8824f63c6b1c8c5) Reviewed-on: https://gerrit.libreoffice.org/42691 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-26xmloff: fix stack-use-after-return in SvXMLExport::exportDoc()Michael Stahl
PropertySetInfo(PropertyMapEntry const * pMap) stores the pointers, and its lifetime is controlled by refcounting, so the lifetime of aInfoMap can't be automatic. ERROR: AddressSanitizer: stack-use-after-return on address ... ... is located in stack of thread T46 at offset 224 in frame SvXMLExport::exportDoc(xmloff::token::XMLTokenEnum) This frame has 39 object(s): ... [224, 288) 'aInfoMap' <== Memory access at offset 224 is inside this variable Change-Id: I4eaa9d38bab708b222d999b0982100d7ef97e95c (cherry picked from commit ee599ea46365adc37f4d495d9ff9778c25c04c92) Reviewed-on: https://gerrit.libreoffice.org/42505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e68c82d2c194aafc6406f9f27caa2d1e70a7614e)
2017-09-26tdf#112005 xmloff: ODF export: export embedded object text *first*Michael Stahl
... before adding any attributes, so that the attributes don't erroneously get added to the paragraph element. Also fix the problem that if you set "ODF format version" to 1.1 or 1.2, export asserts in SvXMLNamespaceMap::GetQNameByKey() because the "loext" namespace isn't registered, and creates an invalid <p> element. Change-Id: I637f9d3ff746d877ced480e35ef53f4545a06a4b (cherry picked from commit 86f256596c8566e80993e1cf6035bc3534b6f816) Reviewed-on: https://gerrit.libreoffice.org/42569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 65c99825ceb08743a70b6e598f65491a67d9a884)
2017-09-26Make the testTdf106974_int32Crop pass on my MacTor Lillqvist
For some reason, on my Mac the Right value is 41226, both times the function gets called. (On my Linux box, it is 46387 and 46394.) So compare to 41000 instead of 46000. Or would it be better to just bypass the test on macOS, as we already do for other tests in this file...? (cherry picked from commit 1391f3702a3daaefc67a8ee4b62ac38959db283f) Make the testTdf106974_int32Crop pass on my Mac, too cf. 1391f3702a3daaefc67a8ee4b62ac38959db283f "Make the testTdf106974_int32Crop pass on my Mac". For some reason, on my Mac the Right value is 40474 resp. 40471 the two times the function gets called. (cherry picked from commit a900c72c675c8605fc004a4f63ba1d82eaeed9d5) Change-Id: I731ff9c5cf76be9d4817ad14f296807017d10dbd Reviewed-on: https://gerrit.libreoffice.org/42642 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit b012ddbf39eaa51a05aec590f35e2f4d46cddd57)
2017-09-26ofz#3457 Unknown ReadCaolán McNamara
similar to commit 35bac83ed2b5d48233c653cc7dc4eab5c234f7ac Date: Mon Aug 7 19:24:37 2017 +0100 ofz#2877: crash in SVTB16Short Change-Id: Idc2ca89647a5e17484effaca49afce349b98f0a3 Reviewed-on: https://gerrit.libreoffice.org/42624 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 46882bb61b1381dd257cd96a255ed71f7af03166)
2017-09-26Resolves: tdf#112180: avoid crash with specific ttfCaolán McNamara
Change-Id: I8cde147279173bffec0c991eb7676f5d4641138d Reviewed-on: https://gerrit.libreoffice.org/41935 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f263692de96ac68e73eeb953b7e92a18d149f30e) Reviewed-on: https://gerrit.libreoffice.org/42507 (cherry picked from commit 70f8b4b9b0330b9150c5d6c3f066834f20023578)
2017-09-26tdf#49634 Fix positioning of focus rectangle in Navigator content treeJim Raykowski
https://bugs.documentfoundation.org/show_bug.cgi?id=49634 Change-Id: I3beb41142281b2cda337b457ed287a2cc1f665a6
2017-09-25tdf#112501: Pivot table: popupbuttons are placed on wrong cellsTamás Zolnai
...imported from XLS Reviewed-on: https://gerrit.libreoffice.org/42508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 0098bee792c3e208ea4f6ef1c676958d3f4cd207) Change-Id: I45bc4a0182e6a62471bc02ac1bca31f9735e6566 Reviewed-on: https://gerrit.libreoffice.org/42647 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-23tdf#112557: Subtitle placeholder shape leads to corrupted PPTX fileTamás Zolnai
Reviewed-on: https://gerrit.libreoffice.org/42611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 238cfa9efa21f08514703ea6cc181ce02d8feb12) Change-Id: I26680ecdb5f0db4f27180c221de062341af0265c Reviewed-on: https://gerrit.libreoffice.org/42651 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-23tdf#112552: Shape's gray background is lost after saving to PPTXTamás Zolnai
Reviewed-on: https://gerrit.libreoffice.org/42598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 31919b8909fa7b34412dd52c3d4dff17bc5b6fab) Change-Id: I30f371ad301eede82ddcece4d91ffcd32e164115 Reviewed-on: https://gerrit.libreoffice.org/42649 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-21lok: Don't freeze the LibreOfficeKit via the spell-checking popup menu.cp-5.3-26Jan Holesovsky
Change-Id: I045ed919daeefca612d7908dd7de50c36536c9a0 Reviewed-on: https://gerrit.libreoffice.org/42608 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-19Bump version to 5.3-26Andras Timar
Change-Id: I0108167312db0063f4bdd5e6807c5d5017a32e07
2017-09-19ofz#3301 sw: DeleteAndJoin found yet another way to delete new redlineMichael Stahl
Not only can that happen in CompressRedlines(), it can also happen in the SwComparePosition::Outside case when the DeleteRedline() decides in particular circumstances to split up the inserted new redline. Arguably it's wrong to split up the new redline in this case; not sure if that ever happens in a legitimate use case though. Avoid this by removing the hack to temporarily insert the new redline and instead create a temporary SwUnoCursor that will be corrected on behalf of the new redline, while the new redline is parked on a safe node. This not only avoids the crash on this file but also makes the "corrupted redline table" assertions go away. Change-Id: I478f4cfc53a19d2cf2f0937f631962f80b1815ff Reviewed-on: https://gerrit.libreoffice.org/42408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit a562be54f3127f4e22a3a38e62db2b38d48499f3)
2017-09-19ofz#3412 SYLK import: check ;X;Y;C;R col/row validity earlyCaolán McNamara
Change-Id: I91fcd2571e528201e01467f3bcdbbff30cdfb50c Reviewed-on: https://gerrit.libreoffice.org/42426 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 51854f5432de42bcc1154469edb5395328870613)
2017-09-19Word 2013 and 2016 does not honor the <w:view> setting, let's ignore it too.Jan Holesovsky
In other words, let's open documents in the non-web view even when saved with <w:view w:val="web"/>. The behavior I see in Word 2013 (and it's documented that his happens in 2016 too) is that the setting is not a document setting any more, but user's setting. Ie. regardless of what is written in the file, the .docx document opens in the Print Layout if the Word was in the Print Layout until now, and in the Web Layout if it was that mode. We handle the non-web layout much better than the web layout, so let's just default to the normal layout on load. Change-Id: Ieba7ddc280b9b79501a6b89ff21b03a86356583c Reviewed-on: https://gerrit.libreoffice.org/42414 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42412 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-19lok: Expose the automatic spell checking state in the UI.Jan Holesovsky
Change-Id: I5c22ff70d3895b0f4a86eb8be85dde971604874a Reviewed-on: https://gerrit.libreoffice.org/42479 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2017-09-19tdf#111305: Fix group name refresh in pivot tableDimitri Bouron
Change-Id: Ibc22bfba5765aba3014651df50afb23b893d2b5a Reviewed-on: https://gerrit.libreoffice.org/40712 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 3d37e10684edf9536beefe5670b144571e6c9792)
2017-09-18tdf#108572 remove connection also if not savedSzymon Kłos
Change-Id: Iddce37c3ad187f4a5572cb3cc2362535134c28e8 Reviewed-on: https://gerrit.libreoffice.org/42357 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> (cherry picked from commit 29bd193146b40cf90bda5db04b136987f3c7c94d) Reviewed-on: https://gerrit.libreoffice.org/42369 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2017-09-18gbuild: strip away unexpected CR char at the end of Windows filenamesMiklos Vajna
As reported at e.g. <https://ask.libreoffice.org/en/question/90346/building-libreoffice-in-cygwin-leads-to-infinite-loop/>, sometimes MSVC (seen with 2013 on libreoffice-5-2, but there is no indication that 2015 on master would be different) emits CR characters at the end of filenames, resulting in unnecessary rebuilds at per-module builds, and actually to an infinite loop when doing toplevel make. Given that CR characters are unexpected in any filenames, it should be safe to just strip those away unconditionally. Change-Id: I3d56670b4d930a32489f889085711bfd436de82a Reviewed-on: https://gerrit.libreoffice.org/40452 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit e9b9a456221b4b0660f90efa1ee092ea00c2c728)
2017-09-18detect corrupted job setupCaolán McNamara
Change-Id: I0d3b4850c3d4c015a0a7e5d36d87113a749c7e0f Reviewed-on: https://gerrit.libreoffice.org/42385 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 1eb3822d74f535f75aa336b27568ee8a6084c4dd)
2017-09-18valgrind: Conditional jump or move depends on uninitialised valueCaolán McNamara
Conditional jump or move depends on uninitialised value(s) at 0x4C3535E: strstr (vg_replace_strmem.c:1623) by 0x4FCD9E59: SmFilterDetect::detect(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue>&) (smdetect.cxx:102) by 0x41A1A774: filter::config::TypeDetection::impl_askDetectService(rtl::OUString const&, utl::MediaDescriptor&) (typedetection.cxx:1038) Change-Id: I2f98fd3f7799f34cb5bd9242379ce6440645034d Reviewed-on: https://gerrit.libreoffice.org/42381 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 64aa36e8b999ea4dcad69904da941705effad618) Reviewed-on: https://gerrit.libreoffice.org/42387 Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 256a405d4b1feeafd8a09e98bce9fb0c9125ee3d)
2017-09-18sax: Check if it starts with 5 bytes of "<?xml"Takeshi Abe
Reviewed-on: https://gerrit.libreoffice.org/40139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b64e564492220b34c14f069e8e1f42675bd9abe6) ofz: string has to be at least 5 chars long Reviewed-on: https://gerrit.libreoffice.org/42379 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> this should presumably be 5, rather than 4 Change-Id: Iec5b748b188c7b1bf61e8137faf4b3f2d480d7f1 98c50a59c03fc886d50362b9c5dd8c84f60e0b62 20c6a6fb34485f42c2a828618e8918d8a441860a Reviewed-on: https://gerrit.libreoffice.org/42395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 44815f1439bb36e9fb5f0181c541fc4d0c9422f1)
2017-09-18svtools: HTML import: don't put lone surrogates in OUStringMichael Stahl
The bytes "ed b3 b5" in fdo67610-1.doc (which, as the name indicates, is an HTML file) are converted to the lone UTF-16 surrogate "dcf5", which is inserted into SwTextNode and causes asserts later on. The actual encoding of the HTML document is probably GBK (at least VIM doesn't display any missing characters with that), but because it doesn't contain any indication of its encoding it's apparently imported as UTF-8; the ImplConvertUtf8ToUnicode() thinking a surrogate code point is valid even if the Java-compatible mode RTL_TEXTENCODING_JAVA_UTF8 is not specified is a bit of a surprise. [note: the master commit says "JSON-compatible mode" but i was confusing different text encoding perversions there] Change-Id: Idd788d9d461fed150171dd907439166f3075a834 (cherry picked from commit fc670f637d4271246691904fd649358ce2e7be59) Reviewed-on: https://gerrit.libreoffice.org/42101 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 756949c06b8bf933bcd13a226f449b8909cbf3ae)
generated by cgit (git 2.34.1) at 2024-07-04 23:06:11 +0000