summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-05-27no need to allocate Style objects separatelyNoel Grandin
Change-Id: I88e4642a81b18c41216784332cc4a37a3bde9d95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116247 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27we can search std::set without allocating on the heapNoel Grandin
we just need to add some overloads to UniquePtrValueLess Change-Id: I91c395393a2de609c8f442de605d1dd2098dfae0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116248 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27Fix typosAndrea Gelmini
Change-Id: I9a4ba6b6369da0bac489718230880b04912bd1d7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116214 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-05-27add missing xmlns:loext to example_sl-SI.xmlCaolán McNamara
added to example.xml by commit 71ee09947d5a71105d64fd225bb3672dfa7ce834 Date: Tue Sep 19 15:37:04 2017 +0200 TSCP: add advanced classification dialog but not to example_sl-SI.xml Change-Id: I8aa46554867db8c51bd118b6cc87e649b922cdfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116245 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27gtk4: strip accelerator tagCaolán McNamara
unclear yet if there's another way to do it Change-Id: Ic3355d45bb3bb73c446b576b9cc65204cd39d180 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116238 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27no need to make copies hereNoel Grandin
Change-Id: If3cd60bd48f640c353fd4c28449faed2cdcebdda Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116243 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27tdf#117957 WMF Fix failing tests on arm64Bartosz Kosiorek
So the issue is caused by floating numbers, On x86_64 it is: 338.499728160392-445.269903703769 on arm it is: 338.499728160392-445.26990370377 As in test files, we have two ellipses (which are made from small lines), which points rounds differently on different architectures Change-Id: I10efe80fea0944cf957e949c8c209c94fd588702 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116234 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl>
2021-05-27tdf#141309 tdf#142215 OOXML import: fix double conversion in autofilterBalazs Varga
resulting missing selection of filtered time values and numbers ending with zeroes. No need to convert the filter values from string to number and back at OOXML import, because we'll do that later in the model by filtering with the formatted cell values. Follow-up to commit d5c2584bf36d21580db677b231c57f99f49aa2cb "Related: tdf#140968 avoid duplicated filter values". Change-Id: I75e5b2391624ff85a8ed545926ec519355a356bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115473 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-27no need to allocate Sw2LinesPos separately on heapNoel Grandin
Change-Id: I39dec50f491a313ac188bb2f73073ecc32ebfc21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116240 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27sw_ooxmlexport: just use exportonly hereXisco Fauli
Change-Id: I37fe18528dbe821eb60c7b1d6c65039e2ae91b7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116236 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-27fix leaks in ScAcceptChgDlgNoel Grandin
Change-Id: Idaa946f06fdfdc1f908cff02cab542b64066763c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116241 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-27tdf#47065 Add new file open UI options and implement a new threadMatt K
Add new UI options when opening a locked or non-writeable document to allow the user to be notified when such a document becomes editable . If the user selects "Notify", then that document is added to a list of open documents to be checked by a thread every 60 seconds for read/write access and whether lock file is available/obtainable. If access is allowed for a document, then show UI dialog to the user asking to Reload that document. If Reload is selected by the user then that document is reloaded with read/write access. The checking thread is spawned only once no matter how many "Notify" documents there are. The thread is spawned if not already running when a new "Notify" document is opened, and it terminates when all "Notify" documents have been closed or the application terminates. Also update badstatics clang plugin to ignore new global variables introduced. Change-Id: I7555ce6f5df79c2c87216e0129ef3b2883c7d921 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111654 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-05-27sw_ooxmlexport14: simplify codeXisco Fauli
Change-Id: I2e52a042b514e6724dbd282a41a4ca7f66981f2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116233 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-27gtk4: drop can't focus from GtkBox and GtkGridCaolán McNamara
it used to be that can-focus of true in a child with false in the parent allowed focus in the child, that's no longer true. We're already clearing can-focus of false from a widget if a child has can-focus but we build notebooks (especially) with separate .ui files each page so can't tell that there will be contents inserted. Plenty of ways to target just the case for notebook contents, but seems easiest to just clear can-focus of false from all GtkBoxes and GtkGrids. Change-Id: I460f3d5990a5df7b8b8e7d37ce592a5731794f31 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116226 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27gtk4: apply 'border' to dialog content child widget if it existsCaolán McNamara
and if it doesn't apply to the object itself Change-Id: If73e1e78ddc7945480bb2c2e59bf50350ba53e3f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116225 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27Introduce SwContentFrameInvFlags to replace magic numbers in ...Miklos Vajna
... SwContentFrame::SwClientNotify() SwContentFrame::UpdateAttr_() is not yet updated to produce these. Change-Id: Iccb1a9a5cfea967dfd9ca68d25dd9dccb6cc6fe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116229 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-27expand frames horizontally to fitCaolán McNamara
Change-Id: I2c2fc8a726c279583ef9aa3d51eebe7f28164684 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116224 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27resave with latest gladeCaolán McNamara
Change-Id: I91a3836e02cf3ed1cfdcea93f8812dcecc43afcb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-27tdf#139196 - Import/export macros using utf-8 including BOMAndreas Heinisch
Moved import logic to a local function, and during the import of a *.bas file, check if it starts with BOM in order to detect the correct charset. If there is no BOM, use the default charset of the system, since after the change in 178adcd8459af63ddb48927207baa5b4efbfda12, all the newly created *.bas files have a BOM and are written using the utf-8 charset. Change-Id: Iefdecb5762d896ce3e52fd6d212de42cf417ddac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116186 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2021-05-27osl::Module::loadRelative against symbol from executable is unreliableStephan Bergmann
It turns out that c8976bdfdfa361fec9e1e5ff342094e409981fad "tdf#137208 Assume that dladdr provides an absolute pathname" is wrong with glibc if the requested address is in the executable itself, not in a dso. In that case, glibc just returns argv[0] as Dl_info::dli_fname (see <https://sourceware.org/git/?p=glibc.git;a=commit;h=b8565e7817d7c6afd8eac804867b88c9bad1c9f1> "Fill in correct information if symbol is in main program"), which need not be absolute. With > cp workdir/LinkTarget/Executable/fftester instdir/program/ that causes > LD_LIBRARY_PATH=`pwd`/instdir/program instdir/program/fftester sd/qa/unit/data/cgm/pass/binary_corvette.cgm cgm to crash (cf. comment at <https://gerrit.libreoffice.org/c/core/+/111004/2#message-239c434e95f6fee5f5232e32f731595f56116aa3> "tdf#137208 Assume that dladdr provides an absolute pathname"): The call to osl::Module::loadRelative dlopen's instdir/program/libsdlo.so with a relative pathname containing at least one slash, which in turn causes dladdr with an address from libdlso.so to also return a relative pathname, which causes osl_getModuleURLFromAddress on such an address to fail, which causes the CGMPointer ctor in sd/source/filter/cgm/sdcgmfilter.cxx to set m_pPointer to null, causing SIGSEGV when TestImportCGM dereferences it. (Whereas e.g. > (cd instdir/program && PATH= LD_LIBRARY_PATH=`pwd` fftester sd/qa/unit/data/cgm/pass/binary_corvette.cgm cgm) would dlopen libsdlo.so with a relative pathname consisting just of a filename without a slash, so dlopen would search for the library, record its absolute pathname and return that from dladdr, and the program would have worked.) Change-Id: Ifa23124090275a397d4a9b0672ab845af23cf4d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116194 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-05-27sw: rework to avoid the DECLARE_ODFIMPORT_TEST macroMiklos Vajna
See commit a226cec52e536c46e03f57a5f1f7931abbeb0cdd (CppunitTest_sw_rtfimport: convert one testcase to use CPPUNIT_TEST_FIXTURE(), 2019-11-05) for motivation. Change-Id: I7a6de527c28c543d7b622398dab406e2bfb80805 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116216 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-05-27cross-toolset: explicitly add PythonJan-Marek Glogowski
It's needed for the build and it was at least missing on Windows when building without galleries. Change-Id: Ibfcc6f0159e17d69755b230767b64b03dc5537a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116227 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26Cleanup Library_vcl.mkJan-Marek Glogowski
Merge a few duplicate calls and generally prefer inline $(if ..) over extra ifn?eq lines. There are minimal changes: * Move X11 settings from !DISABLE_GUI to USING_X11 * Move the vcl_opengl_denylist from WNT+!DISABLE_GUI to WNT only * SkiaHelper compiles to "isVCLSkiaEnabled() { return false; }" without the enabled feature, so move code to the general list. * Move the SKIA library to !DISABLE_GUI, where the code is * Move PDFium source + external to generic lists * "extract" common ${vcl_headless_freetype_libs} Change-Id: I9836ab3c1791b6406984ec4d4c27a8924faffdca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116220 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26configure: internal OpenLDAP depends on NSSJan-Marek Glogowski
So we need either NSS or a system OpenLDAP. Also add the $test_openldap flag. Change-Id: I134d1ed3a0a9654e264ccc66cdbe993a355620cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116109 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26gbuild: Handle glxtest + vclmain usage via macrosJan-Marek Glogowski
Use a macro to do the same checks for all Executable with glxtest or vclmain usage. Both are static libraries, so every user has the same dependencies. Introduces: * gb_Executable_use_vclmain * gb_Executable_use_glxtest Change-Id: Ib80b4e7c6f5078d47ad8f1ec5708a7174415f705 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116145 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26gtk[3|4] gtk_widget_get_root returns null when no rootCaolán McNamara
unlike gtk_widget_get_toplevel which returns itself if that is the case Change-Id: If977440265bd8ae2c892ee5d52091ebf16ad03cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116218 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: add parent-less widgets to default containerCaolán McNamara
Change-Id: Ia0c06db5a4f1c4ce453c424835d032ebb021f40a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116217 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: wrap gtk_buildable_set_name/GtkBuildableIface::set_idCaolán McNamara
Change-Id: Ia19179bc5879218495184dcec80fd96eb375bc00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116209 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: wrap gtk_buildable_get_name/gtk_buildable_get_buildable_idCaolán McNamara
Change-Id: Iadafc7a7b4eb49bd15c22f006955003554cd7079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116208 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26configure: Remove kde5 compatibility optionJan-Marek Glogowski
Change-Id: Idce493e5f5ac045f7e977b4073152c2fe2668b56 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116111 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-05-26tdf#126541 XLSX import: fix View grid linesAttila Szűcs
It was not possible to enable the disabled grid with View->View grid lines, as intended, because document-level grid visibility was set to the visibility of the actual sheet's grid (which already imported correctly) instead of keeping its default true value. Note: document-level or global grid visibility is unknown for XLSX, but handled by Writer/ODS, see Tools->Options->Calc->View->Grid lines. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Iccab3e2b9f617cdcd678071f73c7c2d6db0bc161 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116096 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-05-26log what page id is missing if this happensCaolán McNamara
Change-Id: Ie279350446ef1892d5bb145e58b9f0d9dba683f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116206 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: "focus" signal is goneCaolán McNamara
its not clear yet if there's another way to do what we want here Change-Id: Id9e54a481ac33038d605b0488315e73fd5b5a310 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116205 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: reenable NotebookCaolán McNamara
Change-Id: I5342e5ef35f9d270d8ac51c3d696beddc8b67529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116203 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26comphelper: fix the "console" use-case of ProfileZoneMiklos Vajna
m_nCreateTime was changed to NS, nEndTime was still MS, comparing the two is not a great idea. Change-Id: I102990838d1e3d543a356b5ad2d3f68ce1d20623 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116210 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-26sw XHTML / reqif export, RTF markup of images: write WMF in \pictMiklos Vajna
Some consumers (e.g. IBM Doors) can only consume the RTF snippet if it's an OLE object and can't deal with plain images. Wrap \pict inside \object and unconditionally use WMF as the RTF-level preview format. The actual \objdata is not yet written. Change-Id: I203fcd8709b25a4dd543047bd804af8181df9940 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116207 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-05-26don't need always-show-image if there's just an image and no textCaolán McNamara
Change-Id: Ic3a1aad525af39b723e71f579fba40157cb15ac7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: restore ContainerCaolán McNamara
Change-Id: Ide82777fadbee2c644c3a19d418c3683f6ff2c11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26gtk4: strip GtkLinkButton xalignCaolán McNamara
Change-Id: I44065da82f577e226ee1c52f858917a1d825d9ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116200 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26tdf137314 Add margin to CppunitTest assertionsJan-Marek Glogowski
The test had multiple failures on Windows with: oox/qa/unit/vml.cxx(79) : error : Assertion Test name: tdf137314_vml_rotation_unit_fd::TestBody equality assertion failed - Expected: 1490 - Actual : 1491 So add a 1px margin to all value checks. Change-Id: I70298db253299a57cc37eed482c0816d902fbeab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116192 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-26tdf#142467 crash on calling 'getInfoHelper' in final classCaolán McNamara
IPropertyArrayHelper & rInfo = getInfoHelper(); crashes when CandleStickChartType is final for unknown reasons. I see this with gcc-11.1.1-1.fc34.x86_64 in 7-1 locally but also in the fedora libreoffice-7.0.6 built with gcc-10 so this isn't a recent problem. #1 0x00007ffff6f4fe91 in cppu::OPropertySetHelper::getFastPropertyValue(int) (this=this@entry=0x5bdd588, nHandle=nHandle@entry=3) at cppuhelper/source/propshlp.cxx:549 #2 0x00007fffad45e9ff in chart::CandleStickChartType::getSupportedMandatoryRoles() (this=0x5bdd520) at chart2/source/model/template/CandleStickChartType.cxx:219 Change-Id: Ia029162587da1fc00df32866863deb186c7e11bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116196 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-26tdf#100122: svl_qa_cppunit: Add unittestXisco Fauli
Change-Id: Ie0a7ea6ae08ea96b04019148f80ee94ef22ef1bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116187 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-26tdf#52510: svl_qa_cppunit: Add unittestXisco Fauli
Change-Id: I18a7000104add044ba59381c201cb5aff9fb459d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116184 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-05-26fix another leak in SwInsTableDlgNoel Grandin
Change-Id: I743a3231ef62e30242e54315bc3d3183f691f13d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116191 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix callgrind job by providing dummy privacy-urlChristian Lohmaier
Change-Id: I786c14c19f1ac74e424be869771440c55be08877
2021-05-26Refactor module media item handlingJan-Marek Glogowski
Move common functionality into svx::MediaShellHelpers. Change-Id: I6f5db59bdcff7cad00a64e76f6aad7b8ecb4ffa9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116126 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26loplugin:includeform (clang-cl)Jan-Marek Glogowski
Change-Id: I12632b72c8e4e95bef24c8c26bee5887f9695d66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116143 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-05-26fix leak in SvxConfigPageNoel Grandin
Change-Id: I6b95d33cfbad455692c8047968a2581fe4610260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116190 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix leak in SfxAutoRedactDialogNoel Grandin
Change-Id: I5ebfe5eba77de3380e991ced26f396821613b7f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116189 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-05-26fix leak in SwInsTableDlgNoel Grandin
Change-Id: I1d4b4f5098eeec7b0042f3ffd457566ecb3e31de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/116188 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-11 12:00:45 +0000