summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-07try to autodetect flags needed to build Clang pluginsLuboš Luňák
Instead of having a lot of it hardcoded, which brings problems like: - Clang-to-be-10 has switched to -std=c++14, so our hardcoded c++11 makes the build fail - I cannot compile with my openSUSE-shipped clang, because it ships only libclang-cpp and not the other libClangSomething libs The possibility to explicitly set the necessary variables is still there. Change-Id: I58d401d4584fa064f1c1351a8a06ff4e29643063 Reviewed-on: https://gerrit.libreoffice.org/80300 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07fix various warnings in compilerpluginsLuboš Luňák
These are triggered when using llvm-config --cxxflags for building, and sometimes there's -Werror. The warnings were mostly unused variables because of being used only in assert(), or default case in switch that covers all enums (it's better to not handle default to get warning if a case is not handled). Change-Id: I0ecdd1f27390aadf033852b0d1ee0ca424ae3c37 Reviewed-on: https://gerrit.libreoffice.org/80317 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07generate make dependencies also for clang.pchLuboš Luňák
Change-Id: Id05f2741763ef0d9e87d9804339d29aee6bc068f Reviewed-on: https://gerrit.libreoffice.org/80380 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07handle more -arch: options when avoiding D9025Luboš Luňák
Change-Id: I97ff0418e25aeaea4cae349f2d228fb35219b5c2 Reviewed-on: https://gerrit.libreoffice.org/80374 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07use FileDialogHelper which is able to set parent easilyCaolán McNamara
Change-Id: I0389311323175fbbc58ee0b9fbb6353061b21e2f Reviewed-on: https://gerrit.libreoffice.org/80395 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07use FastParser in linguisticNoel Grandin
Change-Id: Iee2254dc13ccc31d266009ba1eb00f2517484cc7 Reviewed-on: https://gerrit.libreoffice.org/79814 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07use cppu::WeakImplHelper in VCLXDeviceNoel Grandin
Change-Id: Ia83cc372d53db41edc8199077db91cb7b1d06e24 Reviewed-on: https://gerrit.libreoffice.org/80386 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07use cppu::WeakImplHelper in VCLXFontNoel Grandin
Change-Id: Iab0ff79ba1f94f087b57faefa3945aba1ed42448 Reviewed-on: https://gerrit.libreoffice.org/80387 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07Fix function name, "revert" -> "reverse"Stephan Bergmann
(See the discussion in the comments to <https://gerrit.libreoffice.org/#/c/80317/> "fix various warnings in compilerplugins".) Change-Id: Ia6ba32206ddf44bba9bb5acdd929c0750c48cca9 Reviewed-on: https://gerrit.libreoffice.org/80372 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-07cid#1454630 Uninitialized scalar fieldCaolán McNamara
Change-Id: Id8b7e4dfb021b836d5d14ce9ca73f3835288a7a4 Reviewed-on: https://gerrit.libreoffice.org/80343 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07weld ScreenshotAnnotationDlgCaolán McNamara
Change-Id: I94e42c1d10922170f53af917bba6848c9f006a11 Reviewed-on: https://gerrit.libreoffice.org/80383 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07Fix typoAndrea Gelmini
Change-Id: I81084e169722f6abcc660e360d6e39aff7446240 Reviewed-on: https://gerrit.libreoffice.org/80370 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-07update sw pchCaolán McNamara
Change-Id: Ica2fb688d3fcf6f9f74399215e3092bf4a2ac9c8 Reviewed-on: https://gerrit.libreoffice.org/80337 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07SvSimpleTableContainer is now unusedCaolán McNamara
Change-Id: I7762d95290a0b35de4f909895a4e28b52c436ed9 Reviewed-on: https://gerrit.libreoffice.org/80307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07drop comment referencing ModalDialogCaolán McNamara
Change-Id: I887b0371309a897848eed5d72c55458f78ed1f68 Reviewed-on: https://gerrit.libreoffice.org/80361 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07adjust a confusing testLuboš Luňák
GetPrefSize() at this point is Size(0,0), so the test was testing topleft corner. And getPixel() takes Y,X , so even then it wasn't testing the center. Change-Id: Ie2e489a693fae2b7ea41075ebe6fa3ef405545d5 Reviewed-on: https://gerrit.libreoffice.org/80351 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07fix test for CanvasBitmap not handling N32BitTcMask bpp properlyLuboš Luňák
Change-Id: Ic331d33e0f0feca1fde4425fdb4106b1a769194d Reviewed-on: https://gerrit.libreoffice.org/80350 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07cid#1454629 silence bogus Arguments in wrong orderCaolán McNamara
Change-Id: I7dc06a2754eaa172f112f38a260240f8e2cc0983 Reviewed-on: https://gerrit.libreoffice.org/80345 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07weld SwSendMailDialogCaolán McNamara
Change-Id: Ibb21567c11adef233061cb53f787a73eb56cc282 Reviewed-on: https://gerrit.libreoffice.org/74848 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07cid#1448512 silence bogus Out-of-bounds accessCaolán McNamara
Change-Id: I6febe3d48fc9018b373a940d88d2afeefad7502c Reviewed-on: https://gerrit.libreoffice.org/80355 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07cid#1130173 Logically dead codeCaolán McNamara
Change-Id: I3b283a3283d865f5f96d872bad219ce9c3f872df Reviewed-on: https://gerrit.libreoffice.org/80356 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: Jenkins
2019-10-07tdf#112368 Qt5 don't lose ownership in flushClipboardJan-Marek Glogowski
I didn't know that flushClipboard is called for simple text edit fields for C'n'P operations, and not just on LO shutdown. This way the simple text is actually secured in the clipboard instandly, as there aren't complex mime-types to generate and secure. As a result we also need to protect flushClipboard from loosing ownership, which wasn't needed for the shutdown-only case, as this would give up ownership anyway. Change-Id: Ib3cd4979228fc645a27c658abb3df38ccf8c8956 Reviewed-on: https://gerrit.libreoffice.org/80042 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-10-07cid#1453997 silence Uncaught exceptionCaolán McNamara
Change-Id: I8158bf997de6e34da1f2ab6a2f9b5e3c61267520 Reviewed-on: https://gerrit.libreoffice.org/80354 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07cid#1454627 Dereference null return valueCaolán McNamara
Change-Id: Idc94a2a912d94a8208348a8d6151c6d7dfe3ccb9 Reviewed-on: https://gerrit.libreoffice.org/80352 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07do not use compiler.getSourceManager().getFilename()Luboš Luňák
This is a continuation of ff002524c12471668e63837a804b6006f9136a34. When compiling with icecream, its -frewrite-includes merges all #include's into one .cxx file and marks them with with line markers. But SourceManager::getFilename() doesn't take those into account and so it reports all of those as <stdin>. So use getFileNameOfSpellingLoc(), which explicitly handles this case. And we should probably never ever use SourceManager::getFilename(). Change-Id: Ia194c2e041578e1e199aee2df2f885922ef7e31a Reviewed-on: https://gerrit.libreoffice.org/80326 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07add missing constLuboš Luňák
Change-Id: I20baebc41bd833764bbe828dd63df5218a12ce20 Reviewed-on: https://gerrit.libreoffice.org/80349 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-07Get rid of another SAL_WARN that just pointlessly fills up log filesTor Lillqvist
Change-Id: Ic499677dad477d1ed194d63929f9374995fccb65 Reviewed-on: https://gerrit.libreoffice.org/79254 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 5a742afd3dde74138bda8fd140d3801b3ca900e6)
2019-10-07Drop some useless warnings that we get hundreds ofTor Lillqvist
Change-Id: Ie83b4ad7a7ab1c26ff081f70ad98eb39a04f1015 (cherry picked from commit 7dd803da92d9b2ff36ded57ea22fbb41ef1db28f) Reviewed-on: https://gerrit.libreoffice.org/79253 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit dedf3da4d33a51f63006b125991e1d64d70df381)
2019-10-07Makefile comments need to start in the first columnTor Lillqvist
This "comment" was actually interpreted as a shell command. Sure, the "command" was a comment in shell, too, but still, quite pointless to run it. Change-Id: If5abeabb1c10d62fa90dcdaf81b3b54af958ba62 Reviewed-on: https://gerrit.libreoffice.org/79292 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit d7cbe885daf2e05677b2891c920e5ff125ee15a9)
2019-10-07Avoid dialog headings showing up as some serif font in the iOS appTor Lillqvist
Apparently the use of [UIFont systemFontOfSize:10] familyName] to get a default font family name is a bad idea. Presumably the return value from this, ".SF UI Text", is matched against the list of font family names enumerated from the system. (The "SF" apparently stands for "San Francisco".) That ".SF UI Text" is not among them, so maybe vcl chooses some arbitrary other font instead that happens to be a serif one? If we instead use "Helvetica", at least we get a sans-serif font, even if it doesn't match the system UI font exactly. Change-Id: I7ff39d8e7893ce3c27f3f12d227f87209bbc7952 (cherry picked from commit 685e91a7aee4a4acc60e33bf1313a394fd15b1ff) Reviewed-on: https://gerrit.libreoffice.org/79196 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit ba9f91a909cb52194178ac2ed78dc62bd61c1be3)
2019-10-07InsertQuote can be constMike Kaganski
Change-Id: I57b50e72b68b71406d1745304d24b52d75b3d082 Reviewed-on: https://gerrit.libreoffice.org/80342 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-07Bin pointless nested #if HAVE_FEATURE_AVMEDIATor Lillqvist
Change-Id: Id36265c5bd50d95105e3abf37e999aba80b4712c
2019-10-07Some !HAVE_FEATURE_AVMEDIA falloutTor Lillqvist
Change-Id: Ie7c2f75ec66ae4c1f8dc49075624617c294cbc25 Reviewed-on: https://gerrit.libreoffice.org/62945 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/79131
2019-10-07Revert "We need UNO components from libmswordlo.a"Tor Lillqvist
Nah. We already have com_sun_star_comp_Writer_DocxExport_get_implementation as it is called in this branch. This reverts commit 98deb6e96f547e8eedff40c992fefe3514021447. Change-Id: Ic5db66420db9ef2477df8d9905ba3525f3b57e5b Reviewed-on: https://gerrit.libreoffice.org/79010 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit cb61889e8761837150236c617e806d52c54fd72f)
2019-10-07Use correct directory for some data files on iOS: share/filter, not filterTor Lillqvist
Change-Id: Idd7d675872b73454d78576ed231fe90644dbe4c5 Reviewed-on: https://gerrit.libreoffice.org/78142 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/78999
2019-10-07We need UNO components from libmswordlo.aTor Lillqvist
They are needed for .docx and .rtf export at least. No idea how we have managed without it previously. Change-Id: Iff9224f92520e19d9baa691a9e7cd3c944004eed Reviewed-on: https://gerrit.libreoffice.org/78125 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 1a0bd0c6914bf93733c7ab3a27741fc1dc0e3f26) Reviewed-on: https://gerrit.libreoffice.org/78996 (cherry picked from commit 98deb6e96f547e8eedff40c992fefe3514021447)
2019-10-07tdf#126964: Set background colours to white in IosSalFrame::UpdateSettings()Tor Lillqvist
Change-Id: I92110a7a501571d7fd707dc33502ff553f02ae5e Reviewed-on: https://gerrit.libreoffice.org/77823 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit e84c42ee32d1a23729c65b534c4418e2043f706d) Reviewed-on: https://gerrit.libreoffice.org/78994 (cherry picked from commit 1e7a3f82324c3b855c2b3c1f8d4dec73c5162806)
2019-10-07Add the guesslang component (to apps) in case it is essentialTor Lillqvist
(I saw warnings about it missing in the iOS app.) Change-Id: Ib286b107e529e80ec36ffb87059f4f5923867abe Reviewed-on: https://gerrit.libreoffice.org/77399 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-07Add libexttextcat, needed by the guesslang componentTor Lillqvist
Change-Id: Id13ddee66a70d8cd293940f7eea8597257d169c5 Reviewed-on: https://gerrit.libreoffice.org/77398 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit aa0b785946ba39bbce419a6b356a7ce07349501c)
2019-10-07DialogClosed doesn't existCaolán McNamara
Change-Id: I3f098cf0b364abb1423b5cecb8cca763f053fa4b Reviewed-on: https://gerrit.libreoffice.org/80336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07Remove unnecessary(?) memsetStephan Bergmann
...that was there ever since 7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import", while 2e93541d00f9d4aaa6ad2aeb35ee0c901d216cc0 "Resolves: fdo#69220 crash in doc (ww6)" introduced a WW8PLCFxDesc default ctor that initializes all members (even though it initializes some of them to non-zero, but lets assume that that doesn't matter here). Change-Id: I21a75675d59ded81ccb17397f8c464efdfc3d78f Reviewed-on: https://gerrit.libreoffice.org/80316 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-07cid#1454631 Logically dead codeCaolán McNamara
Change-Id: Ie2850a38db3d2e343d9fc19e245eb97238196110 Reviewed-on: https://gerrit.libreoffice.org/80339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07openssl 1.0.2tCaolán McNamara
Change-Id: Ideb980a07632e75e2bc7fffa851b8419e727c13b Reviewed-on: https://gerrit.libreoffice.org/80340 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07lok: comments: fix hidden text cursor and sudden document scrollMarco Cecchetti
On Android, SwAnnotationWin::Rescale leads to invoke ImpEditEngine::UpdateViews which hides the text cursor. Moreover it causes sudden document scroll when modifying a commented text. Not clear the root cause, anyway skipping this method fixes the problem, and there should be no side effect, since the client has disabled annotations rendering. Change-Id: I572a9c6b3fe39473a596209413945d777bd79506 Reviewed-on: https://gerrit.libreoffice.org/80244 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-07tdf#127777 OOXML chart export: fix "CrossBetween" for not imported chartsBalazs Varga
Newly created or ODF charts were still exported incorrectly, because ShiftedCategoryPosition was stored in the view code. Now it is removed to the model using ChartTypeTemplate::adaptScales. See also commit 6027ec08fd5df2e09e34ff61b3777ad2cc8304b3 'tdf#127777 OOXML chart export: fix X axis position setting "CrossBetween"' Change-Id: I7cd69e311833bf9f24f3a600ee7c6312285a7738 Reviewed-on: https://gerrit.libreoffice.org/80160 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-10-07cid#1454632 silence Uncaught exceptionCaolán McNamara
Change-Id: I577cfdfde9076a3c6273c9af1f0b35108a0a0160 Reviewed-on: https://gerrit.libreoffice.org/80338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07sw: fix Android buildMiklos Vajna
/home/vmiklos/git/libreoffice/master-android/sw/source/core/txtnode/txtedt.cxx:1203:41: error: loop variable 'rImplicitChange' has type 'const std::pair<int, int> &' but is initialized with type 'std::__ndk1::pair<long, long>' resulting in a copy [-Werror,-Wrange-loop-analysis] Just use auto, the copy that was happening here was not intentional. Change-Id: I2f98519f7891bd52ccf560ba0707ad8eef415e06 Reviewed-on: https://gerrit.libreoffice.org/80364 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07[DECL|IMPL]_ABSTDLG_BASE now unusedCaolán McNamara
Change-Id: I111d96da3615f5084f10b4e81dd10bc559c29757 Reviewed-on: https://gerrit.libreoffice.org/80335 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07Fix typoAndrea Gelmini
Change-Id: Ice72d00eb402a291f9a9e262a582493e316864fc Reviewed-on: https://gerrit.libreoffice.org/80358 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-07vcl: fix Android buildMiklos Vajna
UNX is defined for Android. Other code in the same file has guards like: #if !defined(ANDROID) && !defined(IOS) but this is already in an #ifndef IOS block, so just check for ANDROID. Change-Id: I73f92ef5702ec1f1385e2ffa0ea3dbedf7d3b6a2
generated by cgit (git 2.34.1) at 2024-07-11 11:12:01 +0000