summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-09-22loplugin:flatten in scaddins..sdNoel Grandin
Change-Id: I190323ce910224f883c4370b2c752644a5a35edd Reviewed-on: https://gerrit.libreoffice.org/42626 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-22tdf#111994 WIN workaround PostMessage delaysJan-Marek Glogowski
Fixes the "Multiple timers in queue" assertion by effectively removing it. When debugging it became obvious, that PostMessage returns, even if the message was not yet added to the message queue. The assert happens, because we start the timer in the Scheduler before Invoke(), so it fires, if we block in Invoke(), and then reset the timer after Invoke, if there were changes to the Task list. In this case it fires during Invoke(), the message is added. We restart the timer, first by stopping it (we wait in DeleteTimerQueueTimer, to be sure the timer function has either finished or was not run). And the try to remove the message with PeekMessageW, which doesn't remove the posted message. Then the timer is restarted, and when the event is processed, we end up with an additional timer event, which was asserted. As a fix this adds a (microsecond) timestamp to the timer message, which is validated in the WinProc function. So if we stop the timer too fast, the event is ignored based on the timestamp. And while at it, the patch moves timer related variables from SalData into WinSalTimer. Change-Id: Ib840a421e8bd040d40f39473e1d44491e5b332bd Reviewed-on: https://gerrit.libreoffice.org/42575 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-09-22Fix typoAndrea Gelmini
Change-Id: I3bdc875963c413996ffb6403c44968447dbb3131 Reviewed-on: https://gerrit.libreoffice.org/42629 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-22Fix typosAndrea Gelmini
Change-Id: I51700733fda3a08570085ed6745961cd1680eabd Reviewed-on: https://gerrit.libreoffice.org/42588 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-22Bin leftover SAL_DEBUGTor Lillqvist
Change-Id: I452909cc1f0529ecb24b1f705a86a0a8bc1a3c9f
2017-09-22lok: Don't freeze the LibreOfficeKit via the spell-checking popup menu.Jan Holesovsky
Change-Id: I045ed919daeefca612d7908dd7de50c36536c9a0 Reviewed-on: https://gerrit.libreoffice.org/42608 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/42627 Tested-by: Jenkins <ci@libreoffice.org>
2017-09-22EPUB export: add table testcaseMiklos Vajna
Fails without commit 54ad8ad0f0ce22299d28b4ec09eea26ad2691642 (EPUB export: initial table support, 2017-08-22). Change-Id: Ie8d793a8851dba894c57f2071e1b4717fa1e17af Reviewed-on: https://gerrit.libreoffice.org/42590 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-22Watermark: apply to existing styles (also not used)Szymon Kłos
Change-Id: Ic57418f3191cc3c30a348db3e784d4cfbeffae79 Reviewed-on: https://gerrit.libreoffice.org/42576 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-22i18npool: -Werror=misleading-indentationMichael Stahl
Change-Id: I399f8266bf543aa7b31d7833bd27aa7bec8a6708
2017-09-22tdf#112334 unit testSzymon Kłos
Change-Id: Ie041595ba604d4563d7ff356eee18ff3e50fef41 Reviewed-on: https://gerrit.libreoffice.org/42628 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-22<drawinglayer/tools/converters.hxx> can be internal to drawinglayerTor Lillqvist
And while moving it, get rid of the 'drawinglyer::tools' subnamespace. Less potential confusion with the global 'tools' namespace. Change-Id: Iab3c25be0cec7f3d182228d122837e9f2ac9a529 Reviewed-on: https://gerrit.libreoffice.org/42619 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2017-09-22ofz: don't leak in face of exceptionsCaolán McNamara
Change-Id: Ic15590a13bd3770ee5dd7db76b21c830a4fe73e2 Reviewed-on: https://gerrit.libreoffice.org/42587 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22allow system-libepubgen to limp alongCaolán McNamara
Change-Id: I038421749ed6f20d74984beb2e703ffa43a09ff3 Reviewed-on: https://gerrit.libreoffice.org/42620 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-22compilerplugins: add test for badstaticsMichael Stahl
Change-Id: Ibdb3144c0510ed723a01ca28d7cdcd6b21caec54 Reviewed-on: https://gerrit.libreoffice.org/42596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-22Revert "Revert "compilerplugins: Build them in parallel.""Michael Stahl
This reverts commit cd2725de90517cd63a17ccbf2c59c1e07eca5744. Norbert's list of CI performance issues includes "2/ clang plugin build should not be serialized (forced -j1)" Change-Id: Ib77f951a31adc20f6a9f88e8b51632bd81273327 Reviewed-on: https://gerrit.libreoffice.org/42595 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2017-09-22tdf#112334 PPTX export style.colorlbenes
Change-Id: I6a5779cee379b82d81cc73a0d0c154e6caa51424 Reviewed-on: https://gerrit.libreoffice.org/42613 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Szymon Kłos <szymon.klos@collabora.com>
2017-09-22Bin obsolete commentTor Lillqvist
Change-Id: Id3a3fd5317aef2acdc30605f816c2656990a94b6
2017-09-22iOS, updated helper.s to do 64 bitjan Iversen
Removed __arm reference Change-Id: I194d79ccb5ba2117e0f468080813bf8de1ada84a
2017-09-22tdf#112557: Subtitle placeholder shape leads to corrupted PPTX fileTamás Zolnai
Change-Id: I26680ecdb5f0db4f27180c221de062341af0265c Reviewed-on: https://gerrit.libreoffice.org/42611 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-22remove confused error-handlingBjoern Michaelsen
- tracking the error state in a bool - which gets pushed by reference to subfunctions - and signals back error state from a bazzilion different location - in a long operation that is not grouped into one undo - and then haphazardly triggers an indiscriminate Undo - and in addition throws an excpetion More likely than not leaves the client with an undefined half-reverted state, which an impossible situation to properly recover. This either has to be done properly or not at all. Change-Id: I677f87e78c32f4d93c8d21e9df7130a2595da891 Reviewed-on: https://gerrit.libreoffice.org/42510 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2017-09-22IndexedPropertyValuesContainer: remove iterators stupidityMike Kaganski
It uses random-access iterators, so just use O(1) increments Change-Id: I9f80789d0bc03184d346c6814fd015bc06876acd Reviewed-on: https://gerrit.libreoffice.org/42606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-22loplugin:flatten in framework..packageNoel Grandin
Change-Id: Ide8a97eae6e2fdc7d2dcccba1480ac55a9b555bc Reviewed-on: https://gerrit.libreoffice.org/42593 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-22loplugin:flatten in filter..i18npoolNoel Grandin
Change-Id: I9024b8b614a4de83a4d927e1918f6d4904a7fccb Reviewed-on: https://gerrit.libreoffice.org/42592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-22Also handle OUString with non-RTL_TEXTENCODING_ASCII_US encodingStephan Bergmann
(just in case) Change-Id: I7ba2967c1cef81a3f6604077d876c8b993f7f16a Reviewed-on: https://gerrit.libreoffice.org/42609 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-09-22EPUB export: test image handlingMiklos Vajna
Fails without commit 28102e471d3cb6b6976380ca84b1094078ac1af1 (EPUB export: handle inline images, 2017-08-17). Change-Id: Ie96430e9b2d988574464d359111619fc18109566 Reviewed-on: https://gerrit.libreoffice.org/42589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-09-22Replace some lists by vectors (ucb)Julien Nabet
Change-Id: I2e42f6b0f3835400bca008cca31129fc03a76359 Reviewed-on: https://gerrit.libreoffice.org/42607 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-22tdf#112552: Shape's gray background is lost after saving to PPTXTamás Zolnai
Change-Id: I30f371ad301eede82ddcece4d91ffcd32e164115 Reviewed-on: https://gerrit.libreoffice.org/42598 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-21tdf#111894: fix leak memory with PaletteManager (take 2)Julien Nabet
Thanks to Maxim Monastirsky for the suggestion! Change-Id: I6ab799848f80f785fd24905c0a540885c41afb86 Reviewed-on: https://gerrit.libreoffice.org/42494 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-21writerperfect: add initial UITest_writerperfect_epubexportMiklos Vajna
Fails when EPUBExportDialog::VersionSelectHdl() does not take the version from the VCL widget. Change-Id: I8f77643ffbd7766ecec7bc2e148259765ab635b8 Reviewed-on: https://gerrit.libreoffice.org/42600 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-21Map from GetLastError() to HRESULTStephan Bergmann
clang-cl reported "error: comparison of integers of different signs: 'DWORD' (aka 'unsigned long') and 'HRESULT' (aka 'long') [-Werror,-Wsign-compare]" Change-Id: I568f03bd863ba63e30143483d9573042f3506de7 Reviewed-on: https://gerrit.libreoffice.org/42597 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-21tdf#112501: Pivot table: popupbuttons are placed on wrong cellsTamás Zolnai
...imported from XLS Change-Id: I45bc4a0182e6a62471bc02ac1bca31f9735e6566 Reviewed-on: https://gerrit.libreoffice.org/42508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-09-21License date updateMarina Latini
Updated the copyright date from 2014 to 2017 Change-Id: I9d2e6502c97bfa732ab636c9d47221a55d3cde56 Reviewed-on: https://gerrit.libreoffice.org/42547 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2017-09-21Related tdf#112423: avoid crash when calling procedure twice (dbaccess)Julien Nabet
Since SbaTableQueryBrowser::implSelect returns a bool to indicate if everything is ok, should return false when we entered in a catch Change-Id: I9ae3ff3bf082278edb16a9b91701d6cf457e7179 Reviewed-on: https://gerrit.libreoffice.org/42564 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2017-09-21Ignore AquaBlinker on Scheduler shutdownJan-Marek Glogowski
Change-Id: If107d2ac01b7be91be34ff753b52f307a6e10f58
2017-09-21More naming errors. There are no "Descriptions" in the SDBCX module,Damjan Jovanovic
there are only "Descriptors". Patch by: me (cherry picked from commit ccc4532f9ed95f4460941e2762ae3250d37805f5) Change-Id: Ifd4f34c7b1ba64b449222dc864a38df80f4c6727 Reviewed-on: https://gerrit.libreoffice.org/42535 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21ofz#3454 Floating-point-exceptionCaolán McNamara
Change-Id: I2432bff8e1c102b83f0b7aff1303a03539ce0350 Reviewed-on: https://gerrit.libreoffice.org/42580 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21-Werror=unused-but-set-variableStephan Bergmann
Change-Id: I8bdf8a4c04256ad665960dd6f0d71d032156a34b
2017-09-21loplugin:flatten in connectivity..desktopNoel Grandin
Change-Id: Iff59d3049ba40b4338ef8eec67d08a96b0834d2b Reviewed-on: https://gerrit.libreoffice.org/42578 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-21loplugin:flatten in editeng..extensionsNoel Grandin
Change-Id: I2b68f5640471ea827c09af1b5a319fb526a53b4b Reviewed-on: https://gerrit.libreoffice.org/42579 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-21loplugin:flatten in basctl..configmgrNoel Grandin
Change-Id: I674cad57ce30a885e126d3bcc921f8fcb53dc36d Reviewed-on: https://gerrit.libreoffice.org/42577 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-09-21More missing GetSelectEntryPos -> GetSelectedEntryPosStephan Bergmann
Change-Id: I89d1dfd2468691fce03a8525b3fa7209bf859293
2017-09-21ofz#3445 exception thrown through XMLImpRubyContext_Impl dtorCaolán McNamara
#0 in __cxa_throw () at /lib64/libstdc++.so.6 #1 in SwXFootnote::createTextCursorByRange(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) (this=0xa21ef0, xTextPosition=uno::Reference to (SwXTextRange *) 0xa18cd8) at core/sw/source/core/unocore/unoftn.cxx:459 #2 in XMLImpRubyContext_Impl::~XMLImpRubyContext_Impl() (this=0xa18bf0, __in_chrg=<optimized out>) core/xmloff/source/text/txtparai.cxx:641 #3 in XMLImpRubyContext_Impl::~XMLImpRubyContext_Impl() (this=0xa18bf0, __in_chrg=<optimized out>) core/xmloff/source/text/txtparai.cxx:646 #4 in cppu::OWeakObject::release() (this=0xa18bf0) at core/cppuhelper/source/weak.cxx:232 Change-Id: I071dc65751724f96b2386dea4f26a6ef476f4ef6 Reviewed-on: https://gerrit.libreoffice.org/42551 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21More missing GetSelectEntryPos -> GetSelectedEntryPosStephan Bergmann
Change-Id: I0c59eac4d0bca2d0a086b9e319dcb50bc6a15b8e
2017-09-21EPUB export: add uno command to bypass options dialogMiklos Vajna
Similarly how this is possible with PDF. The toolbar button is hidden by default in Writer, though. Change-Id: Iaf3b61ac2160578f7eaabd194ce8932792575c29 Reviewed-on: https://gerrit.libreoffice.org/42554 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-09-21bump hunspell to 1.6.2Caolán McNamara
Change-Id: I91d4d58f2b8ba69067de1d08476a8cebbb780535 Reviewed-on: https://gerrit.libreoffice.org/42555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-09-21Updated coreOlivier Hallot
Project: help c25389900adcc9915010b1867aa37e691ea05a62 tdf#108090 Clarify array separators in help pages Change-Id: I60ddea24020d5775a373b1a06b1bdfa8f33d3c5d Reviewed-on: https://gerrit.libreoffice.org/42571 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-21Updated coreAdolfo Jayme Barrientos
Project: help aaf3eadc2accd171b57f13d013f9adf526651171 Helponline: Override the “normalizer” rule messing with line height Otherwise, the body text looks cramped. Change-Id: I4bf6a8b714a243c5de333f46c4249e1c51060f50 Reviewed-on: https://gerrit.libreoffice.org/42222 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2017-09-21Missing GetSelectEntryPos -> GetSelectedEntryPosStephan Bergmann
Change-Id: I353f64553ed5968e504d6f0c2a11131df8e2fc56
2017-09-21iOS, change bridges to 64bit and reducejan Iversen
Changed __i386 to not __arm64 iOS either compiles for arm64 (production) or x86_64 (simulator) add common parts to cpp2uno and uno2cpp Change-Id: I059f3cc23bb658d6d53dbf2bf4aa6634eeac9662
2017-09-21fix 'make solenv' test failure on clang-3.8Noel Grandin
clang-3.8 and clang trunk differ in how they represent ranged-for which leads to a test failure Change-Id: Ia8965802260fdc946d3a705c6fef82d98eeb8230
generated by cgit (git 2.34.1) at 2024-07-31 08:40:45 +0000