summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-01-13Access2Base - Review size limits of VARCHAR fieldsJean-Pierre Ledure
- Basic has no practical limit anymore for string variables - LONGVARCHAR fields can vary a lot in size across RDBMS's (f.i. Sqlite < 64K) This forces an overflow check when setting a field value and no check when getting it Change-Id: I4c9629f63164fbbdb84497e7002fa3186d7c63b7
2017-01-13use the same number in alloc and memsetCaolán McNamara
Change-Id: Ie532985e655d1dd383a1781422213cee0787bfae
2017-01-13coverity#1371198 Missing move assignment operatorCaolán McNamara
Change-Id: I89a718a245ea36f33c47f8044280bf7e46c0f66a
2017-01-13coverity#1371289 avoid the need for an assignmentCaolán McNamara
Change-Id: Ia0efc427d9996eb8414821d07f7e760fb1b35246
2017-01-13coverity#1371287 don't need to copy and then overwriteCaolán McNamara
Change-Id: Ica30e4bed463e8e42cbf54f4b81491149a8de8ab
2017-01-13add STEYX testcaseZdeněk Crhonek
Change-Id: I9184dab8c0b7ef80055835ef962449a63761ae86 Reviewed-on: https://gerrit.libreoffice.org/32977 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-13avoid infinite loops in dxf renderingCaolán McNamara
Change-Id: Id2eb5540241f0792cde35c444fc2c0c5b7778353
2017-01-13new loplugin: useuniqueptr: editengNoel Grandin
Change-Id: I6df65eab882780d996ee996b5fef8020186b6d98 Reviewed-on: https://gerrit.libreoffice.org/32958 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13tdf#105259 calculate sizes of all area tab pages on constructionTomaž Vajngerl
When we open dialog that contains the area tab, we need to calculate the size of area tab pages (that are triggered by clicking on a button) and set the page area to the appropriate combined size. Otherwise we don't account for the needed space correctly and some page will be squished or have overlapping controls. This change creates all pages at dialog construction, gets all the optimal sizes and sets the size of the page container box to the combined (minimal) size. Change-Id: Ie04a121810b96973f6e4502a52af675b2baacf25 Reviewed-on: https://gerrit.libreoffice.org/33040 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-13don't build the internal hsqldb and rhino for coverity checkingCaolán McNamara
Change-Id: I7d269b1de29ecc1b0b9e6d58e316d5084e2fdcb6
2017-01-13Rename mail dispatcher membersJan-Marek Glogowski
Makes the members conform with most LO variable naming, This especially switches Active <=> Running in the member names. "Running" is normally referred to as the thread state, while it exists (also look into the osl::Thread API) and now active is the state, when messages are processed, controlled by the start() and stop() functions. Change-Id: I3b8437d4ff24731348272a84720ff81fdea90db7
2017-01-13refactor this to open the display just onceCaolán McNamara
and use the https://wiki.gnome.org/HowDoI/HiDpi HiDPI detection rules. all of this does nothing in practice, cause there is no hidpi splashscreen image Change-Id: I609faab0f207d71fd4a17bb54ef688bdd623eaea
2017-01-13tdf#90794 Fix the Linux HiDPI start screenAbhilash Singh
Change-Id: I2553cf69d6968865dc6011c73a0d2c0e7519b7a8 Reviewed-on: https://gerrit.libreoffice.org/32018 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-13solenv: don't run solenv_python test with make 3.81Michael Stahl
see 7a75b39273de47190b7a1fa20e0bcaca6d089033 Change-Id: I575e5d5dc757cc054a49ae6596183f46373072f2
2017-01-13gbuild-to-ide simplifications.jan Iversen
Simplified GbuildLinkTarget, removed functions. Prepare to clean GbuildParser Change-Id: I67bb3ba0279f615cb6c361818ade6fe629dca60c
2017-01-13ofz: ensure all not explicitly set indexes are zeroCaolán McNamara
Change-Id: Idbe6ceeb61d3dfe26f281349181e7a60f7e59000
2017-01-13new loplugin: useuniqueptr: sc part 1Noel Grandin
Change-Id: Ic96fd3b56b2063df0882168a7d02725d3c50515f Reviewed-on: https://gerrit.libreoffice.org/32961 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13make this a tiny bit less unreadableCaolán McNamara
Change-Id: Ib8205e76f6d1d59ef06eba6e3365c0b4cad0ecaf
2017-01-13tdf#46552 fixing preview for bullets/numbering configurationpv2k
Change-Id: I959169428d4ed0498a2b78fc7a6ae0815e780648 Reviewed-on: https://gerrit.libreoffice.org/32816 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-13Remove --disable-gtk from Windows distro configsSamuel Mehrbrodt
Change-Id: I04e8bdfb3129a444008755f461da5ea7d97a7248 Reviewed-on: https://gerrit.libreoffice.org/33027 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-13unixODBC changed soname to .2 so reflect itTomáš Chvátal
we dlopen this library and thus we should be able to find it with any soname, so far .1 and .2 seem to be used. Also now the load order on linux is: .so.2 -> .so.1 -> .so Change-Id: Idcd284fada1acdfe8dde46c3056c21b792777280 Reviewed-on: https://gerrit.libreoffice.org/32755 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-13jdbc clob character stream: return 1 when returning a single odd byteLionel Elie Mamane
if at that point nBytesToRead is 0, it may be that it was 1, but we have read one byte from the buffer (m_buf). So in this case, return 1, not 0 (which would signal EOF). Change-Id: I229e53f1c38c80f709df244a3509caccd69c8ecf Reviewed-on: https://gerrit.libreoffice.org/33029 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Lionel Elie Mamane <lionel@mamane.lu>
2017-01-13tdf#101689 - Fix returning to first part of documents when resumedMert Tumer
Change-Id: I6d3a9354c702628e991c69176086efbbc28ddd74 Reviewed-on: https://gerrit.libreoffice.org/31753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: jan iversen <jani@documentfoundation.org>
2017-01-13inline InitGuardNoel Grandin
since it is only used in one place Change-Id: Ie541a255ddbe71105f6b58f02f372f4f45667d7a
2017-01-13Remove unused ini propertiesSamuel Mehrbrodt
Change-Id: Iea95f5975968f73e2e4aea34246c83f384341592 Reviewed-on: https://gerrit.libreoffice.org/33000 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-01-13unused variablesCaolán McNamara
Change-Id: I77a3fc5478a068530d9de4cc6962fe439169567e
2017-01-13tdf#105272: fix wrong namespace URLRosemary Sebastian
regression from f1dcb8b3e2e01848d44dd1beb82cd4e6e68a2acd Change-Id: I088894711617bd762bf4e9352ddf6d850a5cbe7b
2017-01-13new loplugin: useuniqueptr: sw part 1Noel Grandin
Change-Id: I2bc55634e80976951ede768c97fbc4b7c4eda46c Reviewed-on: https://gerrit.libreoffice.org/32963 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-13add PI, NA testcaseZdeněk Crhonek
Change-Id: I1c72c1c81883b43a13cf583a98b2f2a261a60895 Reviewed-on: https://gerrit.libreoffice.org/32844 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2017-01-13fix android buildNoel Grandin
Change-Id: I55ff31b40366398b6159ee7a99c75e393a05b36a
2017-01-13new loplugin: useuniqueptr: vclNoel Grandin
Change-Id: Idcbc8655108ff57c06c33bbcabd652387bf3c4ec Reviewed-on: https://gerrit.libreoffice.org/32948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-12tdf#48140 replace CellRangeAddress in xlsx import (14)Jochen Nitschke
Change-Id: Ie322489bd11d2a14810fec87f83ce04c652bea43 Reviewed-on: https://gerrit.libreoffice.org/33002 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-13tdf#105188 sd: fix shutdown crash after accessing master pagesMichael Stahl
The problem here is that the destructor of SdModule does a lot of things, including destroying an SdXImpressDocument that is referenced from some SdGlobalResourceContainer. This calls SD_MOD() to get the SdModule to get some resource, but at that point SfxApplication::GetModule() returns null, because the sequence was changed from first deleting the SfxModules, then clearing the pointer in ~SfxModule to null, to unique_ptr::reset(), which, at least in libstdc++, is implemented via std::swap, so it clears the pointer before deleting the SfxModule. It appears rather brittle to rely on such a subtle detail, so refactor things so that SdGlobalResourceContainer is no longer owned by SdModule but has its own pet XTerminationListener, which means it will be destroyed earlier, while the SdModule is still fully alive. (regression from f7b1cd66167050afecf487e3d89ea12de74200b5) Change-Id: I7f03f3adf431be8728ef3d65a078b536cb96f959
2017-01-12Drop unused struct membersKhaled Hosny
Change-Id: I37aea9a2a40ab0e9642709de3b9e935bee9a6a53 Reviewed-on: https://gerrit.libreoffice.org/32986 Reviewed-by: Khaled Hosny <khaledhosny@eglug.org> Tested-by: Khaled Hosny <khaledhosny@eglug.org>
2017-01-12sfx2: fix race in JunitTest UndoManager.checkBrokenScripts()Michael Stahl
1) checkBrokenScripts(complex.sfx2.UndoManager) java.lang.NullPointerException at complex.sfx2.UndoManager.impl_clickButton(UndoManager.java:432) at complex.sfx2.UndoManager.checkBrokenScripts(UndoManager.java:188) impl_clickButton() gets the wrong accessible object and throws. The .uno:SwitchControlDesignMode is dispatched async, so make sure it's processesed before trying to click the button. See UnoControl::getAccessibleContext() "in design mode, use a fallback". This was running in "rr record --chaos". Change-Id: Iee9f25c2fff56d32e6b579b5d44ee6df9870fd8b
2017-01-12tdf#50916 Use aCol.size() instead of MAXCOL to increase max number of columnBartosz Kosiorek
Currently when we are increasing MAXCOL variable, the memory usage and performance are increase dramatically. To resolve that, columns needs to be created dynamically according to needs. This patch replace hardcoded MAXCOL with aCol.size(). It is next step to make creation of columns dynamic. Change-Id: Ic7b7a76863e063a607165629bdf82699eaa847b3 Reviewed-on: https://gerrit.libreoffice.org/32708 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-01-12ofz: this cluster of variables are unusedCaolán McNamara
but lead to a fpe on an empty filter Change-Id: Id76b365b5fcc866d214753dada80411fc33d2e5c
2017-01-12ofz: avoid config during fuzzingCaolán McNamara
Change-Id: Ia5fa7a9c3304483e69db31256b9ffb22bb152c62
2017-01-12add -mlong-jump-table-offsets for m68k also for ooxRene Engelhard
Change-Id: Ibfba6c7c808ca5212884032c17546e95fa16353a
2017-01-12tdf#105071 MM no emails sent when using doc as mail bodyAlex McMurchy1917
The conditional statement exits if there is data to process and continues if there is no data to process. Thus all records are lost. This commit reverses this behaviour so that data is processed by the rest of the Mail merge activities. Change-Id: I4c92cbd7ca55be7842b07ad887813e417430ba4f Reviewed-on: https://gerrit.libreoffice.org/32994 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Tested-by: Jan-Marek Glogowski <glogow@fbihome.de>
2017-01-12tdf#48140 replace CellAddress in xlsx import (4)Jochen Nitschke
Change-Id: I52d7a37dd106744052d714e66fd84895aeb0a9b8 Reviewed-on: https://gerrit.libreoffice.org/33001 Reviewed-by: Jochen Nitschke <j.nitschke+logerrit@ok.de> Tested-by: Jochen Nitschke <j.nitschke+logerrit@ok.de>
2017-01-12Resolves: tdf#101187 colossal page width wraps around if doubledCaolán McNamara
when trying to generate a reasonable upper bound clipping region Change-Id: I53f8ea1bd6c52c88284e1f41369f83492d078b5d
2017-01-12tdf#103225 make AreaTab box fill to contentTomaž Vajngerl
Change-Id: I9900bab2bb4510352d191ee42c0fa83049d9cecc Reviewed-on: https://gerrit.libreoffice.org/33006 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2017-01-12tdf#104414: don't stop on exception from SwXFrame::setPositionMike Kaganski
Change-Id: Ib6d4e398d546d6fe250b9c1efe099ae8eef2d580 Reviewed-on: https://gerrit.libreoffice.org/32978 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-12Resolves: tdf#104897 sort windows buttons into yes, no, cancelCaolán McNamara
and kde, for gnome/macosx use no, cancel, yes Change-Id: I4aff39938c1c9f81b47934d8f1d9400c106781ad
2017-01-12don't check every possible kde variant, startswith kde is good enoughCaolán McNamara
Change-Id: I7fb9d22af32ad5bab2deedfc993e1ffaebd57111
2017-01-12gbuild: make 3.81 doesn't currently work with gbuildtojsonMichael Stahl
There is some problem with the pattern rule in post_GbuildToJson.mk being ignored, causing spurious workdir/GbuildToJson/Library/lib*.exports files with bogus content to be written; rather than trying to adapt that to 3.81 pattern rule evaluation, just refuse to run with 3.81, which is obsolete anyway. Change-Id: I492866464b309f8c475e34e8f311e42bf8736247
2017-01-12Adapt loplugin:overrideparam to recent Clang trunk changeStephan Bergmann
Change-Id: Ia372e39bc7e51f290a6d631bf0b81fd75f4fdc1d
2017-01-12a11y crash on accessing disposed TabControl during close of impressCaolán McNamara
Change-Id: I3064eb136ed3a6a32acd64bfb2f6fbe31595e1cf
2017-01-12gbuild: fix "make gbuildtojson" on Mac OS XMichael Stahl
Fails because library has dep on GeneratedPackage_python3, so nerf the dep like the others. Change-Id: I050a0f50996ce4231eb966fb6b624908d2f1788c
generated by cgit (git 2.34.1) at 2024-07-19 22:15:35 +0000