summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-07-15builds externals without werrorCaolán McNamara
I get a warning under MacOSX of argument unused during compilation -I . -Werror,-Wunused-command-line-argument Change-Id: I0ae48783eefa52a829471e51a94c79d235dc2f38 Reviewed-on: https://gerrit.libreoffice.org/39988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-14implement Application.FileDialog attributeTamas Bunth
Documentation: https://msdn.microsoft.com/en-us/vba/excel-vba/articles/application-filedialog-property-excel https://msdn.microsoft.com/VBA/Office-Shared-VBA/articles/filedialog-object-office Using FilePicker and FolderPicker uno services. Change-Id: Ifd3b3fc9c135efb0663d2ef36ecbe2b2fbe6132f Reviewed-on: https://gerrit.libreoffice.org/39806 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2017-07-14Turn m_nEdFocus into local variable, it's not read elsewhereEike Rathke
... and not read after having been set in FillControls() Change-Id: I09ae5655b6187bcedc95232797bddb24b9064847
2017-07-14Prefix member variables with m_Eike Rathke
Code is already confusing enough.. Change-Id: I5b6f5bce32342623374df67727c44cc50b77930c
2017-07-14Assert non-empty sheet nameEike Rathke
Change-Id: I6794d134a6f0d1f1b1531782c5f8011ce322085b
2017-07-14Embedded obj: don't change new window sizeSzymon Kłos
Change-Id: Idc5e1e26fa1a98c6f96a1f0f15b6e5c3c9398402 Reviewed-on: https://gerrit.libreoffice.org/39957 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2017-07-14Resolves: tdf#99071 tree view shows odd text widths when > 100 linesCaolán McNamara
reverts commit 62ea355b2679073b8ee326df5793231996136da9 Date: Thu Dec 12 09:55:35 2013 +0100 fdo#72125: GetTextWidth() can get very expensive. Let's just count an approximate width using a cached value when we have too many entries. The expert dialog got fixed by not populating it with all options on load and instead by incremental disclosure as the users searches/expands it so this optimization effort isn't needed in the meantime there was another problem the above papered over with commit b4bbb5e5d7b31caad2fbcc00382ad27df3c81001 Date: Sun May 17 22:56:46 2015 +0900 refactor how font, fg. and bg. are applied in widgets/controls which was fixed (hopefully) in the previous commit Change-Id: I8383d9cd7a9983a85c7f3acec0281d984c44f9e7 Reviewed-on: https://gerrit.libreoffice.org/39951 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-14list views are recalculating layout on every paintCaolán McNamara
instead of when the font changes since... commit b4bbb5e5d7b31caad2fbcc00382ad27df3c81001 Date: Sun May 17 22:56:46 2015 +0900 refactor how font, fg. and bg. are applied in widgets/controls Change-Id: I8c9ebeb8d85f2c8b5e5ddc0aa03b6d64b5348132 Reviewed-on: https://gerrit.libreoffice.org/39950 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-14loplugin:staticmethodsJan-Marek Glogowski
Change-Id: I40d08932115e07470de73b0f0dc9b9b03e608fbe
2017-07-14Fix instant 0ms scheduler wakeup for headlessJan-Marek Glogowski
This is a regression from commit 503eba23c9a199583eddee9e169a4fddbecf416f Due to rounding errors, as the Scheduler uses milliseconds, but the headless backend uses nanoseconds the StartTimer assumed it would wake up this ms, but the headless check function would still wait. This is more of a workaround, so instant wakeup for the headless backend works again. Change-Id: I2ba9b4ad2b67ec99eeb4dd098ded6457d3753127
2017-07-14tdf#108831 PGP signature shown as invalidSamuel Mehrbrodt
It was valid, but not trusted. We need to show the owner trust in another place. gpg4libre Change-Id: I344a7b064a22c16b647c73d52f7abd91cfc86be9 Reviewed-on: https://gerrit.libreoffice.org/39826 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-14gpg4libre: Show whether pgp keys are trusted or notSamuel Mehrbrodt
Owner trust levels considered valid keys: Marginal Full Ultimate Owner trust levels considered invalid keys: Unkown Undefined Never Change-Id: I7338b587acfd105ca24e40b45960cea8d2c04ded Reviewed-on: https://gerrit.libreoffice.org/39952 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-14tdf#96505 Get rid of cargo cult "long" integer literalsIvan Safonov
Remove unnecessary "Long" literals in cui/source/tabpages. Change-Id: Ia46cc027e2225ab7dcfdab2828f1fb4a60f4619a Reviewed-on: https://gerrit.libreoffice.org/39881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2017-07-14officecfg: increase GraphicManager/TotalCacheSize again for 64-bitMichael Stahl
There's a bit of a problem with XFillBitmapItem, which contains a GraphicObject that can't be swapped because it's a poolable item. Generally contemptorary hardware has enough RAM that we can easily increase the cache size to 400M (effectively there's another factor of 2x), but on legacy 32-bit platforms the address space is getting scarce, so keep the existing size for those. Change-Id: I8437f4e8c5421f8ec20e94e4cdf64f867d7760ca
2017-07-14sw: make SwGrfNode::mpReplacementGraphic swappableMichael Stahl
Same as previous commit, but for sw. Change-Id: Id678de3f512204437e37aaedf24e24aff7a9e592
2017-07-14svx: make SdrGrafObj::mpReplacementGraphic swappableMichael Stahl
These GraphicObjects clog up the GraphicManager cache so it's effectively useless. Round-tripping the ML bugdoc, this doesn't provide much of a speed-up by itself, but together with the previous fix it goes from 3:00 to 1:30 (in an optimized build). Change-Id: If52e176c790b94ffef9984be53376a34345b06e3
2017-07-14xmloff: ODF export: fix redundant setting of GraphicStreamURL swappingMichael Stahl
XMLShapeExport::ImpExportGraphicObjectShape() unnecessarily swaps out the GraphicObject by calling setPropertyValue("GraphicStreamURL") even if the URL didn't actually change from what was retrieved just a couple lines earlier, incidentally swapping it in too. Well actually it isn't really swapped out, it's marked as auto-swapped, but nevertheless on getting the "ReplacementGraphicURL" property its Graphic will be replaced by swapping it in again. So don't do that, then it's only swapped in once. This speeds up round-tripping the ML bugdoc from 3:20 to 3:00. Change-Id: I65a211a0c225444c06d5516df9c6716360be46c0
2017-07-14vcl: fix -Werror=format (32-bit GCC)Michael Stahl
Change-Id: Ia7afb5b9750704797ff8030688d0531c27d80836
2017-07-14CppunitTest_sw_uiwriter: disable testLinesMoveBackwards... on macOSMiklos Vajna
No idea off the top of my head what is the problem here, seeing Linux and Windows is happy; clang on Linux as well. Change-Id: I56c79b37a5648d9afd02d8e161ea4a279cc89744
2017-07-14gpg4libre: Don't use xmlStrlen on binary dataKatarina Behrens
Odd things happen inside gpgme if the buffer is prematurely truncated due to \n char and valid signature is then evaluated as invalid Change-Id: I24d4d22af06a3dde6eb7fdfc12953cf1b5f19c1e Reviewed-on: https://gerrit.libreoffice.org/39945 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2017-07-14tdf#108524 sw: handle sections inside tables in SwFrame::GetPrevSctLeaf()Miklos Vajna
This addresses the sub-problem described in comment 12 of the bug, i.e. text frames are now moved to the first page from the second one when text frames are deleted on the first page. Change-Id: Ic0ede45381fb84b13d1ac02e4d1f39d817650616 Reviewed-on: https://gerrit.libreoffice.org/39946 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-14Fix export test crash of ooo95715-1.xlsEike Rathke
Negative sheet number injected by sc::FormulaLogger::GroupScope::addRefMessage() wans't handled by lcl_Format() #9 0x00007f292172c322 in ScGroupTokenConverter::convert (this=0x7ffc5b1940d0, rCode=..., rScope=...) at /build/libo/dev/sc/source/core/data/grouptokenconverter.cxx:140 #8 0x00007f29224c54d8 in sc::FormulaLogger::GroupScope::addRefMessage (this=0x7ffc5b193ff0, rCellPos=..., rRefPos=..., nLen=111, rArray=...) at /build/libo/dev/sc/source/core/tool/formulalogger.cxx:147 #7 0x00007f292181c071 in ScRange::Format (this=0x7ffc5b193dc0, nFlags=-32760, pDoc=0x4b1db70, rDetails=..., bFullAddressNotation=false) at /build/libo/dev/sc/source/core/tool/address.cxx:2211 #6 0x00007f292181b9a9 in ScAddress::Format (this=0x7ffc5b193dc0, nFlags=-32760, pDoc=0x4b1db70, rDetails=...) at /build/libo/dev/sc/source/core/tool/address.cxx:2111 #5 0x00007f292181ecf5 in lcl_Format<rtl::OUStringBuffer> (r="", nTab=-1, nRow=75, nCol=0, nFlags=-30968, pDoc=0x4b1db70, rDetails=...) at /build/libo/dev/sc/source/core/tool/address.cxx:2018 #4 0x00007f29214471fb in rtl::OUString::operator[] (this=0x7ffc5b193c00, index=0) at /build/libo/dev/include/rtl/ustring.hxx:668 Change-Id: I68ecfb11574644e9e5670431789ee42d37d27523
2017-07-14gtktiledviewer: Typo; these should be classesPranav Kant
Change-Id: Iba449fc66423959340c7967c64bc422a28fc75dd
2017-07-14use more OUString::operator== in test..xmlsecurityNoel Grandin
Change-Id: If5bdd1532be44a47ff7cc3b769be3ea585aea562 Reviewed-on: https://gerrit.libreoffice.org/39685 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-14remove some dead code from unusedfields pluginNoel Grandin
Change-Id: I268b32270a17c0c3fcf8236c3e0eebac9a57cb5d
2017-07-14tdf#109107: Sidebar's fontheight field is not updated...Tamás Zolnai
... by moving cursor in an Impress table Table controller handles key and mouse events itself, but can't do the invalidation of the slotids which would lead to update sidebar corresponding widgets. Change-Id: I0d1db58ecb714bb16dfb1b5662f0fba7ce69c06f Reviewed-on: https://gerrit.libreoffice.org/39933 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-07-14use more OUString::operator== in swNoel Grandin
Change-Id: If43c8bfa906fc711ed8026a1e06add3d7ac166d9 Reviewed-on: https://gerrit.libreoffice.org/39941 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-14use more OUString::operator== in svxNoel Grandin
Change-Id: Ice996c741e239767a7a15fe9b11147f5384150ba Reviewed-on: https://gerrit.libreoffice.org/39940 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-14vcl: If we fail to create an OpenGLContext for a window - don't crash.Michael Meeks
Change-Id: I362724911ac60df7ac699495bac852be9e7c6b13 Reviewed-on: https://gerrit.libreoffice.org/36684 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-07-14tdf#108824 Save "Mouse pointer visible" propertySamuel Mehrbrodt
Change-Id: I6c5c9d885df7fa4032724861361957cb6981091c Reviewed-on: https://gerrit.libreoffice.org/39939 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2017-07-14 use more OUString::operator== in sfx2..svtoolsNoel Grandin
Change-Id: I859b77319f551eabd19dae54bd69c212221112a8 Reviewed-on: https://gerrit.libreoffice.org/39938 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-14extend loplugin useuniqueptr to POD typesNoel Grandin
Change-Id: I6ff24f048bd8f75bf87a78b718f37b57855d4781 Reviewed-on: https://gerrit.libreoffice.org/39932 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-14 use more OUString::operator== in scaddins..sdextNoel Grandin
Change-Id: I8bc5c925f940283bc54698bbcba77efcca883273 Reviewed-on: https://gerrit.libreoffice.org/39937 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-14UBSan misses typeinfo for CBmpContextStephan Bergmann
...after e3f3b3b75d7411827291e98c9c78c89cedc2836b "pdfium: update to 3151" Change-Id: Ie8646b4f1a132e8be6da10e9919e17865bc3e571
2017-07-14loplugin:oncevar: empty stringsStephan Bergmann
...which showed that checking the parent statement (which may be too large to) in OnceVar::VisitDeclRefExpr is inadequate. Change-Id: I07fb8ba9e2dfbd0c65a2723737d14abcddcefec4 Reviewed-on: https://gerrit.libreoffice.org/39757 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-14Remove unused [m]sChartAddressStephan Bergmann
...as found by an improved loplugin:oncevar (to be pushed later). The code's effectively been like that ever since its introduction in a41687b62b0a6f2b79e44311ddf74c52e844ee36 "New files from xlsx-shared-oox-chart-export-part1.diff", and (as Bubli states) is apparently a poor copy/paste from xmloff/source/chart/SchXMLExport.cxx. The equally-unused [m]sTableNumberList had previously been removed with f9cd73ebe116cd95247aff1963e2f5b4ec671dfa "remove a few more unused variables". Change-Id: I1e0e14b4d79cd34437b0061fc9ea3ce4d5636b31 Reviewed-on: https://gerrit.libreoffice.org/39756 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-07-14Modernize gtktiledviewer; use GApplicationPranav Kant
Put all the UI content in UI XML file. Unfortunately, lots of boilerplate code because G_DECLARE_* macros are available only since glib 2.44 Change-Id: Idc74ba8565d482c28abd00b6f6f75646ab3d40b9 Reviewed-on: https://gerrit.libreoffice.org/39913 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2017-07-14Revert "tdf#109067 Fix default value of rotWithShape"Miklos Vajna
This reverts commit 1b08f129677c1109aae1fadc72ae68ebb7df7cb0. The change was Jenkins-verified, but just rebasing it on top of latest master (without getting conflicts) broke the test added in the commit. So let's revert it for now to have time to find out why does the test fail on top of latest master. Change-Id: I3bce24e54fb07df2dd460fb0f01d44516b3fcd0d
2017-07-14use more OUString::operator== in scNoel Grandin
Change-Id: I1a7691fe59e5e93c15bd812f03366da814f9f3db Reviewed-on: https://gerrit.libreoffice.org/39900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-14loplugin:useuniqueptrStephan Bergmann
Change-Id: Idcfec3e33031eea311377a51f51c65dd3c4d25dc
2017-07-14Fix o3tl::make_uniqueStephan Bergmann
...after 3f20471490c61b19fe4222f8c40df255051f6e3d "use std::unique_ptr in FlatFndBox: and extend o3tl::make_unique to cope with arrays" Change-Id: I17a07d0be677aa4a5427be4a5c2f05ed8b675726
2017-07-14tdf#109067 Fix default value of rotWithShapePaul Trojahn
According to the OOXML standard the default value is true, so for the export of gradients and blips it has to be set explicitly to false. Change-Id: I3c9f67787cb11d6d9b58f07377b03167df669ed8 Reviewed-on: https://gerrit.libreoffice.org/39725 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-14tdf#97362: TextPortionEnumerationTest partially migrated to python (part 3)jmzambon
Convert tests: - test_marks1 - test_marks2 - test_marks3 - test_frame_mark1 - test_frame_mark2 - test_frame_mark3 - test_frame_mark4 - test_frames1 - test_frames2 - test_frames3 - test_frames4 - test_frames5 - test_ruby_hyperlink1 - test_ruby_hyperlink2 Change-Id: I3ee495cdd88cffefd3980184bac0a72bae6a749f Reviewed-on: https://gerrit.libreoffice.org/38976 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-14xmlsecurity pdf verify: push_back -> emplace_backMiklos Vajna
And a few other similar small cleanups. Change-Id: I91c992f33f2166d1cf27cbc9def1b69965040658 Reviewed-on: https://gerrit.libreoffice.org/39928 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-07-14Moving legacy contexts to FastContexts:Mohammed Abdul Azeem
ScXMLTrackedChangesContext ScXMLChangeInfoContext ScXMLBigRangeContext ScXMLCellContentDeletionContext ScXMLDependenceContext ScXMLDependingsContext ScXMLChangeDeletionContext ScXMLDeletionsContext ScXMLChangeCellContext ScXMLPreviousContext ScXMLContentChangeContext ScXMLInsertionContext ScXMLDeletionContext ScXMLMovementContext ScXMLRejectionContext Change-Id: I13b657efa47bd037e9f83c39ba8fd0f6b7edba1c Reviewed-on: https://gerrit.libreoffice.org/39927 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-14tdf#103104 Allow line-continuation followed by a dot in BASICTakeshi Abe
as in VBA-compatibility mode. Change-Id: If263183fc1fa5742235213a8617fdf412d2a245e Reviewed-on: https://gerrit.libreoffice.org/39893 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2017-07-14UI Test idle needs to run with highes priorityMarkus Mohrhard
regression from 00aa0892e7385cd8395dd39814077958be42e720 Change-Id: I840391573ae52be6ba4a34b2a802b637578afa40
2017-07-13tdf#107166 BindDC doesn't handle 0 width/height rect consistentlyTomaž Vajngerl
When binding a GDI device context to D2D we need to provide a rectangle where the surface will have effect. When we just need some font information we need to bind the DC too, but we aren't really interested what the rectangle is, so we just provided a 0,0,0,0 rectangle in that case. This sometimes fails with a "out of memory" result and is dependent on the renderer. Instead of 0,0,0,0 rectangle we rather define a 0,0,1,1 rectangle which should never fail. This is not problematic as for actual rendering we later rebind with an actual rectangle. Change-Id: I79c7f0cf4d69f213370ed26a811a908ed16070ff Reviewed-on: https://gerrit.libreoffice.org/39901 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-13tdf#108524 sw: allow frames in follow sect-in-tables in SwFlowFrame::MoveBwd()Miklos Vajna
The intention is to filter out text frames directly inside tables; since tables in general reflow by moving all of the content to the first page, then moving not fitting content to the next pages. Section frames are different, there we explicitly move content backwards, similarly to page body frames. Teach SwFlowFrame::MoveFwd() that a text frame inside a section-in-table is the section situation, not the table situation, since what matters here is the direct parent. To be on the safe side allow this for follow section frames only. This is necessary, but not enough to address the sub-problem described in comment 12 of the bug. At least SwFrame::GetPrevSctLeaf() is invoked to consider a precede section frame, though. Change-Id: Ic88602cffefbbc81ecc90e3880be2a098f60fb04
2017-07-13libreofficekit: Merge add_libs block into onePranav Kant
Change-Id: I0c4c2f3389cae243dbbfd16667d44d3ab8851860 Reviewed-on: https://gerrit.libreoffice.org/39914 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-10 23:13:32 +0000