summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2014-10-15More -Werror,-Wunused-private-fieldStephan Bergmann
...detected with a modified trunk Clang with > Index: lib/Sema/SemaDeclCXX.cpp > =================================================================== > --- lib/Sema/SemaDeclCXX.cpp (revision 219190) > +++ lib/Sema/SemaDeclCXX.cpp (working copy) > @@ -1917,9 +1917,10 @@ > const Type *T = FD.getType()->getBaseElementTypeUnsafe(); > // FIXME: Destruction of ObjC lifetime types has side-effects. > if (const CXXRecordDecl *RD = T->getAsCXXRecordDecl()) > - return !RD->isCompleteDefinition() || > - !RD->hasTrivialDefaultConstructor() || > - !RD->hasTrivialDestructor(); > + return !RD->hasAttr<WarnUnusedAttr>() && > + (!RD->isCompleteDefinition() || > + !RD->hasTrivialDefaultConstructor() || > + !RD->hasTrivialDestructor()); > return false; > } > > @@ -3517,9 +3518,11 @@ > bool addFieldInitializer(CXXCtorInitializer *Init) { > AllToInit.push_back(Init); > > +#if 0 > // Check whether this initializer makes the field "used". > if (Init->getInit()->HasSideEffects(S.Context)) > S.UnusedPrivateFields.remove(Init->getAnyMember()); > +#endif > > return false; > } to warn about members of SAL_WARN_UNUSED-annotated class types, and warn about initializations with side effects (cf. <http://lists.cs.uiuc.edu/pipermail/cfe-dev/2014-October/039602.html> "-Wunused-private-field distracted by side effects"). Change-Id: I3f3181c4eb8180ca28e1fa3dffc9dbe1002c6628
2014-10-15Resolves: #i63015# always default to WinAnsiEncoding...Herbert Dürr
for non-symbol PDF-Type1 export Suggested-By: edv@gruene.de Reviewed-By: hdu@apache.org (cherry picked from commit b8186703cb43d2b57460cb23a7a4e3f989e95426) Conflicts: vcl/source/gdi/pdfwriter_impl.cxx Change-Id: I02227724bff301133ac8ce5562ec5ca1ed94f136
2014-10-15Resolves: fdo#85032 max len property of -1 -> crashCaolán McNamara
Change-Id: Ief903c619204f01784e93fd5e2d582632cef032e
2014-10-15coverity#982478 Dereference after null checkCaolán McNamara
maybe sort of can be considered a regression from commit 733b831970204059b9d89eff203551d6d3bf4bbe Date: Tue Jan 5 16:37:41 2010 +0100 swunolocking1: swtypes.hxx: rename frame anchor types enum RndStdIds: rename frame anchor types (FLY_*) to be more intuitive. where if (0 == (pAnchorPos = pAnch->GetCntntAnchor())) bCallMake = sal_False; turned to if (pAnchorPos) bCallMake = sal_False; but there would always be a following de-ref of a potential NULL pAnchorPos which wasn't FLY_AT_PAGE Change-Id: I808b4f178887ab6149e38bab6e36eb68d7a1eb29
2014-10-15loplugin: cstylecastNoel Grandin
Change-Id: I0ccdd2ce18336afea67a3f296b26b2de50f14808
2014-10-15loplugin: cstylecastNoel Grandin
Change-Id: I96a0d5d7ec3363076b0165f3c540c51ef01b58f3
2014-10-15fdo#82860 RTF import: fix handling of SHAPE fieldsMiklos Vajna
No need to use fieldmarks for these. Change-Id: I8d2c797f2b00be88e445dab0dd69cb1a9556c02c
2014-10-15fdo#82860 RTF export: if shape has textbox, export its contents as shape textMiklos Vajna
See 8c677716c4707ccd86b152ae504841affb393cc0 (DOCX drawingML export: if shape has textbox, export its contents as shape text, 2014-06-06). Change-Id: I5b1afae4d1b80c9b225096677f7d7ae77ff90f5b
2014-10-15fdo#82860 RTF export: don't export textboxes of shapes twiceMiklos Vajna
See 96965fb39d6d376e91030a01c11f16f9428ddf2e (DOCX drawingML export: don't export textboxes of shapes twice, 2014-06-06). Change-Id: I89c039debeca5f88f172479b9f8ecbaec2dc7bc4
2014-10-15fdo#84938: replace SYMBOL_TYPE constants with enumNoel Grandin
Change-Id: Ib3763f20d74c22e28d519a9ac47f6f3ab4e31f51 Reviewed-on: https://gerrit.libreoffice.org/11983 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15vcl: cleanup salgdi.hxxChris Sherlock
Change-Id: Iced928a97afdc30e8cb1e24dd148c8b838e8eb72
2014-10-15coverity#1212509 Logically dead codeCaolán McNamara
this look very wrong, surely this is what was meant Change-Id: I461fc1a67770c733aee2f4379dcc252abd09b641
2014-10-15avoid double-deleteDavid Tardon
This is a regression from commit b1d48f0d9a3442c11adae6e36325a463d89ce44e. Change-Id: Iffd39782c1d1fd7be14f4d657919f704807a40f5
2014-10-15Add a small script to run adb logcat with filteringTor Lillqvist
We use arbitrary tags when logging stuff in our code so we can't use the built-in filtering of adb logcat. Change-Id: I2d607b86bde975c5cbdd17adc22d0fc15076be51
2014-10-15remove unused DECL_OBJHINT and IMPL_OBJHINT macrosNoel Grandin
these have been unused since we switch to using normal C++ RTTI with the SfxHint subclasses Change-Id: Ia271cfa01d2f49ed335e90f78309cd26d6ec9d8f
2014-10-15I think this is what was meant, see cf7832d6Adolfo Jayme Barrientos
Change-Id: I626e3a36426958d7ba1fd320cf8e1a3bf2f3595f Reviewed-on: https://gerrit.libreoffice.org/11980 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-15Trying to make the Find & Replace dialog a bit more compactAdolfo Jayme Barrientos
Especially with long translations, the removal of homogeneous-width columns make the dialog’s size more manageable. Fixed capitalization, indentation, and made the dialog non-resizable to remove the Maximize button under Compiz/GNOME and the fat border under XP. The expander will still work. Change-Id: I2fb820ac406afe45a3d5339f574c13902ad48753 Reviewed-on: https://gerrit.libreoffice.org/11942 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-15coverity#1244937 Unchecked return valueCaolán McNamara
Change-Id: I7691103b5011861d9e84860671be8e46651a27b1
2014-10-15Make ImportCGM signature match ImportCGMPointer (in sdcgmfilter.cxx)Stephan Bergmann
Change-Id: I363777ff59b1756a15615d3daaa0c95542632361
2014-10-15nDrehWink -> nRotationAngleMiklos Vajna
Change-Id: I33ca88f38210140931b12a05e426d1373243156e
2014-10-15runner: replace '.size() == 0' with '.isEmpty()' (collections)Robert Antoni Buj i Gelonch
http://docs.oracle.com/javase/1.5.0/docs/api/java/util/ArrayList.html#isEmpty() Change-Id: I9a8f4feab9120d2d9fbf845f305380cda9b263bb Reviewed-on: https://gerrit.libreoffice.org/11968 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15rm ‘public static final’ modifiers from field declarations within interfacesRobert Antoni Buj i Gelonch
Change-Id: I2154052f89787b6fe17edb2f6e6ea132347b3d13 Reviewed-on: https://gerrit.libreoffice.org/11971 Reviewed-by: Noel Grandin <noelgrandin@gmail.com> Tested-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15convert PORTION_KIND constants to enumNoel Grandin
Change-Id: I32d65cfd7a67cd7ebca0f99061293a9ac3398133 Reviewed-on: https://gerrit.libreoffice.org/11970 Tested-by: LibreOffice gerrit bot <gerrit@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2014-10-15remove duplicated call to mpChildrenShapes->SelectionChanged()Eike Rathke
Found when investigating performance bottlenecks of fdo#75486, after the selection is completed ScTabViewObj::getSelection() is called multiple times, each creating a ScCellRangesObj of the range list of filtered ranges, which then is used for ScChildrenShapes::FindSelectedShapesChanges() The duplicated call was introduced with b41332475783c31136673fb44cf4c411bb0148f8 but IMHO does not make any sense at all unless it has obscure side effects, it only slows down things even more. Change-Id: I3cee2e3e62c24ad72efb8cc2021e74d0afc70b69
2014-10-15speed up simple range list joins that could be appends, fdo#75486 relatedEike Rathke
Change-Id: I734ff88bc4c0633875c9e9c19a817b8b08511c83
2014-10-15speed up range list generation from multi marks, fdo#75486 relatedEike Rathke
Change-Id: Id2114652948d12c92b0e7be7afa304bfffc8fbe0
2014-10-14vcl: re-factor scaling to use a single fn. pointer based invocation.Michael Meeks
Change-Id: Ide61808dbfa82ce67794150f44b6bac4f3c8e302
2014-10-14vcl: Re-factor to use the ScaleContext to pass parameters.Michael Meeks
Change-Id: If4359a6b776b4a94a6934e9fd02ede475a0612a7
2014-10-14vcl: create a ScaleContext to share copy/paste Bitmap scaling code.Michael Meeks
Change-Id: I5a90b7c6065829d74c61b833f0551b8adc3f2711
2014-10-14vcl: hide bitmap helpers in an anonymous namespace.Michael Meeks
Change-Id: I96ad50f538cfb6ecd256c4268feb81796a135b2b
2014-10-15sc: fix temp file leak in ScHTMLExportTestMichael Stahl
Change-Id: Iab385ce8b24dd24985ec9b2d0c9d2a4e603d0fd0
2014-10-15cppunittester: make tracking down temp file leaks easierMichael Stahl
Temp files created before first test method don't see LO_TESTNAME Change-Id: Iff74abf574f5151980f463646f11c1b32ad0c241
2014-10-15sc: fix temp file leaks in ucalc TestMichael Stahl
Change-Id: Id5243aa37578cf9ed534603f3b27e83f0678c3fb
2014-10-15sc: fix temp file leak in ScFiltersTestMichael Stahl
Change-Id: I1920fa405f377abafe793b4bbec52b8b141459f6
2014-10-15sc: fix temp file leak in ScExportTestMichael Stahl
Change-Id: I9b9944fa1b9e00989a499f7a8fac74097ae9d61b
2014-10-15sot: stop leaking temp files from StgTmpStrmMichael Stahl
The problem is that "aName" is stored as a file path, but osl_removeFile only works with URLs. Change-Id: I6929efc89a9e1a2292f038482b88d38946e6e4e8
2014-10-15ww8: warning C4701: potentially uninitialized local variableMichael Stahl
Apparently xmloff supports at least one value that has no equivalent in OOXML; just use "none" for now. Change-Id: I76d2802c7c91ea756125e66c229ec5fdb2e7ec3b
2014-10-14fix tinderboxen with the right sort of brackets.Michael Meeks
Change-Id: I13869771890ce5702d64053e7823dd5cedc82a40
2014-10-14fdo#82071 RTF import: get rid of unexpected underlining in TOC fieldMiklos Vajna
Regression from commit 9679e9c23216decb5f9f25f85b04cb3f25211111 (fdo#69649 Fix for pre-rendered Table Of Contents, 2013-12-30), now that we handle hand-edited TOC, it's necessary to properly track correctly if a property came from a style or as a direct formatting. Fix RTFDocumentImpl::getProperties() to detect direct formatting that cames from a char style and would result in attribute tokens. Change-Id: Iab5a14770de43249961c280a5dc698200abc8f49
2014-10-14Missing ModelessDialog -> ModalDialogStephan Bergmann
Change-Id: I83a3eb34138c75dbc5a0239a9d761d22c6cd98a0
2014-10-14fdo#75757: remove inheritance to std::mapTakeshi Abe
from UniqueIndexImpl. Change-Id: Iaa9040dff117ed5b05955c9f6eef31878dccf3b0 Reviewed-on: https://gerrit.libreoffice.org/11951 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2014-10-14Resolves: fdo#72587 make template dialog ModalCaolán McNamara
Change-Id: Iefb63bc7cdbff2217f16c1a72fc271361227588b
2014-10-14valgrind: init GroupLevelsCaolán McNamara
Change-Id: Idccebc826ade29a507e115108d20fd461b7bb4ec
2014-10-14stray ;s all other the placeCaolán McNamara
Change-Id: If67bf3361e082c1321f42ae7717cc941dc96e74b
2014-10-14valgrind: multiple errorsCaolán McNamara
Change-Id: Ic0ee492710650165004ad05f523424ba1b094473
2014-10-14check for short readsCaolán McNamara
Change-Id: I98a7d77cabe0207ff2b0190ccef47b87d1552930
2014-10-14sal_True->trueCaolán McNamara
Change-Id: Idbbc50afbb229dca1b62a7a0d1b2eeec9b0418d5
2014-10-14valgrind: Source and destination overlap in memcpyCaolán McNamara
Change-Id: I0b83a1955b6752c1253cfd7992a50b932aac078d
2014-10-14valgrind: Mismatched free() / delete / delete []Caolán McNamara
Change-Id: I78a9e08fb3535f9fe6c61a6e192c7aff4ef0c527
2014-10-14valgrind: Mismatched free() / delete / delete []Caolán McNamara
Change-Id: I293229dabb9a04f2e76b556e9da66921328ebe23
generated by cgit (git 2.34.1) at 2024-07-01 04:07:29 +0000