summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-07-17upload libwps 0.4.7David Tardon
Change-Id: I842c7b64527d9b0aae35b3f9e1febcacb601fc28 Reviewed-on: https://gerrit.libreoffice.org/40038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-07-17upload libmwaw 0.3.12David Tardon
Change-Id: Ie1daeb0b637649cbb7eda923495949a6d9e84102 Reviewed-on: https://gerrit.libreoffice.org/40036 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Tardon <dtardon@redhat.com>
2017-07-17connectivity: add initial writer backendMiklos Vajna
Similar to the calc one. As a first step the Driver and the Connection interfaces are implemented, though the later has some stubs. Change-Id: Id043f7742fdb2006d4f88526ef4d055a6d8dee82 Reviewed-on: https://gerrit.libreoffice.org/40033 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-17sw: prefix members of SwFormatAnchorMiklos Vajna
Members had "", "m" and "m_" as prefixes, standardize on the later. Change-Id: I468b3444e4918809bc9a07884c662af042abbd9e Reviewed-on: https://gerrit.libreoffice.org/40034 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-07-17svl: fixup Android build fixMiklos Vajna
Change-Id: I9f4b09ba48cd14e3cdd9cbd126d81f4b40bdb04b
2017-07-17extend loplugin useuniqueptr to OUString pointersNoel Grandin
Change-Id: Ieb5bab3895e1edaff497c4a1a88303ccac097edc Reviewed-on: https://gerrit.libreoffice.org/39948 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-17svl: fix Android buildAshod Nakashian
Change-Id: Ice5bd4da242297d61392dd7a7e557e0182394125 Reviewed-on: https://gerrit.libreoffice.org/40031 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com>
2017-07-17svl: fix Android build where no NSS existsAshod Nakashian
Change-Id: I031b3efd4cf203cda0a69341e8c47b36cc7cfe37 Reviewed-on: https://gerrit.libreoffice.org/40013 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-07-17gpg4libre: use full SHA1 hash for key identificationThorsten Behrens
Read and write full 20 bytes/40 hex chars of SHA1 key hash, instead of some abridged versions. See also https://lists.debian.org/debian-devel/2016/08/msg00215.html Change-Id: I741afc94ac7cf559880fe55ff02420723e13310d Reviewed-on: https://gerrit.libreoffice.org/40027 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-17gpg4libre: unconditionally use binary IOThorsten Behrens
Regardless of changing gpgme defaults, we don't want ascii armor anywhere. Change-Id: Ic1e80e134b8f24d05d6549ef19c5a82220718f1f Reviewed-on: https://gerrit.libreoffice.org/40022 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-17gpg4libre: search for _all_ local keys in getCertificate()Thorsten Behrens
Otherwise, newly-imported ones will not show up, which is bad when trying to figure out how much we trust a key in DocumentDigitalSignatures::ImplVerifySignatures() Change-Id: I771cf71b5e0ddb5cc76db94d7ada4c5291fe56f1 Reviewed-on: https://gerrit.libreoffice.org/40023 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2017-07-17svl: move byte-array verification from vclAshod Nakashian
Also use comphelper::Base64 and DateTime::CreateFromUnixTime to avoid depending on sax. Change-Id: If1853f8d9481c9caa0625a111707531bbc495f75 Reviewed-on: https://gerrit.libreoffice.org/39993 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-07-16tools: create DateTime from Unix timeAshod Nakashian
Certain parts of the code need to work with Unix time (seconds from epoch--Jan 01, 1970). This helper is currently intended to be used by the crypto signing logic, but should be adopted elsewhere to eliminate unnecessary conversions via string and other intermediatary forms. Change-Id: I3113c17f5d91f9b6cb59a00215582441b0186644 Reviewed-on: https://gerrit.libreoffice.org/39992 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-07-16Fix lifecycle issueStephan Bergmann
...as shown by ASan/UBSan build use-after-free report at <https://ci.libreoffice.org/job/lo_ubsan/602/> after 8e39ef66928a3e37c618d3a70a631e71266db274 "extend loplugin useuniqueptr to POD types" Change-Id: Ic42e408c2c4b2901cdf5d681b332543ec8f445ef
2017-07-16lopgluin:unnecessaryparen: Properly treat parenthesized sub-expr in sizeof (x)Stephan Bergmann
...where redundant parentheses are probably common enough to not warn about them Change-Id: Ia88097f5d3433e03337d6d42a144abfe210733c2
2017-07-16Avoid crash when rSignal.Handler is SIG_DFL etc.Stephan Bergmann
Change-Id: I20bccf4f6d52986334725cf72909730fcfc5109b
2017-07-16comphelper: move base64 encode/decode helpers from saxAshod Nakashian
Change-Id: I02e33793736003f36976bc8b518c389a31082dbe Reviewed-on: https://gerrit.libreoffice.org/39991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-07-16zero init the TabSet tooCaolán McNamara
and move the ColumnDef init into its ctor Change-Id: I16e5252c53037663caf9f51b55adfbb7d29da549 Reviewed-on: https://gerrit.libreoffice.org/40008 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-16FormulaDlg_Impl::UpdateValues: evaluate in force-array context if presentEike Rathke
Change-Id: I32488373bd22e644ee06920045008f3d9e20e985
2017-07-16Updated coreOlivier Hallot
Project: help 7d9270f4d45603665daaa51f31914eadbbd6b353 Help-in-browser (ix) Add contents treeview Add Contents tree transforming *.tree files Reposition <meta> tag for UTF-8 Fork bash script for faster processing Change-Id: I6c74aa1e855b7f4bb152e2c632f6ab7d683e5462 Reviewed-on: https://gerrit.libreoffice.org/40007 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-07-16Updated coreStanislav Horacek
Project: help 0d9a8fd684b33942185c76e1a37353ce4566f014 fix command in Detective for automatical refreshing of traces Change-Id: I17d733ee55e0908d27c3d4ecc58237b8858dcd73 Reviewed-on: https://gerrit.libreoffice.org/40006 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-07-16vcl: use svl signing and remove moved codeAshod Nakashian
Change-Id: Id875a675d7ab649c9223ecca5de2da69ff4b8786 Reviewed-on: https://gerrit.libreoffice.org/39718 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-07-16don't use memset on structure with std::shared_ptr memberMarkus Mohrhard
Change-Id: Ie6033b9820435bb6a45aa70f9a48115000571e0f Reviewed-on: https://gerrit.libreoffice.org/40004 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-15tdf#38915: don't wait on message queue if application already has quit.Mike Kaganski
Despite precautions in Application::Execute() and ImplYield(), in my testing I sometimes see that soffice is waiting in ImplSalYield()'s GetMessageW() when ImplGetSVData()->maAppData.mbAppQuit is true, so that soffice.bin hangs in the background. I suspect that this is related to the bug. Some obscure code path seems to be able to get here after the flag is already set. So, test also in ImplSalYield() right before GetMessageW() to make sure. Another possibility is that we get here when the flag is not set yet, and gets set while already waiting, but that would mean this happens in a different thread. Change-Id: Idb19eabcca8b5c24eac0ca76950edc1bf1e5bccb Reviewed-on: https://gerrit.libreoffice.org/39996 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-07-15svl: move byte-array signing from vclAshod Nakashian
Signing a generic byte-array can (and will be) used by more than the existing PDF signing code, hence the move into comphelper from vcl and ourside of the PDF-specific logic. Change-Id: I7257b5218c6ba37960c6a013746eb387917a23a4 Reviewed-on: https://gerrit.libreoffice.org/39717 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Ashod Nakashian <ashnakash@gmail.com>
2017-07-15the font installation code is now controlled by ENABLE_GIOMarkus Mohrhard
Found by the random config linux tb. Change-Id: I86921dedb5c8bacc5131e6dd66df86cb028edaf3 Reviewed-on: https://gerrit.libreoffice.org/40001 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2017-07-15coverity#1415093 annotate Waiting while holding a lock as deliberateCaolán McNamara
Change-Id: I88146737b1a1480c9ed1207896b0343dc982784a
2017-07-15coverity#1415095 annotate Infinite loop as false positiveCaolán McNamara
Change-Id: I030a6bee3864e758177ce73b678ba22cd10ec217
2017-07-15coverity#1415092 Logically dead code (golden)Caolán McNamara
this was detected after commit 85ff2eafc692f6f0d33ac611600935a96058f20a Date: Thu Jul 13 23:32:46 2017 +0530 Moving legacy contexts to FastContexts: but exists since commit 3d23002b6c1189e18922dbcbfbd5d271ecd09c2a Date: Tue Sep 4 05:26:24 2001 +0000 #91850#; fix the problems of called assertions which resulted in... else if (IsXMLToken(aLocalName, XML_TYPE)) { if (...) ... else if (IsXMLToken(aLocalName, XML_TABLE)) nActionType = SC_CAT_DELETE_TABS; } ScXMLInsertionContext::ScXMLInsertionContext though doesn't suffer from this Change-Id: I8c5fced7a81d892cc6208a1d9a2c78a692e02090 Reviewed-on: https://gerrit.libreoffice.org/39998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-07-15use unique_ptr for ScMyLabelRangeJochen Nitschke
Change-Id: Ib54d28024d5f853c6f54600222be7a4285873a9b Reviewed-on: https://gerrit.libreoffice.org/39986 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-15Don't call ensureIsAlive after comphelper::OExternalLockGuard.Arnaud Versini
comphelper::OExternalLockGuard calls ensureIsAlive, no need to call it twice. Change-Id: I08d2b77dcb4d1e72a69c521bf969cbe1e65d5721 Reviewed-on: https://gerrit.libreoffice.org/39997 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-07-15improve variable scopeCaolán McNamara
Change-Id: I1207c570c4bceac73b3197e11bcefcf73837d1b3
2017-07-15coverity#1415091 Dereference before null checkCaolán McNamara
Change-Id: If22c6a9d9b312e52b2956fd84618d3e95fda1c3e
2017-07-15coverity#1415090 Unchecked dynamic_castCaolán McNamara
and coverity#1415096 Unchecked dynamic_cast Change-Id: I29a20a0868f8720a7aee60ebd6f55a7dbb76f894
2017-07-15coverity#1415097 Uninitialized scalar fieldCaolán McNamara
Change-Id: Id9c70160143be0bede015f07e091c25f36bb13db
2017-07-15loplugin:useuniqueptr in basic..cppcanvasNoel Grandin
Porting over b0e05f9ade9e93c569c6a62c59ac1819e615f27b to copies of emfpp*.[ch]xx Change-Id: I059d2cc371f24ce3d43fc2e255b1dc1c227cf555
2017-07-15emfplus: corrections for UnitTest in vclArmin Le Grand
The CppunitTest_vcl_filters_test was not working due to a wmf file now being loadable. This leaded to better check errors on stream and react on it in test code. Hrad to find since that test - for whatever reason - is not executed on win. Also need to check result of EmfReader. Added emfio to test's module list Change-Id: Iea2b835408e919a8456e8f178cbfc782885ffebb
2017-07-15emfplus: more corrections due to linux buildArmin Le Grand
Change-Id: Ib2c3bff23043638d315405b5a91b2596e92f7ffa
2017-07-15emfplus: UnitTests and gerrit build correctionsArmin Le Grand
Needed to migrate UnitTest for Emf/Wmf import from vcl to emfio. Corrected stuff based on gerrit build feedback Change-Id: I7fd2456f814ea19583072ba09730a07e9b9d4061
2017-07-15emfplus: finetuning, UnitTest, not active by defaultArmin Le Grand
Change-Id: Ie085ad2610a306c7f9c44551114041d0950d1af5
2017-07-15emfplus: unified transformations, added test codeArmin Le Grand
More unifications, changed all Map*() methods to use a single B2DHomMatrix which is created based on former stuff, XForm now completely replaced. To check, added debug-only code and switches to the VclPixelProcessor so that visual checks get easy when using these modes (overlay of both methods with modded colors). Also resynched to master. Change-Id: I7b749f90bfde2ec1c2e49ee90ca2ef368da0547e
2017-07-15emfplus: more corrections and rough geometryArmin Le Grand
Corrected/streamlined more, added 1st rough geometry creation to have a proof of concept. Checked the helper classes based on EMFPObject and their derivates. First versions of EMFPPlusDrawPolygon and EMFPPlusFillPolygon, but the complex info in the data objects needs more complex primitive creation. Not sure if primitive creators like createHairlineAndFillPrimitive will be usable, these are based on PropertyHolder info. Also added usage of HandleNewClipRegion, that should be usable Change-Id: I96119be290140bee252ee21a3e1187fad60e9c7d
2017-07-15emfplus: some cleanup/streamliningArmin Le Grand
Change-Id: Ia931ca356fb079b9cb2395ba2311b91d2481e2d4
2017-07-15emfplus: migrate gdiplus reader to drawinglayerArmin Le Grand
In the current state interpretation of the GDI+ data is needed in the MetafilePrimitive in the drawinglayer project. Migrate helper stuff and reader from cppcanvas to drawinglayer as tooling, prepare tooling, prepare changing from direct canvas rendering, isolate and migrate existing tooling from MetafilePrimitive from reading emf/wmf to places where it can be commonly used by both, prepare cange of different graphic statue usages, start changing XForm to B2DHomMatrix conversions, ... Change-Id: I2d6954f69464653d111abb316fd9654ad3499c3f
2017-07-15emfplus: completed isolation/migration of Emf/WmfArmin Le Grand
Decided to keep the migrated/isolated Emf/Wmf reader which are now hidden behind a Uno Api. Had to re-implement WMF_EXTERNALHEADER (now WmfExternal, own file/header) to not break anything. It *seems* to just scale something and could be done after import, but I could not be sure. Also needed a callback hook to allow getting the Metafile out of a MetafilePrimitive in a lower module (vcl relative to drawinglayer) which is needed as long as primitives are not completely on Uno Api. Deleted all Emf/Wmf reader stuff from vcl. Change-Id: Ic5540defa8ec770728280df4df3f12e1f48cfc3a
2017-07-15emfplus: more streamlining of metafile importerArmin Le Grand
Change-Id: Ice0f779f8026983fd0884c2a02e9fd7220b498dc
2017-07-15emfplus: reorganized some old filter aspectsArmin Le Grand
Change-Id: I1949e851c560a81a461ec42a992f3b2cb0d019f8
2017-07-15emfplus: add rough version of local readerArmin Le Grand
Complete redevelopent is too expensive, start with adding a copy of the existing vcl importer which will in the next steps be adapted to import primitives instead of MetaFile(Actions). Adapted namespace, made compile and added sample code to roughly use it Change-Id: I79e7ea0d78099fbbe18e2a595457b2ab353f58ea
2017-07-15emfplus: use size of image of metafile fallbackArmin Le Grand
Change-Id: I0de82e0e431c0ce4527a909c2f98194f465ace8d
2017-07-15emfplus: for convenience added fallbackArmin Le Grand
For development and to not be dependent of the progress of the coming EMF+ importer, for now add fallback to using the old Metafile importer, plus conversion to primitive representation. That way the whole encapsulation is ready and can already be used Change-Id: I29afadaaaba71d75d0f5593852f4cc0cb3dd13f8