summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-09-24-Werror,-Wunused-variable (clang-cl)Stephan Bergmann
Change-Id: I4132e02ce9a4eb509a2e70a705068102f95ffd3e Reviewed-on: https://gerrit.libreoffice.org/60937 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24Resolves: tdf#119624 stray image_position bottom for some icons in buttonsCaolán McNamara
icons are off by default so not usually seen Change-Id: I6076fd87250fc4595d279c830e14779147b7857a Reviewed-on: https://gerrit.libreoffice.org/60935 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24missing includes (--with-webdav=serf)Stephan Bergmann
Change-Id: I021b378b2ae001a38c8f84a71e90ec4f14c905e6 Reviewed-on: https://gerrit.libreoffice.org/60928 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24Scheduler: add per-priority Task listsJan-Marek Glogowski
This way we don't have to search the whole list for a higher priority event, if an immediate Task is found. This probably helps bugs like tdf#119724 and tdf#119428. Change-Id: Ic5685193d1bedb6996cf46f0ee2cba42190ff7cc Reviewed-on: https://gerrit.libreoffice.org/60572 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-09-24loplugin:simplifyconstruct (--with-webdav=serf)Stephan Bergmann
Change-Id: I3a52b0e2517cfd88f661dde2b01b2e6bc6913ba2 Reviewed-on: https://gerrit.libreoffice.org/60927 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24Personas: add 6 default themesandreas kainz
Change-Id: Id8a920054c5b6f560ff2b26ce39c2a99574ad680 Reviewed-on: https://gerrit.libreoffice.org/60929 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-24Simplify assertion codeStephan Bergmann
...avoiding conditional blocks and variables (that need careful #if'ing to avoid them being either undefined or unused depending on NDEBUG and OSL_DEBUG_LEVEL combintaion) Change-Id: Ica9fe3857694f5c0a6e9079dfff05f2e0554b781 Reviewed-on: https://gerrit.libreoffice.org/60926 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24Looks like these functions can be static and not STDAPIStephan Bergmann
...as they appear to only be called from within this .cxx. (And <https://msdn.microsoft.com/library/ms686631(vs.85).aspx> documents that STDAPI expands to a return type of HRESULT, among further decoration.) Change-Id: I4994e6e6f8fe0466f9aa9b4c9cf2c20bd718fa05 Reviewed-on: https://gerrit.libreoffice.org/60925 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-24weld ScTabPageProtectionCaolán McNamara
Change-Id: I85fa703ebe73987822f85ff722f02627751937ec Reviewed-on: https://gerrit.libreoffice.org/60909 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24coverity#1438870 Big parameter passed by valueCaolán McNamara
Change-Id: I6ade72ed19b63b7f68c8f58c57bb409eab55e55c Reviewed-on: https://gerrit.libreoffice.org/60919 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-24sw: prefix members of SwRedlineExtraData_Format, ...Miklos Vajna
... SwRedlineExtraData_FormatColl and SwRedlineExtraData_FormattingChanges. Change-Id: I7dedf293ba06879985d4652e073642d5a15d97ca Reviewed-on: https://gerrit.libreoffice.org/60922 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-24elementary: improve many icons, add more 32 pxRizal Muttaqin
Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b6 Reviewed-on: https://gerrit.libreoffice.org/60920 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-24NB tabbed: graphic update writer and draw layoutandreas kainz
open calc and impress and drop down graphic menu Change-Id: I28f0e7b964a229320ede7accfd3a98e35ef113b5 Reviewed-on: https://gerrit.libreoffice.org/60778 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-09-23Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - tdf#108890 Chapter Numbering button “Format” renamed “Load/Save” Change-Id: Iec39885663c838dfaf112c1a4a99bcde7b9f9036
2018-09-23coverity#1401334 Uncaught exceptionCaolán McNamara
Change-Id: Id6dad66b3c55e5b3049f57e65c857db5abce50b1 Reviewed-on: https://gerrit.libreoffice.org/60901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-23tdf#120056 reorder radiobuttons elements into desired logical orderCaolán McNamara
Change-Id: I770dad005779e7bf347221afad46633371f17a07 Reviewed-on: https://gerrit.libreoffice.org/60908 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-23tdf#108890 - "Format" in outline/chapter dialog not self-explanatoryheiko tietze
Renamed to Load/Save according discussion on BZ Change-Id: I7444ffc6b2d6158542357364fd6a282a1684a33d Reviewed-on: https://gerrit.libreoffice.org/60876 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-09-23qt5: fix buildThorsten Behrens
Add missing header after 60a23d5d5f0963cd9bea7711ff4336418e3d6392 Change-Id: Ic24a78db3b425966e49fec96160d10670f68dea4
2018-09-23ŧdf#120069: Do not crash changing background color in drawXisco Fauli
Regression from c57f10b67fceef47d304d74dce93be7389a7720c, where I disabled the master background in Impress but not in Draw, and both share some common code. Besides, disable master background in draw as well. Follow-up of bug tdf#111306 Change-Id: I772382b5ed8eff3a35d001ea498810613137d172 Reviewed-on: https://gerrit.libreoffice.org/60913 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-09-23loplugin:unusedmethodsNoel Grandin
Change-Id: I9dac9260af9955dc4a66b34c33265c6e36094322 Reviewed-on: https://gerrit.libreoffice.org/60911 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-22Always disable loplugin:expressionalwayszero, to avoid false positivesStephan Bergmann
bdade7e3fc33c1832c6f6a472443fca8238738d2 "tdf#105444 DOCX import: don't put extra paragraphs in comments" caused > /home/sbergman/lo2/core/writerfilter/source/dmapper/DomainMapper_Impl.cxx:441:22: error: expression always evaluates to zero, lhs=0 rhs=unknown [loplugin:expressionalwayszero] > (sizeof(SAL_NEWLINE_STRING)-1 == 2 && xCursor->getString() == "\n")) > ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ now with sufficiently new Clang, and the code looks reasonable, and there's no apparent way to avoid such false positives in the plugin. (It could check for a sub-expression of the problematic expression being an object-like macro, but SAL_NEWLINE_STRING could just as well be a variable instead of a macro. That variable would need to be defined in some #if to have different values on different platforms, so the plugin could theoretically check for such conditional inclusion, but it's not clear whether that's worth it and would even be a useful heuristic to not produce neither too many false positives nor too many false negatives.) So just disable the plugin for good. Change-Id: I85dc8573735ccac4e19be20ab7443cbaa85a3164 Reviewed-on: https://gerrit.libreoffice.org/60907 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-22Ensure settings consistency for default personasMuhammet Kara
Change-Id: I7610e890a8b49c50bf23ed07daa5517c33edcb8d Reviewed-on: https://gerrit.libreoffice.org/60897 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-09-22ofz#10610 Direct-leakCaolán McNamara
Change-Id: If7cd5e7157419c5d3b3a7ff834613e7f6489047c Reviewed-on: https://gerrit.libreoffice.org/60900 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22tdf#119569 try most likely to succeed method to get column metadata _before_Lionel Elie Mamane
We first try to prepare the statement and get metadata information. That's fine. Some DB engines/drivers will not give column information on an unexectured prepared statement. In that case, first try to execute the statement with all parameters set to NULL, which is likely to succeed. If not, keep "execute the raw SQL indiscriminately" as a last resort. I'm not sure it will ever be useful, though. Change-Id: I76b5fd6b2059e96fabe9a611c8e3ed115acfc964 Reviewed-on: https://gerrit.libreoffice.org/60884 Tested-by: Jenkins Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-09-22tdf#120045 propagate_natural_[width|height] illegal in gtk 3.18Caolán McNamara
no warning in glade about it, though there is for other such things that don't exist in the targetted version Change-Id: Ib1522aaf9709b94274db378678314dc945048d97 Reviewed-on: https://gerrit.libreoffice.org/60899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22external/harfbuzz's libharfbuzz.a links against icuuc libraryStephan Bergmann
buovjaga reported on IRC that his build (implicitly --without-system-harfbuzz --without-system-icu) failed to link e.g. Library_vclplug_gtk3 due to harfbuzz missing symbols from ICU, like > /usr/bin/ld: /home/user/libreoffice/workdir/UnpackedTarball/harfbuzz/src/.libs/libharfbuzz.a(libharfbuzz_la-hb-icu.o): in function `hb_icu_unicode_decompose_compatibility(hb_unicode_funcs_t*, unsigned int, unsigned int*, void*)': > /home/user/libreoffice/workdir/UnpackedTarball/harfbuzz/src/hb-icu.cc:334: undefined reference to `unorm2_getNFKDInstance_62' [...] It is not clear to me why Library_vclplug_gtk3 would actually use libharfbuzz.a's hb_icu_unicode_decompose_compatibility (and for e.g. my builds, it apparently doesn't), but in general libharfbuzz.a does depend on some symbols from icuuc, so it is correct to add icuuc to the link when linking against harfbuzz. (And "gb_LinkTarget_use_external,...,icuuc" conveniently only adds libs for linking, and does not add C/C++ include file paths, which would not be wanted here.) (<https://gerrit.libreoffice.org/#/c/60882/> "Revert 'Add more more dependencies to VCL makefiles'" was a false start trying to address the above issue.) Change-Id: Ic8bcfa2aab185f8a9487d7787b4f22068e7cb481 Reviewed-on: https://gerrit.libreoffice.org/60898 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-09-22unwind ItemWrapperHelperCaolán McNamara
Change-Id: I171150342e04bee6efd97f36f769a2c3d1db4bd7 Reviewed-on: https://gerrit.libreoffice.org/60887 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22weld AlignmentTabPageCaolán McNamara
Change-Id: I253a01b053efe836b0657f9a711cecd060b6782b Reviewed-on: https://gerrit.libreoffice.org/60883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22tdf#67248 unittest for: Use localized layer name only ...Regina Henschel
for display in UI. The test counts the layers. The error was, that a user layer was merged into a standard layer. Change-Id: Ib73e14965689b005a7d42811b6de9126dd3ef57d Reviewed-on: https://gerrit.libreoffice.org/60892 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2018-09-22tdf#119850 show missing mysql connector optionsTamas Bunth
For MYSQL connections there is an extra window which determines how to connect to a mysql/mariadb database. This functionality is handled in OGeneralPageWizard::approveDatasourceType. Change-Id: Ia3c548103b694731cba47ff5390c34b072a938a0 Reviewed-on: https://gerrit.libreoffice.org/60893 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com>
2018-09-22eState is not that of SID_ATTR_CHAR_WORDLINEMODE as it should beCaolán McNamara
Change-Id: Ibafbaf7c1f7ab0c4922eeaf9cf27b39d90af03bf Reviewed-on: https://gerrit.libreoffice.org/60870 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22tweak markupCaolán McNamara
Change-Id: I5d7171045a9c271e2ef5f456411fa4d3eb5f1571 Reviewed-on: https://gerrit.libreoffice.org/60895 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22try other markupCaolán McNamara
Change-Id: I1d2ff100023ac6d94ea6ec65844cf509988ac90b Reviewed-on: https://gerrit.libreoffice.org/60894 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-22tdf#105444 DOCX import: don't put extra paragraphs in commentsLászló Németh
on Win32, waiting only for \r\n instead of \n in RemoveLastParagraph(). Change-Id: I8921a6a72e8397ed04edb9f339ba3f0bf5bbb98b Reviewed-on: https://gerrit.libreoffice.org/60865 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-09-22tdf#45904 Move _XIndent Java Tests to C++Rahul Gurung
Change-Id: I65b594db595f0e08a50a9ea18baf44c496cf18e3 Reviewed-on: https://gerrit.libreoffice.org/60218 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-22tdf#60543: Remember the URL of the currently applied personaMuhammet Kara
Change-Id: I21bc9353dc37825967bdca3329568990907928b4 Reviewed-on: https://gerrit.libreoffice.org/60888 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-09-22Update git submodulesMike Kaganski
* Update helpcontent2 from branch 'master' - SEARCH spreadsheet function returns error when text not found ... as per OASIS ODF OpenFormula specification: http://docs.oasis-open.org/office/v1.2/os/OpenDocument-v1.2-os-part2.html#__RefHeading__1018874_715980110 Change-Id: I16b81de40dcc4b103e44cc1e3784eea830bf8ffa Reviewed-on: https://gerrit.libreoffice.org/60891 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-09-22tdf#117721 draw ui: add .uno::SetOptimalRowHeightJustin Luth
Optimal row height: Adjusts the height of the selected rows to fit the content, causing the table to shrink. This really is SetMinimalRowHeight, but until minimize is also added, it is the most desirable optimization. Change-Id: I90717b2752027404a85fd5eb01c68279996598ca Reviewed-on: https://gerrit.libreoffice.org/60129 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-09-22Added Date and Time Transformation in data provider dlgManuj Vashist
Change-Id: Iead6b030d54983d08543656d2b62e42ba38b946e Reviewed-on: https://gerrit.libreoffice.org/58912 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-09-21Removed duplicated includeAndrea Gelmini
Change-Id: I913406a2a35f2202b7cfd41e06d1dca620d1b606 Reviewed-on: https://gerrit.libreoffice.org/60864 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-09-21coverity#1439597 Dereference before null checkCaolán McNamara
Change-Id: I0e4f8467440662a3d8cbda642339a55cfad445d8 Reviewed-on: https://gerrit.libreoffice.org/60849 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21Support buffering SystemDependent GraphicDataArmin Le Grand
Started to make the buffering more flexible by adding virtual methods virtual sal_uInt32 getHoldCyclesInSeconds() const; virtual sal_Int64 estimateUsageInBytes() const; to class SystemDependentData. This will allow to add more sensitive buffering/caching. Also fine-tuned Linux-derived classes actively used for buffering to be more sensitive when and where to reuse the buffered data Change-Id: Ifc69c318ade0209aff071d76001869d9f4eeb10d Reviewed-on: https://gerrit.libreoffice.org/60881 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-09-21Related: tdf#120028 PPTX import: fix font size of multi-col shape textMiklos Vajna
Normal shapes have a TextFitToSize property for this, but table cell content has to be scaled manually, as the rendering has no automatic support for them. Luckily the file format has the info we need to scale at import time. Change-Id: Ibbcc4b8685995261536cce88b8c0774e148f708e Reviewed-on: https://gerrit.libreoffice.org/60880 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-09-21new loplugin:methodcyclesNoel Grandin
look for closed cycles of methods i.e. unused code that would not otherwise be found by the unusedmethods loplugin Change-Id: I3fb052132d97aabca573bb8e9fc424201b1e2042 Reviewed-on: https://gerrit.libreoffice.org/60875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-21coverity#1438870 Big parameter passed by valueCaolán McNamara
Change-Id: If170645fa09ffc41948d1770df65b38d35a3f71e Reviewed-on: https://gerrit.libreoffice.org/60856 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21tdf#117721 draw ui: add .uno::SetOptimalColumnWidthJustin Luth
Optimize column width: Adjusts the width of the selected columns to fit the content, without changing the width of the table. Any leftover space is distributed proportionately, with thin columns growing slightly, and wide columns growing much wider. The implementation and results are different from how Writer does it, but tables themselves are also very different in Draw. So I don't think it needs to be handled identically. Writer's implementation is really "minimalColumnWidth" anyway. Change-Id: Ia10cfa9822d7eef3c4909a82c21535aa6668b143 Reviewed-on: https://gerrit.libreoffice.org/60078 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-09-21simplify PlusHdl logicNoel Grandin
like we did with the AddToHdlList stuff, all the client code cares about is fetching the entire list Change-Id: Id3cefa5f316a3f979a276c64f9125943d0981842 Reviewed-on: https://gerrit.libreoffice.org/60813 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-09-21Fix typoAndrea Gelmini
Change-Id: If90ef416e1ed757fede52c33f2e191930be35809 Reviewed-on: https://gerrit.libreoffice.org/60851 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-09-21ofz#10523 infinite .doc parse recursionCaolán McNamara
Change-Id: Ie39ce942bbfe724e0f9c7be6bafaf3fdc607f19d Reviewed-on: https://gerrit.libreoffice.org/60868 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-09-21coverity#1439598 Inferred misuse of enumCaolán McNamara
and coverity#1439596 Inferred misuse of enum Change-Id: I4edd08c46c714c3d513df5f9403ab29dfd0e2497 Reviewed-on: https://gerrit.libreoffice.org/60850 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-06-28 23:42:36 +0000