summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-29replace rtl_allocateMemory with std::mallocNoel Grandin
where used directly, since rtl_allocateMemory now just calls into std::malloc Change-Id: I59f85bdb7efdf6baa30e8fcd2370c0f8e9c999ad Reviewed-on: https://gerrit.libreoffice.org/59685 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29new loplugin:oustringbufferNoel Grandin
look for places where we are appending the temporary result of adding strings together, to an OUStringBuffer, where we could rather call append repeatedly and avoid the temporary creation Change-Id: I481435124291ac7fb54b91a78344a9fe5b379a82 Reviewed-on: https://gerrit.libreoffice.org/59708 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29remove 1 pixel white band in XRectPreviewCaolán McNamara
Change-Id: I3089f9305b8142e2c78405a4f9ae6a2066e90cfa Reviewed-on: https://gerrit.libreoffice.org/59725 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-29loplugin:constantparam (1)Noel Grandin
Change-Id: I25077e391ecca1b678062d261a83d88daadf0a58 Reviewed-on: https://gerrit.libreoffice.org/59701 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-29-Werror=redundant-move (GCC 9), take twoStephan Bergmann
...after 5b62a43349da6fda13fb33e0f1ec477c21daec8f "Revert '-Werror=redundant-move'" to fix the build for GCC 8.1 again. Turns out the std::move can only be dropped if the compiler has a fix for CWG1579. For GCC that's the case starting with GCC 5.1, so the !HAVE_CXX_GWG1579_FIX case can hopefully be removed again soon, see the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2018-July/080588.html> "Compiler baselines (was: [Libreoffice-qa] minutes of ESC call ...)"). Change-Id: I3592cad7fb503db921c37e92831a34785a1054a1 Reviewed-on: https://gerrit.libreoffice.org/59741 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-29Use ConvertSidToStringSidW instead of composing SID string manuallyMike Kaganski
Change-Id: I0dc22130b5dec5eb2250c9625773b6c9720182a9 Reviewed-on: https://gerrit.libreoffice.org/59740 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-29pdfium: replace FPDFTextObj_GetFontName() patch with backportMiklos Vajna
Change-Id: I36d86e7ccca66b09f2f49e401d77deb52fbf742a Reviewed-on: https://gerrit.libreoffice.org/59738 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-29XHTML import: <br></br> is one line breakMiklos Vajna
But only for XHTML, HTML stays unchanged to be in sync with web browsers. Change-Id: I3a1cf6651dab565bafece68963acb112ae715cdd Reviewed-on: https://gerrit.libreoffice.org/59727 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-29chmod -xTor Lillqvist
Change-Id: I6ba581f3665bc2934b8e3af5985ae853d60be39f
2018-08-28Colibre icons: remove convertmenu iconandreas kainz
Change-Id: Id3e167009ad5cc7677930ebfad412600e62f261f Reviewed-on: https://gerrit.libreoffice.org/59681 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-08-28tdf#119122 first (5%) pattern initially drawn with too many black cellsCaolán McNamara
pattern of area tab, pattern subtab of e.g. format page and in the pattern editor the 5% style is shown wrong, clicking ona different pattern and then back may make it draw correct a problem since... commit 6fbb6d80fe6203ff6f84ee85ca625b6e60bf5bae Date: Fri Feb 16 16:13:38 2018 +0200 use std::array in createHistorical8x8FromArray to make the assumption about the size of the array obvious in the code. Change-Id: I882384a13dedc7a14b63b3b8a9b764a4367b7cc6 Reviewed-on: https://gerrit.libreoffice.org/59724 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28Use tools::Time::GetClock() to obtain hour,minute,secondEike Rathke
... instead of rtl::math::approxFloor(fValue*DATE_TIME_FACTOR+0.5) seconds that most times works but sometimes not. Change-Id: Iaca69630461f2067622898fab35cda61d20172a9 Reviewed-on: https://gerrit.libreoffice.org/59719 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-08-28Assign fFractionOfSecond in shortcutEike Rathke
Otherwise it may be uninitialized. Change-Id: Iccb61d66c8410ac8ecdabbd96204d2393060bc1d Reviewed-on: https://gerrit.libreoffice.org/59721 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-08-28tdf#42949 Fix IWYU warnings in sc/source/core/inc/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I5af85ef9ed3e6d15f7e98e9d669c59a66fc70833 Reviewed-on: https://gerrit.libreoffice.org/59478 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28Revert "-Werror=redundant-move"Stephan Bergmann
This reverts commit 3ba67ff4b110635bae9552d1d895443a9df5e3e2. Turns out GCC 4.8 fights GCC 9 here, so needs a more elaborate fix. Sorry for the noise.
2018-08-28-Werror=redundant-moveStephan Bergmann
Change-Id: I8e239d95e288cba4fd798ce04cfe56cb62fff6a9
2018-08-28upgrade epoxy to 1.5.2Caolán McNamara
Change-Id: Ic3093d3c12c33cbcc09903409daec6277428ecd6 Reviewed-on: https://gerrit.libreoffice.org/59664 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28Move lcl_getHourMinuteSecond() to tools::Time::GetClock()Eike Rathke
Also add fFractionOfSecond and nFractionDecimals to obtain the remaining fraction of second. In preparation to use this in the number formatter and other places that obtain the wall clock time particles, which likely so far use bad rounding as well. Change-Id: I4fbea4165c560646438b06c340756c97dafa7c78 Reviewed-on: https://gerrit.libreoffice.org/59700 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-08-28Fix typo in codeAndrea Gelmini
To complete commit: e9fa088735bfbd34bc81f1925438691f746db070 It passed "make check" on Linux Change-Id: I2772b1ac5d4024bb11f3e09e24afc566b7091fb8 Reviewed-on: https://gerrit.libreoffice.org/59693 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2018-08-28create toggles with WB_TOGGLE setCaolán McNamara
Change-Id: Ic4142b6f80f2b47e745c4d2bd898c6aef865ca36 Reviewed-on: https://gerrit.libreoffice.org/59703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-28tdf119556 Sync "Use only paper size from printer preferences"Michael Weghorn
Since commit ee6dad51150fd53d19f882edfefa879e18f9897d, the "Use only paper size from printer settings" is shown at two places in the print dialog 1) in the "Options" tab 2) in the "Properties" -> "Paper" tab This makes the setting being correctly updated in the UI in 1) as well if changed in 2). The other way around was already working previously. Change-Id: I41d29a11b4e1695a4b2f676b8d7a9c01e4abde3e Reviewed-on: https://gerrit.libreoffice.org/59581 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-08-28mysqlc: registry xml: install driverTamas Bunth
Change-Id: I864302cc7ba8f27300e4bf0dd3d8a6cc1896da4b Reviewed-on: https://gerrit.libreoffice.org/59698 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-08-28tdf#119050 sfx2 store: don't inherit temp file permissions when overwritingMiklos Vajna
The too aggressive error handling in commit fb04780cf8523ad4e900ae8b9cecbe7a2697a12a (tdf#116117 sfx2 store: don't inherit temp file permissions when renaming, 2018-03-12) means that if the file is already there, then we don't try to stat() it; even if there is no problem with that. Change-Id: Ie0b9084064834e339bcae3ad7b4a35c54cb9d3c2 Reviewed-on: https://gerrit.libreoffice.org/59684 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-28Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Preface->Precede Just a suggestion. I'm not english-native but it sounds wrong to me with "preface". Change-Id: I403dfb162b399f4a487d616cde3209ba9efcba0b Reviewed-on: https://gerrit.libreoffice.org/59695 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-28We do want to initialise m_MainThread on iOS, tooTor Lillqvist
This doesn't make the LibreOfficeLight app work much better, though. But at least it doesn't hang its event loop completely, some 10 s timer keeps firing. (But nothing sane shows up in the app UI, even if some welcome.odt document apparently does get loaded. Clearly something is waiting for something else that never happens...) Change-Id: Ieba22a5e1418d48a7dd6cacda526aca69cced4c3
2018-08-28Fix typoTor Lillqvist
Change-Id: I78571f8494a13f6f8c07f9aee2bf6f8144a48ed2
2018-08-28tdf#119458 fix sw background Idle unblockingJan-Marek Glogowski
We can't handle the correct state when blocking via a tasks mbActive bool, as this also schedules the task and starts the scheduler timer. So reintroduce a bool for the unblock state. Change-Id: I40991d0160b058fae3803fab002dc036fc0b0339 Reviewed-on: https://gerrit.libreoffice.org/59692 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-08-28fix glib/bluetooth linking errorsLuboš Luňák
Since nobody else seems to have this problems, this may be possibly only specific to KDE builds or to using gold linker. Change-Id: I29359e298178b934a6232b78da684e55db590863 Reviewed-on: https://gerrit.libreoffice.org/59655 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2018-08-28Shortcut small negative values to 0:0:0, tdf#119533 tdf#118800 follow-upEike Rathke
... instead of letting them end up as 24:0:0 Change-Id: I0212a2b422a931a24fd2748aa2826a5b60d2a397 Reviewed-on: https://gerrit.libreoffice.org/59699 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-08-28writerfilter: not FirstParaInSection if IsInShapeJustin Luth
Since anchored objects can contain paragraphs, considering all of them to be "firstParagraphs" would generally be considered an incorrect result. Browsing through the existing uses of IsFirstPara.*InSection I didn't see any that looked like it should be considered true if IsInShape. Since this is the kind of gotcha that that the programmer should be aware of, add it directly into the function instead of requiring each use to have an additional qualification. The following ooxml unit tests match these conditions, but only one was fixed - the rest were unaffected since they just avoided adding/removing dummy paragraphs. fdo79540.docx - 5 tblppr-shape.docx - 5 ooo47778-3.odt- 5 ooo47778-4.odt- 5 textbox-rounded-corners.docx - 7 n780563.docx - 8 missing-path.docx - 10 floating-tables-anchor.docx - 10 tdf117805.odt - 11 (fixed - prevented extra section paragraphs) Change-Id: I841475e214c194a673321c1229d9254dd07205f8 Reviewed-on: https://gerrit.libreoffice.org/59659 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-08-28Add --enable-ios-libreofficelight-app option to build stuff for janI's appTor Lillqvist
Change-Id: I1310cb8f5f543f49f9667ee10cb26c9809df259e
2018-08-28Bin superfluous whitespace on empty lineTor Lillqvist
Change-Id: Ida0ab3cd78514b2c10f8e6655becefe794217f8c
2018-08-28Add getMaskSet() to the dummy AVMediaSetMaskTor Lillqvist
As such I am not convinced that this "dummy" replacement class approach is the right thing; we don't do it like that elsewhere either? Change-Id: Ife912d9ed91bd26610ea40cf4b446beb2ed481ec
2018-08-28Bump version number in ICU data file nameTor Lillqvist
Change-Id: I222792dd34cd016196dfec9870161896c7c43b0d
2018-08-28return ScMemChart by std::unique_ptrNoel Grandin
Change-Id: I5a5b54872ce6ae351c6550a1ec0b2f7c52c35e13 Reviewed-on: https://gerrit.libreoffice.org/59683 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-28loplugin:useuniqueptr pass ScDocument by unique_ptr in undo codeNoel Grandin
Change-Id: Ib05638865a42ad37c3382714e1790c7035ed8ebf Reviewed-on: https://gerrit.libreoffice.org/59638 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-28return by std::unique_ptr from CreateSortInfoArrayNoel Grandin
Change-Id: I4be97a5e93bd4cb08a9c25dc663883c2c5e8dd5e Reviewed-on: https://gerrit.libreoffice.org/59682 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-28tdf#42949 Fix IWYU warnings in chart2/source/inc/[l-z]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Some only-recently analyzed files were cleaned. Also tried harder to use more fw decls instead of blacklisting Change-Id: Ie4f8eb7065e44a2b5208d6da4fa8e3681a31820b Reviewed-on: https://gerrit.libreoffice.org/59420 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28tdf#119451 vcl layout cache: fix glyph fallback handlingMiklos Vajna
Type ":dog:" into Writer with e.g. the Liberation Serif font, glyph layout doesn't execute, a literal 0 glyph id is rendered. Fix the problem by returning the glyph items (to be inserted into a cache) after handling glyph fallback. Change-Id: I928b0087de309dbe04936c6e7732d79bec541596 Reviewed-on: https://gerrit.libreoffice.org/59665 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-28tdf#39593 deduplicate code using existing functionArkadiy Illarionov
Change-Id: I437becdb0ed4840738d6c45d88cd3be2ff1243fb Reviewed-on: https://gerrit.libreoffice.org/59591 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-28SYSTEM_MYSQL_CPPCONN is never definedStephan Bergmann
...since 5061663ce052087c6d5d0910d6f99358e26dbbd1 "drop unnecessary SYSTEM_MYSQL_CONNECTOR_CPP" Change-Id: I2023baf04dfb050833a0032367fc2dc2cfdb9d92 Reviewed-on: https://gerrit.libreoffice.org/59670 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-28No space before periodStephan Bergmann
...left there by 26b40fcfc67480e75bd9959b0c5cb9db10fdf6a1 "Moving mysqlc into connectivity as a library". (And remove latter half of sentence that doesn't make much sense anymore.) Change-Id: Ic87bd243cfde61080e4afae14de5c3fe7c53824b Reviewed-on: https://gerrit.libreoffice.org/59656 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-28Resolves: tdf#119533 reintroduce time rounding but cut, tdf#118800 follow-upEike Rathke
Regression from commit c69e7266916ac1b8917477fb4eccdb9098da5792 CommitDate: Thu Jul 19 14:01:30 2018 +0200 tdf#118800 fix rounding error in Calc function HOUR, MINUTE, SECOND. Rounding was only an error if it produced a value of a full day in seconds, or if it otherwise led to an inappropriately rounded-up individual value, but in general some rounding is necessary. Instead of omitting rounding completely, basically round to nanoseconds and then do not round individual hour,minute,second values but instead truncate to the next magnitude so 23:59:59.9999 gives 23h59m59s instead of 24h0m0s Change-Id: I93df1aa54212c1b8816237c9467f270ed28a3f1f Reviewed-on: https://gerrit.libreoffice.org/59677 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-08-27sw: fix inconsistent bookmark behavior around at-char/as-char anchored framesSerge Krot
Added fix for Change-Id: Ic1f173c85d3824afabb5b7ebf3a8594311eb9007 Reviewed-on: https://gerrit.libreoffice.org/46889 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> The problem was (the same condition of the bOnlyFrameStarts parameter was used during output of Start and End bookmarks): if (BkmType::Start == pPtr->nBkmType && !bOnlyFrameStarts) ... if (BkmType::End == pPtr->nBkmType && !bOnlyFrameStarts) ... Should be: if (BkmType::Start == pPtr->nBkmType && bOnlyFrameStarts) ... if (BkmType::End == pPtr->nBkmType && !bOnlyFrameStarts) ... I assume this was a simple copy-paste bug. Change-Id: I712a0dccc1638fed3b81c65628033a4dc06c1ca4 Reviewed-on: https://gerrit.libreoffice.org/59556 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-08-27Remove Extensions_MySQLConnector junkStephan Bergmann
...left over from 26b40fcfc67480e75bd9959b0c5cb9db10fdf6a1 "Moving mysqlc into connectivity as a library". (Apparently, for one, a module's Files that don't exist are ignored, so 8ecf5e1815b5459bc0bbcdfb398d3bd53b0c2861 "Build fix, make install: mysql-connector-ooo extension is gone" removing gid_File_Oxt_MySQLConnector but not gid_Module_Optional_Extensions_MySQLConnector referencing it didn't cause trouble; and for another, an empty module is ignored, so there were no extension-mysql-connector packages generated any more---but better clean up the junk anyway.) Change-Id: If598a968dfbbe9b5f16d735e8011e192cbd4178b Reviewed-on: https://gerrit.libreoffice.org/59669 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-27fix own-cairo edge case buildCaolán McNamara
Change-Id: I787c5e5a53f93b3a3bb511fe0bbd107ef7963ec7 Reviewed-on: https://gerrit.libreoffice.org/59663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-27Avoid 'HAVE_FEATURE_GPGME' is not defined, evaluates to 0 [-Werror,-Wundef]Tor Lillqvist
Change-Id: Ic788c84171747c31a686da7c523da72b0f838742
2018-08-27Fix iOS build after f05f4e042ca6ac8ae7f1d1e8e6bfb4cbba17a044Tor Lillqvist
Change-Id: I7b0c737b84f4528a8fba01e2998f525046834b1c
2018-08-27Fix build in the !(USE_TLS_OPENSSL + USE_TLS_NSS > 0) caseTor Lillqvist
Change-Id: I746f0f322082e81cc47322989634322a0659aa73
2018-08-27Fix warning in !HAVE_FEATURE_SCRIPTING caseTor Lillqvist
Change-Id: Ibc2a9d4426e9ef09eb874e7a9fef0ea31cad56d5
generated by cgit (git 2.34.1) at 2024-07-15 09:30:54 +0000