summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-05-23clang-tidy modernize-pass-by-value in jvmaccessNoel Grandin
Change-Id: I9a2ef4370136b0f26ae3590f358025e7d89f30d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134757 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-23tdf#66228 PPTX export: fix lost U-shaped connectorsTibor Nagy
which were replaced with straight connector lines. The "Line Connector" has no equivalent in OOXML. So far it has been saved as a "Straight connector". In most cases, the better solution is to change it to "Standard connector", keeping the original layout with U-shaped connectors. Change-Id: I9d6b6174d0556ba2478c6a9837c500b3cc794c82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134284 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-05-23cid#1504543 Silence unhelpful, aggressive UNINIT_CTORStephan Bergmann
Change-Id: Ida0c1bfd34ee68968b22579492bce4b137fa8a93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134749 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-23sw: copy grab bags in mail mergeMichael Stahl
Otherwise formatting may get lost when the result is stored as DOCX. Change-Id: I62cbeb1fc9f120dd9c424daf5dc0471686715537 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134694 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-23sw: avoid ~SwIndexReg() assert in SwFEShell::PastePages()Michael Stahl
Change-Id: I5337dc8568255a778d29b676a39c99f72c42486b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134693 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-23sw_redlinehide: fix crash in IsMarkHidden() if pointing to table nodeMichael Stahl
This is called during mail merge from documentStartPageNumber() and if the document starts with a table, the passed UNO mark will point to SwTableNode. (regression from commit 943d9be770e550d20ca72274fa5e914d1f61e605) Change-Id: Ic69c12ba0d819eda85de5dde95e35a8071466c2e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134692 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-23clang-tidy modernize-pass-by-value in configmgrNoel Grandin
Change-Id: If2e69c04e4d72ec6911fb435092275dbfffbf991 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134752 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-23starmath: fix real use-after-free detected by GCC 12Michael Stahl
In file included from starmath/inc/mathml/iterator.hxx:12, from starmath/source/mathml/iterator.cxx:10: In member function ‘SmMlElement* SmMlElement::getParentElement()’, inlined from ‘void mathml::SmMlIteratorBottomToTop(SmMlElement*, runType, void*) [with runType = void (*)(SmMlElement*, void*)]’ at starmath/inc/mathml/iterator.hxx:43:39, inlined from ‘void mathml::SmMlIteratorFree(SmMlElement*)’ at starmath/source/mathml/iterator.cxx:57:28: starmath/inc/mathml/element.hxx:263:46: error: pointer ‘pCurrent’ used after ‘void operator delete(void*, std::size_t)’ [-Werror=use-after-free] 263 | SmMlElement* getParentElement() { return m_aParentElement; }; | ^~~~~~~~~~~~~~~~ In function ‘void mathml::deleteElement(SmMlElement*, void*)’, inlined from ‘void mathml::deleteElement(SmMlElement*, void*)’ at starmath/source/mathml/iterator.cxx:19:20, inlined from ‘void mathml::SmMlIteratorBottomToTop(SmMlElement*, runType, void*) [with runType = void (*)(SmMlElement*, void*)]’ at starmath/inc/mathml/iterator.hxx:65:21, inlined from ‘void mathml::SmMlIteratorFree(SmMlElement*)’ at starmath/source/mathml/iterator.cxx:57:28: starmath/source/mathml/iterator.cxx:19:77: note: call to ‘void operator delete(void*, std::size_t)’ here 19 | static inline void deleteElement(SmMlElement* aSmMlElement, void*) { delete aSmMlElement; } | ^~~~~~~~~~~~ Change-Id: I09acfe3f7e90bd7f919cfba161f72bdd7a8da70a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134742 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-23sw: SwNodeIndex GCC12 spurious -Werror=dangling-pointer=Michael Stahl
It doesn't understand that ~SwNodeIndex() will remove the pointer, which is obfuscated by over-boostified code. In member function ‘void SwNodeIndex::RegisterIndex(SwNodes&)’, inlined from ‘SwNodeIndex::SwNodeIndex(SwNodes&, SwNodeOffset)’ at sw/inc/ndindex.hxx:54:22, inlined from ‘bool SwNodes::InsBoxen(SwTableNode*, SwTableLine*, SwTableBoxFormat*, SwTextFormatColl*, const SfxItemSet*, sal_uInt16, sal_uInt16)’ at sw/source/core/docnode/ndtbl.cxx:301:41: sw/inc/ndindex.hxx:37:31: error: storing the address of local variable ‘aEndIdx’ in ‘*this.SwNodes::m_vIndices’ [-Werror=dangling-pointer=] 37 | rNodes.m_vIndices = this; | ~~~~~~~~~~~~~~~~~~^~~~~~ sw/source/core/docnode/ndtbl.cxx: In member function ‘bool SwNodes::InsBoxen(SwTableNode*, SwTableLine*, SwTableBoxFormat*, SwTextFormatColl*, const SfxItemSet*, sal_uInt16, sal_uInt16)’: sw/source/core/docnode/ndtbl.cxx:301:17: note: ‘aEndIdx’ declared here 301 | SwNodeIndex aEndIdx( *this, nIdxPos ); | ^~~~~~~ sw/source/core/docnode/ndtbl.cxx:301:17: note: ‘<unknown>’ declared here Change-Id: I3f24cd8e3e0b1fd0a0943150d3d83d09f2c984fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134741 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-23svx: work around GCC12 spurious -Werror=stringop-overflowMichael Stahl
/usr/include/c++/12/bits/stl_algobase.h:431:30: error: ‘void* __builtin_memcpy(void*, const void*, long unsigned int)’ writing 1 or more bytes into a region of size 0 overflows the destination [-Werror=stringop-overflow=] Change-Id: Ib581b5788ff5d363b688000e700a42074c3b78eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134740 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-23vcl: GCC12 says fclose() causes -Werror=use-after-free on any use of FILE*Michael Stahl
In file included from vcl/inc/unx/cpdmgr.hxx:34, from vcl/unx/generic/printer/cpdmgr.cxx:25: In member function ‘size_t psp::FPtrHash::operator()(const FILE*) const’, inlined from ‘std::__detail::_Hash_code_base<_Key, _Value, _ExtractKey, _Hash, _RangeHash, _Unused, __cache_hash_code>::__hash_code std::__detail::_Hash_code_base<_Key, _Value, _ExtractKey, _Hash, _RangeHash, _Unused, __cache_hash_code>::_M_hash_code(const _Key&) const [with _Key = _IO_FILE*; _Value = std::pair<_IO_FILE* const, rtl::OString>; _ExtractKey = std::__detail::_Select1st; _Hash = psp::FPtrHash; _RangeHash = std::__detail::_Mod_range_hashing; _Unused = std::__detail::_Default_ranged_hash; bool __cache_hash_code = true]’ at /usr/include/c++/12/bits/hashtable_policy.h:1268:18, inlined from ‘std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey, _Equal, _Hash, _RangeHash, _Unused, _RehashPolicy, _Traits>::size_type std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey, _Equal, _Hash, _RangeHash, _Unused, _RehashPolicy, _Traits>::_M_erase(std::true_type, const key_type&) [with _Key = _IO_FILE*; _Value = std::pair<_IO_FILE* const, rtl::OString>; _Alloc = std::allocator<std::pair<_IO_FILE* const, rtl::OString> >; _ExtractKey = std::__detail::_Select1st; _Equal = std::equal_to<_IO_FILE*>; _Hash = psp::FPtrHash; _RangeHash = std::__detail::_Mod_range_hashing; _Unused = std::__detail::_Default_ranged_hash; _RehashPolicy = std::__detail::_Prime_rehash_policy; _Traits = std::__detail::_Hashtable_traits<true, false, true>]’ at /usr/include/c++/12/bits/hashtable.h:2358:43, inlined from ‘std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey, _Equal, _Hash, _RangeHash, _Unused, _RehashPolicy, _Traits>::size_type std::_Hashtable<_Key, _Value, _Alloc, _ExtractKey, _Equal, _Hash, _RangeHash, _Unused, _RehashPolicy, _Traits>::erase(const key_type&) [with _Key = _IO_FILE*; _Value = std::pair<_IO_FILE* const, rtl::OString>; _Alloc = std::allocator<std::pair<_IO_FILE* const, rtl::OString> >; _ExtractKey = std::__detail::_Select1st; _Equal = std::equal_to<_IO_FILE*>; _Hash = psp::FPtrHash; _RangeHash = std::__detail::_Mod_range_hashing; _Unused = std::__detail::_Default_ranged_hash; _RehashPolicy = std::__detail::_Prime_rehash_policy; _Traits = std::__detail::_Hashtable_traits<true, false, true>]’ at /usr/include/c++/12/bits/hashtable.h:971:24, inlined from ‘std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::size_type std::unordered_map<_Key, _Tp, _Hash, _Pred, _Alloc>::erase(const key_type&) [with _Key = _IO_FILE*; _Tp = rtl::OString; _Hash = psp::FPtrHash; _Pred = std::equal_to<_IO_FILE*>; _Alloc = std::allocator<std::pair<_IO_FILE* const, rtl::OString> >]’ at /usr/include/c++/12/bits/unordered_map.h:763:26, inlined from ‘virtual bool psp::CPDManager::endSpool(const rtl::OUString&, const rtl::OUString&, FILE*, const psp::JobData&, bool, const rtl::OUString&)’ at vcl/unx/generic/printer/cpdmgr.cxx:725:28: vcl/inc/unx/cupsmgr.hxx:35:43: error: pointer may be used after ‘int fclose(FILE*)’ [-Werror=use-after-free] 35 | { return reinterpret_cast<size_t>(pPtr); } | ^ vcl/unx/generic/printer/cpdmgr.cxx: In member function ‘virtual bool psp::CPDManager::endSpool(const rtl::OUString&, const rtl::OUString&, FILE*, const psp::JobData&, bool, const rtl::OUString&)’: vcl/unx/generic/printer/cpdmgr.cxx:695:15: note: call to ‘int fclose(FILE*)’ here 695 | fclose( pFile ); | ~~~~~~^~~~~~~~~ Change-Id: Ib035f2287649dcf9a2d37bda85ebcf52c6c51aaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134739 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-23vcl: WhitespaceToSpace() spurious -Werror=maybe-uninitializedMichael Stahl
vcl/source/helper/strhelper.cxx:366:9: error: ‘pBuffer[-1]’ may be used uninitialized [-Werror=maybe-uninitialized] Change-Id: I37250b0790bd9c33eb01c552c8267251bc0026f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134738 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-23svl: spurious GCC12 -Werror=maybe-uninitializedMichael Stahl
In file included from svl/source/misc/sharedstringpool.cxx:11: In constructor ‘svl::SharedString::SharedString(rtl_uString*, rtl_uString*)’, inlined from ‘svl::SharedString svl::SharedStringPool::intern(const rtl::OUString&)’ at svl/source/misc/sharedstringpool.cxx:129:51: include/svl/sharedstring.hxx:56:20: error: ‘pResultUpper’ may be used uninitialized [-Werror=maybe-uninitialized] 56 | mpData(pData), mpDataIgnoreCase(pDataIgnoreCase) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ svl/source/misc/sharedstringpool.cxx: In member function ‘svl::SharedString svl::SharedStringPool::intern(const rtl::OUString&)’: svl/source/misc/sharedstringpool.cxx:93:33: note: ‘pResultUpper’ was declared here 93 | rtl_uString *pResultLower, *pResultUpper; | ^~~~~~~~~~~~ Change-Id: I2171855844c76ad3b2a72c1eca737691ca96fc46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134736 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-05-23handle RTL space in non-RTL layout in SalLayoutGlyphsCacheLuboš Luňák
Reproduced with tdf#95217-1 on the crashtesting server. Change-Id: I44dfa762b624ca24a8bd4ce8df03f8c870d4e7c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134755 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-05-23Adapt commentStephan Bergmann
...after 084b2b068ad6729775f7fa5965429fc5cc3c2ae3 "optimise Any::operator=(&&) a little" folded moveAnyInternals into its only remaining call site Change-Id: I2a9d8a775d601bc0307a3f3a5dfc139c571489ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134751 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-05-23skia: fix GCC12 -Werror=shadowMichael Stahl
Change-Id: I0ec8e9d7d54b48281332cb5128d03ac28dad87e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134737 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-05-23comphelper: -Werror=class-memaccessMichael Stahl
Change-Id: Ia38274fac70618902f562fec657ad9cccfcf8cb3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134735 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-05-23sw: prefix members of SwWW8Shade, WW8Glossary, WW8ListManager and ...Miklos Vajna
... sw::util::HdFtDistanceGlue See tdf#94879 for motivation. And add a build-time test to ensure that wrtsh.hxx is self-contained. Change-Id: I493931eeeb8c57264c6f884b48b83881dda6632d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134748 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2022-05-23Resolves tdf#131155 - Keep frequently used options on sort criteria tabHeiko Tietze
* Row/Column header moved * Sort by row/column moved * Extra variables removed * UI tests adjusted to read/set sort direction and header from first tab Change-Id: I9fc0406806256f289d52e45b096e392067768eaa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130843 Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-05-23tdf#149176 tdf#149178 fix Save autorecovery information.. optionTünde Tóth
Autorecovery information was saved in every 10 minutes, regardless of the "Save Autorecovery information every" setting. Change-Id: I1a52da2fa5febb53c270a8db7472e9a8c0e4c426 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134642 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-05-23tdf#149017 Justify::SpaceDistribution unit tests.Mark Hung
Cerate new unit test cases for core/txtnode/justify.cxx and Justify namespace. It implements basic utility to convert between KernArray and char width array, and can serve for kern array related tests. Change-Id: I3da172853c6d8aca517247af34b29f712d3b6e62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134298 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2022-05-23Extend '-Werror=attributes' workaround to GCC versions < 12.1Michael Weghorn
Adapt the GCC version check from the workaround introduced in commit 2c6cea672a852b85cfb6d2e313d806f257481417 Date: Wed May 18 10:46:55 2022 +0200 Work around bogus -Werror=attributes with old GCC ...after 9c3c6a6b661ea8f84c1285b07a502de5c98a1495 "Replace OFFSET_OF macro with a function template", as seen at <https://ci.libreoffice.org//job/lo_tb_master_linux_dbg/38076/>, > /home/tdf/lode/jenkins/workspace/lo_tb_master_linux_dbg/cppu/source/uno/check.cxx:263:28: error: ‘maybe_unused’ attribute ignored [-Werror=attributes] > [[maybe_unused]] Char3 chars; > ^~~~~ (Not sure which versions of GCC are affected exactly; lets restrict this to to all versions before 12.1. My GCC 11.3.0 build on Debian testing failed just the same way otherwise. A `git log --grep=maybe_unused` in the GCC git repo suggests that this is no longer necessary from the following GCC 12.1 commit [1] on: commit c0f769fa3114ea852a26d93f0ee3f9595463de0b Author: Jason Merrill <jason@redhat.com> Date: Fri Jun 11 16:10:50 2021 -0400 c-family: don't warn for [[maybe_unused]] on data member The C++17 standard (and C2x) says that [[maybe_unused]] may be applied to a non-static data member, so we shouldn't warn about it. And I don't see a reason not to handle a FIELD_DECL the same as any other decl, by setting TREE_USED on it. It doesn't look like anything yet cares about that flag on a FIELD_DECL, but setting it shouldn't hurt. gcc/c-family/ChangeLog: * c-attribs.c (handle_unused_attribute): Handle FIELD_DECL. gcc/testsuite/ChangeLog: * g++.dg/ext/attrib62.C: No longer warn. * g++.dg/diagnostic/maybe_unused1.C: New test. gcc/ChangeLog: * doc/extend.texi (unused variable attribute): Applies to structure fields as well. [1] https://gcc.gnu.org/git/?p=gcc.git;a=commitdiff;h=c0f769fa3114ea852a26d93f0ee3f9595463de0b Change-Id: I815e4a24da13e0ae66b1dff2941e636c7ebdfd9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134653 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2022-05-23tdf#144788 follow up fix: Fix null pointer useJim Raykowski
Change-Id: I62c3e337a8ec5391c3f18bb42ce8778acd36451b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134747 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-05-22tdf#144788 follow up: fix SwNavigator footnote trackingJim Raykowski
Changes incorrect handling for both footnote and endnote tracking when either a footnote or an endnote attribute is at the current cursor position to handling for only footnote or endnote. Change-Id: Ib65704ae48298c02cfe557d62d1c002a1859321f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134717 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-05-22for fuzzers add libtiff to common externals, not just tiffuzzerCaolán McNamara
Change-Id: I747a39a26c446000924a1d48c5d650fac330216e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134746 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22Get make_installer calls to run in parallelThorsten Behrens
If available, use GNU parallel to run N make_installer.pl scripts in parallel, to scale packaging LibreOffice up with the rest of gbuild. * fallback if no GNU parallel found - run make_installer sequentially as before * push most of the make_installer.pl input param tweaks from gbuild down into a shared call_installer.sh script * call gnu parallel with generated number of "templ:lang:prodname:ext:pkgfmt:strip-flag" tuples, one for each package to build (empty templ for non-windows, to save on cmd line length) * such that we can run all those in parallel (taking into account the build's PARALLELISM parameter) * there's still the main package build running epm sequentially for umpteen sub-packages from within _one_ make_installer.pl instance, but that's much harder to parallelize from inside Perl (so we punt on that here) Change-Id: Ie7d3084ed60d003d587c5e64dc9fb1809b23e409 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/133957 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-05-22tdf#131199 add some basic 16bitcielab supportCaolán McNamara
to get that final tiff loadable Change-Id: Ia772c06521c93ac860e9d3014706d677f16c8d4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134734 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22move fuzzer to libtiffCaolán McNamara
Change-Id: Ib2a3da65f13a239076981473410a0e3240cab670 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134744 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504537 silence Dereference after null checkCaolán McNamara
no change in practice because either pDoc or pDocSh and not both are set Change-Id: I1da19bef2a2a5cec700cbc6126f873079efcba88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134733 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504538 Dereference after null checkCaolán McNamara
and cid#1504536 Dereference after null check Change-Id: If727df50e9e375b0ebd30e7537ac3d88ad72dc11 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134731 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504545 Dereference after null checkCaolán McNamara
Change-Id: If23314cca9eec9c4b9cf668945976327184d5690 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134730 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22pass ScDocShell by reference in ctor to indicate never initially nullCaolán McNamara
Change-Id: I6b07f734aba06a643b6240562bb3e427e5c1e9ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134729 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504539 Dereference before null checkCaolán McNamara
seeing as its always derefed before here, the null check isn't useful Change-Id: I7c50d357978c7468eec469b4f32601e9b99e07e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134728 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504532 Dereference after null checkCaolán McNamara
Change-Id: I044e3bfec2af9d6379849b8ee6ce4ecbe637cc35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134727 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504534 Dereference before null checkCaolán McNamara
Change-Id: I7deb272cbf7105b78911acb4b17bc3f078913a2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134726 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504540 Dereference before null checkCaolán McNamara
Change-Id: Ia47b6dd5d1524bd377670815a342d0ee478f823e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134725 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504542 Dereference before null checkCaolán McNamara
Change-Id: I3a3ee9ddc09d63fb33fd041353399b3aa4f79d96 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134724 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504440 move Uninitialized scalar field annotationCaolán McNamara
Change-Id: Ia147241460c537abea7f6ef3cd32038551c45826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134723 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504544 deliberately Uninitialized scalar fieldCaolán McNamara
Change-Id: Idbc44ac01787f93fa5af1e5358a70590fa4cc64d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134722 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504541 Uninitialized scalar fieldCaolán McNamara
Change-Id: I1fa061f9713c808bd06933ae9c574e70a1ec0915 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134721 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504533 silence Uncaught exceptionCaolán McNamara
Change-Id: Id2c782e417b673dcc2e2b5170bcaf6b98bef85f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134720 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22cid#1504535 Uninitialized scalar fieldCaolán McNamara
Change-Id: I8a99a5e5e4ec892c460edb4151554cd071fb54ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134719 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-22[API CHANGE] call ftruncate instead of ftruncate_by_nameNoel Grandin
The actual point of this change is making osl_fileOpen faster by avoiding constructing and storing an OString. But that requires changing to using ftruncate on the filehandle, which is arguably more correct anyway, using the filename to truncate in the presence of unlink() is dubious Change-Id: I8bc5022e1d1afb53fb4e2fd920e43e5daaf74ec4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134704 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-22tdf#145182 related: fix SwNavigator repositioning on resizeJim Raykowski
Repositioning on resize began with commit ca8f1ff34e291b74068dace619e58c37ef169f88 which is LOK related. The fix given in this patch checks if LOK is active before executing the lines of code that cause reposition to happen when LOK is not active. Change-Id: I13e7d289dd7ef1d99966d4f5b47a961b868b1b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/131570 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-05-22tdf#84502 related: Show keyboard shortcut in sidebar tab bar tab buttonJim Raykowski
tooltip Change-Id: Ia0d48ac437c6a18c4e1624dd9b154ee7a8514f1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134594 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2022-05-21tiff: output libtiff error via SAL_WARN for failuresCaolán McNamara
Change-Id: Iff62f8081d5d7b1971940775bd72722f376bf3d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-21drop unused hxx filesCaolán McNamara
Change-Id: I68ea314f20b599c181f2ae9f264037918419d15c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134715 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-21clang-tidy modernize-pass-by-value in canvasNoel Grandin
Change-Id: Ib6e1b6182d83b09dbf5e2aeb9cf3e4ca11d9f48b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134712 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-05-21ofz#47559 Integer-overflowCaolán McNamara
setLinearPosX already takes a double so use that type for nOffset, use DeviceCoordinate as the types where that is the type of the source data Change-Id: I411d5034a42648bab94d6b8789bbdd172d0cf841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2022-05-21tiff: enable webpCaolán McNamara
Change-Id: Ifd277fd89393f964817bf58dead53074321252d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134711 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-01 23:30:03 +0000