summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-23remove unused enums in reportdesign,linguistic,l10ntools,vcl,svxNoel Grandin
Change-Id: I3ae854f9fed485be915ded5bc4d7e93f5db23dc6 Reviewed-on: https://gerrit.libreoffice.org/63891 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23convert CallbackType to scoped enumNoel Grandin
and drop unused INVALID constant Change-Id: Ifbfaeb209ed75af99f8e531105b9f23541034648 Reviewed-on: https://gerrit.libreoffice.org/63890 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23Unit test for 0853b05b1fabb231a7d57d811c5a06ee542d3295Thorsten Behrens
Change-Id: Iea6554448f7a3fcc621eac7248abcee9c4285688 Related: i#117783 and tdf#38443 Reviewed-on: https://gerrit.libreoffice.org/58687 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23loplugin:overrideStephan Bergmann
Change-Id: Ia45b5f7c126c082d8f3835c3c3529a34a9e20975
2018-11-23use binary search for starmath tokenNoel Grandin
Change-Id: I187a5471f0e733007e3a56d8bb4972ee71f7cf17 Reviewed-on: https://gerrit.libreoffice.org/63882 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23enum ScMatrix::Op is unnecessaryNoel Grandin
Change-Id: If4ae97b43f012f1770213d99407ffaadac05f9de Reviewed-on: https://gerrit.libreoffice.org/63756 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23Bump Xcode baseline to 9.3Stephan Bergmann
...as discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html> "minutes of ESC call ..." Change-Id: I47e23d222b4b27256483dfd7de915dd99ae81317 Reviewed-on: https://gerrit.libreoffice.org/63878 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-23Use the correct DPI scaling factor in LibreOfficeKit for iOS, tooTor Lillqvist
Fixes the rendering of spreadsheets in the iOS app. (The cell area was rendered at half the scale of the row and column headers.) Actual code change only in desktop/source/lib/init.cxx, but update related comments elsewhere to mention CoreGraphics, too, and not just cairo. Change-Id: Ife99c6a2d58e592cfea3b4ed1ab09c19fba77e72
2018-11-23Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - Hyphenate pre-noun adjective phrase Change-Id: I108cb3b91031327f7d775857f8e7d55042eccb6c
2018-11-23Improve wording of loplugin:unoany warningsStephan Bergmann
...which apparently caused confusion occasionally, cf. <https://gerrit.libreoffice.org/#/c/58687/5> "Unit test for 0853b05b1fabb231a7d57d811c5a06ee542d3295". Change-Id: I32f1137bcbb86ffa04bc1a6a58fc93ef69cb3022 Reviewed-on: https://gerrit.libreoffice.org/63874 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-23Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' - tdf#114263 add help page for GetPathSelector() Change-Id: I021dcde2c5bb27713cbbff03af9f3662f187be4b Signed-off-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/63807 Tested-by: Jenkins
2018-11-23Resolves: tdf#121644 clear pointer to customlines when customlines clearedCaolán McNamara
Change-Id: I09bf6f3c484a2d90a865f0a5743c4e99d2f77b0a Reviewed-on: https://gerrit.libreoffice.org/63871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23remove some unused enums in sc/Noel Grandin
Change-Id: I841f64a8b4f7f9a9e09df3b7877843616129dee1 Reviewed-on: https://gerrit.libreoffice.org/63755 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23improve function local staticsNoel Grandin
simplify the initialisaion and make them thread-safe i.e. initialise them using the runtime's local static locking. Thanks to mike kaganski for pointing out the nice lambda approach that makes this feasible. Change-Id: I76391189a6d0a3d7eed2d0d88d28dfa6541eaff7 Reviewed-on: https://gerrit.libreoffice.org/63645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23Check isEmptyStringQuery() early to avoid call ..., tdf#121052 follow-upEike Rathke
... and comparison of lcl_getPrevRowWithEmptyValueLookup() result. Change-Id: Ie4b848f30a0696cc40b04376c352a530b99190b9 Reviewed-on: https://gerrit.libreoffice.org/63840 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-11-23Related: tdf#118764 last of the GtkRadioButtons with can-focus FalseCaolán McNamara
Change-Id: I1346478fb8bbb1720ecc6cf7c88407be3b126bf1 Reviewed-on: https://gerrit.libreoffice.org/63867 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23Related: tdf#118764 last of the GtkCheckButtons with can-focus FalseCaolán McNamara
Change-Id: I81d3e03a0ccea3851b01d39b2e972b13ef4f6359 Reviewed-on: https://gerrit.libreoffice.org/63869 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23tdf#121417 Allow dynamic menu changes for Qt5 and KDE5 interfacesAleksei Nikiforov
Separate HandleMenuActivateEvent function call from HandleMenuCommandEvent function call since first one might update some of menus. Also add call to HandleMenuDeActivateEvent function. Delete action with Qt5MenuItem to reflect the change in actual menu. Also update underlying qt-based menu from Qt5Menu::InsertItem function. And update Qt5Menu::SetItemImage to work with different types of descendants of SalBitmap. This code is shared between Qt5 and KDE5 plugins, but KDE5 plugin uses SvpSalBitmap instead of Qt5Bitmap. New image conversion process is borrowed from GTK plugin code. This approach is used in order to properly process transparency channel if it's present, and it is present usually. This change also fixes tdf#120789. Change-Id: Ifdc64c3e5d80782955b52e2da8fcff4844d2dc25 Reviewed-on: https://gerrit.libreoffice.org/63862 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-23check EnableLocalizedDecimalSepCaolán McNamara
Change-Id: I77b6b28ddf50b6fc363f09bf4f7226d39504a571 Reviewed-on: https://gerrit.libreoffice.org/63865 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23Move menu item insertion into separate functionAleksei Nikiforov
Change-Id: I721910bbbd558827e9a5de1f8763426b460f08fa Reviewed-on: https://gerrit.libreoffice.org/63861 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-11-23Tabbed NB calc: fix drop down menuesandreas kainz
Change-Id: I13978d74ad64891108b4c633d342146ad2655087 Reviewed-on: https://gerrit.libreoffice.org/63858 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-23remove some dead enums in sd/Noel Grandin
Change-Id: I72bfaf2be6939798cd3db21df959b07500751fab Reviewed-on: https://gerrit.libreoffice.org/63754 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-23tdf#118764 Animation panel tab stop fixesJim Raykowski
Change-Id: I551a5e930731b5a173066b831dd40bea1bfdfbcd Reviewed-on: https://gerrit.libreoffice.org/63834 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23Related: tdf#118764 last of the GtkButtons with can-focus FalseCaolán McNamara
Change-Id: I8001d8c6c950e74df0f909e1cebfb3d1e52a84a4 Reviewed-on: https://gerrit.libreoffice.org/63846 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-23Get rid of ValueSet's internal VirtualDevice, draw to RenderContextMike Kaganski
This improves support for Online HiDPI scenarios. Change-Id: I1d4d13d8877b761cabaefa028dcd50d8345d9893 Reviewed-on: https://gerrit.libreoffice.org/63827 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-23Bump compiler plugins Clang baseline to 5.0.2Stephan Bergmann
...as discussed at <https://lists.freedesktop.org/archives/libreoffice/2018-November/081435.html> "minutes of ESC call ..." Change-Id: Ia053da171d59747984546f38e19da808825b4f79 Reviewed-on: https://gerrit.libreoffice.org/63832 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-23tdf#114836, only set changed SfxItemSet propertiesMarkus Mohrhard
By always setting all existing properties again the calls started to differ between XMultiPropertySet::setPropertyValues and XPropertySet::setPropertyValue. This patch reduces the changes in the called methods. We can not avoid slight differences but at least the risk is minimized that something is unexpectedly changed. Change-Id: I5866db7be2829e6aba930f620f45db655df4e3f7 Reviewed-on: https://gerrit.libreoffice.org/63854 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-11-23Colibre icons: add calc data icons and sync with elementaryandreas kainz
Change-Id: I38dc00c4d4364e50fa3e3aef8e3d613d9d8b4992 Reviewed-on: https://gerrit.libreoffice.org/63848 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-11-23sw: new unit test for XTextCursorVasily Melenchuk
Change-Id: I5b70f6dc8f7399be78daefa95d6d98687d99ec18 Reviewed-on: https://gerrit.libreoffice.org/61098 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: new testcase for XTextVasily Melenchuk
Change-Id: I8c4b89e1e0851e808daa0902f970f967c6d057a9 Reviewed-on: https://gerrit.libreoffice.org/61348 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: new testcase for XTextRangeVasily Melenchuk
Change-Id: Ia476f4f001851d0f8b51fca62b5c041b1d866cc3 Reviewed-on: https://gerrit.libreoffice.org/61174 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: fixup XAutoTextContainer testThorsten Behrens
This is a follow-up to 4967d498c486800b72ba34192c82c232bc0685bd and avoids to have setup errors making these tests silently pass. Also cleanup code a bit & share common init sequence. Change-Id: I043447a28f5e2c9f416aa906135030c07b2cacc8 Reviewed-on: https://gerrit.libreoffice.org/63800 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-23sw: new unit test for XAutoTextGroupSerge Krot
Change-Id: I3928248b73025f304c0e1ef7b5f86349df9a3c8d Reviewed-on: https://gerrit.libreoffice.org/61267 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-22tdf#121326 Don't tab stop at toolboxes with no visible or enabled itemsJim Raykowski
Change-Id: I4d20bafbda9e6b675654d0359421cf9e57712d15 Reviewed-on: https://gerrit.libreoffice.org/63457 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#118764 Pos&Size and Shadow panels tab stop fixesJim Raykowski
Change-Id: Id6ee2eed8ee96b901be8172cccc9b50e01877e3b Reviewed-on: https://gerrit.libreoffice.org/63361 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22weld SwFramePageCaolán McNamara
Change-Id: I12f868611860867df26bd29474aa19189c2b9a96 Reviewed-on: https://gerrit.libreoffice.org/63818 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22coverity#1441484 Logically dead codeCaolán McNamara
Change-Id: I42a97ccb5cae95f57a03faf210af362a2874fcb1 Reviewed-on: https://gerrit.libreoffice.org/63809 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22coverity#1441483 try and silence bogus Using invalid iteratorCaolán McNamara
Change-Id: I312cef93a0cef48207a3b7f5165dd48d702de3c6 Reviewed-on: https://gerrit.libreoffice.org/63810 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22weld SwFrameURLPageCaolán McNamara
Change-Id: If189c6bbc11f85a47e3908e4ffcef36344ff8f9d Reviewed-on: https://gerrit.libreoffice.org/63819 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22tdf#120426 save the style names when set or changedCaolán McNamara
instead of waiting until gaining focus of the listbox, because of the differences in what that focus means in the different backends. It was an odd way to do things anyway. Change-Id: I072e3da04db184b49a86a9888080b60223813729 Reviewed-on: https://gerrit.libreoffice.org/63820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-22uitest Calc ScenariosZdeněk Crhonek
Change-Id: Iddb099f4b4773d8b70d24d7df011e103fbf0ac7a Reviewed-on: https://gerrit.libreoffice.org/63806 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-22tdf#121052 sc: avoid multiple empty value lookups in rangesSerge Krot
Change-Id: I7759aef51af2f400f3f5ec69854fd9133e845f49 Reviewed-on: https://gerrit.libreoffice.org/62712 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-11-22Don't create temp file in save destination folder when sandboxedTor Lillqvist
In a sandboxed environment we don't want to attempt to create temporary files in the same directory where the user has selected an output file to be stored. The sandboxed process has permission only to create the specifically named output file that the user chose in the system file dialog in that directory. Change-Id: I65274b4c433bd66b436429bea4b287a0505b72c9
2018-11-22--enable-dbgutil --disable-assert-always-abort fixesStephan Bergmann
...which <https://ci.libreoffice.org/job/lo_tb_random_config_linux/> occasionally stumbles across; plus some related loplugin:staticmethods fixes Change-Id: If6998c302cfbabfcad626d9c68d94d3368548a41 Reviewed-on: https://gerrit.libreoffice.org/63808 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-22Avoid busy-loop related to layout when dragging objects.Michael Meeks
Change-Id: I4fb437356bc154cfefc5958592ae5888e24d59c3 Reviewed-on: https://gerrit.libreoffice.org/63804 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-11-22tdf#121425 Use better Bezier curves to approximate circle arcRegina Henschel
The distance between curve point and control point was calculated as linear scaling with ratio of central angle of the arc to pi/2. The patch replaces this with the mathematical correct formula. Change-Id: I0195e40bb99cd4bbcce95f7ac896158b7e7e3d29 Reviewed-on: https://gerrit.libreoffice.org/63659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22improve function-local statics in toolkitNoel Grandin
Change-Id: I2a134d1cc74eaeaad46f4249fadd215b2391ba19 Reviewed-on: https://gerrit.libreoffice.org/63789 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-22Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - tdf#119415 Widen search box and style placeholder Change-Id: I0f60cfea338e695e778d16a208153597ec6d19ca
2018-11-22tdf#121597 DOCX: don't export empty paragraphs at tracked deletionLászló Németh
of non-empty multiple paragraphs. Complete the fix for "tdf#115521 DOCX export: keep empty paragraphs in tracked deletion" in commit 2cdc870a7ee82d0faf35cdb5b2bf4e687cfd2b8d Change-Id: Ic3446e2a2118e604a7a4d269c8fed1f9f157846f Reviewed-on: https://gerrit.libreoffice.org/63731 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-11-22tdf#116931 Fix scale when calc cells move indirectlyArmin Le Grand
For the anchor mode 'To Cell (resize with cell)' there were errors e.g. when the cell the object is in does not scale but move. If that move went further than the object is, wrong offsets emerged. Also added full linear per-cell scale instead of only scale (no translation through scale). Overhauled to use liner transfomations, too. Change-Id: Icff0fad168476c68ea10fd5830bf53bd7294b89f Reviewed-on: https://gerrit.libreoffice.org/63803 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>