summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-11-11loplugin:expandablemethods in chart2Noel Grandin
Change-Id: Ie6650628683ec7c67359351eec0e09033f2b50cb Reviewed-on: https://gerrit.libreoffice.org/30750 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11update vclwidget loplugin to find ref-dropping assigmentNoel Grandin
Look for places where we are accidentally assigning a returned-by-value VclPtr<T> to a T*, which generally ends up in a use-after-free. Change-Id: I4f361eaca88820cdb7aa3b8340212db61580fdd9 Reviewed-on: https://gerrit.libreoffice.org/30749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-11add move operators for VclPtrNoel Grandin
Change-Id: Ic32894d13aac2d8038afec2efebcc544f1c408af Reviewed-on: https://gerrit.libreoffice.org/30748 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10Make sure we pass the top-left corner address.Kohei Yoshida
aRefPos may shift to the right in case of a multi-column range. Change-Id: I1ed033707b9f4f2c3523631b5035b02e59bbaa6a
2016-11-11More XAdES workTor Lillqvist
Accept and store a set of EncapsulatedX509Certificate data for a signature. Change-Id: Iae69502bc8caa0287c8f6d6c352256bdda22406b
2016-11-10loplugin fixes here, tooTor Lillqvist
Change-Id: I32cf90d524f8dd9fb454d4145d314b748ac0b281
2016-11-10use-after-free fix here, tooTor Lillqvist
Change-Id: I228b6367abadfc25c85fdb6821faebc7e4e8dda8
2016-11-10TyposTor Lillqvist
Change-Id: I87a63c4b1a13186efa5d0bd807605092197082e0
2016-11-10'make screenshot' use-after-free fixesStephan Bergmann
Change-Id: I4302d0d767a1bf50fd34a78e9aa0ad6d6b0c7a22
2016-11-10'make screenshot' loplugin fixesStephan Bergmann
Change-Id: Ibebcd1c1ebfea0ecdf9d90b6f8bcc8ceb87df456
2016-11-10tdf#103792: No placeholder text imported for empty title shapeTamás Zolnai
Change-Id: I95b4358f0d4311e8f427c8de18863049fb718d9b Reviewed-on: https://gerrit.libreoffice.org/30731 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-11-10Reduce scopeKhaled Hosny
Change-Id: I12f9f5edc4929264627ba949ebf95abd369778c6
2016-11-10sfx2: fix showing PDF signaturesMiklos Vajna
A ZIP storage was unconditionally assumed when calling showDocumentContentSignatures() for "originally" read-only documents, i.e. in case the file itself is read-only at a filesystem level. Change-Id: Iba69000fc396afaf5ab34699e811b5d2c216e2bb Reviewed-on: https://gerrit.libreoffice.org/30758 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-10xmlsecurity PDF sign: support non-compressed AcroForm objectsMiklos Vajna
This was the last problem to be able to counter-sign Acrobat-created PDF 1.6 signatures unlimited number of times. Change-Id: I24ab80c8516b6fe9c08d57c08907bec70384dc28 Reviewed-on: https://gerrit.libreoffice.org/30757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-11-10xmlsecurity PDF verify: fix incremental updates vs object streamsMiklos Vajna
The problem: an object stream provies obj#1 and obj#2, then an incremental updates provides an updated obj#1'. Then we look up obj#2, parse the stored objects on-demand, so at the end when later we look up the first object, we find obj#1, not obj#1'. An easy workaround would be to never update already existing objects from object streams, but that would break when an incremental update provides an object stream. Fix the problem by parsing stored objects right after tokenizing the object stream, and not later, on-demand, when we no longer have the context what objects should be ignored. This is needed (but not enough) to correctly append a signature at the end of a PDF file that has both object streams and incremental updates. Change-Id: I3c1fae5ac26804c8e8cc1984511f43cfa881c97b
2016-11-10Resolves: tdf#103809 the argument is a bool* not a VclPtrCaolán McNamara
Change-Id: Ia07f4ff7b243708304186c840135ec1180621fa5
2016-11-10micro optCaolán McNamara
Change-Id: I4ef86a56780cf9ea8fe244a5347a79099bc05979
2016-11-10tdf#103826 Missing master page pane context menus in DrawMaxim Monastirsky
Change-Id: I355e9507692e770063a91d05efd3ebc3e2671d57
2016-11-10More work in progress on XAdES compliant ODF signingTor Lillqvist
Pass an XAdES flag to a couple more functions and adapt to that. Factor out writeDigestMethod() and writeSignedProperties() from OOXMLSecExporter::Impl to DocumentSignatureHelper and use them in an additional place. Write xd:UnsignedProperties with EncapsulatedX509Certificate. Probably much more work needed. Change-Id: I2a0cd1db6dd487b9c7ba256ad29473de3d271cd8
2016-11-10Adapt sd.screenshotStephan Bergmann
to b1164b07f9fdcd06a77dbdd74d45245a7c42c93e "loplugin:constantparam in sd" Change-Id: I5e03c9ab19af630cdc536fddcb2f39815084b714
2016-11-10Refactor ScAttrArray for tdf#50916Dennis Francis
For a default column, now ScAttrArray does not store the default format. So the case of default pattern from 0 to MAXROW is represented as nCount = 0 and pData = nullptr in ScAttrArray. A new ScAttrArray object (aNextColAttrArray) is introduced as a member of ScTable. This is used to store the formatting of *unallocated* columns (whose indices are from aCol.size() to MAXCOL). In next patches for this bug, I plan to refactor table*.cxx functions related to formatting such that : 1) In formatting setter functions, if colspan of the input range spans the colrange(aCol.size() to MAXCOL) then instead of allocating columns, apply that formatting to aNextColAttrArray. 2) In formatting getter (const) functions, if requested colspan has some intersection with the colrange(aCol.size() to MAXCOL) then use the formatting info stored in aNextColAttrArray to calculate the formatting of the input range. 3) In general setter (non-const) functions if we really need to allocate new columns (example, when data is entered), use the formatting info stored in aNextColAttrArray to create pAttrArray of the new column. Change-Id: Ieb56f853209b396d92fdb2c27e39361703576423 Reviewed-on: https://gerrit.libreoffice.org/27828 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-11-10Windows 8 driver blacklistMarina Latini
Blacklisted intel driver for graphics card Intel(R) HD Graphics 4000 for Windows 8. With this card LibreOffice won't start. Change-Id: I3f4e04da7b4d61bddb1e755771b6a9538b596c51 Signed-off-by: Marina Latini <marina@studiostorti.com> Reviewed-on: https://gerrit.libreoffice.org/30754 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2016-11-10WaE: unused variableDavid Tardon
Change-Id: I44fcadbf34677887853324e15cc46388f6f55448
2016-11-10Resolves: rhbz#1342828 toolbars jumping around while moved under XCaolán McNamara
because the start move by wm conflicts with the manual efforts to position the toolbar. the move by wm was done to get wayland to move the toolbars, but (gnome#768128) supporting docking toolbars under wayland is futile as far as I can see Change-Id: I502d4617efaf1eb686469e100224e56104ad650d Reviewed-on: https://gerrit.libreoffice.org/30751 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-11-10tdf#67379 - sw: treat clicking h/f-fly the same as any otherJustin Luth
Why should clicking on a frame/image in a header act any differently from a one insde the text body? (The only time frames (or any kind of fly) required a double click occured when switching from inside a header to a body-fly or from inside the body to a h/f-fly. This patch removes that oddball corner-case.) Now all frames are handled with a single click and there will not be an impact on double-clicking anymore. regression caused by 7e2f98d0a0c4a0f36a94353a256e7cc5caa3113b and its prior commit which say: > Header/Footer: fixed click on frames over the header/footer area. > The main problem here was due to the click to show the separator when > there is no header or footer under the frame. That code was just exiting > MouseButtonDown too early, which isn't good. > Now, double-click actually selects a frame anchored in header/footer. confirmed that single-clicking on frames over the header/footer section still shows the header blue-line. Change-Id: I4770cfe7898202929742743931e22de8bf233b03 Reviewed-on: https://gerrit.libreoffice.org/30693 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-11-10xmlsecurity PDF verify: fix reading multiple subsections from an xref streamMiklos Vajna
This is especially needed, as we don't bother compressing updated objects into sections on signing, we simply use a separate section for each updated object. Work towards supporting xref streams and incremental updates at the same time. Change-Id: Ie9759edbba816991615fafc6602cdd440141b989
2016-11-10re-apply "use material style selection handles""Christian Lohmaier
and account for the libreofficekit changes This reverts commit 50e9065cbbb2c62fa925cf5b561a85c715a0eb1e. that did in turn revert 4ae8c3c20bd4a10ba141a32f01e23ac63636f9c3. Change-Id: Ie02d8743b3608120ed63bfe2a014fa4139577b01
2016-11-10Resolves: tdf#103815 Revert "use same GtkInstance::AnyInput impl"Caolán McNamara
cause of the reported regression, it seems extradinary that this would cause that, but it seems to be the case and I have no interest in debugging the undebuggable scheduler. This reverts commit 180a0eac238ce456771ff20b8d3274b43408f54c.
2016-11-10clarify class documentationEike Rathke
Change-Id: I282a438159b9862034ba9fe4acdf87bf859b0465
2016-11-10Avoid writing to the log for the same group twice.Kohei Yoshida
This can happen when the group calculation is disabled and falls back to non-group calculations. And we only care about the first entry in case of non-group calculation of grouped cells. Change-Id: I545980acf8e35b4d0504aa2a77f86bdc85799e29 Reviewed-on: https://gerrit.libreoffice.org/30738 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-10temporarily revert "use material style selection handles"Christian Lohmaier
the linux build / libreofficekit also uses those and needs to be told about this change as well. This reverts commit 4ae8c3c20bd4a10ba141a32f01e23ac63636f9c3.
2016-11-10bump gradle/gradle-plugin to instant-run compatible versionsChristian Lohmaier
Change-Id: Ib0d2dac42814c9daf752f0421922fb093507eb7c
2016-11-10refresh app icons to flat/material styleMirek Mazel
Change-Id: I0c0a8a540eccc022c405659f53da73bd87eced18
2016-11-10use material style selection handlesMirek Mazel
Change-Id: If42bf5757e2010fccc7061ccffda76048b2e0dda
2016-11-10demote "unknown android ndk" to warning only (and add 13.1 as known)Christian Lohmaier
android studio/sdk manager doesn't provide a default way to install multiple versions of the NDK, so typically only the latest one will be available. Don't make configure error out in this case, but print a warning instead. Change-Id: I6af9a3f088daf7d12ebd9910286d7f44d264014a
2016-11-10Access2Base - Code cleanupJean-Pierre Ledure
Replace double code by function calls (dialog libraries handling) Change-Id: I17fc700e47a258b281214fe29e075bc782fb6acd
2016-11-10Updated coreMiklos Vajna
Project: help 02139162f541bb56ddbaf0a2d6142256a0454372 digital signatures: briefly document OOXML/PDF signing effort It may be unexpected for users to see that OOXML files are always only partially signed. Change-Id: Ie7c6c553580a4eb38ed72c8a50b75f4b7902613f
2016-11-10Wrap pointer to dialog with VclPtrTakeshi Abe
Change-Id: Ifaf0f45b12d983d556ca4c7e0b4a57c47ff38597 Reviewed-on: https://gerrit.libreoffice.org/30737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-10loplugin:staticmethodsStephan Bergmann
Change-Id: Id7d7bb572466bcc803ac424cd8ddb64205a1c273
2016-11-10loplugin:stringconstantStephan Bergmann
Change-Id: I0eb2b9986840b1bd5bc892da23c56205047bc120
2016-11-10loplugin:cstylecastStephan Bergmann
Change-Id: I6ec274c6c546f60c23fe639002d751f0a9f11d33
2016-11-10Access2Base - Comments reviewJean-Pierre Ledure
Change-Id: If7fb37a3656b55f7820698a59b8f1d8d8b14d594
2016-11-10Don't let multiple JunitTests operate in parallel on ScDDELinksObj.odsStephan Bergmann
...seen a failure of JunitTest_sc_unoapi_3 with > checking: [sc.ScDDELinkObj::com::sun::star::util::XRefreshable] is iface: [com.sun.star.util.XRefreshable] testcode: [ifc.util._XRefreshable] > LOG> Execute: refresh() > LOG> starting required method: addRefreshListener() > LOG> Execute: addRefreshListener() > Method addRefreshListener() finished with state OK > LOG> addRefreshListener(): COMPLETED.OK > warn:unotools.misc:30768:84:unotools/source/misc/mediadescriptor.cxx:690: caught Exception "" while opening <file:///data/lo/core/sc/qa/unoapi/testdocuments/ScDDELinksObj.ods> > warn:filter.config:30768:84:filter/source/config/cache/typedetection.cxx:455: caught Exception "Could not open stream for <file:///data/lo/core/sc/qa/unoapi/testdocuments/ScDDELinksObj.ods>" while querying type of <file:///data/lo/core/sc/qa/unoapi/testdocuments/ScDDELinksObj.ods> > Method refresh() finished with state FAILED and it appears that all of sc.ScDDELinkObj, sc.ScDDELinksObj, and sc.ScIndexEnumeration_DDELinksEnumeration try to open that file (necessarily for writing?), and the first two are in JunitTest_sc_unoapi_3 (so are executed sequentially), but the last one is in JunitTest_sc_unoapi_4 (so may be executed in parallel with the others), so that may be the reason for such sporadic failure. Easiest workaround appears to be to move the third test into the same JunitTest as the other two... Change-Id: Iefb94cf657bdc9c1eac92dd49ee6257eb5e80905
2016-11-10WiP tdf#74172 use DECIMAL and NUMERIC data typesWastack
Change-Id: I917cdf6e8d3ebfa7c9e4a52ca61adc5b8707ecfc Reviewed-on: https://gerrit.libreoffice.org/30447 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2016-11-10xmlsecurity PDF sign: use a predictor when compressing the xref streamMiklos Vajna
With this our xref stream output is close enough to Acrobat so that the existing signature verifier runs without any problems. Change-Id: I6eca7966890365759c269b465e4bf4d86d335219
2016-11-10start with a defined stateDavid Tardon
Change-Id: I7e77fcf2d120845b436b7d6220025fd5b339aafa
2016-11-10Don't let MODULE.all depend on MODULE.screenshotStephan Bergmann
...as that, somewhat surprisingly, causes 'make MODULE.all' do additional targets that a plain top-level 'make' would never do. See discussion in mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2016-November/075797.html> "[Libreoffice-commits] core.git: Branch 'feature/dialog-screenshots' [...]". Change-Id: I460f3c91cf00d3398c61833fdcd5eaebdc87fbf2
2016-11-10writerfilter: remove never read m_xTableRangeMiklos Vajna
Its last user was writerfilter::dmapper::DomainMapperTableHandler::getTable(), removed in commit 6ea66657ebca5b3ec63f93b496b812888e0d53c9 (loplugin:unusedmethods writerfilter, 2015-07-20). Change-Id: Ibaf536d4dd8f01f4413c3cec033db7438501e58c
2016-11-10Access2Base - Call GetLocale() only onceJean-Pierre Ledure
and not for each individual label Change-Id: I7014be30569a275fa20faaa2ba9255d3968b70dd
2016-11-10make comphelper::sequenceToContainer a little smarterNoel Grandin
so we don't have to specify the source type Change-Id: I4106705a39874a8043f0f294a11374404d6cfc3a Reviewed-on: https://gerrit.libreoffice.org/30713 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-08 05:48:47 +0000