summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-18clang-tidy readability-simplify-boolean-exprNoel Grandin
Change-Id: I78fa01a6c803dec782488490b730af3a11814d64 Reviewed-on: https://gerrit.libreoffice.org/61902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18xmlsecurity: avoid repeated manual calls to PORT_FreeArena()Miklos Vajna
Change-Id: Id62a894b08e6221c858304d7cb198a5a3f0cbd43 Reviewed-on: https://gerrit.libreoffice.org/61893 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-18tdf#37778 ww8import: protect section only if protEnabledJustin Luth
Protection is not related to fReadOnlyRecommended In Word, documentProtection enforcement is a document level setting which is required for the section protection setting to be enforced. formprot: "The enforcement of this property is determined by the documentProtection element (§17.15.1.29), as it is possible to specify protection without turning it on." In LO, section protection is honored if it is simply enabled, so only enable a section's protection if the enforcement variable is set. Round-tripping will lose the fact that sections are marked as protected if the enforcement is off. patch initially developed to support tdf#120499 where the focus is on sections, not on read-only and the fake section that was being created. Change-Id: I08c37ea6a9cc8fd1bdf7f36771b2d719bf9c93d6 Reviewed-on: https://gerrit.libreoffice.org/61899 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-10-18Qt5AccessibleEventListener: Improve mappingSamuel Mehrbrodt
Change-Id: I8852b37b2c82f88b5feb5aa42775fbfeb3c9b187 Reviewed-on: https://gerrit.libreoffice.org/61886 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-18loplugin:staticvar in hwpfilter..salNoel Grandin
Change-Id: I8bf3509637cb295847e0dd667c1862269a192bbe Reviewed-on: https://gerrit.libreoffice.org/61881 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-18tdf#120231 Focus to document on sidebar tabbar deck tab clickJim Raykowski
Change-Id: Ic93b0171c9862f70311e93d64d1b93baf35a5182 Reviewed-on: https://gerrit.libreoffice.org/61457 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-10-18Need <rtl/strbuf.hxx> for the !HAVE_FEATURE_EXTENSIONS case, apparentlyTor Lillqvist
Change-Id: I3d3c31f785ae2969660c95425419ef9fe5b893c3
2018-10-17Turn sd::BluetoothServer::Impl into scoped enumStephan Bergmann
...to avoid -Werror,-Wshadow from Clang trunk with <https://reviews.llvm.org/D52400> "Improve -Wshadow warnings with enumerators", warning about shadowing of UNKNOWN in anonymous enum in sd/source/ui/remotecontrol/BluetoothServer.hxx Change-Id: Ie0e6794da82c79ae2f8fd848c3c015c873fd60aa Reviewed-on: https://gerrit.libreoffice.org/61878 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-17Resolves: tdf#120003 missing prefix to link url in .doc importCaolán McNamara
regression from... commit 9b77f8142bf665a47c3a179e3fe3f82623a99f8a Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Apr 6 15:08:45 2017 +0100 ditch ReadRawUniString three argument lclGetString32 variant mistaken for two argument lclGetString32 variant Change-Id: I163aad0de7873487d9f9c8b6c28d162159fe7ad4 Reviewed-on: https://gerrit.libreoffice.org/61884 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-17Increase number of default personas to 6Muhammet Kara
Also: * Prepare the ui file for up to 9 default personas * And make the click handlers future-proof for different numbers Change-Id: Iddf3b1c07feff12dc1fbba3e8a881ddf04923ced Reviewed-on: https://gerrit.libreoffice.org/61891 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-17oox: add an environment variable to bypass the SmartArt warningMiklos Vajna
That dialog is counter-productive if you develop that feature itself. Change-Id: Ia635a2ff0ecc29a0d11be5c621a7c2a76469f9ba Reviewed-on: https://gerrit.libreoffice.org/61880 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-17tdf#120395 - Rename Page numbers in Fields dialogheiko tietze
Change-Id: I47c52fbda3692178ad6c02fea7615463eeb4dcc8 Reviewed-on: https://gerrit.libreoffice.org/61876 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-10-17fix buildRene Engelhard
Change-Id: I33451bd326697cfffb156f041dd1c2500da385da
2018-10-17KJ: Rename wrong iconRizal Muttaqin
Change-Id: I5285409f69f8e6568436fcc25a58eca4a24a0887 Reviewed-on: https://gerrit.libreoffice.org/61863 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-17tdf#120651 have to sort radiogroup by tab positionCaolán McNamara
Change-Id: I8fcf4c4b186d8292c85babaa90e98396a5fbc71b Reviewed-on: https://gerrit.libreoffice.org/61882 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-17Limit variable scopeMike Kaganski
Change-Id: I42d2e59297a70c977ec2f7782b403c1f79c434de Reviewed-on: https://gerrit.libreoffice.org/61875 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-17loplugin:unusedmethodsNoel Grandin
Change-Id: I73de303f93b3557881dbb84d6d11d89f193da010 Reviewed-on: https://gerrit.libreoffice.org/61868 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17elementary: fix for tdf#120192, add more 32px, etcRizal Muttaqin
Change-Id: I6441f66f7cd078dae0c81cb1a5c62b5130187537 Reviewed-on: https://gerrit.libreoffice.org/61862 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-17Implement Qt5AccessibleText::characterCountSamuel Mehrbrodt
Change-Id: I91135172bbfb34010f6c53833ac4b7c06b0f7d26 Reviewed-on: https://gerrit.libreoffice.org/61872 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-17weld SwMailMergeFieldConnectionsDlgCaolán McNamara
Change-Id: I15ee027db596c98eef878e2e174429c532789dad Reviewed-on: https://gerrit.libreoffice.org/61871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-17weld BrokenRecoveryDialogCaolán McNamara
Change-Id: I6bcc067eba0648f0f4c000d1fbb811d9235c8707 Reviewed-on: https://gerrit.libreoffice.org/61870 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-17Remove unused FormulaLogger::maMessageStephan Bergmann
Change-Id: Ie1bc5cf4db6b46160fd950f471c9baf9ec51ebf7 Reviewed-on: https://gerrit.libreoffice.org/61873 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-17qt5 a11y: Add event notificationsSamuel Mehrbrodt
Change-Id: Idb2fb2f880b4e848adc213a4e2cea33c5eb56f05 Reviewed-on: https://gerrit.libreoffice.org/61424 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-17tdf#42949 Fix IWYU warnings in include/tools/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I9dc920e9388f9e2aa4dcae1f0b3f7562d08f7f70 Reviewed-on: https://gerrit.libreoffice.org/61809 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-17Silence more Clang trunk -Wdefaulted-function-deletedStephan Bergmann
...similar to 3db830d354de80b319fb818a0373365a1e647264 "Silence new Clang trunk -Wdefaulted-function-deleted", after fb1d3b580763a333bbbfe115d09e1b5cd8849675 "loplugin:constfields in sc" Change-Id: I8358e862e53dd8f57169ba2d2f2c543edb93e2a5 Reviewed-on: https://gerrit.libreoffice.org/61867 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-17loplugin:staticvar in editeng..frameworkNoel Grandin
Change-Id: I8e555a98f74f61e6e40122564b7ad19ca07a8a91 Reviewed-on: https://gerrit.libreoffice.org/61866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17ScTable::CopyTable drop defaults from paramsNoel Grandin
so I can change the signature of this method safely Change-Id: I91574cc1660c14408f2dcd9dbd18c0faa1a1e5c5 Reviewed-on: https://gerrit.libreoffice.org/61864 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17workaround weird linking error on tb71Noel Grandin
ever since commit 9ec8bf8f22fe74884185492ef2576ce79b41e4f1 add SvStream::TellEnd Change-Id: I3043459688e9cee16cdb71137c6808a3365b69f6 Reviewed-on: https://gerrit.libreoffice.org/61869 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17sw, writerfilter: avoid some unnecessary value parametersMiklos Vajna
Change-Id: I409eb644bdf519e097c87911b90f83c5ecd913ee Reviewed-on: https://gerrit.libreoffice.org/61853 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-17loplugin:staticvar in cppuhelper..desktopNoel Grandin
Change-Id: I21cf6bafab6e865b90b29caa73183a8e00b538d1 Reviewed-on: https://gerrit.libreoffice.org/61865 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17ofz: thread shenanigansCaolán McNamara
Change-Id: I638b4e670f88aee78b6bd9ec638014795e103971 Reviewed-on: https://gerrit.libreoffice.org/61851 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-17Resolves: tdf#119997 toolbar layout unlock doesn't refresh uiCaolán McNamara
because lock was taken when toolbar layout wasn't set yet Change-Id: I695493d4fb637210c72b9ce53af9f089c79b0c7b Reviewed-on: https://gerrit.libreoffice.org/61848 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-17Simplify containers iterations in unodevtools, unoidlArkadiy Illarionov
Use range-based loop or replace with STL functions. Change-Id: I3089a4d4a94eea849cad442b04906908908e4c27 Reviewed-on: https://gerrit.libreoffice.org/61854 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17clang-tidy readability-redundant-smartptr-getNoel Grandin
redundant get() call on smart pointer Change-Id: Icb5a03bbc15e79a30d3d135a507d22914d15c2bd Reviewed-on: https://gerrit.libreoffice.org/61837 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17loplugin:staticvar in avmedia..connectivityNoel Grandin
Change-Id: I5dcac79131c810787e8fa49df75e55cc78147860 Reviewed-on: https://gerrit.libreoffice.org/61834 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17new loplugin staticvarNoel Grandin
looks for variables that can be declared const and static i.e. they can be stored in the read-only linker segment and shared between different processes Change-Id: I577fb2070604003e56fb44f8a02c9684070311cf Reviewed-on: https://gerrit.libreoffice.org/61817 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17loplugin:singlevalfieldsNoel Grandin
tighten up the handling of binary operators Change-Id: I262ec57bf7142fa094d240738150a94d83fd15ee Reviewed-on: https://gerrit.libreoffice.org/61777 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-17Use curl while getting the actual personaMuhammet Kara
Change-Id: Ia2f9c3b7c68ffba1e80ecd271bc92467210fa9b5 Reviewed-on: https://gerrit.libreoffice.org/61833 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-17Notebookbar: sync tabbedbarandreas kainz
Change-Id: I6441f66f7cd078dae0c81cb1a5c62b5130187536 Reviewed-on: https://gerrit.libreoffice.org/61858 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-17Notebookbar: update calc tabbed notebookbarandreas kainz
Add Printpreview, Object, Media, Update Image, Draw Context tab Change-Id: I4433ba838ca734f2214679f9bdfa50427edfcc71 Reviewed-on: https://gerrit.libreoffice.org/61856 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-16Resolves: tdf#115182 default Chart percentage format is integerEike Rathke
Regression from commit 0f4b3cb7d3d68906de316a64dcec281da2a641bd CommitDate: Mon Aug 10 17:12:45 2015 +0200 The chart2/qa/extras/xshape/data/reference/tdf90839-?.xml reference files were created with the then wrong default of two decimals so need to be adapted. For chart2/qa/extras/xshape/data/reference/tdf90839-1.xml this meant to regenerate because of the changed positions and sizes of labels. Change-Id: Ib0c2c862af9399ab2af5178d01510aa5e4fff97c Reviewed-on: https://gerrit.libreoffice.org/61826 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2018-10-16tdf#119885: a typo fixMike Kaganski
5d0c83fd4cf91083805f60f49e4fafd3d6ac73d4 follow-up Change-Id: I3611172944072ac009c7c5191cbe05ec9600fd1d Reviewed-on: https://gerrit.libreoffice.org/61847 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-16Fix build in sfx2Julien Nabet
Failing build due to 27dadc070ec2c2a602d3c5b3494dd0bdc15c785f Change-Id: I34aa67185e7889fd4ee1781b9a45c9a202e76954 Reviewed-on: https://gerrit.libreoffice.org/61846 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-16Narrowed variableScopeZdibák Zoltán
Change-Id: Ic3284266a021e3fe17bf99a64e75c0d5a7e662d7 Reviewed-on: https://gerrit.libreoffice.org/61739 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-10-16tdf#45904 Move _XTableChartsSupplier Java Tests to C++Rahul Gurung
Change-Id: I4cd0b25cefce60e8253df65d5136d15d690dbc38 Reviewed-on: https://gerrit.libreoffice.org/61540 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-10-16Avoid risk of looking at an errno modified by SAL_INFO() callTor Lillqvist
Thanks to Stephan for noticing. Change-Id: I6b90258bdc6bce7b2aeb44f9a1a136b4b9bd51c9 Reviewed-on: https://gerrit.libreoffice.org/61812 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-10-16tdf#119885: OOXML import: try to get cell paddings as Word doesMike Kaganski
Change-Id: I7abd715b6bb71d6e2e01939c4cf849d94eb6a103 Reviewed-on: https://gerrit.libreoffice.org/61843 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-16tdf#119956 unit test, LayerTabBar, adapt focus if Alt+ClickRegina Henschel
The test simulates Alt+Click and checks which tab is current. Some methods have been exported, so that they can be used in the test. The test classes have been changed to get an odg document really opened in Draw. Change-Id: I6ece8594f297c48c862693ead049e6e1f9edbc31 Reviewed-on: https://gerrit.libreoffice.org/61545 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-10-16crashtesting: exception on exporting fdo77519-2.odt to docxCaolán McNamara
since... commit 761308edb65a6cf44ef84cebc387e77af8b70f83 Date: Thu Sep 13 04:04:41 2018 -0400 tdf#108064 OOXML export: fixing linestyle export in charts Change-Id: I3b1a43246adaa1476ddba1b67f37d0e933a44345 Reviewed-on: https://gerrit.libreoffice.org/61842 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-16coverity#1440303 use emplace_back instead of push_backCaolán McNamara
Change-Id: I51457423fdd8d39b5c11d02b450d31fa59127952 Reviewed-on: https://gerrit.libreoffice.org/61840 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-17 23:10:42 +0000