summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-02-17move statusbar into DBTreeListBox containerCaolán McNamara
and convert to weld::Label Change-Id: Ic3cacf2197895712c6e6b38226f65078320c590f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111071 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-17tdf#130629: sw: Move UItest to CppUnitTestXisco Fauli
Change-Id: I80f248ec79f5bc04dc370b4c549730392110aaca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111074 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-17tdf#140058 "Bullets and Numbering" -> "List" in Text context menuSeth Chaiklin
This change has following consequences for UI: - context menus for Text | Bullets and Numbering and Table | Bullets and Numbering will now appear as Text | List - right-click in text will now show "List..." under "Character" and "Paragraph", instead of "Bullets and Numbering" and will open a menu where it is possible to select default lists, list styles and modify an existing list. The entry is singular because it is a context menu, and only one list can be modified. Change-Id: I941ebf01a005cf1c422e73611067bbc90d63e616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110928 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2021-02-17Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 71f0c6a4724fa28a2a2d72b0547aa0370c287fcf - update translations for master and force-fix errors using pocheck Change-Id: Iaf573f747484376b8aeb1854bc5342507a27d92d
2021-02-17tdf#115965 tdf#92622 NoList default in menu,tool,sidebarAnshu
Change-Id: Icbc612b44593c5366f3e7f81112f4013884f3599 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108841 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-02-17tdf#106612: sd: Add UItestXisco Fauli
Change-Id: I5364f963207fc9aa23ea133e3a0861b6e5f7455d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111063 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-17tdf#130677 Write new tests for literalsshubham656
Change-Id: I22607fdcaab840ca1512abf534712d36d4b5ee9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109964 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Tested-by: Jenkins
2021-02-17CppunitTest_sc_shapetest needs some more RTTI in UBSan builds nowStephan Bergmann
...since 02e4f6c44295004f5c7201a7aa2744fd0518ba9d "tdf#134355 custom shapes are never on layer 'controls' in Calc" and ae2e7a2a7f9fc56f0388b823a6e35111c4005619 "tdf#140252 unit test Controls in Calc are always on layer 'controls'": > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sc_shapetest.so > workdir/LinkTarget/CppunitTest/libtest_sc_shapetest.so: undefined symbol: _ZTI11FuConstruct" (due to e.g. the derived call to FuConstruct::MouseMove at sc/qa/unit/scshapetest.cxx:239:17); > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sc_shapetest.so > workdir/LinkTarget/CppunitTest/libtest_sc_shapetest.so: undefined symbol: _ZTI17FuConstUnoControl" (due to e.g. the static_cast at sc/qa/unit/scshapetest.cxx:232:37); > DynamicLibraryManagerException: "Failed to load dynamic library: workdir/LinkTarget/CppunitTest/libtest_sc_shapetest.so > workdir/LinkTarget/CppunitTest/libtest_sc_shapetest.so: undefined symbol: _ZTI18FuConstCustomShape" (due to e.g. the static_cast at sc/qa/unit/scshapetest.cxx:279:38). Change-Id: I79a8f5d31647c7b04a3519923cd7fcae58cd8f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111053 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-17More targeted suppression of bogus GCC -Werror=stringop-overflow=Stephan Bergmann
...given that <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87296#c5> "[8/9/10/11 Regression] -Wstringop-overflow false positive due to using MEM_REF type of &MEM" is declared fixed now on GCC 11 trunk. (Moving -Wno-stringop-overflow from gb_CFLAGS_WERROR to gb_CXXFLAGS_COMMON is done for no other reason than to harmonize this with the code for the similar HAVE_BROKEN_GCC_WMAYBE_UNINITIALIZED.) Change-Id: I3468138c9bbda28f754d4162cb9c059796bd3932 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111029 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-17Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 6a461bd0ac2ccb8b385f24d0698d29cad49084b7 - make file and Scriptforge link past patch #111036 Change-Id: Id827cf8e5fa35ad61d7130ea3247bd6395ab1401 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/111037 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-02-17Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 00cf8de0436b61d64c7c406de2106ee0c1949459 - Create SF Filesystem Help page Also in this patch: - lib_ScriptForge.xhp: add links to table of contents - sf_dialogcontrol.xhp: silence strings for translation Change-Id: I9b69be483d93957cdc793d95f56f33a48e3f1c85 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110788 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-02-17loplugin:referencecasting in desktopNoel
Change-Id: I19da92c3cbf082965f01fd2339f42419f4229aa1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111056 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to ec6e0c930fd8a7ca5dc6a84a686602acff69234e - sf_services new help page + sf_session adjustments and links - Addition of Array formulae and Array function information Change-Id: I03d64d863db90124cad75d13a66ade8d6abba126 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/110921 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-02-17tdf#42982 updated RunTimeException with 2nd argument(pointer)vipbuoy
Change-Id: I52dd9b9808e5fd61d07d4f8a6642124230ede23f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110971 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-02-17tdf#36466 calc UI: add option to Select Visible Cells OnlyTünde Tóth
Implement "Select Visible Cells Only" option to deselect the cells of the hidden rows in the actual selection. Change-Id: Ifa5a5c3aeeb45a7960a387d91b176cc66733ab10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110937 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-02-17loplugin:referencecasting in xmloffNoel
Change-Id: Ib601b7045d773ab612569a8fd00d76545dea13af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111055 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17sw: document SwTOXAuthorityMiklos Vajna
Even if it derives from a "Tab", it's not a table, just a row in it. Change-Id: I303fdcb8719e61ca790096b8cc342af3ffb28930 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111052 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-02-17tdf#39593: reduce copy/paste in Converter::convertDurationBayram Çiçek
Change-Id: I520e10ef96c677be9f80bba510fe9c89295d416c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111008 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-02-17ofz#31021 Stack-buffer-overflowCaolán McNamara
Conditional jump or move depends on uninitialised value(s) at 0x483CB98: strlen (vg_replace_strmem.c:459) by 0x49B4CA3: int rtl::str::getLength<char>(char const*) (strtmpl.hxx:65) by 0x49B7232: void rtl::str::newFromStr<_rtl_String>(_rtl_String**, rtl::str::STRCODE_DATA<_rtl_String>::type const*) (strtmpl.hxx:1344) by 0x49B470C: rtl_string_newFromStr (string.cxx:611) by 0x6059266: rtl::OString::OString<char [18]>(char (&) [18], rtl::libreoffice_internal::NonConstCharArrayDetector<char [18], rtl::libreoffice_internal::Dummy>::Type) (string.hxx:275) by 0x6058B5E: vcl::GraphicFormatDetector::checkTGA() (GraphicFormatDetector.cxx:525) since... commit 48d655fe12bc2c4c42d6c88b8a43fade1614ee2a Date: Mon Feb 15 16:25:56 2021 +0900 vcl: Detect TGA graphic by inspecting the file footer Change-Id: I52641ac541d5631e16fc271c35d6a671acb75c93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111006 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-17tdf#128213 Add unit test for text camera z rotation.Gülşah Köse
Change-Id: I50dab62ba1013d4ae17684edde620f9c94c5ec47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111028 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2021-02-17tdf#82616: sd: Add UItestXisco Fauli
Change-Id: I84c148f98517cd4f7cb07f268b71bf2ac7e18322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111031 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-17loplugin:referencecasting in connectivityNoel
Change-Id: I4b91c3e4a225323235ea37d77f0f96600bf412be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110969 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17Move DXF reader from filter module into VCLTomaž Vajngerl
Change-Id: If1a933256401c1a971f581d1b389ca06fd77eaae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111022 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17tdf#127471 correct EMF/WMF im/export for scaled fontArmin Le Grand (Allotropia)
If FontScaling is used, system-dependent data is held at vcl::Font Width(). Already if not scaled, we have three definitions: Width is zero, Width is equal to Height (unx) or - on Windows - Width equals avgFontWidth. If used it is W!=H where on unx Width equals Height multiplied with the scale factor. On Windows, this is Width multiplied with the only there existing avgFontWidth. Unfortunately that is ex/imported (since ever) undetected to EMF/WMF thus making EMF/WMF files containing FontScaling system-dependent - on which system was LO running when creating the file? The error can be seen when loading such a EMF/WMF on the vice-versa system, the FontScale is very ugly and wrong. Since EMF/WMF *are* Windows-specific formats the Windows-like definition is the correct one. This change makes all other systems export that now, and adapt on import to their system- specific definition (assuming coming from Windows). As can be seen, the difficulty is that these adaptions are necessary on non-Windows plattforms, but these do not have that avgFontWidth available. Thus I made a deep-dive investigation and multiple experiments to create a as similar as possible value to apply the needed calculations. For details and discussion refer to the bug description. Change-Id: I983fb6d882e2e8fccf9c8460f01509201d8157f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111000 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2021-02-17Avoid crash in online on a document with commentsAron Budea
Crashed on a specific doc with the following backtrace: Thread 1 "kitbroker_001" received signal SIGSEGV, Segmentation fault. 0x00007f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField (this=0x0) at /.../libreoffice/sw/inc/AnnotationWin.hxx:71 71 const SwPostItField* GetPostItField() const { return mpField; } 0 0x00007f4807c76d44 in sw::annotation::SwAnnotationWin::GetPostItField() const (this=0x0) at /.../libreoffice/sw/inc/AnnotationWin.hxx:71 1 0x00007f4807f0641b in SwXTextDocument::getPostIts(tools::JsonWriter&) (this=0x557e1d985a10, rJsonWriter=...) at /.../libreoffice/sw/source/uibase/uno/unotxdoc.cxx:3337 2 0x00007f4823216534 in getPostIts(LibreOfficeKitDocument*) (pThis=0x557e1d93c890) at /.../libreoffice/desktop/source/lib/init.cxx:3425 ... Change-Id: Ib97fd33fda936cad0c9ed3a29564fc0a49ff20c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110958 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-17loplugin:referencecasting in configmgrNoel
Change-Id: Ib74468d3a6a40b32896c58b0d30e3121ee834e1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111027 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in cppuhelperNoel
Change-Id: Ie19f01a35ef656f5532c5ec41dbed1c0e4cf77d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111026 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in cuiNoel
Change-Id: Id73971bdd986101eeb53bf0b140ef6a7c72191a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111025 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17pdfium: eliminate FPDF_SIGNATURE from public headerMiklos Vajna
Change-Id: I9c8297c69ca359d861c8506e41c069692331eb8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111005 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-02-17loplugin:referencecasting in chart2Noel
Change-Id: I4864b5f73a65de04ed3e3524e1331094049b1263 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111002 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in canvasNoel
Change-Id: Ic802d6593db053bb31c3463e67b63399b5f26d67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111001 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in comphelperNoel
Change-Id: If826cd7c6818d9cc0662321ff31e0594fe6d48e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111003 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17loplugin:referencecasting in test..toolkitNoel
Change-Id: Ia290ff4849f4d7eda978c7b1e2c7f36de744056f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110997 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-02-17Move PBM,PPM reader from filter module into VCLTomaž Vajngerl
Change-Id: I1ce998575f8d204045fabea184e80e71308a16b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111019 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move PCD reader from filter module into VCLTomaž Vajngerl
Change-Id: Icd23d1343f5231c09dd8197943ca472f4b573bfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111018 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move PSD reader from filter module into VCLTomaž Vajngerl
Change-Id: I53b11be6e9eb0013f017b2da5745ff525ca79c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111017 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move EPS reader and writer from filter module into VCLTomaž Vajngerl
Change-Id: I1646f72d6a1db176e4520f8f64321646a26f054e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111016 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move RAS and PCX reader from filter module into VCLTomaž Vajngerl
Change-Id: Id846abf257b598489a59ebf9b62b19840a950322 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111015 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move MET reader from filter module into VCLTomaž Vajngerl
Change-Id: I478ef775bc73349094f88012ceb57b1712a27f55 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111012 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move PICT reader from filter module into VCLTomaž Vajngerl
Change-Id: I6d3a28769ff3bffa3970a4ab6ab2384bb0aebbca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111011 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Move TGA reader from filter module into VCLTomaž Vajngerl
Change-Id: I0fea5d6e75c6bfd05ea91ed7b92aaacfcc5ec177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111010 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17vcl: add TIF case to GraphicDescriptorTestTomaž Vajngerl
Change-Id: I2e2724fda545e67777c1101b33cc10483f73b3a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111009 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-02-17Improve code for Protect in viewfunc.cxxAnshu
Change-Id: If197f74945b54675c304d23cac802e3769599554 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110205 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-02-17update Find & Replace icons & Show Drawing iconRizal Muttaqin
Change-Id: Ic9288b85bb5df595cac537988e8fd3db040cb329 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110990 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2021-02-16tdf#137208 Assume that dladdr provides an absolute pathnameStephan Bergmann
3dfb38a45d6495d357c3359b5b02cde871df6f67 "added getUrlFromAddress (#88338#)" had introduced the call to osl_getAbsoluteFileURL for no documented reason, but it looks unlikely that any relevant implementation of dladdr (as called by getModulePathFromAddress; and where dladdr is a non-POSIX extension on the various platforms) would provide pathnames that are relative to the process's CWD. (Instead, add a check whether osl_getFileURLFromSystemPath succeeds.) Change-Id: If291e9fdf63fc3f42ba7c7e3138d7db5328ed165 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111004 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2021-02-16tdf#139511: sd: Add UItestXisco Fauli
Change-Id: I21bd6c0643333cdf98d65b3fa3f141dc6ddfa937 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110982 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16tdf#140252 unit test Controls in Calc are always on layer 'controls'Regina Henschel
This is the missing unit test for the case of drag-created controls in the fix in commit 1d53f3709de2956f14db31677b6c461f33843bd9. Change-Id: I3afce044588e6b5d850d948dd0cbc4df9185029d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110959 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2021-02-16uitest: sc: test charts are pasted in a new document...Xisco Fauli
... when the source sheet has a dot in the name I found this problem while working on another UItest. This started to work after b9652803096b68a33702601aac52e78c8a4250c6 Before this commit, the chart wasn't even pasted, due to a2e6f31c6f90e446d1462e7c80f6b1317f7825bc. Before this commit, the ranges in the pasted chart were incorrect. Not sure when this issue got fixed though. Anyway, let's add a test for it Change-Id: I152d569bfa04a0e3e6056e39b9ee59955bf9e1d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110993 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-02-16WB_HYPHENATION is newly unusedCaolán McNamara
Change-Id: If1fd94b1a0f572fb1bc40f2098079408c9916ce1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110999 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-02-16move FixedImage to toolkit-only headersCaolán McNamara
Change-Id: I7ae18ef3225b4ca1448a2a3b0fccfc2206f7a5ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110995 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>