summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-08-16tdf#119224 start and end are expected to exist for the scope of this functionCaolán McNamara
Change-Id: I771bce68a2ac923af6a7d54646a2c59ce6f10f7e Reviewed-on: https://gerrit.libreoffice.org/59176 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16vcl: support pre-computed glyph items in OutputDevice::ImplLayout()Miklos Vajna
This allows using the SalLayoutGlyphs obtained from GenericSalLayout::GetGlyphs() to return early in GenericSalLayout::LayoutText(). Change-Id: If3a004f983f3578915786668bfcada00227d2eeb Reviewed-on: https://gerrit.libreoffice.org/59169 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-16skip text layout when fuzzingCaolán McNamara
Change-Id: I4d1c0ce31c4bfde0c1c681235868f6e5484fb561 Reviewed-on: https://gerrit.libreoffice.org/59174 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16tdf#118385 Avoid crash on loading documentSzymon Kłos
Change-Id: Ifb18fee79667a5d0284407e84877b0d4d89536d9 Reviewed-on: https://gerrit.libreoffice.org/59173 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-16tdf#118127 fix date format duplications in Hungarian localeLászló Németh
– by adding and using narrow month names "jan."–"dec." (abbreviated month names are still Roman numbers for back-compatibility); – by adding ortographically incorrect, but "interoperable/back-compatible" typewriter & Excel format "YYYY.M.D."; – by replacing one of the "YYYY. MMM. D." by "YYYY. MM. DD.". Other changes: – replacing incorrect "YYYY. M. D." format with the ortographically correct "YYYY. MM. DD." format. We keep its long YYYY format for back-compatibility. (This system format is visible only on the extra page of the Date formatting list, so it's not an annoying duplication.) – abbreviated eras use non-breaking narrow spaces. Note: there is also a not so annoying duplication, the "YYYY-MM-DD HH:MM:SS", not on the first page of the date list in the dialog window and not in the XML file, but only on the second page of the date list. For back-compatibility, we keep this format in the XML file. Change-Id: I4c49d637710295395b75034aa50015a5f3719d89 Reviewed-on: https://gerrit.libreoffice.org/59171 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-08-16ofz#9691 infinite-loopCaolán McNamara
Change-Id: Ifab7271c20104e0e073f68d8a570bceb9d8f387a Reviewed-on: https://gerrit.libreoffice.org/59168 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16tdf#119294: reimplement fix for tdf#118859Mike Kaganski
When removing paragraphs with mail mere fields, both field type reference and node reference could get invalid, because field type will be destroyed when its last field is gone; and node will be destroyed if it is in a fly with anchor in another node which gets destroyed. To avoid use-after-delete, we will use an SwClient on field types, thus detecting if a collected field type got destroyed; iterating over fields using SwIterator is safe, because removing a node with fields would update the iterator. Change-Id: Id8b555ef7015b13ab70ebb41845d34c477ac6b31 Reviewed-on: https://gerrit.libreoffice.org/59164 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-08-16remove mempoolNoel Grandin
we've been using the normal memory allocator instead of the sal slab allocator ever since commit bc6a5d8e79e7d0e7d75ac107aa8e6aa275e434e9 Date: Wed Nov 15 16:52:44 2017 +0530 Disable custom allocator Change-Id: I3383962cedb85d56fbec695398901f6ff7057651 Reviewed-on: https://gerrit.libreoffice.org/58577 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16tdf#119284 bg for automatic not set while editingCaolán McNamara
refactor and reuse fdo#35779 solution for this case Change-Id: I0631cd2560aa2acc2310f95b5c4dea36a2845a58 Reviewed-on: https://gerrit.libreoffice.org/59165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16these only get used if pOL is non-nullCaolán McNamara
Change-Id: I70d38727027d15b0bf3ea2904655f15d9503b681 Reviewed-on: https://gerrit.libreoffice.org/59162 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-08-16Update git submodulesJan Holesovsky
* Update helpcontent2 from branch 'master' - Generate the modules dropdown content on demand too. Change-Id: Ibcbd8faac4f31d41398d8ae98314d83690136ab6 Reviewed-on: https://gerrit.libreoffice.org/59152 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/59153 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-16Adapt castStephan Bergmann
...to 0d227c96e11d7d03829144183bc66d229e059a4b "SvxNumberFormat::nAbsLSpace should have a larger type", from which this was accidentally missing Change-Id: I1d84f8f3545512ca47181b40b56effda39894e67 Reviewed-on: https://gerrit.libreoffice.org/59160 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-16Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' - Fix typo: s/an other/another/g Change-Id: I7cf78bc37d3bdc44a0bfb6fe34a3ef1a53a4a73c Reviewed-on: https://gerrit.libreoffice.org/59103 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-16Adapt external/breakpad/0001-Handle-race-between-ExceptionHandler...Stephan Bergmann
to old compilers that default to < C++11. (Explicitly passing CXXFLAGS_CXX11 into ExternalProject_breakpad wouldn't work well for now, as it would cause -Wregister error with -std=c++17 at workdir/UnpackedTarball/breakpad/src/common/dwarf/dwarf2reader.cc:878:43.) Change-Id: I1d04e0f05e36e2f9622991fb477f430a062fee0b
2018-08-16Update git submodulesJan Holesovsky
* Update helpcontent2 from branch 'master' - Translate the language names in JS. Change-Id: I7185a7d0981abbacef4a152ee6ac5352ebe970cd Reviewed-on: https://gerrit.libreoffice.org/59150 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-16Update git submodulesJan Holesovsky
* Update helpcontent2 from branch 'master' - Don't embed links to all the languages into every page. Change-Id: I31f140919a18db55ef5afab9f229afa7eed3e36c Reviewed-on: https://gerrit.libreoffice.org/59149 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-08-16vcl: introduce a SalLayoutFlags::GlyphItemsOnlyMiklos Vajna
OutputDevice::ImplLayout() does a number of things: first it calls the expensive SalLayout::LayoutText(), then it does a number of remaing tweaks to the resulting SalLayout based on the rLogicalPos and pDXArray parameters. This means that the resulting layout is not easy to reuse for Writer purposes, as it typically operates with the same text multiple times, but with different LogicalPos/DXArray. Add a new flag that returns the glyph items early, with the hope that this way the result only depends on the output device state and the string only, nothing else. Change-Id: I7c4a23d0f230495c8ba0ebbd1cfc3421e4a6e43c Reviewed-on: https://gerrit.libreoffice.org/59159 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-08-16-Werror,-Wmultichar (clang-cl)Stephan Bergmann
(<https://docs.microsoft.com/en-us/cpp/cpp/string-and-character-literals-cpp> specifies that, for MSVC, "Multiple characters in the literal fill corresponding bytes as needed from high-order to low-order.") Change-Id: I192be65adf3bfff1a4d0f0f4862939be2736ffad Reviewed-on: https://gerrit.libreoffice.org/59154 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-16loplugin:reservedid (clang-cl)Stephan Bergmann
Change-Id: I324b93db2040efeff9d56f529df998cb8d64ec03 Reviewed-on: https://gerrit.libreoffice.org/59155 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-16loplugin:returnconstant in dbaccessNoel Grandin
Change-Id: I37b7dc7f0a7786089034acc279cb6ed7a6ef863f Reviewed-on: https://gerrit.libreoffice.org/58426 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16Handle race in external/breakpadStephan Bergmann
...that hit once in a UBSan build in UITest_calc_tests4: > soffice.bin: /data/sbergman/lo-san/core/include/com/sun/star/uno/Reference.h:420: interface_type *com::sun::star::uno::Reference<com::sun::star::xml::crypto::XXMLSecurityContext>::operator->() const [interface_type = com::sun::star::xml::crypto::XXMLSecurityContext]: Assertion `_pInterface != NULL' failed. > warn:desktop:11041:11425:desktop/source/app/sofficemain.cxx:82: minidump generated: /data/sbergman/lo-san/core/workdir/UITest/calc_tests4/user/crash//0585280b-6f1e-fa99-4b711485-60baa6f1.dmp > src/client/linux/handler/exception_handler.cc:367:34: runtime error: member call on null pointer of type 'std::vector<google_breakpad::ExceptionHandler *, std::allocator<google_breakpad::ExceptionHandler *> >' > warn:sal.osl.mutex:11041:11041:sal/osl/unx/mutex.cxx:82: pthread_mutex_destroy failed: Device or resource busy > #0 in google_breakpad::ExceptionHandler::SignalHandler(int, siginfo_t*, void*) at <null> (instdir/program/libsofficeapp.so +0x963904) > warn:unotools.config:11041:11041:unotools/source/config/configmgr.cxx:169: ConfigManager not empty > #1 at <null> (/lib64/libpthread.so.0 +0x11fbf) Change-Id: Icf46adea879c0541a297e5f54f9ce936caa9858b Reviewed-on: https://gerrit.libreoffice.org/59157 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-16-Werror,-Wformat (clang-cl)Stephan Bergmann
Change-Id: I2605d5d9bc201bac8160c96b47c6e03181fcbfc3 Reviewed-on: https://gerrit.libreoffice.org/59156 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-08-16tdf#113608 DOCX import: don't use numbering of removed paragraphsLászló Németh
to avoid direct numbering of the unnumbered paragraphs later using numbering of the removed w:r-less paragraph incorrectly. Test file and clean up by Justin Luth. Change-Id: I821eed11f96e56e945aa88da03cc84e29322195a Reviewed-on: https://gerrit.libreoffice.org/59117 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2018-08-16tdf#116350 Better text layout for big shapesSzymon Kłos
Added some horizontal padding - for bigger shapes and vertical adjustment for multi-line labels. Change-Id: I665b238b0d08a499cd846952d831fe449f72f575 Reviewed-on: https://gerrit.libreoffice.org/58975 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-08-16pass SfxMedium around by std::unique_ptrNoel Grandin
Change-Id: Ibde7b68d9248f80d5304991390a80742265f37b3 Reviewed-on: https://gerrit.libreoffice.org/59031 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in ScOutlineDocFuncNoel Grandin
Change-Id: I036a860bd861f0fa1136d242a5e042c5c56d4226 Reviewed-on: https://gerrit.libreoffice.org/59125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:useuniqueptr in swf::WriterNoel Grandin
Change-Id: Id10d9b120cf81b1576da48840f84353537466d17 Reviewed-on: https://gerrit.libreoffice.org/59027 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16reenable the rest of the fuzzersCaolán McNamara
Change-Id: I84050caa6f606a4a41724620ac5fe716a2a56fb9
2018-08-16loplugin:returnconstant in ScDBDocFuncNoel Grandin
Change-Id: Iaa71bbc2a10e46153209bf3264c74c8ce78f007b Reviewed-on: https://gerrit.libreoffice.org/59124 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16Update git submodulesJan Holesovsky
* Update helpcontent2 from branch 'master' - Let's have Content-Type everywhere. Change-Id: I000658561d76d6a95a4acbc621db5e3f6d081e08 Reviewed-on: https://gerrit.libreoffice.org/59051 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-08-16Update git submodulesJan Holesovsky
* Update helpcontent2 from branch 'master' - Try to detect the system at least a bit. Change-Id: I5c5243d56cf85eeb7cd857c7d9f6da5cd305b429 Reviewed-on: https://gerrit.libreoffice.org/59049 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-08-16Update git submodulesJan Holesovsky
* Update helpcontent2 from branch 'master' - The <version>/index.html can default correctly, no need to do it in the root. Change-Id: If74aaea6924638f9fef647121da4a35c66fc0213 Reviewed-on: https://gerrit.libreoffice.org/59048 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-08-16reenable another bunch of fuzzersCaolán McNamara
Change-Id: Ibee698f8dcc79e1599e9790fb6710f80e22821c3
2018-08-16Update git submodulesJan Holesovsky
* Update helpcontent2 from branch 'master' - Limit the online help only to the built languages. Change-Id: Ib81dbd9a4047d9bb63761a43ef0b183a450b03f1 Reviewed-on: https://gerrit.libreoffice.org/59047 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-08-16xmlsec: replace macOS configure patch with backportMiklos Vajna
Change-Id: I5d3b16e09e585607a4261f8435d032d0d2ae4bd9 Reviewed-on: https://gerrit.libreoffice.org/59146 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-08-16loplugin:useuniqueptr in SwTOXBaseSectionNoel Grandin
Change-Id: I1c4d9cb4189073d83ea2872b87475b8bf79e43db Reviewed-on: https://gerrit.libreoffice.org/59030 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16return std::unique_ptr from CreateOverlayObjectNoel Grandin
Change-Id: Ib4e8849cd82ee0374228405209a33554310579d7 Reviewed-on: https://gerrit.libreoffice.org/59115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in OPropertyBrowserControllerNoel Grandin
Change-Id: Id5e225dbe5a1c2f27c1032cdaab35a01c78ede81 Reviewed-on: https://gerrit.libreoffice.org/59136 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in XclImpChangeTrackNoel Grandin
Change-Id: Ib7670dd3595af4a4aafa2502a5e3b2ed4ad7fe11 Reviewed-on: https://gerrit.libreoffice.org/59135 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in XclExpAutofilterNoel Grandin
Change-Id: Ibd57de5b8309048ec29e869f3058b0a8bb26df71 Reviewed-on: https://gerrit.libreoffice.org/59134 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in ScGridWindowNoel Grandin
Change-Id: I4b7cb0b5346cd21d6aa3b25dbe5e37a107b179b5 Reviewed-on: https://gerrit.libreoffice.org/59133 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16Related tdf#117795: comment fixJulien Nabet
Change-Id: Icf3bb150d0009b50295002a781e71a70a77521fa Reviewed-on: https://gerrit.libreoffice.org/59147 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in ScContentTreeNoel Grandin
Change-Id: Ib3aab99712e40f0b5482f87aaf37d228a72f3684 Reviewed-on: https://gerrit.libreoffice.org/59132 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in ScViewUtilNoel Grandin
Change-Id: Id28d24e05e0f416ffaab4e22ad1189834e1570ab Reviewed-on: https://gerrit.libreoffice.org/59131 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16fix bug in SwCTBWrapper::ImportCustomToolBarNoel Grandin
the code structure here and at the callsite indicats that wants true to mean "successfully imported" Change-Id: Ibe3242e85ed970494c2ee0deb4b898db0fe85d0d Reviewed-on: https://gerrit.libreoffice.org/59130 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in DocxAttributeOutputNoel Grandin
It appears that the last code which returned something other than true from PostponeOLE was removed in commit 21d356f691a7c1859f85a19c79060a3d31cffc21 Date: Fri Feb 28 10:44:53 2014 +0100 sw: export OLE objects outside run properties Change-Id: Ie0197be980014a7ceb58c6b71adf69babd734e4e Reviewed-on: https://gerrit.libreoffice.org/59128 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in PresenterFrameworkObserverNoel Grandin
the Predicate stuff is effectively unused Change-Id: Icdba9872f9915f1c7bae89548343580e97ff5de2 Reviewed-on: https://gerrit.libreoffice.org/59129 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in SwWrtShellNoel Grandin
Change-Id: I1f810108a3c79f4d8b7df6ef1ad755a29dbc62b6 Reviewed-on: https://gerrit.libreoffice.org/59127 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16loplugin:returnconstant in ScTokenConversionNoel Grandin
Change-Id: I17d8d188cb4a51978af41788ee3adf9d221c8bdb Reviewed-on: https://gerrit.libreoffice.org/59126 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-08-16tdf#106572 writerfilter: don't write to dummy paragraphJustin Luth
I found a few existing unit tests that this fixes, and a few unit tests that already worked without this. So something else is at play here, but it doesn't appear to be hurt by this fix since each one still starts with "First Page" style. Change-Id: Idc61279fc5fddc9df62b6ab7a9bcd3822d52cbbb Reviewed-on: https://gerrit.libreoffice.org/59033 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
generated by cgit (git 2.34.1) at 2025-02-27 17:23:52 +0000