summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-03-31tdf#120703 PVS: Silence V575 warningsMike Kaganski
V575 The potential null pointer is passed into 'foo' function Add asserts to those cases that are related to OOM cases. There's nothing to be done if the assertions fail anyway. Change-Id: I92ac95d44f512aa1948b1552b0e1f6da695a9f92 Reviewed-on: https://gerrit.libreoffice.org/70008 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-31tdf#73092 remove remaining shape of the repeating animation.Mark Hung
It is neccessary to set a drawshape to invisible (i.e. remove the effect ) before the drawshape rewind, otherwise it remains at the original place. The timenode container will ask its child to remove the effect after all the child finished, before it start to repeat or it deactivate. Change-Id: Iaef1a8269b61afa0c37b03655e2ea169f1d3c453 Reviewed-on: https://gerrit.libreoffice.org/69543 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2019-03-31tdf#120703 PVS: remove redundant static castsMike Kaganski
V572 It is odd that the object which was created using 'new' operator is immediately cast to another type. Change-Id: I54976062dc3f62eaaa79f89eff54454f0b24ac2c Reviewed-on: https://gerrit.libreoffice.org/69989 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-31license: fix one more internal linkAndras Timar
Change-Id: I22b33d80a65bc55765ff13f39459de6f68485caa
2019-03-30license: fix a few internal linksAndras Timar
Change-Id: I9139bb22881e7761028a7b78ac644bea4f83e35b
2019-03-30tdf#45904 Move XFormLayerAccess Java tests to C++Jens Carl
Move XFormLayerAccess Java tests to C++ for ScViewPaneObj. Change-Id: I7ed6ff51d435b6f3de85daec99a13583e50a450a Reviewed-on: https://gerrit.libreoffice.org/69942 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-30license: update 'Dictionaries' sectionAndras Timar
Change-Id: I18ec509ffac02bba0fd6191041a8f994034c8e74
2019-03-30Fix typoAndrea Gelmini
Change-Id: If908885fe642e0222f53d57e25ce9dab81bf27d5 Reviewed-on: https://gerrit.libreoffice.org/69973 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-30tdf#123912 ww8 export: re-protect implicit sectionJustin Luth
Sections should retain their protected on/off status regardless of the value of PROTECT_FORM. However, if there ARE no sections, then the implicit section should use the document settings. The same is true for the pseudo -1 section which I believe can only be the last section (the fragment of the implicit section that follows the last real section). This is basically a revert of LO 6.2 commit fa667b6dc410f3af57ef436cc117352c829f95e7, restoring the previous behaviour in the case of the implicit section. Change-Id: If0b473445e0add017504a3cb61b63116f92be5ce Reviewed-on: https://gerrit.libreoffice.org/69957 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-03-30uitest for bug tdf#122509Zdeněk Crhonek
Change-Id: Ie8b53cc693421fd18901b73b911ac2e9e0533281 Reviewed-on: https://gerrit.libreoffice.org/69937 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-03-30Some refactor of lockfile classes to minimize interfaceMike Kaganski
Change-Id: Icc67c31d6a2351b6504429e25067c25353233f5f Reviewed-on: https://gerrit.libreoffice.org/69947 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-30Slightly simplify URL handlingMike Kaganski
Change-Id: Ie63745c1cb826399dc78f93ebb21af8d165c4bff Reviewed-on: https://gerrit.libreoffice.org/69946 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-30Fix typoAndrea Gelmini
Change-Id: I67e15931dbf4d7e7045395698030c7ae01435be7 Reviewed-on: https://gerrit.libreoffice.org/69944 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-30tdf#122056: Catch DisposedExceptions everywhereKatarina Behrens
Change-Id: I6bdb9aa89a8a5181b096f47f90ab6fb5711e7447 Reviewed-on: https://gerrit.libreoffice.org/69541 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2019-03-30uitest for bug tdf#123479Zdeněk Crhonek
Change-Id: I836ab17dbb6cbeaf62462cfac90d3c9ac1c890a9 Reviewed-on: https://gerrit.libreoffice.org/69940 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-03-30Sifr icon theme updateandreas kainz
Change-Id: Ifc05c6424588c1485bcb3372c90c11e3f1f1d410 Reviewed-on: https://gerrit.libreoffice.org/69943 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-30ios theme definition: file rename svgx -> svgTomaž Vajngerl
Change-Id: I9bebc4405185496b8243e6f7951a2a9f0b6559fb Reviewed-on: https://gerrit.libreoffice.org/69932 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-30add sifr_svg icon theme to buildTomaž Vajngerl
Change-Id: Ia20647012cee1d25823779b7384c5fd43b4e1712 Reviewed-on: https://gerrit.libreoffice.org/69923 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-30tdf#124292 Qt5 / KDE5 disable Qt's HiDPI scalingJan-Marek Glogowski
LO does its own layouting and also all the scaling, so disable the automatic HiDPI scaling explicitly. Otherwise fonts will be rendered in LoDPI and just scaled as an image, if UI scaling is enabled in KDE, resulting in really blocky / ugly fonts. Change-Id: I38503ce27c1671e80d0749d21c6c6dcff1a808a6 Reviewed-on: https://gerrit.libreoffice.org/69941 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-03-29Move UNO Api helper form to include/Jens Carl
Move UNO Api helper form to include/, so it can be used outside of directory test/. Change-Id: I9392f44df8a93d2b5ee092b0458aeef12f99fc7a Reviewed-on: https://gerrit.libreoffice.org/69936 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-29Accessible Descriptions are supposed to be human text (and translated)Caolán McNamara
Change-Id: I75e839d9276e98af0b255c2e40f30c42a700ff29 Reviewed-on: https://gerrit.libreoffice.org/69935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-29prefer help strings to a11y strings when availableCaolán McNamara
Change-Id: I50b36f697b8dd9ff8108392d48a7050702edbfbe Reviewed-on: https://gerrit.libreoffice.org/69934 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-29Remove now moot commentEike Rathke
That compiler workaround isn't necessary anymore since at least commit 9894f158a287bdfe9933df96ab117a9527e9195b CommitDate: Sat Apr 21 12:51:13 2012 +0200 simplify lifetime management of some variables that changed the array form to a simple instance. Change-Id: Ic11fa8422c0be62f24e2135298104123d23c8d2f
2019-03-29tdf#115843 avoid using transparent virtualdevice when 100% opaqueCaolán McNamara
which for the common case avoids the narrowing of hidpi outputdevices through non-hidpi bitmaps Change-Id: Ibdc004a0946e8cb118818e58a01e5791c869353a Reviewed-on: https://gerrit.libreoffice.org/69930 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-29copy between the outputdevices without interim BitmapCaolán McNamara
Change-Id: I6c0097b1b069cad2771c94210986714d59431e4f Reviewed-on: https://gerrit.libreoffice.org/69929 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-29tdf#124410 re-call SetScrollBarRange when aSymbolSet changesCaolán McNamara
and do the work that depends on size happen at size-changed instead of first-draw Change-Id: Ia2605ba9bb875be9248a009a6f26f01cbbbd4632 Reviewed-on: https://gerrit.libreoffice.org/69928 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-29fix testConvert for OpenGLTomaž Vajngerl
Change-Id: Id78ef9fd05bc158b52aa465c932869c0ef1c55d7 Reviewed-on: https://gerrit.libreoffice.org/69921 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-29add bitmap test with a custom 8bit paletteTomaž Vajngerl
Change-Id: I83d7f1f28c7b0dc707ef26675449d5f3654dacda Reviewed-on: https://gerrit.libreoffice.org/69922 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-29tdf#124149 add bigger 32px icons for border line and shadowTomaž Vajngerl
Change-Id: I7ea382f3ba648657d2a6d009bf90dcc3be879c63 Reviewed-on: https://gerrit.libreoffice.org/69925 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-03-29tdf#107966 vcl opengl: fix not drawn 1px wide polypolygonsMiklos Vajna
Visible at e.g. in Calc: Format Cells/Borders/Line Styles. The problem was that first commit 2e99e4e11d33679aed674eea0d6054d16d39d6df (opengl: use MVP matrix in vertex shaders, pixel offsets, 2015-07-08) introduced the concept of pixel offsets, setting the value (implicitly) to 0 in OpenGLSalGraphicsImpl::DrawTrapezoid(), but using 0.5 in OpenGLSalGraphicsImpl::FlushLinesOrTriangles(). This is fine, but then later commit 2003076c4318511a3d621558d3b44b4e8e6c6529 (opengl: batch draw polypolygons, 2016-05-29) changed OpenGLSalGraphicsImpl::drawPolyPolygon() to use deferred drawing instead of DrawTrapezoid(), without doing any translation of the input polypolygon. This resulted in loss of those polygons when used in the above mentioned dialog, which has a listbox of bitmaps, where each line style preview is drawn on a virtual device with a height of 1px. So at the end the 1px offset meant the previews were simply missing. ('make CppunitTest_vcl_gen SAL_USE_VCLPLUGIN=gen SAL_FORCEGL=1' is needed on Linux to see the test failing without the fix.) Change-Id: Ia9f3d6e7cb38a43fe2f8a41746b538af68add43c Reviewed-on: https://gerrit.libreoffice.org/69920 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-29Resolves: tdf#124410 crash cell border page with diagonal bordersCaolán McNamara
Change-Id: I0fd8738d42ad33f029381dae0ec9f41e7912b72c Reviewed-on: https://gerrit.libreoffice.org/69918 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-29Add RedactDoc to Tools menu of ImpressMuhammet Kara
Now that we have redaction enabled for Impress, after commit 33e840896a69a66c44e74beb995d558735fb84ad, let's sync the Impress Tools menu with Writer and Calc. Change-Id: I1aaf29e5ea0ddb07b1f3b6ef98e017904896fcd4 Reviewed-on: https://gerrit.libreoffice.org/69911 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-03-29tdf#42949 Fix IWYU warnings in include/sfx2/[n-r]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia2bea9bd4775f4ed5ef0133971106a6c0bfdd1c0 Reviewed-on: https://gerrit.libreoffice.org/69896 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-29tdf#114311 Translate "LibreOffice Extension" file type in WindowsTakeshi Abe
Change-Id: I5e2f222449424d4a6498d8566f13aca7f07c0c51 Reviewed-on: https://gerrit.libreoffice.org/68303 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-29preload: cleanup disabled messages and simplify flow.Michael Meeks
Change-Id: I249b81afe5ec2fab5e0aaf73a2cde62173fa803e Reviewed-on: https://gerrit.libreoffice.org/69912 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-03-29Enable redaction for ImpressMuhammet Kara
After the commit c2330b14e2bfa170131a83c375ec0b1a91c95415, different page sizes and orientations are handled properly, and Impress pages are converted to Draw perfectly. Change-Id: Ib9ab6b298e12fc0d8e9440bf63f31ad6dd05ab35 Reviewed-on: https://gerrit.libreoffice.org/69910 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-03-29tdf#124384 sw DOCX: fix crash during bibliography loadingSerge Krot
Change-Id: Ic0c4b6f7480a4c6c3f53bd04e285cb0cab172531 Reviewed-on: https://gerrit.libreoffice.org/69888 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-03-29Handle different page sizes for redactionMuhammet Kara
Change-Id: I7136717936668fbb1d87b5d9491430c13c5e73fd Reviewed-on: https://gerrit.libreoffice.org/69909 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2019-03-29check that jpeg export of 8bit grayscale worksLuboš Luňák
This is a simpler check for 77146ca8193a8e258dbb0dae0793497a66734ff1 (related to tdf#121615). Change-Id: I33b92f07bebeb735466e0728c6c51b79fc0b5bb8 Reviewed-on: https://gerrit.libreoffice.org/69820 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-03-29sw btlr writing mode: implement DOC filterMiklos Vajna
Replace WW8TabDesc::Start/EndMiserableHackForUnsupportedDirection() added in commit 69ba46df8be261e665214390cd57a141ad65c210 (INTEGRATION: CWS vertcell (1.95.32); FILE MERGED, 2004-04-21) with the usage of the new writing direction. Adapt export accordingly. Change-Id: Ic85b69c806fbd1c1b4eb21cff3ee46dd5da497e8 Reviewed-on: https://gerrit.libreoffice.org/69901 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-29tdf#108523 Removed @author annotationsJaromir Wysoglad
Change-Id: I5905dd94843595b229046c0b4a0f16181c16fd9e Reviewed-on: https://gerrit.libreoffice.org/69869 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-29tdf#84635 quadratic slowdown on loading large tablesNoel Grandin
skip the re-registration scan in SwTableBox::ChgFrameFormat, which we don't need since we are creating this table for the first time On my machine, loading the 69 page file goes from 40.9s to 30.4s loading the 128 page file goes from 79.1s to 45.1s Change-Id: Id9e48256556e19eca34a892b29beff7eab9f51f1 Reviewed-on: https://gerrit.libreoffice.org/69885 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-29loplugin:useuniqueptr in PDFReaderNoel Grandin
Change-Id: I22a96bbf9266cc8dfbe223b985d0ba005a6367e9 Reviewed-on: https://gerrit.libreoffice.org/69881 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-29Fix typoAndrea Gelmini
Change-Id: I334a253dcbf6aef8b182e249605b625b89347450 Reviewed-on: https://gerrit.libreoffice.org/69908 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-29GTK use SalYieldMutex lock argumentsJan-Marek Glogowski
The acquire and release functions already provide arguments to release and re-acquire the lock, so use these. Also moves the n-1 lock handling from release into acquire. This way release doesn't need any special handling, which acquire already does. Change-Id: If2fc92beb8e3ea1f5c078da4d8dde3ce9c774c6f Reviewed-on: https://gerrit.libreoffice.org/69574 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-03-29tdf#45904 Move XNamed Java tests to C++Jens Carl
Move XNamed Java tests to C++ for ScSheetLinkObj. Change-Id: I64904ed6bae1b96767f8b0a65b0850a8694b10c2 Reviewed-on: https://gerrit.libreoffice.org/69907 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-29tdf#45904 Move XRefreshable Java tests to C++Jens Carl
Move XRefreshable Java tests to C++ for ScSheetLinkObj. Change-Id: I8225a3eb8be903ebcf51950431a5f6810a5aaa4f Reviewed-on: https://gerrit.libreoffice.org/69906 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-29tdf#45904 Move XShapes Java tests to C++Jens Carl
Move XShapes Java tests to C++ for ScDrawPageObj. Change-Id: I1b65e8ad685c3d387a5023e8e8e9b9e06627af11 Reviewed-on: https://gerrit.libreoffice.org/69904 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-03-28tdf#124286 fix annoying rounding error.Winfried Donkers
In case of ROUNDDOWN and ROUNDUP, it is possible that seemingly clear decimal values are rounded unexpectedly (from the user's POV). This is caused by the i decimal to binary to decimal conversions. By rounding to 12 significanr digits before calling the round-down of -up function, most of these unexpected roundings are eliminated. Change-Id: Ia19181383b77e1ff40a067c4a1cea1ece0955871 Reviewed-on: https://gerrit.libreoffice.org/69762 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-03-28tdf#120660: Populate rNewSharedRows even if no FC...Dennis Francis
at specified position. At least in case of ScUndoPaste, during undo operation, the content from changed area in main-document is removed before actual undo-paste, so when cloned formula-cell from undo-doc is inserted to main-doc, there is no "old" cell to detach, so "rNewSharedRows" is not populated which is needed for proper re-establishment of listeners if there are formula/ formula-groups adjacent to insertion position. Change-Id: Id2bfb65a2a7a5abb03effbdcc4405015fddc401c Next: fix the vector version of this case and write unit tests. Reviewed-on: https://gerrit.libreoffice.org/69737 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-28 11:01:32 +0000