summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-01-18android: use unified headers and llvm-c++ STL (x86) with NDK 16Christian Lohmaier
gnustl (and others) are to be removed in future versions of the ndk also bump gradle and build-tools to current versions along with it arm unfortunately crashes with llvm-c++, so keep with gnustl for now/fix that later Change-Id: Ic794c3293b599b77ec48096bf3283a99c09cbb79 Reviewed-on: https://gerrit.libreoffice.org/45163 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-01-18lokdialog: No modal mode in LOKPranav Kant
... otherwise the cursor in the document goes invisible as soon as the dialog is launched. Change-Id: I77bc30879550b354e1a9593db3c2db7ad3c68193 Reviewed-on: https://gerrit.libreoffice.org/48126 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-01-18ofz#5462 Direct-leakCaolán McNamara
Change-Id: Ic2b7d139ebb6e88fac5cf9f4cf8dbec26905bcdc Reviewed-on: https://gerrit.libreoffice.org/48097 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-18use string-resource with placeholder instead of hardcoded concatenationChristian Lohmaier
as this is more l10n/translation friendly Change-Id: I1050fb24e0d6e94a2f1ad1605003a9c7010ca7cb
2018-01-18CheckLinkFormulaNeedingCheck() for .xls cell formulasEike Rathke
Change-Id: I2587fbc4fec39b6f2c8e733331815a2953dee308
2018-01-18iOS, readded function declaration.jan Iversen
Function declaration got lost in the different gerrit patches Change-Id: Iec2b0449c0c6e41fb1b5568d6f5651b697a2daa5
2018-01-18Revert "lok dialog: enable MessageDialog tunneling"Miklos Vajna
This reverts the translations submodule change of commit 072e3ce1cfea5bb61cc5f3001c288df6deb45613, which was not intentional. Change-Id: Icdeefe17e2d70b62221b61419b45e18e1317fb9a
2018-01-18iOS, directory creation as part of setupjan Iversen
Corrected sequence for creating directories Change-Id: I7a148b5568694c67e382e75a2e1629d3e23bf197
2018-01-18iOS: add a temporarily exposed function that calls ↵Jon Nermut
CallbackFlushHandler::Invoke in order to manually flush the callback queue. To be reverted once the callback problem is solved. Change-Id: I95273b8a01eec62f639edd6767f69e02a294d8aa Reviewed-on: https://gerrit.libreoffice.org/48101 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2018-01-18iOS, avoid racing conflict in dependenciesjan Iversen
WORDIR might be deleted, but generated kept, situation solved Change-Id: I5847d590affa7f80ef734bf314dbee9a6fc81669
2018-01-18Typo: rDesciprtor->rDescriptorJulien Nabet
Change-Id: I71987a989e204c9b4039c8a046e55a0857ad8889 Reviewed-on: https://gerrit.libreoffice.org/48092 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-18Revert part of 970b76816a03be0f57f35a790bea57bf299e344bJulien Nabet
Change-Id: If75ec666c0872875ab4e84e70424e540d44bc360 Reviewed-on: https://gerrit.libreoffice.org/48104 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-01-18iOS: keep track of the keyboard, and scroll the next search result into ↵Jon Nermut
view. Reimplement RenderCache (+2 squashed commits) Squashed commits: [3c3f36f] iOS: quieten warnings [8eae946] iOS: display search results in an overlay view Change-Id: I04a38943d5a22b8e6a52ae854e65f01bf43fda7b Reviewed-on: https://gerrit.libreoffice.org/48100 Reviewed-by: jan iversen <jani@libreoffice.org> Tested-by: jan iversen <jani@libreoffice.org>
2018-01-18lok dialog: enable MessageDialog tunnelingHenry Castro
Change-Id: I05b270a19e29c5ed3a2482fd8163e61e66bfdf74 Reviewed-on: https://gerrit.libreoffice.org/47772 Reviewed-by: pranavk <pranavk@collabora.co.uk> Tested-by: pranavk <pranavk@collabora.co.uk>
2018-01-18android: fix some layout issues with new-document buttonsChristian Lohmaier
functionality to create new documents was added for tdf#106325 with commit 1503769fe15c122ff2bb8f6f7e7b4ab72656ddc2 However the commit had some issues, most notably clipping of the shadow effect and alignment issues to to scaling down (via the animation effect, took me quite a while until I looked at that) with having a centered pivot. I think it was due to those alignment issues that the label was set to a fixed with - which is a problem for future translation. This commit: * changes the animation to not scale down the initial views * changes the FABs' setting to use compatPadding - this not only ensures enough room for the shadow, but also allows for consistent look across android versions. Side effect is that it needs more height, so * the effect was adjusted accordingly, to shrink to/expand from the lower-right corner of the parent view, instead of "mid-air" * the labels were given a proper background drawable with rounded corners and some padding for a (much more9 polished look * formatting of the labels was split out to a style, for ease of tweaking the looks * add tools:visibility statement to see the elements in layout editor * fixed the strings for the labels (and ID) to some less awkward ones Change-Id: Ifd2d90ec8d23e40603edff19c9af9e0b32090c9f Reviewed-on: https://gerrit.libreoffice.org/42033 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-01-18tdf#112140 fix some NPEs re touch/zoom while doucment is not readyChristian Lohmaier
touching the screen or trying to zoom were trying to get/adjust zoom factor despite not ready yet, similarily swiping from the left to show the parts view would crash as well in case the document is not ready yet. Most likely to see this with a debug build (where loading is slower to begin with), or with long documents like the license text. Change-Id: Iea5e8c07a9b0973ce50f90114eb015e8e896e390 Reviewed-on: https://gerrit.libreoffice.org/46848 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2018-01-18tdf#76817 ooxmlexport: only use stylename for Outline listJustin Luth
In LibreOffice, the special, built-in, Outline numbering style ("Chapter Numbering") is connected via the paragraph style to control the numbering. Thus, only the ParaStyleName should be written to the paragraph properties, and not the direct numbering properties. Both MSO and LO get confused when there are multiple definitions for outline numbering. Change-Id: I1af54fdea164d68e5e156c256b478e518daa5e99 Reviewed-on: https://gerrit.libreoffice.org/47828 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-18Fix typosAndrea Gelmini
Change-Id: I7aa101a5e1e47118ab94527eb37269dd7e544cf4 Reviewed-on: https://gerrit.libreoffice.org/48093 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-18sw: Actually only .uno:StyleApply and .uno:StyleWatercanMode can return...Jan Holesovsky
...a value, at least according to sfx2/sdi/sfx.sdi. Change-Id: I1a12c025386cfc6eae529782cdb69207ffa388c5 Reviewed-on: https://gerrit.libreoffice.org/48041 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-18clang-format: allow just listing formatted filesMiklos Vajna
Without running clang-format on them. Also format one file at a time, so we don't run into command line length limits as the number of formatted files grows. Change-Id: Ie559d566db784e04965678f056dcb81cefe95378 Reviewed-on: https://gerrit.libreoffice.org/48085 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-18framework: disable layout manager in hidden framesMiklos Vajna
The point of hidden frames is that they are not visible on the UI, only their doc model / layout is accessible via the API or file format conversion. That means that laying out the UI elements like menus and toolbars is pointless. So change Frame::initialize() and Frame::setLayoutManager() to not enable the layout manager for hidden frames. To do this, we need a new window style flag, as both hidden and visible frames have an underlying hidden window at the time the framework layout manager would be enabled. Times for 200 hello world inputs: 5780 -> 5054 ms is spent in XHTML-load + ODT export + close (87% of original). Change-Id: I841507bbb62f8fc2979d20e2d579d0bb47b98f37 Reviewed-on: https://gerrit.libreoffice.org/48068 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-18Fix Android build (missing std::trunc)Stephan Bergmann
...after 110025afab3946586826b18a316416fba41dc1f6 "Odd conversion double -> sal_Int32 -> double" Change-Id: Iaff78e2046261290f8c4ae8bdfcbf1edc5963d87
2018-01-18lokdialog: Convert the Format -> Bullets and Numbering... dialog to async execJan Holesovsky
Change-Id: I01886ca1f0d7942450838e5f2de4700bdf81150f Reviewed-on: https://gerrit.libreoffice.org/48029 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-18Fix typosAndrea Gelmini
Change-Id: Iaad78e5f1100df1ca69d34bf7693e4a9feac17eb Reviewed-on: https://gerrit.libreoffice.org/48084 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-18sfx2 store: create temp files next to local files (storage case)Miklos Vajna
This is similar to commit 5259ab8104cfba60c40748ed0cd59d93df038c5b (sfx2 store: create temp files next to local files, 2018-01-08), except there only the stream case was handled (e.g. sw HTML export), while this is the storage case (e.g. ODT export). Change-Id: I88d78aa0f09e9fdfdd27cd0fad1a2633ff54d576 Reviewed-on: https://gerrit.libreoffice.org/48071 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-18Replace OUStringBuffer in valueacc (svtools)Julien Nabet
Change-Id: I8b40c0c29154e8b4162e55dc202bfb0233c79a61 Reviewed-on: https://gerrit.libreoffice.org/48072 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-18Odd conversion double -> sal_Int32 -> doubleStephan Bergmann
...which had been introduced into that assignment in ScDataPilotFieldObj::createDateGroup with 7dd50f9ec124f2666dcfd1fd8bb02a1335a360ac "CWS-TOOLING: integrate CWS dr67", but for no documented purpose. So lets assume the truncation is for a reason, and replace it with a call to std::trunc. Change-Id: I2dfd4c0f5966e9ab294ecd5b3424fece2ea70daa Reviewed-on: https://gerrit.libreoffice.org/47995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-01-17sal: use snprintf for sal logThorsten Behrens
Change-Id: I0fe7029991052a59ee56cef1897cf6688bfa24b9 Reviewed-on: https://gerrit.libreoffice.org/48083 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-01-17CheckLinkFormulaNeedingCheck() for .xlsx cell formulasEike Rathke
Change-Id: Ia6dd195f7eb4d43483e87eeca59f651e7bf2dcb8
2018-01-17Move implementation to CheckLinkFormulaNeedingCheck() for further reuseEike Rathke
Change-Id: I541d2b6e12a88371c064b901b00e71206ee0c18e
2018-01-17coverity#1427627 'Constant' variable guards dead codeCaolán McNamara
Change-Id: I1b286dbacdcff35baf7c7802eec85859ae8e78c2 Reviewed-on: https://gerrit.libreoffice.org/48052 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-17Fix typosAndrea Gelmini
Change-Id: I6f2822e7068754a1b5e70e401247a36b214147e3 Reviewed-on: https://gerrit.libreoffice.org/48079 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-17Fix typosAndrea Gelmini
Change-Id: I18ce04cbaa79c827a52e2441e98ee2e3377b5877 Reviewed-on: https://gerrit.libreoffice.org/48077 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-17Fix typosAndrea Gelmini
Change-Id: Id1c7ddf6c49ec709e38947a82731fe31a64aad04 Reviewed-on: https://gerrit.libreoffice.org/48076 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-17xmlsecurity: cleanup commentThorsten Behrens
Change-Id: I1e34e1c4c51411be3de2dbd417126d263713c88a
2018-01-17WNT: allow to set log level/path from fileSamuel Mehrbrodt
Expects a file logging.ini in the program/ directory with the keys LogFilePath and LogLevel, e.g.: LogFilePath=C:\log.txt LogLevel=info Note: This is Windows-only for now. En passant remove extraneous newlines from syslog and android log calls. Change-Id: I35c730469e4079139da908aa287b989dc98e0f9d
2018-01-17Use for-range loops in QueryDesignView (dbaccess)Julien Nabet
Change-Id: I713654ad7f1139c6f0cb46304a6958020c37f9c7 Reviewed-on: https://gerrit.libreoffice.org/48069 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-17use the same shade of grey as Online UI usesAndras Timar
Change-Id: Idb6dc80f4943323f80bc6851bc184798627722ef Reviewed-on: https://gerrit.libreoffice.org/48056 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-01-17Updated coreLászló Németh
Project: dictionaries 96f0ddc0c4ddfc6f9fa1c94d5844469c1911e712 tdf#95024 fix Hungarian Lightproof module - by removing the obsolete date rule for "1st of month": for example, "január 1-e", "február 1-én" are correct forms already - add new date rules for days with bad affixation (typical mistake after a search & replace): "1-a, 1-án, 1-ára, 1-ához, 3-e, 3-én, 3-ére, 3-éhez etc." Change-Id: If5fcaf4fe693fa7d30aa5c6332975a513d13a0cf Reviewed-on: https://gerrit.libreoffice.org/48074 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2018-01-17tdf#115013: quote columns with spaces and properly escape charactersMike Kaganski
Unit test updated Change-Id: If36c90c0ff372ce45666674d2487e6edf2536dbf Reviewed-on: https://gerrit.libreoffice.org/48038 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-17ofz#5444 asserts and Null-dereference READCaolán McNamara
Change-Id: I35f31e8553045ae61f39dd5679af638ddc3364d8 Reviewed-on: https://gerrit.libreoffice.org/48059 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-17writerfilter: remove unused sStyleName1Justin Luth
Both sStyleName and sStyleName1 were part of the original fork from the OOo project. I'm not sure if/how it was ever used, but sStyleName1 is unused now. Change-Id: I71b54645aa0615101529aa4d5008973f740da1f0 Reviewed-on: https://gerrit.libreoffice.org/48036 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-01-17NFC writerfilter: remove redundant sStyleIdentifierIJustin Luth
Originally, StyleIdentiferI was the string name, and StyleIdentifierD was an integer. That changed a long time ago. Both identifiers are only assigned a value once, and both are given identical values at the same time. Thus, one is completely redundant and is being removed. Change-Id: Ia7e9bbeec53110fa8e56cdfb13b9871486f335fa Reviewed-on: https://gerrit.libreoffice.org/48035 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2018-01-17Silence MSVC warning C4701Stephan Bergmann
..."potentially uninitialized local variable 'nProgressReference' used" after 49f05934edd3723666b7c52eccbf4d0c9a688eb7 "coverity#1427629 Unchecked return value" Change-Id: I710221f730c1c8fb416378de1a57f7e713244cef
2018-01-17ofz#5447 on plcf save force current Fkp to stick in cacheCaolán McNamara
Change-Id: Id7b6c442df10c6de7226702a9bf3ba559a0c2e9a Reviewed-on: https://gerrit.libreoffice.org/48040 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-17coverity#1427632 try silencing Using invalid iteratorCaolán McNamara
Change-Id: I74387fd761f170d61e490418f856bfffd5dd8401
2018-01-17coverity#1427628 Dereference before null checkCaolán McNamara
Change-Id: Ic68d765cc21733ba864b78c135eaae4ec673e7c1
2018-01-17coverity#1427629 Unchecked return valueCaolán McNamara
Change-Id: If12d57826817d5ca866ecc14d81b21f494ff4487
2018-01-17Use ROUNDSIG(...,13) to hopefully fix Jenkins lo_callgrind_linux buildsEike Rathke
Since commit b97a0df0f3234b4c1140ba1418d4b96a592afa4a lo_callgrind_linux builds fail (some of) these tests, https://ci.libreoffice.org/job/lo_callgrind_linux/4939/ This is a blind shot in the air, let's see if the bullet lands. Change-Id: I4eb96746b58f24be62a47099887d5785e3bc28d0
2018-01-17coverity#1427630 Unchecked return valueCaolán McNamara
Change-Id: If92d5b080ce9a4e28fe15da1448f74ecf0a31257