summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-11-01use officecfg for Experimental flagNoel Grandin
move IsShowOutlineContentVisibilityButton out of header to avoid having to add extra include paths to all the unit test makefiles. Change-Id: I2763390e07cd85b8f09b6f2ad7702039daecb22f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105100 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-01Resolves tdf#137880 - Fix for Windows installer imageHeiko Tietze
Change-Id: I0d57fb54343059bc30d032ae7d4bdbbd3c4c5c70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105131 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-11-01tdf#136814 Fix border padding in Word exportSven Lüppken
While converting twips to points in the Word export filer, information is lost due to integer division. This patch tries to fix this by using floating-point division and (hopefully) proper rounding. The example document attached to the bug ticket works as expected now. Change-Id: I4b5b2163e42932b5e877726d16635d9f02a43cb2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105128 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-11-01Use save_CFLAGS etc in a uniform wayTor Lillqvist
Restore the old CFLAGS (etc) as soon as possible. Always use the same variable names for the saved values. Change-Id: I523bbf66ec5400d24993b7e11e444bb63d61751e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105130 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-01Don't try to include hicolor SVG mimetypes icons in rpmChris Mayo
The icons in scalable/mimetypes were multi-image developer files removed from installation in: f9ddaae9caa5 ("tdf#132737: Don't install SVG source icons or locolor theme", 2020-10-14) Change-Id: I6c7eda89a145365ffb598a066b7e817f27f4ea9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105081 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-11-01Colibre: Update Thesaurus iconsRizal Muttaqin
Change-Id: I8ef183715fa328788ecb2aceef9e9f274b098b25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105129 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-11-01Find ODBC headers when building for Windows on WSL, tooTor Lillqvist
Change-Id: I3a05def839c14d59545c4891418577ed36f2b8cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105099 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-01sw/source/core/doc: Stop abusing observer pattern for code obfuscation.Bjoern Michaelsen
The old SwClient/SwModify combo is a questionable implementation of the observer pattern (among other things). The one thing the observer pattern is good for is dependency inversion: The creator of the message does not need to know the type of the receiver. Calling the message handling on the receiver directly introduces tight coupling and entirely defeats the purpose, leaving us with the worst of both worlds. In such case, at least be honest about the tight coupling and call a somewhat more explicit member function of the target. Thus introduce SwFootNoteInfo::UpdateFormatOrAttr, SwContentNode::UpdateAttr, remove some useless SwFormatChg clutter in Set{Foot,End}NodeInfo, and check for some invariants in SwContentNode::SwClientNotify to limit some of the "a message are two void pointers" madness. Change-Id: I32a8d6973231bb5f65c9e144be72d5bcf98f3f44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105104 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-01SwFormat: remove last ModifyNotificationBjoern Michaelsen
Change-Id: Iaa2b7710c7848855541bd3ea5fd83122077253bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105105 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-01Fix typoAndrea Gelmini
Change-Id: If2f4e9af927be2f335bdbbf0d81f8a89cc8b9019 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105127 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-11-01Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 79d9996623c1896170aec53c788f9623df7731e0 - Mostly resolved: tdf#135668 - Help for Navigator context menus in Content View 1. Placed under "Content View" control, because seems most closely linked to that. 2. Separate rows for general categories (e.g., "Headings", "Tables") and specific items in the categories (because (a) there are context menus for both and (b) they are different). 3. Provide links to items already explained in the Navigator page (e.g., Outline Level). 4. Collected Frames, Images, OLE Objects, Bookmarks together, because they have identical context menus, but the ones that follow are different. 5. Collected "References" and "Indexes" together, because they have identical context menus. 6 Provide links to other pages when relevant (e.g., Send Outline to Clipboard). 7. Make new page for Outline Content Visibility (separate patch), with link from Context Menu. 8. "Outline Tracking" (new feature in 7.0) - add a heading and explanation at end of help page (Thanks to Jim Raykowski for advice and accuracy control). Design decisions: 1. Do not explain "Go to", "Select", "Edit", "Delete", "Rename" (because it is contextual; should be easy to understand their meaning in context) 2. Do not explain "Collapse/Expand All" (should be understandable from use/context) Result: Handles all context menus for Categories in Navigator. Added: "Related Topics" Section, with links to: Arranging Chapters in Navigator Navigator for Document Overview Inserting Hyperlinks with Navigator Showing, Docking and Hiding Windows Changed: <note> about context menus to <paragraph> and moved from top of page down to heading on Content View. Moved: <note> about hidden items to end of "Content View" section. Revised: <paragraph> about searching with Navigate by, which replaced a tearaway Navigation toolbar. Change-Id: I965753234b9faec32fdf6d75766023b2f4b36643 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104596 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-10-31Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to a83bcba219360d50b1b38de99be6ae08a49ce500 - tdf#137724 repair access command to Basic Macro editing in Calc * change two menu command sequences + add step about selecting where Module is stored. - remove a word from a menu sequence + <menuitem> Change-Id: I694e544de5977a1ca74b5a3ae572a944f148b830 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104951 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-10-31Enquote sheet name if necessary, tdf#137896 follow-upEike Rathke
Change-Id: I9ebdc30bf0b8b1531d57da299146fda9871442ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105126 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-10-31tdf#121553: Firebird, fix datatypes managementJulien Nabet
In Firebird, BLOB and CLOB are both "BLOB" types but can be distinguished with SUB_TYPE - BINARY for BLOB - TEXT for CLOB ("C" = "Character" -> Text) To deal with this, the enum "BlobSubtype" has been created in connectivity/source/drivers/firebird/Util.hxx it contains: - Blob = 0 - Clob = 1 but also - Image = -9546 This last one is to deal with LONGVARBINARY which doesn't exist in Firebird It has been added with: see https://cgit.freedesktop.org/libreoffice/core/commit/?id=0217031a98508731f15df9d361a6e5b584db5716) When creating a table, Tables::createStandardColumnPart was adding SUB_TYPE part in request part but only when creating table not when altering table. So let's deal with subtypes in the 2 mappings: - ODatabaseMetaData::getTypeInfo from DatabaseMetaData.cxx - ColumnTypeInfo::getColumnTypeName from Utils.cxx and let's remove the SUB_TYPE wrong management part from Tables::createStandardColumnPart Also, BINARY and VARBINARY were wrongly mapped since they should be respectively: - CHAR CHARACTER SET OCTETS - VARCHAR CHARACTER SET OCTETS It also showed that DataType::VARBINARY was missing in ColumnTypeInfo::getColumnTypeName() change from my previous commit see: https://cgit.freedesktop.org/libreoffice/core/commit/?id=5b33b1a6b0f251202e89cef436efd4719c3fc0c4 Change-Id: I5589fd4f781671076f534865cfe9d30943738fd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105107 Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Jenkins
2020-10-31Use ScDocument::GetSheetSeparator()Eike Rathke
Change-Id: Ib83e66f2184b32f98e01e3deae5600c2e0f2045f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105125 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Resolves: tdf#137896 Paste sheet-local names with sheet name prefixEike Rathke
Change-Id: Ib1779bb42c8b26a825899f8a93bc22b7ee441637 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105124 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Implement ScDocument::GetSheetSeparator()Eike Rathke
That can be reused. Change-Id: I4805fefa7585ddee026073e3b647020f8a993ab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105123 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31tdf#137897 scRetypePassInputDlg: re-allow password removalJustin Luth
This weld-conversion logic error caused a LO 6.1 regression in commit 0e4f93e88bfae3489d2de84fc2febed100880628. - m_pPasswordGrid->Disable(); + m_xPasswordGrid->set_sensitive(false); //disable == false - m_pBtnOk->Enable(); + m_xBtnOk->set_sensitive(false); //enable == true The result is that attempting to remove the password did not enable the OK button, so it was impossible. Change-Id: I4067b2ec6b89e86b21968d33c8850cca6d067e71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105101 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-31Constructing ScCompiler is unnecessary hereEike Rathke
The sheet separator can be obtained from the AddressConvention extracted from the document's FormulaGrammar. Change-Id: Ieec8f49f1d338c29665192fc73320f76b8fa1484 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105106 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31rename to NotifyContainsEmbeddedFontCaolán McNamara
to indicate better what its users do with this notification. This reflects better the reality that while the embedded font has been read at this point, vcl hasn't been informed of its existence yet. Change-Id: I87f4d0a0361192dac972f6146d3721a69e11ac27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-31tdf#137865 use stack background to match the other notebookbar areasCaolán McNamara
while the StylesPreviewWindow_Impl is the lone InterimItemWindow in the notebookbar Change-Id: Ie00d5c5ce3b257891696e95a91e6c88bfa0cbcde Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-31Improve 'resize with cell' handlingRegina Henschel
The patch contains a larger rework of RecalcPos and connected areas and covers several bugs. Essentials in short: Move initialization from RecalcPos to own method and use it in ScXMLImport::endDocument Do not change hidden objects, which includes not setting width or height to zero, and be consistent in using object visibility. Special handling of vertical flipped customshapes. Repair anchor on import of line and measure line. ODF conformance: Create logical rectangle from anchor instead using size. Details: tdf#137044 ScDrawLayer::SetPageSize is called several times while loading a document. It includes a call to ScDrawLayer::RecalcPos for all cell anchored objects. An object gets initialized with the first call. Problem was, that the row heights were not finished at that time and anchor cells and offsets were partly calculated based on default cell height. That results in wrong height and offset of objects. The solution separates initialization from RecalcPos and puts it into an own method ScDrawLayer::InitializeCellAnchoredObj. This is then called from ScXMLImport::endDocument when row height settings are finished. The call to RecalcPos is not totally removed from SetPageSize but only excluded while loading, because it is needed for size changes after the document is loaded. tdf#137576 partly For measure lines and ordinary lines, which were anchored 'To cell (resize with cell)', LibreOffice has written wrong end-cell info to file. So reopening results in wrong lines. The geometry of lines is based on two points. Fortunatelly the combination of position of the cell, which contains the shape, and start and end points gives correct absolute position of these points. Solution is, to regenerate the initial ScDrawObjData infos from these points and do not use the stored end-cell info. For a total fix implementation of NbcSetSnapRect for SdrMeasureObj is needed, which is not included here. tdf#137020 Cell anchored shapes are contained in a cell in file. To determine size and position of the shape a rectangle is used, so defined, that after applying transformation you get the desired shape. In case of custom shapes, a vertical flip is not contained in the transformation but it is an attribute inside the shape and flip is done at the shape center and will not change the rectangle. This rectangle determines start and end addresses and offsets in ScDrawObjData in rNoRotatedAnchor. The info is used directly in XML export. It is correctly build while loading the file. But in case of vertical flipped custom shapes the logical rectangle of the shape has an additional 180deg rotation. Changing that behavior is currently out of scope. Therefore special handling of vertical flipped custom shapes was added. tdf#99549 ODF specifies that in case of existence of end-cell attribute, size attributes have to be ignored. But LO has based the logical rectangle on size. In addition it has written zero width and height in case of hidden row and cols. Result was, that objects are 'lost' on opening although they still exists in the file. With the patch the object size is recalculated from anchor on opening. tdf#137355, tdf#137044, tdf#115655 The old solution has recalculated the snap rectangle based on current state of hidden row or column. That has produced shapes of zero width or height and loss of offset in case start or end cell of the shape was hidden. In running LO it was partly offset by using cached infos in ScDrawObjData. That failed in case of save and reload. Solution is, to only change visible shapes. It is enough to adapt the shape when it becomes visible. That is introduced in RecalcPos and SetCellAnchoredFromPosition. tdf#137216 Shapes anchored to cell were not hidden, if the column of its anchor was hidden, and undo of hiding an image in a cell by hiding its column didn't work. Reason was, that the shapes were not set to hidden in the shapes geometry. Solution is to copy a similar part from SetRowHidden to SetColHidden. without bugreport, but detected while debugging LO has used a cell reference with bHiddenAsZero as true in shape export. That has resulted in wrong offsets. Unittest changes: Test::testGraphicsInGroup() ScShapeTest::testCustomShapeCellAnchoredRotatedShape() Set expected values so, that they correspond to anchor in file. ScFiltersTest::testLegacyCellAnchoredRotatedShape() FIXME is solved now and the test is adaped to reflect that. XSheetAnnotationShapeSupplier::testGetAnnotationShape() Expected value is adapted to the fact, that now annotation shape gets its position after optimal row height is applied. Change-Id: Iffee996054ebf79e04044da5520f8d1a8a48b7c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104643 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
2020-10-31Remove remaining ModifyNotifications on TextNodeBjoern Michaelsen
Change-Id: I120dfe756dacf4d97c5708c4c46e4184349226e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105084 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-10-31atrfld: ModifyNotification no more ...Bjoern Michaelsen
Change-Id: I9a5dc35a71725969bc4b75f0444ba663271e3228 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105079 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-10-31remove pimpl from SmViewShellNoel Grandin
Change-Id: Iaa42a593cc76b03e507f34305fce0833f7eac40a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105096 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-31Support external names in INDIRECT()Eike Rathke
Works with external global names, external sheet-local names are not supported by ScExternalRefManager / ScExternalRefCache. Change-Id: I59ecc9444268a14eee67439db5ed99181a716151 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105092 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Resolves: tdf#100818 Support sheet-local scoped names in INDIRECT()Eike Rathke
Change-Id: Iae1ef07bf735b5886e391dced9984acee617f051 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105091 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Let INDIRECT() bail out early on empty stringEike Rathke
e.g. if obtained from yet empty cell. Change-Id: I18597b86b37d5d216213f9a101e8b84b307b2a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105090 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Pass ExternalInfo up to caller from lcl_ScAddress_Parse_OOo()Eike Rathke
... if external and sheet name was detected but a reference not completely parsed, which may indicate an external sheet-local name. This then in ScCompiler::IsSingleReference() is used to reset mnCurrentSheetEndPos and mnCurrentSheetTab, which without before was not done and may have lead to the external sheet-local name being taken as a sheet-local name in the current document if there was an identical one. External sheet-local names so far are not supported at all. The ExternalInfo is filled only if pSheetEndPos was passed but then could be used by the caller to obtain a name later. ExternalInfo::maTabName is filled only if a sheet name separator was encountered. Change-Id: I2414655a90a961af0e8ac2367cde7bdc4dcbb4c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105089 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Reintroduce ScGlobal::FindUnquoted() nStart parameterEike Rathke
That got removed early as unused but will be needed. Change-Id: I71c028bb92f337b10366b3eac44d3eacbf1e1355 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105088 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-10-31Set CPPFLAGS instead of the INCLUDE environment variableTor Lillqvist
INCLUDE is not exported from WSL to Win32 programs without including it in the list of environment variable names in the WSLENV environment variable, and I think we want to minimize the number that need to be mentioned there. Should not affect Cygwin builds. Change-Id: I0af480873badac446305e396b69eec360eb8a270 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105098 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-10-31X11Pixmap::mhDrawable only ever holds a PixmapStephan Bergmann
...(passed in in X11Surface::getSimilar at vcl/unx/generic/gdi/cairo_xlib_cairo.cxx:226), so use that for its type. (Using an appropriate UNO type when passing it into an any in X11SalGraphics::GetNativeSurfaceHandle will be addressed in a later commit; lets stick to tools::Long there for now.) Change-Id: I047a5f078c4b3c45a8fdc0fb09d544c73a6a4e29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105087 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-31remove pimpl in UnoControlTableModelNoel Grandin
Change-Id: Ia7aa2c5fa4d6bbe5cd722d8e27ec1a10c36fc4e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105028 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-31remove pimpl from FSStorageNoel Grandin
Change-Id: If2db85b2fde3ffdd8aa033de74773327e70d3011 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105082 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-31fixed crashing on duplicating slide if slide pan is not visiblePranam Lashkari
Change-Id: I30cdc8365d0a31b408dc4eb18b195703837c838a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104027 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 494cee664a3b3dc64dc83e1c29b17097d184a2d7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104684 Tested-by: Jenkins Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
2020-10-31remove pimpl from SdXMLShowsContextNoel Grandin
Change-Id: I54d4103d3a53300e9ed018b0d7f9a25e177722de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105027 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-10-31Simplify makefile logic using new gb_notStephan Bergmann
Change-Id: I19cb227a52fe6cd55dbba7b28689c4de995837fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105075 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-10-30SidebarToolBox.hxx can be a private headerCaolán McNamara
Change-Id: I2367ef3912f3b84cdd0324b8e76598fc44a22874 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105078 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-30pSysWindow is unusedCaolán McNamara
Change-Id: I36250d032af49f83f28be175a081dba344eac631 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-30tdf#137620 add explicit SurroundingText support to ScGridWindowCaolán McNamara
Change-Id: I51cf18d635c7a32e88c4afd4c59756ef93fc9c4d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-30external/cairo: Silence some more UBSan warningsStephan Bergmann
...seen when opening an Impress presentation on GNOME/X11: > cairo-xlib-source.c:570:26: runtime error: left shift of 191 by 24 places cannot be represented in type 'int' > cairo-xlib-render-compositor.c:1852:17: runtime error: left shift of negative value -186 > cairo-xlib-render-compositor.c:1853:17: runtime error: left shift of negative value -646 > cairo-xlib-surface-shm.c:1157:43: runtime error: member access within null pointer of type 'cairo_xlib_shm_surface_t' (aka 'struct _cairo_xlib_shm_surface') > cairo-fixed-private.h:252:8: runtime error: left shift of negative value -146048 Change-Id: I93a5706c2ec3f83bc56d75fc92817668eef57fdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105074 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-30tdf#126133 Chart OOXML import: set default text rotation to 0°Tünde Tóth
for the horizontal axis title, even if the position of the axis is left or right. With this, OOXML charts generated by third-party tools imported without bad rotated title text (as previously in commit fdb6d6ccf45e679ff3e369a876482b6801e08e25 [tdf#137734 Chart OOXML import: fix variable color charts], without bad variable colors). Change-Id: Id348fe037e4f1eb2d7253957224298aa95db5b15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105012 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-30Fix typoAndrea Gelmini
Change-Id: I6cef71ff511088572c07a893e41c7e1a8ee9b079 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104940 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-30Removed executable permission on fileAndrea Gelmini
Change-Id: If7048f7456fc3dd5562ec99763f1a83486d43c01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105030 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-10-30tdf#105967 sw change tracking: fix line break symbolLászló Németh
Paint strikeout/underline based on redline color and settings at the inserted or deleted line breaks. Follow-up of commit 350dbba44ee7703b1da11cc4732a5090ce5efe3d (tdf#105967 sw change tracking: fix pilcrow symbol). Change-Id: I64e267aef5a8bb1818f7e9d1a2fe5febb0df43a2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105068 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-30tdf#137625 sc: autofill user list sequences in merged cellsAttila Szűcs
Improve FillAuto, FillAnalyse to continue linear sequences of user list values in merged cells. (User lists are special string lists with values like day names Monday, Tuesday, ...) If values are user list values, but not in linear sequence, then the autofill will just fill with FILL_SIMPLE (pattern repeat). Note: the unit test depends on English system locale settings, check it in Tools->Options->LibreOffice Calc->Sort list, otherwise extend Sort list with English day names for manual testing. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I7a1da5e82a18ba8ebd24af7e4b89c7651f3ec24a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104690 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-10-30tdf#137855: sw: Add UItestXisco Fauli
Change-Id: Iea71fdff2b900d36ad9475b20ef93f81138f3e9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105016 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-10-30crashtesting: assert on undo creation on export of tdf105134-1.docx to pdfCaolán McNamara
since... commit c9eb53f200225f2ee6ca695e1326843a487aee51 (HEAD, refs/bisect/bad) Date: Wed Oct 14 15:46:23 2020 +0200 tdf#135198 sw editing: text box fell out of its shape I don't think layout should add into the undo stack Change-Id: I92e154dbe2396ff4085fffd7e962e43d2c61c073 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105045 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-10-30TNumberedItemHash NumberedCollection::m_lComponents is indexed on pointers...Stephan Bergmann
...reinterpret_cast'ed to sal_IntPtr, so consistently use sal_IntPtr throughout here Change-Id: If0085c2ac7e0e2c755ec034766095baa11a1b08c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105071 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-10-30Remove unnecessary includeStephan Bergmann
...introduced with 7a09d67e1c76db7cb6a87a2ceaa6de7325342b75 "convert some more long -> tools::Long" Change-Id: Ia565aea1eae4b3e03939c58f22e4263a4334ec80 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105070 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2025-02-26 22:29:23 +0000