summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-09-12Use sal_Int32 and LISTBOX_ENTRY_NOTFOUND for GetSelectEntryPosMatteo Casalin
Change-Id: I07f6f4426e87cd4066663e0ba7c26917bb984cbd
2015-09-12Reduce scope by early bail outMatteo Casalin
Change-Id: Ia4e1763cc4d70197342be4e5caf6d5c14cd34c80
2015-09-12SimplifyMatteo Casalin
Change-Id: I7e93874ed5127c9d674d53b220ba680718bd82ab
2015-09-12Update many ListBox users to its sal_Int32 interfaceMatteo Casalin
Change-Id: I6469ac5e2d17406bee9bc434930e2471cb3bae9f
2015-09-12Use forward declaration and reduce include scopeMatteo Casalin
Change-Id: I4456629dfc242d78f2c63c0b83d00afc3cdd23e7
2015-09-12fix downcast by intermediate functionMatteo Casalin
Change-Id: I8e7909003249a3f86928197bbde29231f84b01c2
2015-09-12GetCommandLineParamCount() returns sal_uInt16Matteo Casalin
Change-Id: Ie85f3a44034ffcfe08493256bc65e49b63a28013
2015-09-12Use better/auto int types, remove a couple of OUStrings copiesMatteo Casalin
Change-Id: I911742bddba1dac2641d7d2ac1dad0ed195474dd
2015-09-12This parameter type should be sal_Int32, for consistencyMatteo Casalin
Change-Id: I3fe7761d1ec88183853b240f7205bf98cfa5e965
2015-09-12nRepPos is never readMatteo Casalin
Change-Id: I6acb6517b6a62c59dff058e28a9e59342bb32510
2015-09-12tdf#94037: Don't try to manipulate non-existent widget containerKatarina Behrens
Regression from commit 8b7799972a95da50e1e92748, which replaced named GtkFrame with GtkBox, but didn't rename the box accordingly. Change-Id: I321dbee05faded81dbf575bca3c578ecb09f1a3e Reviewed-on: https://gerrit.libreoffice.org/18469 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2015-09-12Actually fix uno bridge on MSVC 14.0David Ostrovsky
VC runtime was substantially refactored on MSVC 14.0. Among other, _tiddata structure defined in crt/src/mtdll.h was replaced with __vcrt_getptd defined in crt/src/vcruntime/vcruntime_internal.h. All members before unsigned long _NLG_dwCode were removed, so that the approach to access the member void * _tpxcptinfoptrs; /* ptr to exception info pointers */ with __pxcptinfoptrs() and compute the offset to the _curexception member of _tiddata doesn't work on MSVC 14.0. As of MSVC 14.0 __vcrt_getptd symbol isn't exported but Microsoft have introduced methods to access current exception, current exception context and processing throw (the later can be accessed through C++17 std::unhandled_exceptions() that was made available in MSVC 14.0): * __current_exception() * __current_exception_context() * __processing_throw() aka std::unhandled_exceptions() Make use of __current_exception() which we can hope will be maintained going forward. Change-Id: Ibfffa5fba62d6928328ac976cb1b24937277363e Reviewed-on: https://gerrit.libreoffice.org/18475 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: David Ostrovsky <david@ostrovsky.org>
2015-09-12Typo: muliple->multipleJulien Nabet
Change-Id: Iebcf44d99bd4cabd5f7f1242e44c1c1d8e5a10d5
2015-09-12comphelper: give up on the XPropertySetInfos for nowMichael Stahl
PropertySetInfo_Impl in ucb/source/core/ucbstore.cxx is sheer insanity, persisting a PropertySetInfo into the configuration => throw up hands in despair. Change-Id: Ic341e453571072a9ed66c6bf51e96dbe39806566
2015-09-11basic: one more WeakImplHelper<XPropertySetInfo> duplicateMichael Stahl
This one may be quite busted even since it compares sal_Int32(-1) with USHRT_MAX. Change-Id: I894b382ad499ee49f4616c7704afbb90f0556744
2015-09-11getFiles refactoring: kde partJulien Nabet
1) kdecommandthread part before: getFiles retrieves all files with: First element = path only of the files other elements = file names (without path) after: Add getSelectedFiles which retrieves all files with their url getFiles uses getSelectedFiles and truncates to 1 entry if more than 1 entry 2) kdefilepicker part before: getFiles case retrieves all files with names including path after: add getSelectedFiles case which retrieves all files with names including path change getFiles to retrieve only the first file (with path) See http://nabble.documentfoundation.org/Dev-f1639786.html for discussion Change-Id: I73cf00e7c03a1f2379f4628b5d7f12418029cca1 Reviewed-on: https://gerrit.libreoffice.org/17064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2015-09-11comphelper: another WeakImplHelper duplicateMichael Stahl
Change-Id: I8b5fad24857f434cab351bbbae42c4b09bc6613a
2015-09-11framework: yet another WeakImplHelper<XPropertySetInfo> dupcliateMichael Stahl
There's a very similar comphelper::PropertySetInfo, unfortunately with an additional mnMemberId on its properties, so convert a little... Change-Id: I2a5fc0bb0ff6d680d546192b9d09afee6348f218
2015-09-11tdf#39468 translated german comments in hdrcont.cxxAlbert Thuswaldner
Change-Id: I0dae68656f1dbe3828e58eb177ce9e98a071fe20 Reviewed-on: https://gerrit.libreoffice.org/18418 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2015-09-11Android: i18-ize some stringsJacobo Aragunde Pérez
Change-Id: I35d0ef7976d6dcca65f3335ff9175c799faa99fe
2015-09-11Android: check file modify date to know if save is completeJacobo Aragunde Pérez
The API does not allow to set a callback for the save operation, we work this limitation around by checking the modification date of the local file periodically. When that date changes, we are sure the local save operation is complete and we can invoke the document provider save operation to push the changes to the cloud, if necessary. Users may press "save" on a document with no changes, in this case we have set a 20 seconds limit to stop checking the modification date. We also add a "save complete" message for the user. Change-Id: Ib8871fac682a5c03a187a7238e11874984143527
2015-09-11Android: Implement cloud saveJacobo Aragunde Pérez
The LOMainActivity now needs to be aware of Document Providers, so we pass the providerId and documentUri in the Intent so it can rebuild the DocumentProvider and the IFile objects. We also implement the ownCloud save operation. TODO: since the local save operation does not have a callback, we do not know when the cloud save operation should be performed. Now we just wait 5 seconds to trigger it. Change-Id: I060969e12888eca07c8c56ddc82cbed6c45a0739
2015-09-11Android: provide an ID to document providersJacobo Aragunde Pérez
This ID will be useful to get an instance of a document provider back from a different activity. Change-Id: I9419ea23d51f8e9ffd70252bd8e367cf51bde1ad
2015-09-11unit test for MoveBlock / ScUndoDragDrop caption life cycle, tdf#92995Eike Rathke
Change-Id: Ide7ec10cee3aefaa89feda73181ac9c11ebcbb5a
2015-09-11vcl: tdf#88206 replace cppu::WeakImplHelper* etc.Takeshi Abe
with the variadic variants. Change-Id: I4499569f73b04cc7444787d51bf804c090a5c951 Reviewed-on: https://gerrit.libreoffice.org/18478 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-11xmloff: tdf#88206 replace cppu::WeakImplHelper*Takeshi Abe
with the variadic variants. Change-Id: I47002abab1e025d0683f4cf8ef7b6c99e668d425 Reviewed-on: https://gerrit.libreoffice.org/18479 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-11LOK: Implement an own trivial InteractionHandler.Jan Holesovsky
So far it just selects 'Approve' for any interaction that is done through that, later we want to route the information via callbacks to the caller. Change-Id: I7ae3e2dcc04877b8b0197b0396299126e1217a2a
2015-09-11tdf#93480: Don't send an EMPTY Invalidate() on .uno:DefaultBullet.Jan Holesovsky
When there was no modification to the document, and .uno:DefaultBullet was sent, we have got an invalidtion of the entire document. It seems that Invalidate() was not supposed to be called in the Validate() call, and instead, we should rely on what the Validate() invalidates :-) Change-Id: Ia65df90e4ff34078b59c1b2eb1ce1faac790b40d
2015-09-11tdf#94031 - slideshow: bind correct GL context for prepareEnvironmentLubosz Sarnecki
Change-Id: Ib139e81f770531f7d808764dd3a77c7ac8d6fa3c
2015-09-11sw: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl
Change-Id: I8baa909f5e3ddb6b227337f3731e4d4b4ca183e5
2015-09-11sw: replace boost::ptr_vector with std::vector<std::unique_ptr>Michael Stahl
Change-Id: I5316874cb8abe191da4fd385b281599d422a23ee
2015-09-11sw: add unit test for the redline frame duplication regressionMichael Stahl
Change-Id: I4b0f6199ebb8a9f462e53f3fdf8be871a267ba69
2015-09-11Revert "Fix single node CopyRange"Michael Stahl
This reverts commit 9099e21b89184bd4e39def497e483cac4a77ec5a. It causes the problem that frames anchored to the same node where redlines start or end get duplicated during Hide. Jan-Marek said that the original mail-merge related problem this change was fixing is now most likely fixed differently, and the test in testMultiPageAnchoredDraws() still passes. Change-Id: Ie84fed3f64be7696782bc557004eb18fccc5b64b
2015-09-11tdf#92145: Writer table rows/columns can't be resizedLászló Németh
with disabled rulers. (This fix was suggested by Tomaž Vajngerl.) Change-Id: I161237cdb4941c0eaf934223b078acd94d72e21d
2015-09-11check stream status more oftenCaolán McNamara
Change-Id: I233c2fff9c06a81117f8114ccee83b53ea4026db
2015-09-11tdf#93243 replace boost::bind with C++11 lambdas in Metadatable.cxxn.r.pearson
Change-Id: I18f72bb6768fae9717c9d88be84ac2bfabd37a3b Reviewed-on: https://gerrit.libreoffice.org/18471 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-11LOK: don't use unstable API unconditionally when including the GTK headerMiklos Vajna
Change-Id: I679ddfdadbf4746d3fba64d3d5157ec070b4f6dd
2015-09-11Resolves: rhbz#1261421 crash on mashing hangul korean keyboardCaolán McNamara
Change-Id: Ie066c7f83ad15bec198f2091a3b084468c502766
2015-09-11tdf#93240: replace boost::ptr_deque with std::deque<std::unique_ptr>Matthew Nicholls
Change-Id: Iba77946a00c6c43c4377b2bae62467581cfed19f Reviewed-on: https://gerrit.libreoffice.org/18468 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2015-09-11tdf#94045: negative margins in OOXML reenabledOliver Specht
OOXMLUniversalMeasureValue is an integer value and needs to be converted to a signed integer. unit test included Change-Id: I7fe3fdf4b8b12df55e9cea2a968b9537676687eb Reviewed-on: https://gerrit.libreoffice.org/18496 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Oliver Specht <oliver.specht@cib.de>
2015-09-11Useless cargo cult?Stephan Bergmann
Change-Id: I0bb5582a6aef51ac65466531115d67c6dbad1fcd Reviewed-on: https://gerrit.libreoffice.org/18493 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2015-09-11tdf#93901: apply handling in style/edit dialog improvedOliver Specht
introduced SfxTabPage::ChangesApplied() to enable resetting values to their initial state while editing styles Change-Id: I60fd68d8464e12e795b0e0d2f2e53882a225c181 Reviewed-on: https://gerrit.libreoffice.org/18467 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2015-09-11lokdocview: GTK+ calls should be made from the main threadMiklos Vajna
Change-Id: Ia76ef111170700ef507550222ca917986d4fe00e
2015-09-11downgrade warning, exception on opening a missing file is an expected thingCaolán McNamara
Change-Id: I3ca2d6af48adb226e0f56d0500c31f19676c6567
2015-09-11valgrind: silence worrying invalid pthread lock/unlock warnings on exitCaolán McNamara
Invalid read of size 4 at 0x57F48E0: __pthread_mutex_unlock_full (in /usr/lib64/libpthread-2.21.so) by 0x4E903F7: osl_releaseMutex (mutex.cxx:136) by 0xB3EECF0: osl::Mutex::release() (mutex.hxx:74) by 0xB3EF92C: osl::Guard<osl::Mutex>::~Guard() (mutex.hxx:135) by 0xB3F755A: SvtCommandOptions::~SvtCommandOptions() (cmdoptions.cxx:318) by 0xB3F75B3: SvtCommandOptions::~SvtCommandOptions() (cmdoptions.cxx:328) by 0x2B13BDE9: std::default_delete<SvtCommandOptions>::operator()(SvtCommandOptions*) const (unique_ptr.h:76) by 0x2B13A3C6: std::unique_ptr<SvtCommandOptions, std::default_delete<SvtCommandOptions> >::~unique_ptr() (unique_ptr.h:236) by 0x2B134063: framework::Desktop::~Desktop() (desktop.cxx:183) by 0x2B13418B: framework::Desktop::~Desktop() (desktop.cxx:187) by 0x79892AD: cppu::OWeakObject::release() (weak.cxx:205) by 0x2B1399B7: framework::Desktop::release() (desktop.hxx:133) by 0x2B13B860: rtl::Reference<framework::Desktop>::~Reference() (ref.hxx:81) by 0x2B13956B: (anonymous namespace)::Instance::~Instance() (desktop.cxx:1780) by 0x54635D7: __run_exit_handlers (in /usr/lib64/libc-2.21.so) by 0x5463624: exit (in /usr/lib64/libc-2.21.so) Change-Id: I98e0e70567ab39a06813fd9b614ba1e04ec22bd1
2015-09-11coverity#1323754 we apparently can survive std::abort for a whileCaolán McNamara
so try and suppress this warning Change-Id: I096352af0116f1ba0911cc201eb884267095a797
2015-09-11coverity#1323755 Using invalid iteratorCaolán McNamara
try and help coverity to know that aEnd and maFragments.end() are the same place Change-Id: I9ce4187d5ed15d0ae26b69bb360dbd47c2a6a185
2015-09-11Missing dependencyStephan Bergmann
(for typeinfo for SvxFontLitsItem, as needed by -fsanitize=vptr) Change-Id: I13ee8f4f52509ca2b26cba16a3e5c93a7223ceb7
2015-09-11sw: indentation fixesMiklos Vajna
Change-Id: I7cf97f06053275fa229bbd24a06f7b0104f024fb
2015-09-11windows opengl: make sure mpLastContext is indeed the current contextMiklos Vajna
There were two problems here: 1) The OpenGLContext ctor registered the instance on the list of contexts, but platform-specific call (e.g. wglMakeCurrent()) was only made later. Add a registerAsCurrent() member function that helps ensuring that the last item in the context list is indeed the current context. 2) OpenGLContext::prepareForYield() is called without the solar mutex being locked, but it still assumes that the last context in the context list is the thread's current context, which may not be true. The result is that during JunitTest_sd_unoapi, we end up in a situation like: debug:4640:5240: OpenGLContext::registerAsCurrent: wglGetCurrentContext() is 00010001, pSVData->maGDIData.mpLastContext is 00FA65F8 debug:4640:7944: OpenGLContext::registerAsCurrent: wglGetCurrentContext() is 000D0003, pSVData->maGDIData.mpLastContext is 00FA6C70 debug:4640:5240: OpenGLContext::prepareForYield: start, wglGetCurrentContext() is 00010001, pSVData->maGDIData.mpLastContext is 00FA6C70 I.e. one thread registers as current, an other registers as current, too (while the other thread has the solar mutex), then once the original thread wants to release the solar mutex, the real current context and the last item in the context list won't match, so the assert at the end of prepareForYield() will fail. Fix this by releasing the GL context in WinSalInstance::DestroyFrame(). With this, JunitTest_sd_unoapi passes on Windows with GL enabled. Change-Id: Icfb9c65c871586b5df69b5a2ab3aa91843dfc799 Reviewed-on: https://gerrit.libreoffice.org/18473 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
generated by cgit (git 2.34.1) at 2025-03-01 00:26:01 +0000