summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-12-12tdf#97361: Changed naming convention to Python type, object factories ↵n5xgdh
implemented Change-Id: Id42e9a2e2cfd7c95140411123e8702dfdb4054da Reviewed-on: https://gerrit.libreoffice.org/31676 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-12-12tdf104532 handle constraints for NEGBINOM.DIST correctly.Winfried Donkers
Also changed variable names for easier understanding of their meaning. Change-Id: Iab558d7d1d9533f2a0c42e3d5f4acecead2e818e Reviewed-on: https://gerrit.libreoffice.org/31807 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2016-12-12Revert "loplugin:refcounting"Tor Lillqvist
Bah, the reverted change actually of course breaks the compilation, I had missed that accidentally. More intrusive chnages are needed to change css::uno::Reference to rtl::Reference, also in parameters to constructors and other calls here. This reverts commit 073f8cdbb77d62a6838c78ff63fca73896b86c79. Change-Id: I2d0f9db9cef8dfbfe7d8a409eb09375c45b9e49f
2016-12-12loplugin:stringconstantTor Lillqvist
Change-Id: I5bf8adf86da9d2e9c53341cdbc94aba05557abfc
2016-12-12Whitelist aLogger, in FormulaLogger& FormulaLogger::get()Tor Lillqvist
To avoid this: sc/source/core/tool/formulalogger.cxx:55:26: error: bad static variable causes crash on shutdown [loplugin:badstatics] static FormulaLogger aLogger; ~~~~~~~~~~~~~~~~~~~~~^~~~~~~ sc/inc/formulalogger.hxx:42:31: note: ... due to this member of 'FormulaLogger' [loplugin:badstatics] const ScFormulaCellGroup* mpLastGroup = nullptr; ~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~ sc/inc/formulacell.hxx:66:20: note: ... due to this member of 'ScFormulaCellGroup' [loplugin:badstatics] ScFormulaCell *mpTopCell; ~~~~~~~~~~~~~~~^~~~~~~~~ sc/inc/formulacell.hxx:114:21: note: ... due to this member of 'ScFormulaCell' [loplugin:badstatics] ScDocument* pDocument; ~~~~~~~~~~~~~~~~^~~~~~~~~ sc/inc/document.hxx:312:27: note: ... due to this member of 'ScDocument' [loplugin:badstatics] VclPtr<SfxPrinter> pPrinter; ~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~ Change-Id: I533e45f655ca928a801188aa48ee818d89a962ac
2016-12-12loplugin:staticmethodsTor Lillqvist
Change-Id: Ia470ed848c5c27de1b0ae3fa89a59f6cb2ae38fe
2016-12-12loplugin:unreffun and loplugin:externandnotdefinedTor Lillqvist
Change-Id: I69f11aa5dd81834aa916a66437d8c091cdf245f3
2016-12-12loplugin:overrideTor Lillqvist
Change-Id: I7ef42d66a0ffbbd8f2754bd4aba0e77659c9ae83
2016-12-12loplugin:nullptrTor Lillqvist
Change-Id: I6ab405e7e9a0c8ac3a323fd2484e334c500280ae
2016-12-12loplugin:unnecessaryoverrideTor Lillqvist
Change-Id: I45d7e14cef0058c4bfca4a3466e31d64e29bdfae
2016-12-12loplugin:unreffunTor Lillqvist
Change-Id: If538d5d5347f58e18869cab2b687af26a39a89eb
2016-12-12loplugin:staticmethodsStephan Bergmann
Change-Id: Ic8e00ab8961811044c26eb237f283617ddeb5cb6
2016-12-12unwind RID_OUTLINEBITMAPS imagelistCaolán McNamara
Change-Id: I44a03f557d7a7aafeb17e5d662797203f975672f
2016-12-12sw: prefix members of SwClientMiklos Vajna
Change-Id: If35981bce951dfab4a784d4cb54ac911249572ed
2016-12-12manage OutlineBitmap imagelist directly in its owner userCaolán McNamara
Change-Id: I4437484192016db7ce72614ae07c5a7d1bd9ec5b
2016-12-12unwind RID_IMGLST_LAYOUT imagelistCaolán McNamara
Change-Id: I17146905c93162977effe9179c844ba691320d35
2016-12-12tdf#104268 NLPSolver: Improve display of solutionLaurent Balland-Poirier
Format "%.2f" is not optimal for large or small values. Format "%g" should be prefered. Change-Id: I92899d80564b9000b1f3e049221c456f8e1176a9 Reviewed-on: https://gerrit.libreoffice.org/31445 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12uno: Add support for targets with 16-bit alignmentJohn Paul Adrian Glaubitz
Despite being a 32-bit architecture, m68k has a basic alignment of 16-bit for historic reasons. On m68k, SAL_TYPES_ALIGNMENT8 is therefore equal to 2 and we need to cover this case in the static asserts as well. Change-Id: I4c756af25d57e5d49209697f6e678ef71a5845aa Reviewed-on: https://gerrit.libreoffice.org/31878 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2016-12-12comphelper: cleanup class NameContainer.Arnaud Versini
Remove useless class NameContainerImpl. Change-Id: I3066abea69ed68d597aeecdd6b3ec7264f7ebe9c Reviewed-on: https://gerrit.libreoffice.org/31830 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12OSL_TRACE->SAL in sd..sdextNoel Grandin
Change-Id: I6b224fa890dc96aada7140af27078da5e25c3ff8 Reviewed-on: https://gerrit.libreoffice.org/31898 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12remove another imagelistCaolán McNamara
Change-Id: Ica62a13b19134030c6f0e2eeaf41df3c0f1294a4
2016-12-12update png locations for various imagelist unwindingsCaolán McNamara
Change-Id: Ib0106c3b88cf54e54aaf784bb526480a1c745a1f
2016-12-12Revert "tdf#103654: Make git hash clickable in the About dialog"Michael Meeks
This reverts commit cc02097495f95967f8f06c364dfa6a8949132868. Need to improve the solution here a little I think.
2016-12-12reintroduce CONV2CHAR/CONV2LINE splitBjoern Michaelsen
Change-Id: I02a3a46d2222b8bfe955eb17ca655d36d9155b48 Reviewed-on: https://gerrit.libreoffice.org/31867 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-12-12refactor out lcl_SetRelationOrientBjoern Michaelsen
Change-Id: I9759a0f21641b6f5ba5e456e5c45ac28238ca672 Reviewed-on: https://gerrit.libreoffice.org/31866 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-12-12add relative to tablecell as stateBjoern Michaelsen
Change-Id: I76e9d317dabeefcdf53468a89f3a6130279993f3 Reviewed-on: https://gerrit.libreoffice.org/31865 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-12-12refactor out lcl_GetWW8PosBjoern Michaelsen
Change-Id: Ie7127668aceade312c68ed3d7f3398fbaf5e8df7 Reviewed-on: https://gerrit.libreoffice.org/31864 Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com> Tested-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-12-12use message passingBjoern Michaelsen
Change-Id: I49c448c454f9bb820c3b9afa3825c58cb2dab978 Reviewed-on: https://gerrit.libreoffice.org/31863 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-12-12move enums up so core specific functionality can followBjoern Michaelsen
Change-Id: Iad8b5ff731c9d53f0f015a95387a00993a4a31f8 Reviewed-on: https://gerrit.libreoffice.org/31862 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2016-12-12remove another imagelistCaolán McNamara
Change-Id: Ica62a13b19134030c6f0e2eeaf41df3c0f1294a4
2016-12-12coverity#1371265 Missing move assignment operatorCaolán McNamara
Change-Id: I5b7c6992e92e4d096b8230774ed8f4bfaaad5831
2016-12-12tdf#99227: use correct serializer when exporting drawingMike Kaganski
Failing to do that leads to write-past-end-of-document, drawing loss and SAXParseException if the drawing is part of a footnote. A unit test is included. Change-Id: Ie7d8263dc72dfef1e9827cc0579a5eaaf5819410 Reviewed-on: https://gerrit.libreoffice.org/31871 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2016-12-12tdf#104573 - Assertion failed: SolarMutex not locked when tryingNoel Grandin
to bring up File Open... dialog we need to hold the SolarMutex when doing VclPtr ref-counting Change-Id: I843f2a243acaf73db1f6557df23475fe5bb12131 Reviewed-on: https://gerrit.libreoffice.org/31892 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12coverity#1397054 silence bogus Dereference after null checkCaolán McNamara
Change-Id: Ifceb60ee9f1f5e0ba5fd68d88a0358b5400008ee
2016-12-12coverity#1397042 Unchecked return valueCaolán McNamara
Change-Id: Ibb24dea2464c2e0bba289f08bba053efe6fe57fc
2016-12-12coverity#1397041 Unchecked return valueCaolán McNamara
Change-Id: Ia8c601475bea142faad9c1f1e9b797d0ebc13679
2016-12-12coverity#1397045 Unchecked return valueCaolán McNamara
and coverity#1397044 Unchecked return value Change-Id: I193bd676e417c35450efa91cb5773c78c998b63f
2016-12-12coverity#1397046 Unchecked return valueCaolán McNamara
Change-Id: I7f8988a7cf5f3d815a20cac249b3753d732994e1
2016-12-12coverity#1397048 Unchecked return valueCaolán McNamara
Change-Id: Ie33ef6565cadcddb59c1d78a63aec666e8693f87
2016-12-12coverity#1397043 Unchecked return valueCaolán McNamara
Change-Id: I37c49aa568646e44c05f5feec537d344a2440b91
2016-12-12tdf#104046 - Slides in the slide pane don't update in realtimeNoel Grandin
This appears to be a consequence of my change commit 942716fee138b68c2af9411384f402b5692a88b2 convert EID constants to typed_flags in that change I made a "fix": @@ -689,20 +687,20 @@ void EventMultiplexer::Implementation::CallListeners (EventMultiplexerEvent& rEv ListenerList::const_iterator iListenerEnd (aCopyListeners.end()); for (; iListener!=iListenerEnd; ++iListener) { - if ((iListener->second && rEvent.meEventId)) + if (iListener->second & rEvent.meEventId) iListener->first.Call(rEvent); } } which causes this bug. I should have noticed that my "fix" indicates that the event filtering part of this multiplexing code was never working, and since no-one has ever complained about, lets just remove all of this unnecessary complexity. Change-Id: Id71613d4fd5817ee1358705059e4ce63d57573ad Reviewed-on: https://gerrit.libreoffice.org/31894 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12coverity#1397053 Logically dead code (golden)Caolán McNamara
and coverity#1397055 Inferred misuse of enum copy and paste error from the other converted call site I bet Change-Id: I63701db153c5fd424374a95dd757d9fd7a8bc216
2016-12-12coverity#1397052 Logically dead code (golden)Caolán McNamara
regression from... commit b894104a0b02a9b074c76feb925389d7bee6a493 Date: Thu Dec 8 00:43:09 2016 +0200 Pass GlyphItem around We have this nice structure that contains (almost) all the information we need, so pass it around instead of passing separate fragments of said information. presumably this is the correct fix given the context of the other changes Change-Id: I8518e739b1caa00ea5ae1569282e98810462d4c3
2016-12-12[API CHANGE] Remove salcpprt static libraryStephan Bergmann
...containing replacements for global operator new/delete (that can be linked into executables), but which is no longer used. The mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2012-March/028690.html> "operator new no longer routes through rtl_AllocMemory in libsalcpprt under gbuild link rules" has the details of how this was used on some platforms (but not on others) before the switch to gbuild, and has been "lost" ever since---but apparently a loss not mourned much over the years. For the SDK, c5f974287fd04bb529de145113133b9e35687702 "INTEGRATION: CWS jsc3: #i62434# copy libsalcpprt.a" added the library (under Linux) and 6db9c5af960f9787e33e4addc56bddbb1695a402 "INTEGRATION: CWS jsc3: #i62434# extend link options for executbales to link libsalcpprt.a, LINUX only" added its use to odk/settings/settings.mk, but fc0ca57f2cd649c6330171445a06b80e2143a0e9 "INTEGRATION: CWS jsc21" removed that use again (for no documented reason). So this is an incompatible change, but unlikely to actually affect any users of the SDK. Change-Id: Ia38b4c439f21fca3f5d9af7d1a34054e992054e9 Reviewed-on: https://gerrit.libreoffice.org/31810 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2016-12-12remove useless Mutex guardsNoel Grandin
Change-Id: Ib1edb681b47ce98e2e810d15111932002786aa51 Reviewed-on: https://gerrit.libreoffice.org/31875 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12coverity#1397056 Dereference null return valueCaolán McNamara
Change-Id: Ieda3afdbdbcc8aa21f6584edc21738c4edb84000
2016-12-12coverity#704109 Unchecked return valueCaolán McNamara
and coverity#1397040 Unchecked return value coverity#1397047 Unchecked return value coverity#1397049 Unchecked return value coverity#1397050 Unchecked return value coverity#1397051 Unchecked return value Change-Id: Idf7dd7818b74c661a1f7a757f0bdc16e2d1d5c72
2016-12-12tdf#101563 - Export to PDF with linked images creates huge PDF files.Noel Grandin
Looks like it was introduced by commit 19b34c0039c6293f9b37aa70f8055aa2be28ba09 loplugin:passstuffbyref in svtools and since it's windows only, probably some subtle mis-compilation. Aron Budea tracked this one down. Change-Id: I77e65ea8a1fb0003d6ff0f3b0f8019f275ff3462 Reviewed-on: https://gerrit.libreoffice.org/31893 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-12-12coverity#704108 Unchecked return valueCaolán McNamara
Change-Id: I5bd58f94fbea3d59849f60f2096e5191dbb0d810
2016-12-12tdf#95416 Fix an include for xmlsecurityAdam Kasztenny
Move one header file to inc/ Change-Id: If8f4bfcf29464011fe68573e7d4e67900aacc2cd Reviewed-on: https://gerrit.libreoffice.org/31891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
generated by cgit (git 2.34.1) at 2025-02-28 10:23:09 +0000