summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-07-16macOS ld doesn't know --rpathStephan Bergmann
Change-Id: I4ebef2f15c409805adcd16916a9137b94e4ee535 Reviewed-on: https://gerrit.libreoffice.org/75677 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-16Missing test dependencyStephan Bergmann
(a macOS build of mine happened to fail in CppunitTest_sd_uimpress with "no suitable windowing system found, exiting" when instdir/LibreOffice.app/Contents/Frameworks/libvclplug_osxlo.dylib had not been built yet) Change-Id: Ic699648f6b0dffd9ed01cf97cf624efe2ef8be30 Reviewed-on: https://gerrit.libreoffice.org/75679 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-16cid#1448243 Using invalid iteratorCaolán McNamara
return early on error paths Change-Id: I5d4f05585bb8c4b7d3fbe6824b8aa97785098ec5 Reviewed-on: https://gerrit.libreoffice.org/75662 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448300 Using invalid iteratorCaolán McNamara
Change-Id: Ibf3c2f90834e40f06ee1ba55480bd1d345642059 Reviewed-on: https://gerrit.libreoffice.org/75663 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448456 Uninitialized scalar fieldCaolán McNamara
Change-Id: I9b29898db96709f5b2d47deb962a124d7cb33eff Reviewed-on: https://gerrit.libreoffice.org/75655 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16remove sallogareas header fileNoel Grandin
in preparation for using LO_CLANG_SHARED_PLUGINS Change-Id: I91cf186188bf0f15fc4e5adc095d404d89d0b025 Reviewed-on: https://gerrit.libreoffice.org/75681 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-16loplugin:simplifyconstruct (macOS)Stephan Bergmann
Change-Id: Ifad405b05142ce61673f22ec3160f50314419ce7 Reviewed-on: https://gerrit.libreoffice.org/75680 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-16missing includeStephan Bergmann
(Windows --disable-pch missed declaration of HasAtHook) Change-Id: I7573328a4f672cbf3585a55ed87199f0982aa987 Reviewed-on: https://gerrit.libreoffice.org/75673 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-16cid#1448421 unsafe_xml_parse_configCaolán McNamara
do we need this as 1 ? Change-Id: I12cdec90f5ca989767a769dfc1dbebf73fae696c Reviewed-on: https://gerrit.libreoffice.org/75658 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-16tdf#125871 - new Tooltip window has empty area selectedHeiko Tietze
Ok button focused by default Change-Id: Ibe7653c09dd9f76d6b9feda295b92c90a4b26058 Reviewed-on: https://gerrit.libreoffice.org/75637 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-16LOK: getPartInfo now returns list of selected partsAshod Nakashian
For spreadsheets, selected parts are still unimplemented, so returns false for all. For presentations, visible parts seem to be always return false at load time. Change-Id: I90c79617f88deec98849bb374ca0ba177cd9c9af Reviewed-on: https://gerrit.libreoffice.org/69611 Reviewed-by: Ashod Nakashian <ashnakash@gmail.com> Tested-by: Ashod Nakashian <ashnakash@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/73494 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-07-16cid#1448219 silence Unchecked return valueCaolán McNamara
Change-Id: I716096d8d165d374f5164d43e5e1c95910c53411 Reviewed-on: https://gerrit.libreoffice.org/75666 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448365 silence Arguments in wrong orderCaolán McNamara
Change-Id: I9da2188f9e6ec2cd07cf4e79ff436cb7c3572c6f Reviewed-on: https://gerrit.libreoffice.org/75665 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448352 silence Arguments in wrong orderCaolán McNamara
Change-Id: I5c8627df362708933594fd8c94aa6125c0e27b10 Reviewed-on: https://gerrit.libreoffice.org/75664 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448533 Uninitialized scalar fieldCaolán McNamara
Change-Id: I20a1be6d14f11ffc6d04f60419fc5c659e59c6fa Reviewed-on: https://gerrit.libreoffice.org/75656 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448248 Unchecked return valueCaolán McNamara
Change-Id: I3b50d3affeb0c25a12dcb2ae0d5c2216d5419249 Reviewed-on: https://gerrit.libreoffice.org/75659 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16Resolves: tdf#120685 don't show decimal places for pointsCaolán McNamara
unless its been explicitly requested Change-Id: Id9f34b68404cb3bdcaea641583980fa14453f2d1 Reviewed-on: https://gerrit.libreoffice.org/75646 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448448 Unchecked return valueCaolán McNamara
Change-Id: I195cc073ff7557d30fbffcb97778751908634303 Reviewed-on: https://gerrit.libreoffice.org/75660 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448424 silence Uninitialized pointer fieldCaolán McNamara
Change-Id: Ie68cb97a092753185cc31c0b590fe75fad79989b Reviewed-on: https://gerrit.libreoffice.org/75668 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448306 silence Unchecked return valueCaolán McNamara
Change-Id: I4d95a54820a3cce9b23ac772abfbfe35ec908765 Reviewed-on: https://gerrit.libreoffice.org/75667 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16cid#1448410 Explicit null dereferencedCaolán McNamara
Change-Id: I491e7b0bd2e3aee02f72da907abe4cbae30ce798 Reviewed-on: https://gerrit.libreoffice.org/75654 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-16Follow up patch tdf#126067 Correct indentation.Gülşah Köse
Change-Id: Idfe608afb8b02f8b9f56b9da76e3f2009617b183 Reviewed-on: https://gerrit.libreoffice.org/75676 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Tested-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-16tdf#42949 Fix IWYU warnings in include/Gabor Kelemen
Recheck directories in include/ between vcl and svx in the module hierarchy Found with bin/find-unneeded-includes Only removal proposals are dealt with here. New IWYU and recent developments in f-u-i helped to identify some non self contained files, those were fixed too. Change-Id: Ieab6083ee2aae33baf32d05943b07ad2de6f9d7f Reviewed-on: https://gerrit.libreoffice.org/75170 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-16convert some plugins to LO_CLANG_SHARED_PLUGINSNoel Grandin
Change-Id: I7451a95377101004c7c53c918f3234415e06f555 Reviewed-on: https://gerrit.libreoffice.org/75670 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-16RTF import: add tests for RTF_PGBRDRT/L/B/RMiklos Vajna
lcov points out these were not covered previously. Change-Id: I0211cc35be99bf2487c73b4e63889a2af56d02c2 Reviewed-on: https://gerrit.libreoffice.org/75661 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-16tdf#126067 Fix slide scope feature.Gülşah Köse
Change-Id: I6e2450572b9c6a30526a8a2a91a6e0bf89103475 Reviewed-on: https://gerrit.libreoffice.org/75669 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-07-16write out empty state explicitly in writeRectangleNoel Grandin
this is purely an internal XML format, so we can change it Change-Id: I9e2a4350c6c3f51031742e94823ea052dd73c8df Reviewed-on: https://gerrit.libreoffice.org/75639 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-16Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - tdf#122706 Update Print page to new dialog elements Update bookmarks and ahelps Remove and add paragraphs as necessary Change-Id: Ibfa471d1c7806c31f8e469e2f21b0cc009c9980f Reviewed-on: https://gerrit.libreoffice.org/75607 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-07-16Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' - Typo Change-Id: I854c7a4112eda552122fa37f15bcf9752ad302ae Reviewed-on: https://gerrit.libreoffice.org/75627 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-07-15cid#1448245 uninit scalar fieldCaolán McNamara
and cid#1448340 uninit scalar field Change-Id: Idfd0944c1a6765593e334b1db56a80e144aedd5e Reviewed-on: https://gerrit.libreoffice.org/75651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15cid#1448286 Uninitialised scalar fieldCaolán McNamara
Change-Id: I064a996c52a95922d72ac8577c98dbb6354daa72 Reviewed-on: https://gerrit.libreoffice.org/75653 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15cid#1448240 Unchecked dynamic_castCaolán McNamara
Change-Id: I1d76775d3f78a128aebce1d3b4018e437cf0931b Reviewed-on: https://gerrit.libreoffice.org/75652 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15uitest for bug tdf#126017Zdeněk Crhonek
Change-Id: I8a64c5eb017f4b6d468d082925a5022cb75d549e Reviewed-on: https://gerrit.libreoffice.org/75564 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-07-15sw comments on frames: avoid overlay that covers only an at-char imageMiklos Vajna
The comment is already attached to the image via the anchor, and the overlay would change the image, which is confusing. Change-Id: I7a1c2a25182f628effa224fb82b5bcd71fdf35d4 Reviewed-on: https://gerrit.libreoffice.org/75638 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-15Resolves: tdf#126202 url not sensitive, so not editableCaolán McNamara
Change-Id: Id211bf3e29bbf32720ca8216ffe6fe589fd85db9 Reviewed-on: https://gerrit.libreoffice.org/75644 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15Simplify Sequence iterations in svlArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: I1c3dbf194600bec60c0881d2d19ff07b89d8333b Reviewed-on: https://gerrit.libreoffice.org/75563 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-15Simplify Sequence iterations in svtoolsArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: I4197b5083327998169a39389b968e1ff99f13339 Reviewed-on: https://gerrit.libreoffice.org/75440 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-15Revert "convert some plugins to use the sharedplugin infrastructure"Noel Grandin
This reverts commit fc1b213d157afa57704cec5a0fb65ae8c11d7822. I didn't convert these correctly, the Traverse calls need adjusting.
2019-07-15make tools::Rectangle::getBottom return 0 when emptyNoel Grandin
LayoutConverter::calcAbsRectangle needed to be tweaked because we now end up with a zero width/height instead of a large negative number. Change-Id: I81f04759a1d5bf6f44753a1701596796fad40567 Reviewed-on: https://gerrit.libreoffice.org/75610 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-15ofz#15797 Integer-overflowCaolán McNamara
Change-Id: I623c934f5bb031d383dcf1ce779521a942f99bdf Reviewed-on: https://gerrit.libreoffice.org/75634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15restore show expandersCaolán McNamara
Change-Id: Ied499bc79e3e445f632b0f1939f89a12df73f467 Reviewed-on: https://gerrit.libreoffice.org/75636 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15ofz#15731 Direct-leak RedlineExtraData is copiedCaolán McNamara
Change-Id: I363c91125ecc78e746865cf1fba5913730e0d8e7 Reviewed-on: https://gerrit.libreoffice.org/75633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15tdf#125783 - .uno:WhatsNew command lacks name and tooltipHeiko Tietze
Label and tooltip added to GenericCommands Change-Id: I292c377aed146196f1a9c3cc92f122b9b14c9b70 Reviewed-on: https://gerrit.libreoffice.org/75632 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-15convert some plugins to use the sharedplugin infrastructureNoel Grandin
Change-Id: I690d9df436abdadc51a6d3f7df686a2e37f79f73 Reviewed-on: https://gerrit.libreoffice.org/75624 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-15cid#1448277 RV: Bad use of return valueCaolán McNamara
Change-Id: I68fdfc59de2d2590730abaae8b16bfe92e1693b2 Reviewed-on: https://gerrit.libreoffice.org/75629 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15qtcreator: Recursively include module's header filesMichael Weghorn
Recursivley walk the include directories located inside the current module's directory, since includes are basically paths relative to the include directories and can refer to files in subdirectories of the include path, like e.g. #include <extended/AccessibleBrowseBoxBase.hxx> in 'accessibility/source/extended/AccessibleBrowseBoxBase.cxx'. This way, such header files are added to the .pro files and are thus e.g. shown in Qt Creator's project view and can be found by using 'a <FILEANME>' in the Locator. Change-Id: Id74f971b2ffee82203f74a4d444c41166c671920 Reviewed-on: https://gerrit.libreoffice.org/75628 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-07-15cid#1448276 Dereference null return valueCaolán McNamara
Change-Id: I1f11115b730cb51d0aa59b99e15b5dacff4cd68e Reviewed-on: https://gerrit.libreoffice.org/75572 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15add material design color paletteandreas kainz
Change-Id: I3cc869382bc2c91ee400c484c936a5c6ea77891f Reviewed-on: https://gerrit.libreoffice.org/75377 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-15cid#1448232 Unchecked dynamic_castCaolán McNamara
Change-Id: Ice3f3b2453c0b38288e859bfa87d582365570377 Reviewed-on: https://gerrit.libreoffice.org/75630 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-15writerfilter: turn on clang-format for SdtHelperMiklos Vajna
This had manual consistent formatting. Recently it was broken, so bring back consistency by using clang-format. Change-Id: I1e4c127b20a2755cda72a35110b6ef8413bac548 Reviewed-on: https://gerrit.libreoffice.org/75621 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
generated by cgit (git 2.34.1) at 2025-02-28 16:11:26 +0000