summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-04remove controlprimitive2d.hxx from clang-format blacklistTomaž Vajngerl
Change-Id: I8918f8c9e4f27a287c98dadd51a11acf3338daa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87942 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04use "pragma once" in controlprimitive2d.hxxTomaž Vajngerl
Change-Id: I5e694b478501edb3d2b5071f48da290367cda3c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87941 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04clean-up namespaces in borderlineprimitive2d.hxxTomaž Vajngerl
Change-Id: If05757ee32027793f57e10f94b836c1a11bfc773 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87940 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04remove borderlineprimitive2d.hxx from clang-format blacklistTomaž Vajngerl
Change-Id: I9e8efbf2a947688fe3ec74fa1b2175a089b91a9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87939 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04use "pragma once" in borderlineprimitive2d.hxxTomaž Vajngerl
Change-Id: I3582f36b0435de343d1e8574bf2bb0e0bd40e16b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87938 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04clean-up namespaces in backgroundcolorprimitive2d.hxxTomaž Vajngerl
Change-Id: I7ef644edf90ced417cf9583175ef777fa921dc94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87937 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04remove backgroundcolorprimitive2d.hxx from clang-format blacklistTomaž Vajngerl
Change-Id: I8ad988dd0eb6a4bbbe9fc9bbc773c692cab4401f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87936 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04use "pragma once" in backgroundcolorprimitive2d.hxxTomaž Vajngerl
Change-Id: I50a2395a42ea523247d0aeff02324988edbcdc77 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87935 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04clean-up and join namespaces in animatedprimitive2d.hxxTomaž Vajngerl
Change-Id: I9c60f2f9e12fe0271efa8546cbcef08178f9552c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87934 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04remove animatedprimitive2d.hxx from clang-format blacklistTomaž Vajngerl
Change-Id: I6e4b2bc524a0880631735fb79b3545e88bf50f0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87933 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04use "pragma once" animatedprimitive2d.hxxTomaž Vajngerl
Change-Id: I5b41a6fd1ce82615b8a3f8382f4d5d9a8c70999d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87932 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04remove use of macro DeclPrimitive2DIDBlock in drawinglayerTomaž Vajngerl
It's quite a usless macro actually. It is forced that every class implements this method anyway. This gets rid of usages in the drawinglayer module first. Change-Id: Ic2b2e7d5b72a8e0f7ea0748d0ea44cd38cf8c1ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87905 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-04Control must be a complete type here (Windows --disable-pch)Stephan Bergmann
...because of ControlLayoutData::m_pParent member and implicitly defined copy/ move functions of VCL_DLLPUBLIC ControlLayoutData Change-Id: I2328bd5128ac778f54fcaec204c92d28c505f040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87897 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-04loplugin:nullptr (clang-cl)Stephan Bergmann
Change-Id: I08dedd4f7af3eff1201d60704324997bf232bb2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87888 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-04move some headers inside ucbhelperNoel Grandin
Change-Id: Iccd80aa4e631abe002837ca61248e136de9a62eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87866 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-04tdf#42695 Fix a couple Writer Navigator "List Box" related bugsJim Raykowski
This patch resolves: 1) content not shown when Navigator is docked from a floating zoomed-in ("List Box" item unchecked) state 2) "List Box" item is visible when the Navigator is in docked state on document open. Change-Id: Id1fcaf0b581e26aabd4fd897ff142a60d6761e1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87758 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-02-03loplugin:stringadd (clang-cl)Stephan Bergmann
Change-Id: Id5babe1e16c8f8a8c72077fc95508a567138766a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87889 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03Avoid loplugin:unsignedcompare (clang-cl)Stephan Bergmann
Change-Id: I95f348cc8b69b6c865ad0038b9ee0017def01e43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87896 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03Silence loplugin:unnecessaryoverride in WinSalInstance::GetBackendCapabilitiesStephan Bergmann
...(vcl/win/app/salinst.cxx) in case the #if HAVE_FEATURE_SKIA #if SKIA_USE_BITMAP32 ... block it contains is excluded (when building with clang-cl on Windows) Change-Id: I60910106bbd6a4c2cb3f393945a5417eb02407c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87898 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03Silence loplugin:duplicatedefines for WIN32_LEAN_AND_MEAN (clang-cl)Stephan Bergmann
...as seen at > In file included from desktop/win32/source/QuickStart/QuickStart.cxx:29: > In file included from include\systools/win32/uwinapi.h:25: > include\prewin.h(38,9): error: duplicate defines [loplugin:duplicatedefines] > #define WIN32_LEAN_AND_MEAN > ^ > desktop/win32/source/QuickStart/QuickStart.cxx(24,9): note: previous define [loplugin:duplicatedefines] > #define WIN32_LEAN_AND_MEAN > ^ (An alternative fix could be to replace all those defines of WIN32_LEAN_AND_MEAN prior to including windows.h with includes of prewin.h and postwin.h?) Change-Id: I0271b5629af8f4ecfb3c90f1455bad399174f6ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87880 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03Missing include (std::isspace)Stephan Bergmann
Change-Id: I17b9acfd265e112ffdd115df06070136a6940804 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87895 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03loplugin:makeshared (clang-cl)Stephan Bergmann
Change-Id: I0c786bf401e514f9d86e33d8ab6366fc5dd1f425 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87887 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03remove bitmapprimitive2d.{cxx,hxx} from clang-format blacklistTomaž Vajngerl
Change-Id: I9d9d7cd8bba489c71a5c1ac0b23755d572696e10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87904 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-03drawinglayer: clean-up namespace and indent for BitmapPrimitive2DTomaž Vajngerl
Change-Id: I43f2030aeabed555baca20e345732ec926963d7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87903 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-02-03DOCX export: fix table style config handling wrt nested tablesMiklos Vajna
The bugdoc had 2 tables: both using the TableGrid table style, but one had a direct formatting to disable all borders. The second was in the A1 cell of the first, and given that the table style config state was not separated for nested tables, the border settings of the inner table affected the settings of the later cells of the outer table. Change-Id: Ie7897bc661d9f47ca9f5c1b3ed1c439ef0406037 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87899 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-03Set INSTALLLOCATION in one single placeMike Kaganski
It used to be set both in AppSearch action (using RegLocator table), and in MigrateInstallPath custom action. This would overwrite value of INSTALLLOCATION taken from user, and read on the previous step, with values taken on the next step. Only migrating the install location in one single place - in custom action MigrateInstallPath - makes the process controllable. Also it allows to easily see all the various places in registry we read. Change-Id: Ib7e04c26e71ba92c6a62a0511971bfb3bdb7db72 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87867 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-02-03Silence -Werror,-Wunused-variable (clang-cl)Stephan Bergmann
Change-Id: Icbf3b6f8f1259e7e50f64e2885b1604f1a98f485 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87894 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03loplugin:redundantpointerops (clang-cl)Stephan Bergmann
Change-Id: I5ce235a72aedc507dbb925db4927f291916716d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87893 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03-Werror,-Wunused-variable (clang-cl)Stephan Bergmann
...found with 2db9a6813a3640005d9b38e419d5cc55f70b03cc "flush out unused MapModes" in code that had not used the variable ever since it got introduced with dd2f230139525891d60e06b4afdc977d5630d4e9 "INTEGRATION: CWS graphicapi" Change-Id: I7412a3badeec546ed1dff8dcf905036f06287e70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03loplugin:duplicatedefines (clang-cl)Stephan Bergmann
(already defined in vcl/inc/opengl/win/WinDeviceInfo.hxx) Change-Id: Ic785a934c16c8a2f3442ff7975f9a84fbc6001c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87891 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03loplugin:duplicatedefines (clang-cl)Stephan Bergmann
(already defined in hwpfilter/source/hwplib.h) Change-Id: Id85048817b825ad265eba20e221c0703467b66b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87890 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03loplugin:unsignedcompare (clang-cl)Stephan Bergmann
Change-Id: I69cc1b352221ca053ccd0c5b78e926480a8c9ccd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87884 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03Remove unnecessary castStephan Bergmann
Change-Id: I675d9e0a87a54eb08abfca114864369b326fb128 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87882 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03make some headers privateCaolán McNamara
as shown with ./bin/find-headers-to-move-inside-modules.py Change-Id: I7662417e76fe00c0fc352957560e104b6c2a3d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03Related: tdf#129933 assert on pasting over selection in editCaolán McNamara
when its selected right to left with cursor flashing at the start format->paragraph->area->color->pick, cursor into hex# edit, end to cursor at the end, shift + home to select all, right to left, ctrl+c, ctrl+v, assert Change-Id: I8e29108ddff94487c298bd5e6607b98f5f841afd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87883 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03Resolves: tdf#130364 let font treeview fit to available dialog spaceCaolán McNamara
Change-Id: Ia000f4cfa041733fc84b45c955e69251c3ce9bcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87871 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03Resolves: tdf#130061 numbering dialog adjustments missingCaolán McNamara
since... commit e82b10f21cb8b77f815be3bd7654e0de7e8ceab5 Date: Sun Oct 20 00:44:05 2019 +0200 tdf#128257 Bullet Dialog update so spinbuttons were disabled Change-Id: Id8d54bd6ba359447943832920fce5e0da271f405 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87878 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03Resolves: tdf#130347 we always need the drag-begin signal in GtkTreeViewCaolán McNamara
Change-Id: Icbd8ab1393e25b698b034341b526b3a55251610d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87876 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03Related: tdf#130143 freeze/thaw around bulk insertCaolán McNamara
Change-Id: Iedb1229b56b5e7f1af1779b830cf324bcc8735e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87862 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-03Optionally generate PDBs also for C#Juergen Funk
Enables pdb generation for symbol builds, for: - cli_basetypes.dll - cli_cppuhelper.dll - cli_uno.dll - cli_ure.dll Not covered are: - cli_oootypes.dll - cli_uretypes.dll ..as sadly climaker generates those, and can't produce PDBs. Change-Id: I6004e06f9f2a76b4577ad9a4de971f46ad6bf521 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87727 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-03avoid flex-caused warnings about unused functionsLuboš Luňák
Change-Id: If6a028efbf2403fd92dcab914ae3197d34579392 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87869 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-03handle -Wunused-function warnings in clang's sharedvisitor.cxxLuboš Luňák
Change-Id: I5fbf7da1da8c1c5b33e008e30898ca5d2cdfde65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87870 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-03Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to c3837f2e395c0606a3383a0594b2a6a759e8bac8 - tdf#128569 improve guide for page numbering Also: - update some <menuitem> and <h2> - update/add <keycode> - update menu commands for manual break and insert page number - add shortcut key for showing field codes (sys-conditional) - update "Default Style" to "Default Page Style" Change-Id: Ieec2be0c48da40f50a1145e8c0a57b190e8c67ba Reviewed-on: https://gerrit.libreoffice.org/c/help/+/87127 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-03tdf#96505: Get rid of cargo cult long integer literalsDesmin Alpaslan
Change-Id: Id64855e3879d21106930a4dc9c36b246deb3c6e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85818 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03tdf:#54938Adapt supportsService implementations to cppu::supportsServiceiakarsu
Change-Id: I9e2dbdfb8bbf5be4a74b1b581e742b3193b3756b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87496 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03tdf#54938: Adapt supportsService implementations to cppu::supportsServiceHakan Bakacak
Change-Id: I4f6defffc7489ae95af3e2758327a26374795969 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87501 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03tdf#75280: Convert inappropriate use of sal_uIntPtr to better integer typesSarper Akdemir
Change-Id: If0c39b85dc5fc8c84b723e03159abbdd790e42ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87453 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03There should be no need to mark nested PropertyPairHash as SVXCORE_DLLPUBLICStephan Bergmann
For one, the surrounding class SdrCustomShapeGeometryItem is already marked SVXCORE_DLLPUBLIC (whether or not that impacts the default export status of the nested struct on the various platforms, though). And, for another, the struct only has inline members (which should make the previous point moot). Also, to be on the safe side, mark the PropertyPairHash member function as inline already on its first declaration. (This is a follow-up to ff546a5dd35d6a31f01c70a9b995afc1f7b7389e "tdf#128302: Split SVXCORE_DLLPUBLIC from SVX_DLLPUBLIC".) Change-Id: I6716a589060d816ca822583711d0e559ea114fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87865 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03Change class with only static member functions into namespaceStephan Bergmann
...and drop the SVX_DLLPUBLIC as all the functions are inline. (The class had introduced as SVX_DLLPUBLIC with 1386c348f81738a9966d1217db89d1f603466317 "fdo#82616: set limits on spinboxes according to size of workarea", but for no obvious reason. It now showed up among the "10 @@@ [that] ask for follow-up clean up" at ff546a5dd35d6a31f01c70a9b995afc1f7b7389e "tdf#128302: Split SVXCORE_DLLPUBLIC from SVX_DLLPUBLIC".) Change-Id: I366b19d596da7cf44a192b1faf47e8ea75d25685 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87860 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-03sw: set unique name for fontwork object and style on insertionVasily Melenchuk
Unique name for fontwork is required to be displayed in Navigator pane, unique style name is important for correct undo/redo work. Change-Id: If633d0fda9bb98558a311dd1dd9324f9d6d04616 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87056 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2025-02-28 15:25:40 +0000