summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-01-24Fix typoAndrea Gelmini
Change-Id: I4dfa637c76e28f820f60388315631d57669b15bf Reviewed-on: https://gerrit.libreoffice.org/66766 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-01-24loplugin:constparams in sd..svtoolsNoel Grandin
Change-Id: I50b864ffc4ed13ba801af46815988bf568b83d2e Reviewed-on: https://gerrit.libreoffice.org/66832 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24tdf#96892 vcl: add unit test for misplaced soft-hyphen ...Michael Stahl
... due to incorrectly exported font size. Change-Id: If06dccc000530427be767fc7a5031f5ebe6fd431 Reviewed-on: https://gerrit.libreoffice.org/66803 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-24vcl: unx: apply configuration to "Generic Printer" so it's PDF ...Michael Stahl
... by default, instead of leaving it with m_nPSLevel == 0 && m_nPDFDevice == 0. Change-Id: I44059ac39791442602cbc48582670d98edc578ee Reviewed-on: https://gerrit.libreoffice.org/66802 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-01-24Related: tdf#122662 unused conditionCaolán McNamara
seen while investigating tdf#122662 since... commit ff4b8d39e649ed56770b28550158b5148432ee48 Date: Wed Jul 1 20:58:14 2015 +0100 gtk3: disable using notification that we are in the backdrop there's no need for this code Change-Id: Iea7f30f8b9a601b0254e6472d8d33a1664ec18c0 Reviewed-on: https://gerrit.libreoffice.org/66804 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-24loplugin:constparams in swNoel Grandin
Change-Id: I4a0f51eae28c82eca3c44b9d06c0410f9645f62f Reviewed-on: https://gerrit.libreoffice.org/66833 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24loplugin:constparams in scNoel Grandin
Change-Id: Ie211eea01eaceb718f701d3fdbb6253700d14e5e Reviewed-on: https://gerrit.libreoffice.org/66831 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24LOK: sd: notify LOK of page size/orientation changeAshod Nakashian
Change-Id: I2eb92d83f50b91b39a10e22298d496668c1cbf72 Reviewed-on: https://gerrit.libreoffice.org/66775 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-01-24Revert "lok: custom widgets: render editbox borders"Ashod Nakashian
Looks like this is no longer needed to correctly render editbox borders. Not clear what fixed the issue. This reverts commit 7484f1691cbe9513dabf084effe8a0366b737a80. Change-Id: Ieb3b8d6f60ab762d0baccb341ed6a39ae2771e79 Reviewed-on: https://gerrit.libreoffice.org/66774 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-01-24CppunitTest_writerperfect_epubexport: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: I212301ffbad7dd975c0e16c1c71d471ec064c83f Reviewed-on: https://gerrit.libreoffice.org/66821 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-24cleanup ImplImageTree.cxx - whitespace, remove unneeded css::Tomaž Vajngerl
Change-Id: Ic0c4d10d60bddc461fc20e98b8424c4e8480ee6e Reviewed-on: https://gerrit.libreoffice.org/66822 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-24Simplify containers iterations in sc/source/filter/[h-o]*Arkadiy Illarionov
Use range-based loop or replace with STL functions Change-Id: I7e024d5bf97d942b8b43465e0779cf9e30df8eb0 Reviewed-on: https://gerrit.libreoffice.org/66827 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24tdf#122901 track changes: keep paragraph top and bottom bordersLászló Németh
applied in Show Changes mode, instead of losing them after saving the document or hiding the changes. The bug occurred in paragraphs with directly preceding tracked deletions. Change-Id: I25a84aec0159f809dd7b67d4e530e87b01070f44 Reviewed-on: https://gerrit.libreoffice.org/66800 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-01-24tdf#122893 track changes: keep paragraph alignmentLászló Németh
and preset line spaces applied in Show Changes mode, instead of losing them after saving the document or hiding the changes. The bug occurred in paragraphs with directly preceding tracked deletions. Change-Id: I33d9db8ee3522470c4f2dfdcfbea4060db8769a2 Reviewed-on: https://gerrit.libreoffice.org/66789 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-01-24loplugin:constparams in dbaccess..ooxNoel Grandin
Change-Id: I9c04906dd492c6f8a816f57f40bc31406a871a78 Reviewed-on: https://gerrit.libreoffice.org/66793 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24loplugin:constparams in connectivity..cuiNoel Grandin
Change-Id: Ia2ae97498a9aad8638c4b77ce20143eeec616751 Reviewed-on: https://gerrit.libreoffice.org/66792 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24loplugin:constparams in basctl..chart2Noel Grandin
Change-Id: I9ac9a34ba58f411d5aad235407553df63216319c Reviewed-on: https://gerrit.libreoffice.org/66791 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-24Fix typosAndrea Gelmini
Change-Id: I371d987884987fab8039c3329968f7a9282455f2 Reviewed-on: https://gerrit.libreoffice.org/66829 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-24Add WordBasic.FileClose()Tor Lillqvist
Change-Id: Ifc48e5fbcc212f0e80cf6877e2781910e38e5e54
2019-01-23tdf#45904 Move XIndexAccess Java tests to C++Jens Carl
Move XIndexAccess Java tests to C++ for ScSheetLinksObj. Change-Id: I1662766ab9026da7c8ce97953e4f690d94c2d479 Reviewed-on: https://gerrit.libreoffice.org/66816 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-23tdf#45904 Move XElementAccess Java tests to C++Jens Carl
Move XElementAccess Java tests to C++ for ScSheetLinksObj. Change-Id: I8265bb9234c93e8a6e64b55522e7f0543b3af7a9 Reviewed-on: https://gerrit.libreoffice.org/66815 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-23tdf#45904 Move XEnumerationAccess Java test to C++Jens Carl
Move XEnumerationAccess Java test to C++ for ScSheetLinksObj. Change-Id: I68013a9717ab8da1dd4b15f489fc394c101cc016 Reviewed-on: https://gerrit.libreoffice.org/66814 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-23Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - Fix some typos Change-Id: Ife8c609e1db336417077a31d8a549614e00bd91b
2019-01-23Bullets: Use relative size when it's supportedTamás Zolnai
In Writer it might cause a problem to use relative size with text based numberings. Change-Id: Id19b5e45f0f932d1b69028f343daad7dec34ae23 Reviewed-on: https://gerrit.libreoffice.org/66811 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-01-23Drop use of obsolete GCC -fno-default-inlineStephan Bergmann
...that is documented as: "Does nothing. Preserved for backward compatibility." ever since <https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=160384> from 2010. -fno-default-inline was the only value ever set in gb_DEBUG_CXXFLAGS, so the latter can be removed now. The use of gb_DEBUG_CXXFLAGS had accidentally already been removed from gb_LinkTarget__get_debugcxxflags with e751e24250fda31dde52b3c65ca79f86142dc789 "--enable-optimized should be orthogonal to --enable-debug/--enable-dbgutil", and that leaves gb_LinkTarget__get_debugcflags and gb_LinkTarget__get_debugcxxflags with identical definitions, so replace those two with a single gb_LinkTarget__get_debugflags. Some external modules had used only gb_DEBUG_CXXFLAGS, when this was apparently meant to be used in addition to gb_DEBUG_CFLAGS, so those uses have been changed to gb_DEBUG_CFLAGS now. Change-Id: I84ea0ab1233569b0b02ca057240a71f138352381 Reviewed-on: https://gerrit.libreoffice.org/66808 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-23rhbz#1667364 Open doc as R/O for which open(...,O_RDWR) returns EOPNOTSUPPStephan Bergmann
Map that EOPNOTSUPP to osl_File_E_NOSYS (and intercept it in StillReadWriteInteraction, as used by MediaDescriptor::impl_openStreamWithURL in unotools/source/misc/mediadescriptor.cxx, which will retry opening it read-only then), instead of to osl_File_E_invalidError (which lead to the "General input/output error" box). Instead of "silently" opening the doc as read-only, this still pops up a box claiming that the doc is locked by somebody else, asking whether to open it read-only or to open a copy. That's probably because of the rDescriptor.erase( utl::MediaDescriptor::PROP_READONLY() ); in TypeDetection::impl_openStream (filter/source/config/cache/typedetection.cxx) where the comment already hints at the confusion among the different read-only and locking concepts. Changing that looks like it would easily cause regressions, so is left for a follow-up commit. (And ultimately LO wouldn't need to treat the doc as read-only at all; it would just need to not attempt to open it O_RDWR upfront, and save it via copy+rename, like other apps appear to commonly do.) Change-Id: I56e18f1864084ba222acaf0e38a604082edaf4c6 Reviewed-on: https://gerrit.libreoffice.org/66805 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-23Related: tdf#122241 improve applying persona for additional menubarsCaolán McNamara
Change-Id: Ic968b022e3b37a9329ca29708f53b36f0e7b2ce9 Reviewed-on: https://gerrit.libreoffice.org/66797 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23Related: tdf#122874 first entry is preselectedCaolán McNamara
so no select-handler called Change-Id: I0398b53b24fa8095af67706922c93bb7e8d6d8d2 Reviewed-on: https://gerrit.libreoffice.org/66799 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23give email settings dialog a titleCaolán McNamara
Change-Id: Id073f9bc4ed4710ba29d7864f8d03a54fa14354c Reviewed-on: https://gerrit.libreoffice.org/66788 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23Related: tdf#122889 weld SwMailConfigPageCaolán McNamara
and reweld SwMailConfigDlg Change-Id: Icf7497db0cd2e9097752414eb11498c694723646 Reviewed-on: https://gerrit.libreoffice.org/66787 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23update creditsChristian Lohmaier
Change-Id: Ib5e07977b6dd15b533e94185ecb80d0d6587b7c7
2019-01-23Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' - Moved the pagination controls to the top As the height of the result list keeps changing constantly, it was highly annoying to click the arrows in the controls. Change-Id: I82308adc3971f25ed629009bf1e0854d38197560 Reviewed-on: https://gerrit.libreoffice.org/66795 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-23set these hidden widgets to insensitiveCaolán McNamara
UpdateName_Impl is called if its sensitive, regardless of hidden and it makes no sense for the character style to update it and results in unsightly warnings of... ... gtk_tree_model_iter_nth_child: assertion 'n >= 0' failed ... gtk_list_store_remove: assertion 'iter_is_valid (iter, list_store)' failed Change-Id: Iaca6104ebb5e44ce45a7bb01a348f9c5f54de876 Reviewed-on: https://gerrit.libreoffice.org/66778 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23tdf#90097 rtfimport: rewrite unit test so it run reliablyJustin Luth
Already broken for windows and mac, the numbers changed for me on Ubuntu when switching from gcc5 to gcc7 or gcc8. How it still works on the tinderboxes etc I don't know. Anyway, by removing the obviously irrelevant actual numbers, the test still covers the original intent by ensuring that the top point is farther to the right than the bottom point. Change-Id: Ieeb7cd854847d47a11dc305db82371e2b8f85049 Reviewed-on: https://gerrit.libreoffice.org/66724 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2019-01-23tdf#115094 part III: DOCX export: export floating tables directlyPatrick Jaap
If a floating table was imported from docx, it will be placed in a frame. A grabBag attribute remembers the original positioning values. Restore this state when exporting to docx again and do not export the surrounding frame. This has to be done at the start of a paragraph, so remember the exported table in a std::set and skip it later in frame export. Change-Id: Ib62d4b228b306e5d1c4ce61fbbd4b6c3e1206603 Reviewed-on: https://gerrit.libreoffice.org/65982 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-23Replace macro with templateStephan Bergmann
Change-Id: I0b444eae51b65caf740e625e65137ff9ff8ce4da Reviewed-on: https://gerrit.libreoffice.org/66782 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-01-23Resolves: tdf#122889 Mail config dialog is emptyCaolán McNamara
revert... commit 7ec12ce7e449d7849b3e67c443783110e2a50a17 Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Sep 28 20:24:35 2018 +0100 weld SwMailConfigDlg the contained page needs to be converted first Change-Id: I9788132b0ad11cec853be7339be1829386794511 Reviewed-on: https://gerrit.libreoffice.org/66781 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' - Add more python examples Change-Id: Id34674cd96d615b8613a35e18d96886a3d39bae0 Reviewed-on: https://gerrit.libreoffice.org/66763 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-01-23Resolves: tdf#122480 make style dialogs take their optimal sizeCaolán McNamara
and let them resize given that they add/remove tabs depending on the language settings. Leaving them unresizable will result in them too large on switching from ctl+cjk to without Change-Id: I56027b1c737822d170416ff4e2497745cb3889ff Reviewed-on: https://gerrit.libreoffice.org/66779 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-01-23loplugin:constparams in svxNoel Grandin
Change-Id: Ie37288e4b9f064e309df81830f3a07507525bc55 Reviewed-on: https://gerrit.libreoffice.org/66771 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-23loplugin:constparams in filterNoel Grandin
Change-Id: Ia7bba27371db1a23a42d77df4c4bfc975fa0366b Reviewed-on: https://gerrit.libreoffice.org/66770 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-23loplugin:constparams in sfx2Noel Grandin
Change-Id: I27102bc0e7d92d50e89248d463fb3fe4048536f3 Reviewed-on: https://gerrit.libreoffice.org/66769 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-23Test for XmlWalker to check it parses the xml as expectedTomaž Vajngerl
Change-Id: Icf6bc7eee09b469f460080b6937fad93de6dbd39 Reviewed-on: https://gerrit.libreoffice.org/66772 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-01-23loplugin:constparams in xmloffNoel Grandin
Change-Id: I8874c9204b8bf8f422fb5bb826a340b787589360 Reviewed-on: https://gerrit.libreoffice.org/66768 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-23loplugin:constparams in vclNoel Grandin
Change-Id: Icf1a952fbe190fd6c4efd89364136aa2b48050e3 Reviewed-on: https://gerrit.libreoffice.org/66767 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-01-23tdf#42949 Fix IWYU warnings in sc/source/filter/*cxxGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Clean remaining cxx files in directories: dif/ ftools/ html/ lotus/ orcus/ qpro/ rtf/ xcl97/ Change-Id: I219b61c087c07b0538b4525bf53d79f413d409c5 Reviewed-on: https://gerrit.libreoffice.org/66657 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-23sw: prefix members of SetGetExpFieldMiklos Vajna
Change-Id: I1ad767fa4dfbf4f3055cc94778c13bfe169f79af Reviewed-on: https://gerrit.libreoffice.org/66753 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-01-23Add XServiceInfo tests to ScDrawPagesObjJens Carl
Change-Id: Ide03e22eb52d22d3a367e2a75af5e08d2c86909c Reviewed-on: https://gerrit.libreoffice.org/66762 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-01-23fix DBG_UTIL macro blockNoel Grandin
ever since commit cef4c601d825027e807236a5b364edddb39be809 Date: Mon May 27 12:52:19 2002 +0000 #98405#: more debugging code for macro recording Change-Id: I7e7f4d917e4efabc7bd3bdef824f389c4f715b7a Reviewed-on: https://gerrit.libreoffice.org/66741 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-01-23remove FWS X11 protocol stuffNoel Grandin
so old even google can find no mention of any of this Change-Id: I82b1470c3c903b26718cbe244b98584575d75cef Reviewed-on: https://gerrit.libreoffice.org/66740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>