summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-05sw: prefix members of HTMLAttrMiklos Vajna
Change-Id: I9f87913ce537e634f8c10ddfee59002293c1fc3f Reviewed-on: https://gerrit.libreoffice.org/62872 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-11-05mysqlc: allow multiple open statementsTamas Bunth
Change-Id: I07e57ea7d9e6af1c7543483b1ab54a0b8c5be2d5 Reviewed-on: https://gerrit.libreoffice.org/62640 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-11-05tdf#108687 vcl: always enable tabstop on radio buttonsJustin Luth
...as long as they are not WB_NOTABSTOP of course, just like checkboxes. Even though all of the radio buttons are now marked as WB_TABSTOP, the tab still only stops once inside the radio group. That's perfect. Without this, if none of the radio boxes was checked, then the entire group was tab-skipped. As a copy/paste programmer, I don't know how to test this because there were no close enough examples to follow. Change-Id: I3c559fb274d736cbd2f56a6a8ddc1ca5a2cfe681 Reviewed-on: https://gerrit.libreoffice.org/62822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-05tdf#120703 PVS: V547 Expression '!pRTLData' is always falseMike Kaganski
Let SbiInstance::GetRTLData() return reference Change-Id: Iafe7e64f6f296b478003ce66ea66936a65ba9edc Reviewed-on: https://gerrit.libreoffice.org/62855 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-05-Werror,-Wunused-local-typedefStephan Bergmann
...after e06afb0c9546ddcde1cedd75f59001396ac6fdf2 "Simplify containers iterations in ucb, ucbhelper" Change-Id: I03b9408ea12be2a1b1b620bd2decf5658356a452
2018-11-05lok: update the test for singing the document from LOKTomaž Vajngerl
Change-Id: Ie34d8c26bfbf4192cd2067c8315030903edb3fb3 Reviewed-on: https://gerrit.libreoffice.org/62274 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-11-05tdf#120703 PVS: V547 Expression is always trueMike Kaganski
The inner check looks suspicious. Still, I don't think that intended behavior was to check nFillDefault, because in that case the next line would likely start with "else if". The change just keeps current behavior; I make this an individual commit to keep the decision's context. Change-Id: I67d37aa0fee82190ce4bba5784b76c9f522b97ff Reviewed-on: https://gerrit.libreoffice.org/62864 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-05tdf#120534 Make escape key focus to document from sidebarJim Raykowski
from all locations other than panel content Change-Id: I85a113d3001338dd1aff27bac75a5debd4635d59 Reviewed-on: https://gerrit.libreoffice.org/62808 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-05tdf#120473 Change sidebar panel content tab navigation behaviorJim Raykowski
Change-Id: Ifa5d52ffed32a4fe0bfe75fb731ee79d0976c0cf Reviewed-on: https://gerrit.libreoffice.org/61949 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-05tdf#105225 new background tab pageJim Raykowski
This patch allows the new background/highlighting tab page and derived from area tab page to work correctly in the same tab dialog. It also provides a cleaner way to use the new background tab page by setting brush item as fill attributes to target set in the background tab page created method. Previously if the new background tab page and the area tab page were used in the same tab page dialog one would affect the other due to the same use of pool fill items. This patch makes a local copy of the attribute item set passed and then passes that set along to the parent class area tab page on each activation/deactivation. Tab page dialogs that use both the background and area tab pages are: Writer Paragraph Styles, Impress Presentations Styles and Drawing/ Graphics Styles, and Draw Drawing/Graphics Styles. All new background tab page merged patches have been reworked in this patch and remaining old background tab pages, with the exception of Report Design, have been replaced by the new tab page. Change-Id: I47f9ae10a0fd967729ff6e83c1a312aa49e1d13c Reviewed-on: https://gerrit.libreoffice.org/57102 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-05loplugin:useuniqueptr in LocaleDataWrapperNoel Grandin
just use OUStringBuffer here, and consequently avoid re-implementing such string-buffer handling code Change-Id: I61e39dada6f46478b9d289f0310bb6846eb9868b Reviewed-on: https://gerrit.libreoffice.org/62646 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-05tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I8217b1a0b6ccc29052257d54ba7844c0970ad9a4 Reviewed-on: https://gerrit.libreoffice.org/62859 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-05tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I4b48dddeaabf6b321196b537bb7aa55a89ab8fe3 Reviewed-on: https://gerrit.libreoffice.org/62863 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-05tdf#120703 PVS: this fix was wrongMike Kaganski
This partially reverts commit 2a3f5d11522cd69f0ce221cde3a63b7e85e94b53 to reimplement the proper index check. Thanks to Svyatoslav Razmyslov. Change-Id: If0928eed8ff137efbb2d7605135375d147e9accf Reviewed-on: https://gerrit.libreoffice.org/62862 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-05tdf#118244 pdfexport: radio buttons can group with same nameJustin Luth
The old implementation grouped radio buttons if their object name was the same, and didn't have a groupname property. The old implementation still works - so that still needs to be supported, which this patch ensures. Change-Id: Ied6ddc52d1c4ab5bca56b14da51258460ca2120c Reviewed-on: https://gerrit.libreoffice.org/62812 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-11-05tdf#118244 pdfexport: radio buttons use groupname nowJustin Luth
The previous implementation grouped radio buttons if their object name was the same. Likely this is a very old implementation, because the current radio buttons have a groupname property which links them together (although that too needed fixing in doc/docx), and their object names are unique. The old implementation still works - so that still needs to be supported, but I think I'll do that in a separate patch, so that it can be easily reverted if the old implementation is deprecated. Edge cases tested: -groupID of 0 works fine - doesn't have to be 1-based. -empty group name works fine (but breaks the old impl). -writer, calc, Change-Id: I84aebdac18b9edfa5ffcbfb23c15d0f37fcd47d1 Reviewed-on: https://gerrit.libreoffice.org/62742 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-11-04[Pardus] ability to change slide nameMert Tumer
This patch is sponsored by ULAKBIM/Pardus project. Signed-off-by: Mert Tumer <merttumer@outlook.com> Change-Id: I6361e3d23b03e5463d165f7f02dacad8be9206da Reviewed-on: https://gerrit.libreoffice.org/62861 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.1004@gmail.com>
2018-11-04[Pardus] Make the slide change command accessible.Gulsah Kose
Allows to call uno:RenamePage from the android viewer and LibreOffice online. This patch is sponsored by ULAKBIM/Pardus project. Change-Id: Ife814846bd7076e9f8830bce4c2451cb6b44a15a Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/62860
2018-11-04crashtesting: kde124742-1.html cannot trust header to be valid asciiCaolán McNamara
Change-Id: Ia073dcbf0a0a4d2f3df1f58d0e140f68e830182b Reviewed-on: https://gerrit.libreoffice.org/62856 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-04coverity#1440843 help coverity out wrt Wrapper object use after freeCaolán McNamara
Change-Id: I2f03cd950d37fc00ab4fe71693e717e82f242254 Reviewed-on: https://gerrit.libreoffice.org/62851 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-04coverity#1440838 Unchecked return value from libraryCaolán McNamara
Change-Id: I200a7be1eefdd2764e79b31ba1950a7b3d97d0b4 Reviewed-on: https://gerrit.libreoffice.org/62850 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-04coverity#1440840 Uninitialized pointer fieldCaolán McNamara
Change-Id: I794ec0a173fb20dc0e0d1cf1717a5ad903f9ba7d Reviewed-on: https://gerrit.libreoffice.org/62848 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-04Fix nullptr exception in presentation on AndroidMert Tumer
Change-Id: If54c26f66466ee591d198aaf3f8f68ba04e5f4b3 Signed-off-by: Mert Tumer <merttumer@outlook.com> Reviewed-on: https://gerrit.libreoffice.org/62774 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.1004@gmail.com>
2018-11-04coverity#1440839: COPY_PASTE_ERRORJulien Nabet
Regression from 39e0bbfdf77cf9653ec68ffcb4374d929838b2a8 Change-Id: Ibb0dea1a78ccf3ef446bbbaad28945f1ac8bdf48 Reviewed-on: https://gerrit.libreoffice.org/62834 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-11-04coverity#1440844 Uninitialized pointer readCaolán McNamara
Change-Id: I5ae1c023bfff4f5d45f8ea8104a58dbd89a5d983 Reviewed-on: https://gerrit.libreoffice.org/62852 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-04tdf#120703 PVS: V547 Get rid of mutexes to initialize function-local staticsMike Kaganski
Also fix an infinite recursion when VCLXHatchWindow::getTypes() called VCLXHatchWindow::getTypes() when initializing its static. Change-Id: I19b8b1e1b367ddf636f905fb141c7690e21f67f8 Reviewed-on: https://gerrit.libreoffice.org/62825 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-04fix indentCaolán McNamara
Change-Id: Ia34b3b326fa48e92f3172b9930c0a985fda6022d Reviewed-on: https://gerrit.libreoffice.org/62849 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-04reweld SwWordCountFloatDlgCaolán McNamara
fixing up the bit that failed the last time Change-Id: I235f8f92cbc0c3e31837e01a9b094580c6f5aecf Reviewed-on: https://gerrit.libreoffice.org/62786 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-04tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I3432afca1ee9bf9e8adce1d55d58d57bf1a09cb4 Reviewed-on: https://gerrit.libreoffice.org/62847 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-04Replace preprocessor macro with short function definitionsMike Kaganski
a2058e7516a01167c2d20ed157500b38db967c64 follow-up. Change-Id: I402cbab4f78daf0de9d1bfa88698d2b071fcabaf Reviewed-on: https://gerrit.libreoffice.org/62840 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-04replace double-checked locking patterns with thread safe local staticsMike Kaganski
Change-Id: I1bf67196e97411aeecc13ed4f91d1088a315e323 Reviewed-on: https://gerrit.libreoffice.org/62839 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-04replace double-checked locking patterns with thread safe local staticsMike Kaganski
Change-Id: Ie1aae7ecbd065a88b371d8c0deb586f54f7eff65 Reviewed-on: https://gerrit.libreoffice.org/62835 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-04-Werror,-Wunused-variableStephan Bergmann
...after 16b2b4f27acb83fc651b8484dead53ebd0e269e1 "Simplify containers iterations in sw/source/ui*" Change-Id: If94cd1b242debe44871fbaa050d270e06bf0171b
2018-11-04tdf#120703 VPS: V547 Expression is always true/falseMike Kaganski
Some convoluted conditions present from the start turn out to be redundant Change-Id: I296928c7ca3852ce3f7b21791440e1b21c64b32c Reviewed-on: https://gerrit.libreoffice.org/62824 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-04Update git submodulesStanislav Horacek
* Update dictionaries from branch 'master' - update readme for Czech dictionaries Change-Id: Iccc08a8535761418d5b8e01b642d5a18a5b7bedf Reviewed-on: https://gerrit.libreoffice.org/62809 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-11-03tdf#120703 PVS: V547 Expression is always falseMike Kaganski
Let FSStorage::GetContent() return reference. Change-Id: I6595f48d56f7eb9256600eb6ee1a569077fef92f Reviewed-on: https://gerrit.libreoffice.org/62823 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03uitest for Writer Table- Split tableZdeněk Crhonek
Change-Id: I95a46d206f846b5babaca41544442bcf8a8b7aa9 Reviewed-on: https://gerrit.libreoffice.org/62773 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-11-03tdf#120703 PVS: V1023Mike Kaganski
V1023 A pointer without owner is added to the 'm_aChartTypeDialogControllerList' container by the 'emplace_back' method. A memory leak will occur in case of an exception. Change-Id: I35bf344fd083c6a1717a150f78370ec59f206240 Reviewed-on: https://gerrit.libreoffice.org/62821 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I27bf92770431f6a1f35e1c8224c0847555a8d43f Reviewed-on: https://gerrit.libreoffice.org/62819 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Let ScEditFieldObj::getData() return reference. Change-Id: I4deed9a1692953088cf6d939508b9045e3e6cb3c Reviewed-on: https://gerrit.libreoffice.org/62816 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V547 Expression is always true/falseMike Kaganski
Change-Id: I75082c85862b83ed2503900186ce9c70783e54db Reviewed-on: https://gerrit.libreoffice.org/62817 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03tdf#120703 PVS: V581Mike Kaganski
V581 The conditional expressions of the 'if' statements situated alongside each other are identical. Check lines: 153, 181. Change-Id: Ifcec371bc2207bdd3594e514f0eab1d06dd24c84 Reviewed-on: https://gerrit.libreoffice.org/62820 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03elementary: add Calc contxt menu, fix unfilled shape, improve query/report, etcRizal Muttaqin
Change-Id: I5e9a4095ce3e114cfb6818264f669c7ac6207ad8 Reviewed-on: https://gerrit.libreoffice.org/62801 Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2018-11-03KJ: Fix for tdf#120300, tdf#120831, tdf#119731, tdf#111950 add Calc's sheet ↵Rizal Muttaqin
context menu, etc Change-Id: I66cde29f8b64c5212f748930b5575763f54e59bd Reviewed-on: https://gerrit.libreoffice.org/62818 Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2018-11-03Still use 'graphicsPort', even if deprecated in macOS 10.14Stephan Bergmann
...macOS 10.9 reportedly doesn't yet support the 'CGContext' replacement, see the comments to <https://gerrit.libreoffice.org/#/c/61353/> "loplugin:redundantcast". This reverts c3c88d6bbe4109fcf1a6d53e947faec775c96e42 "loplugin:redundantcast" (whose commit message was rather misleading; the redundantcast warnings were merely a follow-up to the commit's actual meat, of replacing deprecated uses of 'graphicsPort' with 'CGContext'; I had failed to realize that when I chunked the various changes necessary for 10.14 into several individual commits) and adds SAL_WNODEPRECATED_DECLARATIONS_PUSH/POP instead. Change-Id: I778d7c3a29c780beff561fbbcc38df9e1494114c Reviewed-on: https://gerrit.libreoffice.org/62815 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-03tdf#120703 PVS: V547 Expression is always falseMike Kaganski
This resulted from commit 009e3f4841378f13a2764a2c84e147e401b70525 which failed to replace some of numeric sprm ids with mnemonic names. Change-Id: Ie00a89bee02da383df0cbe27b093f3a1d25e8b03 Reviewed-on: https://gerrit.libreoffice.org/62813 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-03Simplify containers iterations in sw/source/filterArkadiy Illarionov
Use range-based loop or replace with STL functions. Change-Id: Ifffb7ba08b3a9950ee076558ec4048b0788a38c8 Reviewed-on: https://gerrit.libreoffice.org/62806 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-03Create a CG bitmap context in doc_paintWindow(), too, for iOSTor Lillqvist
Just like in doc_paintTile(). Now at least some of the dialogs work in the iOS app, yay. Change-Id: I10c7eeb1f121ba68a1af723d45575890b1d598da Reviewed-on: https://gerrit.libreoffice.org/62800 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-11-03For iOS, do actually export UI builder factory functionsTor Lillqvist
In the DISABLE_DYNLOADING case there is normally no need for functions marked with SAL_DLLPUBLIC_EXPORT to be exported, as these functions won't be dynamically looked up anyway. Thus, when DISABLE_DYNLOADING, SAL_DLLPUBLIC_EXPORT is defined in <sal/types.h> to actually mean __attribute__ ((visibility("hidden"))). But we do need to export the UI builder factory functions so that the osl_getFunctionSymbol() in VclBuilder::makeObject() finds them. (I kinda dislike looking up symbols with dlsym() from the same binary. We know that the function is there and what its name is, we could just call it directly. But makeObject() gets the function name as a string, so we would need a long set of string comparisons to select which function to call. A bit ugly. Let's see if I can come up with something elegant enough later.) Change-Id: Idceaf8c1ed54cd7d372bf4eb85d0428f9b57baeb Reviewed-on: https://gerrit.libreoffice.org/62799 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-11-03More !HAVE_FEATURE_AVMEDIA falloutTor Lillqvist
Change-Id: I5b2c24e555f77199782d60d56086455f04787821 Reviewed-on: https://gerrit.libreoffice.org/62798 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
generated by cgit (git 2.34.1) at 2025-02-28 20:11:27 +0000